brad0 wrote:
Update?
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aganea wrote:
@MaskRay Can you please take another look?
https://github.com/llvm/llvm-project/pull/76306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/76306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea updated
https://github.com/llvm/llvm-project/pull/76306
>From 8187e95ea4e04793fbfc85045aa21f9633bbc03d Mon Sep 17 00:00:00 2001
From: Alexandre Ganea
Date: Sat, 23 Dec 2023 19:17:06 -0500
Subject: [PATCH 1/2] [llvm-driver] Fix tool re-entrance on Windows.
Previously,
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Max Winkler (MaxEW707)
Changes
There are code bases that inline `std::move` manually via `static_cast`.
Treat a static cast to an xvalue as an inlined `std::move` call and warn on a
self move.
---
Full diff: https://github.com/llvm/llvm-p
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/76646
There are code bases that inline `std::move` manually via `static_cast`.
Treat a static cast to an xvalue as an inlined `std::move` call and warn on a
self move.
>From a081f8266f24405523e6d283318bd898fd2d376a M
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Brad Smith (brad0)
Changes
Remove the llvm_unreachable from getSolarisLibSuffix(). The code path is
reachable. In the case of an unsupported architecture we're not worrying
about trying to actually find the library paths, and I don't think
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/76645
Remove the llvm_unreachable from getSolarisLibSuffix(). The code path is
reachable. In the case of an unsupported architecture we're not worrying
about trying to actually find the library paths, and I don't think it
MaxEW707 wrote:
> I don't know whether all of these things should be handled with the same
> attribute, or whether they should be handled at all, but they should
> definitely be considered when designing this attribute.
For this I am more concerned with language level features such as move,
f
@@ -26,7 +26,7 @@ template
void test_call_operator_forwarding() {
using Fn = ForwardingCallObject;
Fn obj{};
- const Fn &cobj = obj;
Zingam wrote:
The reason for reformatting both files is that the CI format check failed for
nearly every line in the pre
ChipsSpectre wrote:
@tbaederr The build is fixed now. Can you merge the pull request?
Since I have no write access to llvm-project, it seems I can not do it on my
own:
![Screenshot](https://github.com/llvm/llvm-project/assets/11499442/e0fb925f-a72a-4c1e-827f-cb39c99faa4c)
https://github.com/
https://github.com/ChipsSpectre updated
https://github.com/llvm/llvm-project/pull/74926
>From cb46f3aab771133e3987c65bcbd1f6011792e74c Mon Sep 17 00:00:00 2001
From: ChipsSpectre
Date: Sat, 30 Dec 2023 23:01:12 +0100
Subject: [PATCH] [clang][Parse] `TryAnnotateCXXScopeToken` to be called only
https://github.com/H-G-Hristov edited
https://github.com/llvm/llvm-project/pull/76447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaxEW707 wrote:
> (@MaxEW707 I think having a chat about this informally would be nice.)
Sounds good. Let me know the best way to contact you.
> While I disagree with the reasoning for not just using std
I'll try to give more context here. The main reason is include times and not
wanting to w
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/75798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/75485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/75590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/71919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/69900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
The build fails though, with this error:
``
tools/clang/docs/ReleaseNotes.rst:691:Unknown target name: "#73559
https://github.com/llvm/llvm-project/issues/73559";
``
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mail
Author: Craig Hesling
Date: 2023-12-30T19:24:14+01:00
New Revision: 8346e8608f5eb7ad03f2c6beacda43af563b4eae
URL:
https://github.com/llvm/llvm-project/commit/8346e8608f5eb7ad03f2c6beacda43af563b4eae
DIFF:
https://github.com/llvm/llvm-project/commit/8346e8608f5eb7ad03f2c6beacda43af563b4eae.diff
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/76301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
It doesn't need a specific approval, just _any_. And @shafik has already
approved this PR, so it can now be merged.
https://github.com/llvm/llvm-project/pull/74926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ding Fei (danix800)
Changes
Fixes #76425
---
Full diff: https://github.com/llvm/llvm-project/pull/76619.diff
2 Files Affected:
- (modified) clang/include/clang/ASTMatchers/ASTMatchers.h (+2)
- (modified) clang/unittests/ASTMatchers/AST
https://github.com/danix800 created
https://github.com/llvm/llvm-project/pull/76619
Fixes #76425
>From b26fa2acfd4974d1c09eef408b4d6c2dcbb16479 Mon Sep 17 00:00:00 2001
From: dingfei
Date: Sun, 31 Dec 2023 00:32:01 +0800
Subject: [PATCH] [ASTMatchers] fix captureVars assertion failure on
capt
https://github.com/michaelmaitland closed
https://github.com/llvm/llvm-project/pull/76575
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Maitland
Date: 2023-12-30T11:31:26-05:00
New Revision: fa8347fbc602d78a7e4297aa83a686b62943d828
URL:
https://github.com/llvm/llvm-project/commit/fa8347fbc602d78a7e4297aa83a686b62943d828
DIFF:
https://github.com/llvm/llvm-project/commit/fa8347fbc602d78a7e4297aa83a686b62943d828.di
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -87,6 +85,28 @@ bool isStdVariant(const Type *Type) {
return isStdType(Type, llvm::StringLiteral("variant"));
}
+bool isStdAny(const Type *Type) {
+ return isStdType(Type, llvm::StringLiteral("any"));
+}
+
+bool isVowel(char a) {
+ switch (a) {
+ case 'a':
+ case 'e':
@@ -58,6 +58,14 @@ void wontConfuseStdGets() {
////
// std::get
////
+void stdGetType2() {
spaits wrote:
O
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Pol M (Destroyerrrocket)
Changes
Summary:
This patch adds constexpr support for __builtin_shufflevector and
__builtin_convertvector.
A small oddity encountered was that the arg to the intrinsics may be an lvalue
without any sort of impl
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
https://github.com/Destroyerrrocket created
https://github.com/llvm/llvm-project/pull/76615
Summary:
This patch adds constexpr support for __builtin_shufflevector and
__builtin_convertvector.
A small oddity encountered was that the arg to the intrinsics may be an lvalue
without any sort of i
@@ -0,0 +1,20 @@
+// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s
+
+namespace mystd {
+inline namespace bar {
+template struct remove_reference { typedef T type; };
+template struct remove_reference { typedef T type; };
+template struct remove_reference { typedef T type
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/76596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 commented:
While I disagree with the reasoning for not just using `std` (@MaxEW707 I think
having a chat about this informally would be nice.), I do think it makes sense
to add the ability to declare some functions as builtins. There are a few cases
inside the sta
@@ -1273,6 +1280,15 @@ public:
__impl_.__swap(__that.__impl_);
}
+# if _LIBCPP_STD_VER >= 26
+ // [variant.visit], visitation
+ template
+ constexpr decltype(auto) visit(this _Self&& __self, _Visitor&& __visitor);
mordante wrote:
nowadays we prefer
@@ -26,7 +26,7 @@ template
void test_call_operator_forwarding() {
using Fn = ForwardingCallObject;
Fn obj{};
- const Fn &cobj = obj;
mordante wrote:
Please undo the formatting changes to this file. It's hard to see what really
changed.
https://github.c
@@ -0,0 +1,268 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -17,27 +17,28 @@
#include "test_macros.h"
struct Incomplete;
-template struct Holder { T t; };
mordante wrote:
For this file too.
https://github.com/llvm/llvm-project/pull/76447
___
cfe-commits mailing list
cfe-
@@ -69,6 +69,12 @@ namespace std {
// 20.7.2.6, swap
void swap(variant&) noexcept(see below);
+
+// [variant.visit], visitation
+template
+ constexpr decltype(auto) visit(this Self&&, Visitor&&);
+template
+ constexpr R visit(this Self&&, Visitor&
@@ -0,0 +1,268 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -40,6 +40,8 @@ Paper Status
.. note::
.. [#note-P2510R3] This paper is applied as DR against C++20. (MSVC STL and
libstdc++ will do the same.)
+ .. [#note-P2637R3] P2637R3: Implemented `variant` member `visit`
mordante wrote:
Since we have both patch
https://github.com/mordante requested changes to this pull request.
Thanks for working on this!
https://github.com/llvm/llvm-project/pull/76447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/mordante edited
https://github.com/llvm/llvm-project/pull/76447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
boris-kolpackov wrote:
> I had looked at `-print-search-dirs` but it seems buggy. For example, it
> ignores the `-stdlib` flag to the compiler invocation.
True. I couldn't find a bug report for this so I filed one:
https://github.com/llvm/llvm-project/issues/76614
> Solving this seems a lot
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -2095,6 +2095,27 @@ This checker is a part of ``core.StackAddressEscape``,
but is temporarily disabl
// returned block
}
+.. _alpha-core-StdAny:
+
+alpha.core.StdAny (C++)
+"""
+Check if a value of active type is retrieved from a
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -30,6 +24,9 @@ bool isMoveAssignmentCall(const CallEvent &Call);
bool isMoveConstructorCall(const CallEvent &Call);
bool isStdType(const Type *Type, const std::string &TypeName);
bool isStdVariant(const Type *Type);
+bool isStdAny(const Type *Type);
whisperi
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -58,6 +58,14 @@ void wontConfuseStdGets() {
////
// std::get
////
+void stdGetType2() {
whisperity wrote
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -87,6 +85,28 @@ bool isStdVariant(const Type *Type) {
return isStdType(Type, llvm::StringLiteral("variant"));
}
+bool isStdAny(const Type *Type) {
+ return isStdType(Type, llvm::StringLiteral("any"));
+}
+
+bool isVowel(char a) {
+ switch (a) {
+ case 'a':
+ case 'e':
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/76580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,170 @@
+// RUN: %clang %s -std=c++17 -Xclang -verify --analyze \
+// RUN: -Xclang -analyzer-checker=core \
+// RUN: -Xclang -analyzer-checker=debug.ExprInspection \
+// RUN: -Xclang -analyzer-checker=core,alpha.core.StdAny
+
+#include "Inputs/system-header-simulat
@@ -0,0 +1,200 @@
+//===- StdAnyChecker.cpp -*- C++
-*===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/whisperity requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/76580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fhahn wrote:
Thanks for working on this! I think it would be good to split this up into
multiple distinct parts for the different improvements.
I put up a patch to support distinct metadata for distinct pointers a while
ago, which I just moved to GH: #76261.
The discussion on Phabricator has
fhahn wrote:
Move this over from Phabricator, see https://reviews.llvm.org/D122573
http://108.170.204.19/D122573 for context.
Type sanitizer patches have been moved to GH as well: #76259, #76260, #76261
https://discourse.llvm.org/t/reviving-typesanitizer-a-sanitizer-to-catch-type-based-aliasin
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Florian Hahn (fhahn)
Changes
This patch extends Clang's TBAA generation code to emit distinct tags for
incompatible pointer types.
Pointers with different element types are incompatible if the pointee types are
also incompatible (modulo
https://github.com/fhahn created https://github.com/llvm/llvm-project/pull/76612
This patch extends Clang's TBAA generation code to emit distinct tags for
incompatible pointer types.
Pointers with different element types are incompatible if the pointee types are
also incompatible (modulo sugar
https://github.com/whisperity edited
https://github.com/llvm/llvm-project/pull/76580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mordante wrote:
I had looked at `-print-search-dirs` but it seems buggy. For example, it
ignores the `-stdlib` flag to the compiler invocation. Solving this seems a lot
of work. So didn't want to add new features to that code.
https://github.com/llvm/llvm-project/pull/76451
___
benshi001 wrote:
Please refer to my previous commit of AVR ABI, how tests are provided for a
functional change.
https://github.com/llvm/llvm-project/pull/72298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
benshi001 wrote:
As I have suggested, any functional change need tests. So I think you need to
add some tests to show what your changes affect.
https://github.com/llvm/llvm-project/pull/72298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: Owen Pan
Date: 2023-12-30T01:32:10-08:00
New Revision: bd3d358ec68f686a280ae628f9074fdff1f10fe9
URL:
https://github.com/llvm/llvm-project/commit/bd3d358ec68f686a280ae628f9074fdff1f10fe9
DIFF:
https://github.com/llvm/llvm-project/commit/bd3d358ec68f686a280ae628f9074fdff1f10fe9.diff
LOG:
73 matches
Mail list logo