[clang] [CodeGen][LTO] Rename some misleading variables (PR #65185)

2023-09-01 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158698: [Clang][M68k] Use `DefineStd` for target-specific macros

2023-09-01 Thread Min-Yih Hsu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG230558e444c2: [Clang][M68k] Use `DefineStd` for target-specific macros (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 230558e - [Clang][M68k] Use `DefineStd` for target-specific macros

2023-09-01 Thread Min-Yih Hsu via cfe-commits
Author: Min-Yih Hsu Date: 2023-09-01T23:25:08-07:00 New Revision: 230558e444c2e1af8f34f99e59433a3fb87ed758 URL: https://github.com/llvm/llvm-project/commit/230558e444c2e1af8f34f99e59433a3fb87ed758 DIFF: https://github.com/llvm/llvm-project/commit/230558e444c2e1af8f34f99e59433a3fb87ed758.diff L

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

2023-09-01 Thread Brad Smith via Phabricator via cfe-commits
brad updated this revision to Diff 64. brad added a comment. x86_64 test for TLS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159390/new/ https://reviews.llvm.org/D159390 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/Driver/ToolCh

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-01 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1761 + getCharAndSize(CurPtr, FirstCodeUnitSize); + const char *CharStart = CurPtr + FirstCodeUnitSize - 1; + const char *UnicodePtr = CharStart; shafik wrote: > Do we need to verify that `Fir

[PATCH] D159345: [Clang] Handle non-ASCII after line splicing

2023-09-01 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 63. cor3ntin marked an inline comment as done. cor3ntin added a comment. Add and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 Files: clang/docs

[PATCH] D159358: [Clang] Realize generic lambda call operators are dependent sooner

2023-09-01 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG890f11d60fef: [Clang] Realize generic lambda call operators are dependent sooner (authored by cor3ntin). Changed prior to commit: https://reviews.

[clang] 890f11d - [Clang] Realize generic lambda call operators are dependent sooner

2023-09-01 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2023-09-02T08:05:49+02:00 New Revision: 890f11d60feffed4207afa58229da7bfaaff276e URL: https://github.com/llvm/llvm-project/commit/890f11d60feffed4207afa58229da7bfaaff276e DIFF: https://github.com/llvm/llvm-project/commit/890f11d60feffed4207afa58229da7bfaaff276e.diff

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
cor3ntin wrote: Just to note that this has some overlap with https://reviews.llvm.org/D159126 https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

2023-09-01 Thread Serge Pavlov via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd57e4d4888: [clang] Support vectors in __builtin_isfpclass (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 9fd57e4 - [clang] Support vectors in __builtin_isfpclass

2023-09-01 Thread Serge Pavlov via cfe-commits
Author: Serge Pavlov Date: 2023-09-02T11:52:43+07:00 New Revision: 9fd57e4d48881b0f395621bd4a7aa8ec54dc6729 URL: https://github.com/llvm/llvm-project/commit/9fd57e4d48881b0f395621bd4a7aa8ec54dc6729 DIFF: https://github.com/llvm/llvm-project/commit/9fd57e4d48881b0f395621bd4a7aa8ec54dc6729.diff

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL review_requested https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 678e3ee - [lldb] Fix duplicate word typos; NFC

2023-09-01 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2023-09-01T21:32:24-07:00 New Revision: 678e3ee12351e525fa9d94e7ff68ba7c1a8ca657 URL: https://github.com/llvm/llvm-project/commit/678e3ee12351e525fa9d94e7ff68ba7c1a8ca657 DIFF: https://github.com/llvm/llvm-project/commit/678e3ee12351e525fa9d94e7ff68ba7c1a8ca657.diff

[clang-tools-extra] [clang-tidy] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. Do not re-implement thigns that are already covered by other check (cppcoreguidelines-pro-type-member-init). I don't see curently any point for this check. If there are some small difrences bettwen this check and cppcoreguideli

[PATCH] D159174: [Clang] Use stable_sort in AppendTargetMangling

2023-09-01 Thread Piyou Chen via Phabricator via cfe-commits
BeMg added a comment. Thanks for the review. I'm working on RISC-V FMV support, and we found the large set of extension features is hard to maintain the priority that doesn't collision at all. Lack the appropriate priority, it will generate the random mangling name. The predictable mangling na

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: " Checks that class members are initialized in constructors (implicitly or explicitly). Reports constructors or classes where class members are not initialized." This is exacly what cppcoreguidelines-pro-type-member-init is doing. And provide same warnings: ``` 10:7: warning: c

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-09-01 Thread Koute via Phabricator via cfe-commits
koute added a comment. I know that there are still open issues regarding the psABI, but considering how slow it's been going, couldn't we merge this in anyway and mark it as experimental and subject to change? Please? The patch is simple enough to not become a maintenance burden, and GCC alread

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL labeled https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libc++] Implement ranges::contains (PR #65148)

2023-09-01 Thread Konstantin Varlamov via cfe-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e ready_for_review https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e updated https://github.com/llvm/llvm-project/pull/65193: >From a65cb213b6ea24a04e170a7cc210ed9d2d00a9ac Mon Sep 17 00:00:00 2001 From: Sheng Date: Wed, 30 Aug 2023 11:44:23 +0800 Subject: [PATCH] [clang][Sema] Fix a bug when instantiating a lambda with requires clau

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

2023-09-01 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/test/Preprocessor/has_attribute.cpp:35 +CXX11(clang::warn_unused_result) + // CHECK: __gnu__::__const__: 1 For the context, the attribute is defined with the following spellings: ``` let Spellings = [CXX11<

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

2023-09-01 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 updated this revision to Diff 51. barannikov88 added a comment. Update one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159393/new/ https://reviews.llvm.org/D159393 Files: clang/test/Preprocessor/has_attribute.c cla

[PATCH] D159393: [clang] Fix several issues in the generated AttrHasAttributeImpl.inc

2023-09-01 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 created this revision. Herald added subscribers: s.egerton, PkmX, simoncook, kristof.beyls, krytarowski, arichardson, dylanmckay. Herald added a reviewer: aaron.ballman. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: cfe-commits,

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e converted_to_draft https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e review_requested https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e review_requested https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e opened https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix a bug when instantiating a lambda with requires clause (PR #65193)

2023-09-01 Thread via cfe-commits
https://github.com/0x59616e review_requested https://github.com/llvm/llvm-project/pull/65193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126586: [InstrProf] Single byte counters in coverage

2023-09-01 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem marked an inline comment as done. gulfem added inline comments. Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:1080-1081 +void CodeGenPGO::setProfileVersion(llvm::Module &M) { + if (CGM.getCodeGenOpts().hasProfileClangInstr() && + llvm::EnableSingleByteCoverage) { +

[PATCH] D126586: [InstrProf] Single byte counters in coverage

2023-09-01 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem updated this revision to Diff 42. gulfem added a comment. 1. Use || to merge counters that refer to the same regions 2. Use || to merge counters from raw profiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126586/new/ https://reviews.

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

2023-09-01 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D159250#4634774 , @jyknight wrote: > In D159250#4633530 , @pengfei wrote: > >> In D159250#4631786 , @RKSimon >> wrote: >> >>> Would it be poss

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
EugeneZelenko wrote: @PiotrZSL, @carlosgalvezp: Somehow label was not assigned automatically, so I mention you manually. https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
@@ -0,0 +1,51 @@ +//===--- CppInitClassMembersCheck.h - clang-tidy *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or +explicitly). Reports constructors or classes where class members are

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
@@ -0,0 +1,32 @@ +.. title:: clang-tidy - google-cpp-init-class-members + +google-cpp-init-class-members += + +Checks that class members are initialized in constructors (implicitly or EugeneZelenko wrote: Please synchronize first state

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
https://github.com/EugeneZelenko edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158668: RFC: Add getLikelyBranchWeight helper function

2023-09-01 Thread Matthias Braun via Phabricator via cfe-commits
MatzeB added a comment. I have a feeling @mtrofin would prefer pass-specific weights rather than a unified notion of "likely"/"unlikely"... So with the latest round of patches it's probably best to abandon this for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D159109: [analyzer] CStringChecker buffer access checks should check the first bytes

2023-09-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159109/new/ https://reviews.llvm.org/D159109 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D159108: [analyzer] CStringChecker should check the first byte of the destination of strcpy, strncpy

2023-09-01 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159108/new/ https://reviews.llvm.org/D159108 ___ cfe-commits mailing list cfe-commits@lists.

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
adriannistor wrote: Thank you for the feedback @Xazax-hun ! Working on it! https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
adriannistor wrote: @ymand https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. In D159383#4635703 , @dschuff wrote: > Suggested edit to the commit description: > "use musl and stddef.h at the same time" -> "use musl and clang's stddef.h at > the same time" Done (Both the CL description and the commit messa

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,56 @@ +// RUN: %check_clang_tidy %s google-cpp-init-class-members %t + +class PositiveDefaultedDefaultConstructor { +public: + PositiveDefaultedDefaultConstructor() = default; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor should initialize these fields: X

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Derek Schuff via Phabricator via cfe-commits
dschuff added a comment. Suggested edit to the commit description: "use musl and stddef.h at the same time" -> "use musl and clang's stddef.h at the same time" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159383/new/ https://reviews.llvm.org/D159

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Really cool check! I can't wait to see how it turns out :) https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
@@ -0,0 +1,105 @@ +//===--- CppInitClassMembersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun edited https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
adriannistor wrote: @Xazax-hun @gribozavr https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e082973 - [Clang][libc] Add wrapper headers for `assert.h` for the GPU libc

2023-09-01 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-09-01T18:34:09-05:00 New Revision: e0829739bc77606aa4dcd4769869d2e9ad9d2ec0 URL: https://github.com/llvm/llvm-project/commit/e0829739bc77606aa4dcd4769869d2e9ad9d2ec0 DIFF: https://github.com/llvm/llvm-project/commit/e0829739bc77606aa4dcd4769869d2e9ad9d2ec0.diff

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:141 + unsigned Line, Col; + std::string Filename; + There is an opportunity for optimization by avoiding the allocation of separate strings for each source location, especially si

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added a comment. Thank you @aheejin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159383/new/ https://reviews.llvm.org/D159383 ___

[PATCH] D159390: Haiku: Enable thread-local storage and disable PIE by default

2023-09-01 Thread Brad Smith via Phabricator via cfe-commits
brad created this revision. brad added reviewers: joerg, kallisti5, nielx. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Derived from https://reviews.llvm.org/D49481, but added tests and simplified the diff a

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. I uploaded D159383 , which removes the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added a comment. Are we keeping the comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159312/new/ https://reviews.llvm.org/D159312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
https://github.com/adriannistor review_requested https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding an initial version of the "Initialized Class Members" checker. (PR #65189)

2023-09-01 Thread via cfe-commits
https://github.com/adriannistor opened https://github.com/llvm/llvm-project/pull/65189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd submitted https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -1200,5 +1235,128 @@ APINotesWriter::~APINotesWriter() = default; void APINotesWriter::writeToStream(llvm::raw_ostream &OS) { Implementation->writeToStream(OS); } + +ContextID APINotesWriter::addObjCContext(std::optional ParentCtxID, +

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -19,11 +19,11 @@ namespace clang { namespace api_notes { -class APINotesWriter::Implementation { - template - using VersionedSmallVector = - llvm::SmallVector, 1>; +template +using VersionedSmallVector = +llvm::SmallVector, 1>; compnerd wrote:

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -33,6 +33,7 @@ class APINotesWriter::Implementation { /// Mapping from strings to identifier IDs. llvm::StringMap IdentifierIDs; +public: compnerd wrote: Why make all this public? https://github.com/llvm/llvm-project/pull/65187 ___

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
@@ -749,6 +750,17 @@ struct Context { Context(ContextID id, ContextKind kind) : id(id), kind(kind) {} }; + +/// A temporary reference to an Objective-C selector, suitable for +/// referencing selector data on the stack. +/// +/// Instances of this struct do not store referen

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd edited https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Remove unused OS-availability feature (PR #65178)

2023-09-01 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd submitted https://github.com/llvm/llvm-project/pull/65178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159320: [NFC] Cleanup some #includes in header files

2023-09-01 Thread Bill Wendling via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG671365225ccc: [NFC] Cleanup some #includes in header files (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159320/new/ https://reviews.llv

[clang] 6713652 - [NFC] Cleanup some #includes in header files

2023-09-01 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-09-01T15:23:46-07:00 New Revision: 671365225ccce00b063f7becfee4388aa7ab013a URL: https://github.com/llvm/llvm-project/commit/671365225ccce00b063f7becfee4388aa7ab013a DIFF: https://github.com/llvm/llvm-project/commit/671365225ccce00b063f7becfee4388aa7ab013a.diff

[PATCH] D159373: [clang][auto-init] Remove -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang

2023-09-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159373/new/ https://reviews.llvm.org/D159373 __

[PATCH] D159383: [Headers] Remove musl-related comment about NULL

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin created this revision. aheejin added reviewers: iana, aaron.ballman, dalias. Herald added a subscriber: wingo. Herald added a project: All. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This removes a comment added in D159

[PATCH] D159312: [Headers] Remove a space in NULL define

2023-09-01 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added a comment. In D159312#4634617 , @dalias wrote: > Please report what you're actually trying to do that's breaking rather than > sending patches to align definitions that are not intended to be aligned. Basically, we tried to use `stddef.h`

[clang] [APINotes] Upstream APINotesWriter (PR #65187)

2023-09-01 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan labeled https://github.com/llvm/llvm-project/pull/65187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >