[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 525961. tomasz-kaminski-sonarsource added a comment. Remove excessive reformating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325 Files: clang/i

[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

FreddyYe created this revision. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151537 Files: clang/test/CodeGen/attr-cpuspecific.c I

[clang] 71decdf - [CodeGen] Remove unused declaration EmitMoveFromReturnSlot

Author: Kazu Hirata Date: 2023-05-25T23:52:09-07:00 New Revision: 71decdfee0b0f0ebb066327d8eb1c15146e67d0c URL: https://github.com/llvm/llvm-project/commit/71decdfee0b0f0ebb066327d8eb1c15146e67d0c DIFF: https://github.com/llvm/llvm-project/commit/71decdfee0b0f0ebb066327d8eb1c15146e67d0c.diff L

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

rjmccall added a comment. One slight miscommunication. Otherwise this LGTM, thank you. Comment at: clang/docs/LanguageExtensions.rst:824 +provide native architectural support for arithmetic on these formats. These +targets are noted in the lists of supported targets above. + -

[clang] b92fb33 - [CodeGen] Remove unused member variable NextBlockInfo

Author: Kazu Hirata Date: 2023-05-25T23:41:34-07:00 New Revision: b92fb33409bb46ca3a1a8ead5cbb958b7f130442 URL: https://github.com/llvm/llvm-project/commit/b92fb33409bb46ca3a1a8ead5cbb958b7f130442 DIFF: https://github.com/llvm/llvm-project/commit/b92fb33409bb46ca3a1a8ead5cbb958b7f130442.diff L

[clang] e6135c2 - [clang] Remove unused declaration IgnoreLinkageSpecDecls

Author: Kazu Hirata Date: 2023-05-25T23:31:17-07:00 New Revision: e6135c27b231c43d84cdc92886d807d7e7a84f1f URL: https://github.com/llvm/llvm-project/commit/e6135c27b231c43d84cdc92886d807d7e7a84f1f DIFF: https://github.com/llvm/llvm-project/commit/e6135c27b231c43d84cdc92886d807d7e7a84f1f.diff L

[PATCH] D151397: [3/N][RISCV] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd

eopXD updated this revision to Diff 525951. eopXD added a comment. Resolve test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/test/Co

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 525950. tomasz-kaminski-sonarsource added a comment. Updated MoveChecker to handle CXXLifetimeExtendedObjects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.o

[clang] 9652eba - [clang] Modernize SourceLocation (NFC)

Author: Kazu Hirata Date: 2023-05-25T22:56:08-07:00 New Revision: 9652eba3cfe004cce533445b7e8aedf96451cc6c URL: https://github.com/llvm/llvm-project/commit/9652eba3cfe004cce533445b7e8aedf96451cc6c DIFF: https://github.com/llvm/llvm-project/commit/9652eba3cfe004cce533445b7e8aedf96451cc6c.diff L

[clang-tools-extra] 8683b2f - [clang-tody] Fix typos in documentation

Author: Kazu Hirata Date: 2023-05-25T22:56:06-07:00 New Revision: 8683b2f1a9a1cb899345452dba097dd1d37efd17 URL: https://github.com/llvm/llvm-project/commit/8683b2f1a9a1cb899345452dba097dd1d37efd17 DIFF: https://github.com/llvm/llvm-project/commit/8683b2f1a9a1cb899345452dba097dd1d37efd17.diff L

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 525946. vikramRH added a comment. rebase and ping, apologies for the short frequency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/include/clang/Ba

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/test/Driver/x86-mabi.c:6 + +// CHECK-NOT: {{error|warning}}: +// ERR: error: unsupported option '-mabi=' for target '{{.*}}' MaskRa

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource added a comment. In D151325#4374326 , @NoQ wrote: > I totally support this! There's no reason why the region wouldn't carry such > information. > > This patch is surprisingly tiny, but this matches my grep observations: > alm

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

h-vetinari added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND CMAKE

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

MaskRay added inline comments. Comment at: clang/test/Driver/x86-mabi.c:6 + +// CHECK-NOT: {{error|warning}}: +// ERR: error: unsupported option '-mabi=' for target '{{.*}}' pengfei wrote: > What's the expected result for e.g. `x86_64-pc-windows-gnu/mingw/cygnus`

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp added a comment. Confirming your sense that those loops look a bit suspicious, I've found that this makes some implicit conversions ambiguous. Put a test case up for that at D151532 , I think I understand what those loops should be changed to instead,

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:398 + Removed checks Excessive newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.o

[PATCH] D151532: [test] Test ext_vector_type operators with implicit conversions

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An extra test for implicit co

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

mstorsjo added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND CMAKE_V

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

pengfei added inline comments. Comment at: clang/test/Driver/x86-mabi.c:6 + +// CHECK-NOT: {{error|warning}}: +// ERR: error: unsupported option '-mabi=' for target '{{.*}}' What's the expected result for e.g. `x86_64-pc-windows-gnu/mingw/cygnus` ? Repository:

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; hokein wrote: > While this patch is an improvement, I wonder we should move it further. > >

[PATCH] D151429: print user provide value in tabstop diagnostic

csmoe added a comment. thanks for your review :) user: csmoe email: cs...@msn.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151429/new/ https://reviews.llvm.org/D151429 ___ cfe-commits mailing list c

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3e7c6e9e080: [NFC][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/ https://reviews.

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525926. chaitanyav marked an inline comment as done. chaitanyav added a comment. Use single backticks for options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 F

[clang] c3e7c6e - [NFC][CLANG] Fix static code analyzer concerns

Author: Manna, Soumi Date: 2023-05-25T20:00:24-07:00 New Revision: c3e7c6e9e0809e2626253af584c7d7acfc4ce60b URL: https://github.com/llvm/llvm-project/commit/c3e7c6e9e0809e2626253af584c7d7acfc4ce60b DIFF: https://github.com/llvm/llvm-project/commit/c3e7c6e9e0809e2626253af584c7d7acfc4ce60b.diff

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz marked an inline comment as done. daiyousei-qz added a comment. Addressed the remaining comments. Thanks everyone for helping review and improve this patch! Comment at: clang-tools-extra/clangd/InlayHints.cpp:802 +Position HintStart = sourceLocToPosition(SM, R

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 525922. daiyousei-qz marked 8 inline comments as done. daiyousei-qz added a comment. - Address remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs updated this revision to Diff 525920. codemzs marked 3 inline comments as done. codemzs added a comment. Addresses feedback on extended floating type documentation from @rjmccall and @pengfei CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150913/new/ https://reviews.llvm.org/D15

[PATCH] D151529: [NFC][CLANG] Fix nullptr dereference issue in DeduceTemplateArgumentsByTypeMatch()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. DeduceTemplateArgumentsByTypeMatch() returns null value which is dereferenced without checking since getAsIncompleteArrayType() r

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

MaskRay added a comment. In D150930#4356732 , @jhuber6 wrote: > In D150930#4355240 , @MaskRay wrote: > >> Note: for options controlling individual optimization behaviors, there is a >> large probability that they

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } jacquesguan wrote: > craig.topper wrote: > > michaelmaitland wrote: > > > m

[PATCH] D150913: [Clang][BFloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/docs/LanguageExtensions.rst:852 ``double`` when passed to ``printf``, so the programmer must explicitly cast it to ``double`` before using it with an ``%f`` or similar specifier. rjmccall wrote: > codemzs wrot

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. `12d840375d5a81e9ce1050354371c550669de2d7` should fix the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 ___ cfe-commits

[clang] 12d8403 - [Clang] Simplify test `clang/test/OpenMP/bug59160.c`

Author: Shilei Tian Date: 2023-05-25T22:12:16-04:00 New Revision: 12d840375d5a81e9ce1050354371c550669de2d7 URL: https://github.com/llvm/llvm-project/commit/12d840375d5a81e9ce1050354371c550669de2d7 DIFF: https://github.com/llvm/llvm-project/commit/12d840375d5a81e9ce1050354371c550669de2d7.diff L

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan marked 5 inline comments as done. jacquesguan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:162 + bool hasVInstructionsF16Mininal() const { +return HasStdExtZvfhmin || HasStdExtZvfh; + } craig.topper wrote: > michaelm

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM except for a possible typo. Comment at: clang/lib/Headers/avx2intrin.h:412 +///vectors of [16 x i16] and returns the lower 16 bits of each difference +///in an

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4374782 , @dyung wrote: > In D141627#4374757 , > @tianshilei1992 wrote: > >> In D141627#4374753 , @Northbadge >> wrote: >> >>>

[PATCH] D151525: [NFC][CLANG] Fix nullptr dereference issue in Type::getSveEltType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match i

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

NoQ added a comment. > By the way, I'm fed up with the hack that ElementRegion is used for three > separate things ("real" array indexing, casts and pointer arithmetic). To fix > this I'm thinking about introducing a subclass hierarchy where a base class > `ElementLikeRegion` has three subclass

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 525902. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai added a comment. Kinda a follow-up to D121176 . One big alternative that I've considered is to store interface name in `ObjCCategoryDecl` because when we parse `@interface InterfaceName(CategoryName)` we know the interface name. The intention was to al

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

vsapsai created this revision. vsapsai added reviewers: martong, shafik, ahatanak. Herald added subscribers: ributzka, rnkovacs. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When this happens, it is i

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

dyung added a comment. In D141627#4374757 , @tianshilei1992 wrote: > In D141627#4374753 , @Northbadge > wrote: > >> FYI this is failing- >> https://lab.llvm.org/buildbot/#/builders/109/builds/64971/steps/6/logs

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 525896. kushanam added a comment. removing commented td entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D151517: Fix wrong error message when compiling C souce code

jyu2 updated this revision to Diff 525894. jyu2 retitled this revision from "Fix couple of problems in uses_allocators clause." to "Fix wrong error message when compiling C souce code". jyu2 edited the summary of this revision. jyu2 added a comment. Thanks Alexey, sure I am separate the patch.

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. In D141627#4374753 , @Northbadge wrote: > FYI this is failing- > https://lab.llvm.org/buildbot/#/builders/109/builds/64971/steps/6/logs/FAIL__Clang__bug59160_c Thanks. I pushed a fix in eaf3de6970fc

[clang] eaf3de6 - [Clang] Fix test case issue introduced by D141627

Author: Shilei Tian Date: 2023-05-25T20:40:57-04:00 New Revision: eaf3de6970fc6e779310a59fbf8f8452f6b34c55 URL: https://github.com/llvm/llvm-project/commit/eaf3de6970fc6e779310a59fbf8f8452f6b34c55 DIFF: https://github.com/llvm/llvm-project/commit/eaf3de6970fc6e779310a59fbf8f8452f6b34c55.diff L

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

Northbadge added a comment. FYI this is failing- https://lab.llvm.org/buildbot/#/builders/109/builds/64971/steps/6/logs/FAIL__Clang__bug59160_c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 ___

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8e3077d60de: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still… (authored by tianshilei1992). Repository: rG LLVM Gith

[clang] b8e3077 - [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

Author: Shilei Tian Date: 2023-05-25T20:19:07-04:00 New Revision: b8e3077d60de73ddcb1511a68af3fdd37fe81cf7 URL: https://github.com/llvm/llvm-project/commit/b8e3077d60de73ddcb1511a68af3fdd37fe81cf7 DIFF: https://github.com/llvm/llvm-project/commit/b8e3077d60de73ddcb1511a68af3fdd37fe81cf7.diff L

[PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

h-vetinari added inline comments. Comment at: libunwind/src/CMakeLists.txt:28-35 # See add_asm_sources() in compiler-rt for explanation of this workaround. # CMake doesn't work correctly with assembly on AIX. Workaround by compiling # as C files as well. if((APPLE AND CMAKE

[PATCH] D144911: adding bf16 support to NVPTX

kushanam updated this revision to Diff 525883. kushanam added a comment. rebasing the diff based on the branch HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144911/new/ https://reviews.llvm.org/D144911 Files: clang/include/clang/Basic/Built

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf75b73549d4a: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas (authored by yronglin). Repository: rG LLVM Github Mon

[clang] f75b735 - [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

Author: yronglin Date: 2023-05-26T07:41:26+08:00 New Revision: f75b73549d4adb7e111444f4144af7bffb532f91 URL: https://github.com/llvm/llvm-project/commit/f75b73549d4adb7e111444f4144af7bffb532f91 DIFF: https://github.com/llvm/llvm-project/commit/f75b73549d4adb7e111444f4144af7bffb532f91.diff LOG:

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin marked 2 inline comments as done. yronglin added a comment. The libcxx CI failure seems not caused bye this patch, I have found that there have a patch to fix this issue. https://reviews.llvm.org/D151508 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D151517: Fix couple of problems in uses_allocators clause.

ABataev added a comment. Could you split it into 3 separate patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151517/new/ https://reviews.llvm.org/D151517 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D151517: Fix couple of problems in uses_allocators clause.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, jplehr, sstefan1. 1> Fix wrong error message when compiling C souce

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:394 +- Extend ``bugprone-unused-return-value`` check to check for all functions + with specified return types using the ``CheckedReturnTypes`` option. Please keep alphabe

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. please let me know if there is better way to do the matching `hasAnyReturnType`. We could also sort then do binarysearch instead of looping through the list of ret types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525855. chaitanyav added a comment. Add tests, update docs and extend matchcallexpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 Files: clang-tools-extra/clan

[PATCH] D151515: [CodeGen] add additional cast when checking call arguments

HerrCai0907 created this revision. HerrCai0907 added reviewers: shafik, erichkeane, aaron.ballman. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed: https://github.com/llvm/llvm-project/issues/6

[PATCH] D151509: [Driver][X86] Reject unsupported value for -mabi=

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, arichardson, craig.topper, erichkeane, pengfei. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -mabi= was incorrectly claimed befo

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

NoQ added a comment. I totally support this! There's no reason why the region wouldn't carry such information. This patch is surprisingly tiny, but this matches my grep observations: almost nothing in the static analyzer treats `CXXTempObjectRegion` specially. Even in case of live symbols/regi

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525831. electriclilies added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td

[PATCH] D127660: [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Herald added a subscriber: ributzka. Comment at: clang/lib/Frontend/FrontendAction.cpp:507 // be resolved relative to the build directory of the module map file. - CI.getPreprocessor().setMainF

[PATCH] D127654: [clang] NFCI: Use DirectoryEntryRef in Module::Directory

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added inline comments. Herald added a subscriber: ributzka. Comment at: clang/include/clang/Basic/Module.h:138 /// are found. - const DirectoryEntry *Directory = nullptr; + OptionalDirectoryEntryRefDegradesToDirecto

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

Mogball accepted this revision. Mogball added inline comments. This revision is now accepted and ready to land. Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:878 }]; - let arguments = (ins StrAttr:$intrin, Variadic:$args); + let arguments = (ins StrAttr:

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525815. electriclilies added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td m

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra edited the summary of this revision. tra edited the summary of this revision. tra published this revision for review. tra added reviewers: qiongsiwu1, jlebar. Herald added a re

[PATCH] D151502: [clang-tidy][docs] Fix link to libc style guide

abrachet updated this revision to Diff 525814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151502/new/ https://reviews.llvm.org/D151502 Files: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.h clang-tools-extra/docs/clang-tidy/checks/llvmlibc/inline-function-decl.rst

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

Mogball added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleTranslat

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

Mogball added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleTranslat

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151502: [clang-tidy][docs] Fix link to libc style guide

abrachet created this revision. abrachet added reviewers: mcgrathr, sivachandra. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. abrachet requested review of this revision. Herald added a project: clang-tools-extra. Heral

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

fahadnayyar updated this revision to Diff 525791. fahadnayyar added a comment. Adding 1 more test chage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriver

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

Mogball added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleTranslat

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

Mogball added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleTranslat

[PATCH] D151495: [clang-tidy] Improve build-in type handling in bugprone-swapped-arguments

PiotrZSL created this revision. PiotrZSL added reviewers: bkramer, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improved det

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:98 static LogicalResult convertCallLLVMIntrinsicOp(CallIntrinsicOp &op, llvm::IRBuilderBase &builder, LLVM::ModuleTranslation &moduleT

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

Mogball added inline comments. Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:870 -def LLVM_CallIntrinsicOp : LLVM_Op<"call_intrinsic"> { +def LLVM_CallIntrinsicOp : LLVM_Op<"call_intrinsic", [DeclareOpInterfaceMethods]> { let summary = "Call to an LLVM in

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp:130 - llvm::CallInst *inst = builder.CreateCall(fn, moduleTranslation.lookupValues(op.getOperands())); ftynse wrote: > Don't use `auto`

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525779. electriclilies added a comment. Remove whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrins

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

ftynse added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, electriclilies wrote: >

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies updated this revision to Diff 525778. electriclilies added a comment. Squish commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 Files: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicO

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

reames added a comment. In D149495#4373796 , @michaelmaitland wrote: > In D149495#4373768 , @reames wrote: > >> Let's go ahead and land this as is, we can rework the stylistic pieces once >> the linked patches l

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, ftynse wrote: >

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies added a comment. For some reason the diff is showing the difference between 2 commits on my branch, anyone know how to fix this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151492/new/ https://reviews.llvm.org/D151492 ___

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

ftynse added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:367 // that can be valid on the real entry. - // This is what I want to do AttributeList NewAttrs = AttributeList::get(Ctx, AttributeList::FunctionIndex, This cleanup should go

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

michaelmaitland added a comment. In D149495#4373768 , @reames wrote: > Let's go ahead and land this as is, we can rework the stylistic pieces once > the linked patches land. This has landed in https://reviews.llvm.org/rG1a855819a87f426bdbd83c815fa47ca0

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:431 + // libc++.dylib in the toolchain. + if ((!Args.hasArg(options::OPT_nostdinc, options::OPT_nostdlibinc, +options::OPT_nostdincxx)) && arphaman wrote: > ld

[PATCH] D151492: Add fastmath attributes to llvm.call_intrinsic

electriclilies created this revision. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauhe

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

MaskRay added a comment. In D151393#4373764 , @smeenai wrote: > I searched for `__clang_call_terminate` in the Clang test directory when I > was working on this diff. Most tests were testing calls to it, not > definitions. There were a couple of tests c

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

reames added a comment. Let's go ahead and land this as is, we can rework the stylistic pieces once the linked patches land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D149495 __

[PATCH] D151393: [CodeGen] Make __clang_call_terminate have an unwind table entry

smeenai added a comment. I searched for `__clang_call_terminate` in the Clang test directory when I was working on this diff. Most tests were testing calls to it, not definitions. There were a couple of tests checking the definition, but they seemed pretty targeted (e.g. https://github.com/llv

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada added a comment. In D151445#4372892 , @clementval wrote: > You should be able to get this information from the source location in MLIR. Hi, thank you for your quick feedback. You are right, the source location is provided in MLIR. Unfortunately,

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. In D150887#4373695 , @nikic wrote: > I wanted to check whether you plan to do more opaque pointer test conversions > in clang. Just to make sure we don't duplicate work... I'm done for now Repository: rG LLVM Github Mon

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

HazardyKnusperkeks added a comment. > In D151145#4365580 , > @HazardyKnusperkeks wrote: > >> As stated on Github I don't think we have a bug. > > Are you sure, I'm pretty sure this is a bug? Can you elaborate on the > discussion on github. I wouldn't wan

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5df593a35471: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method (authored by HerrCai0907). Repository: rG LLVM Github M

  1   2   3   >