[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504516. francii added a comment. Move comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChai

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 504515. dhruvachak added a comment. Herald added subscribers: mattd, asavonic. Addressed comment. Using the alloca insert point for kernel args alloca. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker On AIX, libraries are still being linked when `-r` is passed to the driver. This patch corrects this error.

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

ChuanqiXu added a comment. It looks like that the `Create` template functions get merged expectedly. And the dummy variable shouldn't get merged since it is not in a mergeable primary context (function context is not a mergeable primary context) (see https://github.com/llvm/llvm-project/blob/23

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 504508. xiongji90 added a comment. Add SemaChecking test for incompatible input arguments for __builtin_set_flt_rounds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145765/new/ https://reviews.llvm.org/D145

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 marked an inline comment as done. xiongji90 added inline comments. Comment at: clang/test/CodeGen/builtin_set_flt_rounds.c:5-7 +void test_builtin_set_flt_rounds() { + __builtin_set_flt_rounds(1); + // CHECK: call void @llvm.set.rounding(i32 1) aaron.b

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142692/new/ https://reviews.llvm.org/D142692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

nridge added a comment. @ehntoo hi! are you planning to update this patch to address Kadir's comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139277/new/ https://reviews.llvm.org/D139277 ___ cfe-c

[PATCH] D127184: [clangd] Add to header map

nridge added a comment. What is the status of this patch -- is it still relevant, and if so are there plans to finish/merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127184/new/ https://reviews.llvm.org/D127184 __

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

nridge added a comment. Thanks for the patch! In the future we may want to add other cursor kinds for which `ShouldPatchPlaceholder0` should be false, but I think this is a good start which addresses the case from the bug. Comment at: clang-tools-extra/clangd/CodeComplete.cp

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 504504. xiongji90 added a comment. Add semachecking test for unsupported platform. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145765/new/ https://reviews.llvm.org/D145765 Files: clang/include/clang/Basi

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

hazohelet updated this revision to Diff 504501. hazohelet added a comment. Address comments from @shafik - Pass bool flag `UnreachableFallThroughDiagIsEnabled` instead of `DiagnosticsEngine` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145842/new/ https://reviews.llvm.org/D145842 Fi

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 created this revision. HerrCai0907 added reviewers: erichkeane, aaron.ballman. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR #61326 CorrectDelayedTyposInExpr will clean all typo erro

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

jacquesguan added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:433 +AVRTargetInfo::handleAsmEscapedChar(char EscChar) const { + char C; + switch (EscChar) { redundant variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

pengfei updated this revision to Diff 504498. pengfei added a comment. Support i886 and i986. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp clang/test

[PATCH] D145857: [X86] Make triple ArchName override OS for i686 and i786

pengfei updated this revision to Diff 504497. pengfei added a comment. Only make OS override i386. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145857/new/ https://reviews.llvm.org/D145857 Files: clang/lib/Driver/ToolChains/Arch/X86.cpp clang

[PATCH] D83906: [CodeGen] Emit a call instruction instead of an invoke if the called llvm function is marked nounwind

dexonsmith added a comment. In D83906#4186887 , @hoy wrote: > In D83906#4184916 , @dexonsmith > wrote: > >> In D83906#4183453 , @hoy wrote: >> >>> Wondering if we can come u

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added inline comments. Comment at: clang/unittests/Format/FormatTestObjC.cpp:1619 + // Reflow after first macro. + // FIXME: these should indent but don't. + verifyFormat("- (id)init ATTRIBUTE_MACRO(X)\n" I don't love this FIXME, but I was afraid to

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5329 + if (Right.is(tok::l_square) && Right.is(TT_AttributeSquare)) return !Left.is(TT_AttributeSquare); I broke this `if` into two pieces and restored an original `return t

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 504486. jaredgrubb added a comment. - Fixed an issue in `TokenAnnotator` about it not breaking between macros properly (it was catching in an ObjC selector-check too early) - Add more ObjC tests, covering method and property declarations too. There are st

[PATCH] D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const

PiotrZSL added a comment. Tests: ./clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-transform-values.cpp ./clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-cxx17.cpp ./clang-tools-extra/test/clang-tidy/checkers/misc/const-correctness-templates.cpp ./clang-tools-ex

[PATCH] D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const

ChrisThrasher added a comment. I'm working on the test failures and improved test coverage. Where can I learn more about how to update the release notes and documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145856/new/ https://reviews.l

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Back in D128714

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143849/new/ https://reviews.llvm.org/D143849 ___ cfe-commits mailing list

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Comment at: clang/lib/CodeGen/TargetInfo.h:383 + + /// Return an LLVM target extension type that corresponds to an OpenCL type, + /// if such a type is n

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe added a comment. In D145885#4187679 , @PiotrZSL wrote: > My only complain is documentation, changes in code and tests are correct. > Build failed mainly due to conflicts in previous change. > It should get green once prev patch will land, and th

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57b78faa9eb0: [clang-tidy] Support std::format and std::print in r

[clang-tools-extra] 57b78fa - [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

Author: Mike Crowe Date: 2023-03-12T21:42:53Z New Revision: 57b78faa9eb08017d95bb4e43242648953b08c13 URL: https://github.com/llvm/llvm-project/commit/57b78faa9eb08017d95bb4e43242648953b08c13 DIFF: https://github.com/llvm/llvm-project/commit/57b78faa9eb08017d95bb4e43242648953b08c13.diff LOG: [c

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe updated this revision to Diff 504475. mikecrowe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/ https://reviews.llvm.org/D145885 Files: clang-tools-extra/clang-tidy/readability/RedundantStringCStrChec

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe updated this revision to Diff 504474. mikecrowe edited the summary of this revision. mikecrowe added a comment. Rebase. No conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143342/new/ https://reviews.llvm.org/D143342 Files: cla

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. My only complain is documentation, changes in code and tests are correct. Build failed mainly due to conflicts in previous change. It should get green once prev patch will land, an

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

PiotrZSL added a comment. You will need to rebase this, there are conflicts... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143342/new/ https://reviews.llvm.org/D143342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added a comment. Thank you for your patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143342/new/ https://reviews.llvm.org/D143342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

PiotrZSL added a comment. "The dummy implementations of std::format and std::print require C++20, so it's easier to test them in a separate redundant-string-cstr-format.cpp check file. This also requires a small improvement to the basic_string_view implementation in the dummy header. With these

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146-148 + arguments to ``std::print`` and ``std::format``. The same check can be + used for functions that behave similarly by using the + ``StringParameterFunction`` option. `

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added a comment. In D143342#4187641 , @PiotrZSL wrote: > Correct commit message and this could land. I've read through all the comments and the commit message itself and I can't spot what's wrong with the commit message, except perhaps for its

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

PiotrZSL accepted this revision. PiotrZSL added a comment. Correct commit message and this could land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143342/new/ https://reviews.llvm.org/D143342 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:189 + getLangOpts().CPlusPlus2b + ? hasAnyName("::std::print", "::std::format") +

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe added a comment. I can squash this with https://reviews.llvm.org/D143342 if required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145885/new/ https://reviews.llvm.org/D145885 ___ cfe-commits

[PATCH] D145885: [clang-tidy] Support readability-redundant-string-cstr.StringParameterFunctions option

mikecrowe created this revision. mikecrowe added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscribe

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

jrtc27 added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:112-114 + case llvm::Triple::riscv64: +getTargetFeatures(D, Triple, Args, CmdArgs, /*ForAs*/ false); +break; mnadeem wrote: > identical code, could just do a fallthrough Why

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

mnadeem added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:112-114 + case llvm::Triple::riscv64: +getTargetFeatures(D, Triple, Args, CmdArgs, /*ForAs*/ false); +break; identical code, could just do a fallthrough Repository: rG L

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

mnadeem added a comment. There is an existing test `flang/test/Driver/target-cpu-features.f90` added in D137995 Would it be better to add RISCV to that file? or perhaps rename the tests to have target specific files? Repository: rG LLVM Github Monorepo CH

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

PiotrZSL added a comment. This change obsoletes D115118 and D134588 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145865/new/ https://reviews.llvm.org/D145865

[clang-tools-extra] 55f8a28 - [clang-tidy][NFC] Update docs/clang-tidy/checks/list.rst

Author: Piotr Zegar Date: 2023-03-12T20:01:36Z New Revision: 55f8a287e9e8a137a400349b91426d02d6570b37 URL: https://github.com/llvm/llvm-project/commit/55f8a287e9e8a137a400349b91426d02d6570b37 DIFF: https://github.com/llvm/llvm-project/commit/55f8a287e9e8a137a400349b91426d02d6570b37.diff LOG: [

[clang-tools-extra] d5fd6a3 - [clang-tidy] Fix rename_check.py

Author: Piotr Zegar Date: 2023-03-12T19:51:40Z New Revision: d5fd6a376a7c0a880ccce43fa407177942ce6488 URL: https://github.com/llvm/llvm-project/commit/d5fd6a376a7c0a880ccce43fa407177942ce6488 DIFF: https://github.com/llvm/llvm-project/commit/d5fd6a376a7c0a880ccce43fa407177942ce6488.diff LOG: [

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers added a comment. In D145435#4179662 , @owenpan wrote: > Are the settings above hypothetical or are they real-world use cases? Real-world - actually, all of them. > IMO, if people really want to have per-file configurations, they can do so

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce created this revision. sunshaoce added reviewers: awarzynski, klausler, clementval, sscalpone, craig.topper, jrtc27, kito-cheng. Herald added subscribers: VincentWu, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, simoncook, arichar

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

shafik added inline comments. Comment at: clang/lib/Analysis/ReachableCode.cpp:674 + if (AS && hasSpecificAttr(AS->getAttrs()) && + !Diag.isIgnored(diag::warn_unreachable_fallthrough_attr, + SourceLocation())) { Your passing through `Di

[clang] c8e2dd8 - [clang][darwin] An OS version preprocessor define is added for any darwin OS

Author: Alex Lorenz Date: 2023-03-12T10:58:33-07:00 New Revision: c8e2dd8c6f490b68e41fe663b44535a8a21dfeab URL: https://github.com/llvm/llvm-project/commit/c8e2dd8c6f490b68e41fe663b44535a8a21dfeab DIFF: https://github.com/llvm/llvm-project/commit/c8e2dd8c6f490b68e41fe663b44535a8a21dfeab.diff L

[clang-tools-extra] c491c91 - [clang-tidy] Implement CppCoreGuideline F.18

Author: Chris Cotter Date: 2023-03-12T16:58:08Z New Revision: c491c917023905815d6b4b81f4c5f632b02895c3 URL: https://github.com/llvm/llvm-project/commit/c491c917023905815d6b4b81f4c5f632b02895c3 DIFF: https://github.com/llvm/llvm-project/commit/c491c917023905815d6b4b81f4c5f632b02895c3.diff LOG:

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc491c9170239: [clang-tidy] Implement CppCoreGuideline F.18 (authored by ccotter, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL updated this revision to Diff 504454. PiotrZSL added a comment. Rebase + Fix order of checks in ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:189 + getLangOpts().CPlusPlus2b + ? hasAnyName("::std::print", "::std::format") +

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:189 + getLangOpts().CPlusPlus2b + ? hasAnyName("::std::print", "::std::format") +

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Yes, I'm ready for this to be committed. I don't have commit access, but if anyone could commit this on my behalf with `Chris Cotter ` that'd be great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://rev

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

PiotrZSL updated this revision to Diff 504448. PiotrZSL added a comment. Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145865/new/ https://reviews.llvm.org/D145865 Files: clang-tools-extra/clang-tidy/bugprone/ExceptionEscape

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

PiotrZSL updated this revision to Diff 50. PiotrZSL added a comment. Review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145865/new/ https://reviews.llvm.org/D145865 Files: clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cp

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:491 if (const auto *ThrownExpr = Throw->getSubExpr()) { - const auto *ThrownType = - ThrownExpr->getType()->getUnqualifiedDesugaredType(); - if (Thro

[PATCH] D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified.

PiotrZSL updated this revision to Diff 504434. PiotrZSL added a comment. Rebase on top of main + Change llvm::Optional into std::optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129070/new/ https://reviews.llvm.org/D129070 Files: clang-too

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added a comment. In D145312#4187247 , @PiotrZSL wrote: > In D145312#4187195 , @carlosgalvezp > wrote: > >> @PiotrZSL I believe you have landed some patches of this chain. Would you >> mind sharing

[PATCH] D145479: [clang][ASTImporter] Import typedefs to distinct records as distinct nodes.

vabridgers accepted this revision. vabridgers added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145479/new/ https://reviews.llvm.org/D145479 ___

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. @ccotter Do we commit this, or you plan to still change something here ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 ___ cfe-commi

[PATCH] D145724: [clang-tidy] Provide default template arguments in

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4918cbf3ba3: [clang-tidy] Provide default template arguments in (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D145313: [clang-tidy] Make readability-container-size-empty check using header

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a93abd97658: [clang-tidy] Make readability-container-size-empty check using header (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9dc14cf1f7e: [clang-tidy] Make readability-string-compare check use header (authored by mikecrowe, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang-tools-extra] 0a93abd - [clang-tidy] Make readability-container-size-empty check using header

Author: Mike Crowe Date: 2023-03-12T13:32:29Z New Revision: 0a93abd9765809bb13cfdb43794bf17e9ad5e137 URL: https://github.com/llvm/llvm-project/commit/0a93abd9765809bb13cfdb43794bf17e9ad5e137 DIFF: https://github.com/llvm/llvm-project/commit/0a93abd9765809bb13cfdb43794bf17e9ad5e137.diff LOG: [c

[clang-tools-extra] c4918cb - [clang-tidy] Provide default template arguments in

Author: Mike Crowe Date: 2023-03-12T13:32:45Z New Revision: c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec URL: https://github.com/llvm/llvm-project/commit/c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec DIFF: https://github.com/llvm/llvm-project/commit/c4918cbf3ba3f6f0caefae3f283b5c05c3baf7ec.diff LOG: [c

[clang-tools-extra] f9dc14c - [clang-tidy] Make readability-string-compare check use header

Author: Mike Crowe Date: 2023-03-12T13:32:05Z New Revision: f9dc14cf1f7eadffa7b11b86aaeaee5af26a21c0 URL: https://github.com/llvm/llvm-project/commit/f9dc14cf1f7eadffa7b11b86aaeaee5af26a21c0 DIFF: https://github.com/llvm/llvm-project/commit/f9dc14cf1f7eadffa7b11b86aaeaee5af26a21c0.diff LOG: [c

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

PiotrZSL added a comment. In D145312#4187195 , @carlosgalvezp wrote: > @PiotrZSL I believe you have landed some patches of this chain. Would you > mind sharing how you do it? I'm not an expert in Phabricator and simply doing > `arc patch D145312` leads

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added a comment. @mikecrowe I seems I cannot land this until it's rebased on top of `main`, would you be able to do that? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145312/new/ https://reviews.llvm.org/D145312 ___ cf

[PATCH] D145869: [clang][ExtractAPI] Add multiple file support to --extract-api-ignores

Arsenic created this revision. Herald added a reviewer: ributzka. Herald added a project: All. Arsenic requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Modify -extract-api-ignores command line option to accep

[PATCH] D145868: [clang][ASTImporter] Fix import of anonymous structures

vabridgers created this revision. vabridgers added reviewers: a.sidorin, shafik, donat.nagy, gamesh411, balazske. Herald added a subscriber: martong. Herald added a project: All. vabridgers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fi

[PATCH] D145312: [clang-tidy] Make readability-string-compare check use header

carlosgalvezp added a comment. @PiotrZSL I believe you have landed some patches of this chain. Would you mind sharing how you do it? I'm not an expert in Phabricator and simply doing `arc patch D145312` leads to cherry-pick conflicts, and when I solve them I don't end up having this patch as `H

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20273 + Style.ColumnLimit = 20; + EXPECT_EQ( + "demo = std::array<\n" any reason you didn't use verifyFormat here? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

PiotrZSL added a comment. Herald added a reviewer: njames93. Herald added a project: All. This need to be rebase due to conflict to land. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49864/new/ https://reviews.llvm.org/D49864 _

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Added support for C++

[PATCH] D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. - Failed tests - Missing tests for this change - Missing configuration option for this change (changing default behavior) - Missing release notes - Missing documentation update - a

[clang] 7488dd2 - Revert "[Clang][AIX][p] Manually Claim -p in front end"

Author: Michael Francis Date: 2023-03-12T08:14:33Z New Revision: 7488dd25e1613894d79d69f153469545b9bf660a URL: https://github.com/llvm/llvm-project/commit/7488dd25e1613894d79d69f153469545b9bf660a DIFF: https://github.com/llvm/llvm-project/commit/7488dd25e1613894d79d69f153469545b9bf660a.diff LO