[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 updated this revision to Diff 501389. xiongji90 added a comment. Update test for llvm.set.rounding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144454/new/ https://reviews.llvm.org/D144454 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c112897b202: [clang][driver] Do not emit default '-Tdata' for AVR devices (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D144533?vs=499360&id=501386#toc Repository: rG LL

[clang] 1c11289 - [clang][driver] Do not emit default '-Tdata' for AVR devices

Author: Ben Shi Date: 2023-03-01T15:55:30+08:00 New Revision: 1c112897b20274852a9280d20cebd5c9f3619a7a URL: https://github.com/llvm/llvm-project/commit/1c112897b20274852a9280d20cebd5c9f3619a7a DIFF: https://github.com/llvm/llvm-project/commit/1c112897b20274852a9280d20cebd5c9f3619a7a.diff LOG:

[PATCH] D145034: [Clang][Sema] Preparations to fix handling of out-of-line definitions of constrained templates

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: rsmith, aaron.ballman. alexander-shaposhnikov created this object with visibility "All Users". Herald added a project: All. alexander-shaposhnikov requested review of this revision. Herald added a project: clang.

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141666/new/ https://reviews.llvm.org/D141666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

vedgy added a comment. Can someone merge/land this review? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143415/new/ https://reviews.llvm.org/D143415 ___ cfe-commits mailing l

[PATCH] D145031: [clang-tidy] use isConvertingConstructor to simplify code

thyecust created this revision. thyecust added a reviewer: clang-tools-extra. thyecust added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. thyecust requested review of this revision. Herald added a s

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder updated this revision to Diff 501380. tbaeder marked 2 inline comments as done. tbaeder added a comment. Added the new test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/ https://reviews.llvm.org/D136751 Files: clang/lib/AST/Interp/Function.h clang/lib/AST/

[PATCH] D145030: [clang-tidy] use isConvertingConstructor to simplify code

thyecust created this revision. thyecust added a reviewer: clang-tools-extra. thyecust added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, mgehre, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. thyecust requested review of this revision. Herald a

[PATCH] D140075: [libclang] Expose using shadow types and declarations in libclang.

serge-sans-paille added inline comments. Comment at: clang/tools/libclang/CXCursor.cpp:1281 +if (const UsingShadowDecl *Shadow = Using->getFoundDecl()) + if (const auto *TD = dyn_cast_or_null(Shadow->getTargetDecl())) +return MakeCursorTypeRef(TD, Loc, TU); -

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c943e368818: [libclang] Remove redundant return statements in CXType.cpp (authored by emilio, committed by serge-sans-paille). Repository: rG LLV

[clang] 5c943e3 - [libclang] Remove redundant return statements in CXType.cpp

Author: Emilio Cobos Alvarez Date: 2023-03-01T07:29:11+01:00 New Revision: 5c943e36881815807e0f52743eabe785bf24e2db URL: https://github.com/llvm/llvm-project/commit/5c943e36881815807e0f52743eabe785bf24e2db DIFF: https://github.com/llvm/llvm-project/commit/5c943e36881815807e0f52743eabe785bf24e2d

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

0x59616e accepted this revision. 0x59616e added a comment. This revision is now accepted and ready to land. Shoot. I mixed it up with my own one. I'm sorry. I can't find any isseu in this patch and it LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 added a comment. In D144533#4160297 , @MaskRay wrote: > This change is an improvement but why is `__DATA_REGION_ORIGIN__` defined? Because, 1. Different AVR devices have different SRAM address range (start & length), and `__DATA_REGION_ORIGIN

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 501365. junaire added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/include

[PATCH] D141215: [clang-repl] Introduce Value and implement pretty printing

junaire updated this revision to Diff 501363. junaire edited the summary of this revision. junaire added a comment. Remove extra includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/inc

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 501362. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/Clang.cpp Index: clang/lib/Driver/ToolC

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 501360. junaire added a comment. Support printing temporaries. Note there's a ugly hack because I didn't find the right way to synthesize the AST for explicit destructor call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added a comment. Thanks both! Assuming this passes build, would one of you mind committing this for me? `Chris Cotter ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 ___

[PATCH] D143529: [M68k] Add support for basic memory constraints in inline asm

0x59616e requested changes to this revision. 0x59616e added a comment. This revision now requires changes to proceed. A few minor adjustments are required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143529/new/ https://reviews.llvm.org/D143529

[clang] db1b827 - Revert "[Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity"

Author: Chuanqi Xu Date: 2023-03-01T11:19:10+08:00 New Revision: db1b827ecfed6d311c315484f8a0bd78d4e9f99a URL: https://github.com/llvm/llvm-project/commit/db1b827ecfed6d311c315484f8a0bd78d4e9f99a DIFF: https://github.com/llvm/llvm-project/commit/db1b827ecfed6d311c315484f8a0bd78d4e9f99a.diff LO

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 501358. rsundahl added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 501357. rsundahl added a comment. Deleted extraneous line from compiler-rt/cmake/config-ix.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 Files: clang/inclu

[clang] 5bb3253 - Revert "[C++20] [Modules] Trying to compare the trailing require clause from the primary template function"

Author: Chuanqi Xu Date: 2023-03-01T11:04:20+08:00 New Revision: 5bb3253cf5b47dd49f431896b8d6412947a848f1 URL: https://github.com/llvm/llvm-project/commit/5bb3253cf5b47dd49f431896b8d6412947a848f1 DIFF: https://github.com/llvm/llvm-project/commit/5bb3253cf5b47dd49f431896b8d6412947a848f1.diff LO

[PATCH] D144878: __builtin_FILE_NAME()

MaskRay added a comment. It'd be nice to have compiler feature parity. I created a GCC feature request for `__builtin_FILE_NAME`: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108978 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https:/

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

MaskRay added a comment. This change is an improvement but why is `__DATA_REGION_ORIGIN__` defined? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144533/new/ https://reviews.llvm.org/D144533 ___ cfe-comm

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 501341. paulkirth added a comment. Allow EmbedBitcodePass to emit sections for Thin + Full LTO - Improve options handling when FatLTO is enabled, so LTO related flags are not dropped in CC1 - Misc code cleanups. I still view this as very much a WIP, but t

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The current implementation of `-p` does not claim the argument once it is passed. Since it pushes `-pg` directly, it

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

efriedma added a comment. Maybe worth cherry-picking to 16 branch? I think someone will need to rebase onto the branch for that, though; there was merge conflict on the microsoft-abi-eh-cleanups.cpp change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

efriedma closed this revision. efriedma added a comment. rG674099113533 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 _

[clang] 6740991 - [Clang][CodeGen] Fix this argument type for certain destructors

Author: Jacob Young Date: 2023-02-28T16:43:03-08:00 New Revision: 67409911353323ca5edf2049ef0df54132fa1ca7 URL: https://github.com/llvm/llvm-project/commit/67409911353323ca5edf2049ef0df54132fa1ca7 DIFF: https://github.com/llvm/llvm-project/commit/67409911353323ca5edf2049ef0df54132fa1ca7.diff L

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. In D143675#4160084 , @vitalybuka wrote: > Usually freezing signatures is not a big concern, we can agree to preserve > existing functions. > The stuff like ASanStackFrameLayout is the concern. compiler and runtime must > agree

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

thetruestblue added inline comments. Comment at: compiler-rt/cmake/config-ix.cmake:734 set(COMPILER_RT_HAS_ASAN TRUE) + set(COMPILER_RT_HAS_ASABI TRUE) else() This was an artifact leftover from some of my cmake changes. This line needs to be removed.. Re

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

emilio added a comment. In D140074#4159583 , @serge-sans-paille wrote: > The cleanup looks good to me, thanks! Out of curiosity, did just stumble on > this, or did an automatic tool gave you an hint? I was just reading through the code. Repository:

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl added a comment. Added to Discourse: https://discourse.llvm.org/t/darwin-sanitizers-stable-abi/68834 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 _

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

vitalybuka added a comment. Usually freezing signatures is not a big concern, we can agree to preserve existing functions. The stuff like ASanStackFrameLayout is the concern. compiler and runtime must agree on data layout. The same for global. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 501315. davidtgoldblatt added a comment. Use utils/update_cc_test_checks.py for the codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: cla

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce7eb2e05544: [Coroutines] Avoid creating conditional cleanup markers in suspend block (authored by weiwang). Repository: rG LLVM Github Monorepo

[clang] ce7eb2e - [Coroutines] Avoid creating conditional cleanup markers in suspend block

Author: Wei Wang Date: 2023-02-28T15:30:04-08:00 New Revision: ce7eb2e05544437af127684030a21b9e54a34f93 URL: https://github.com/llvm/llvm-project/commit/ce7eb2e05544437af127684030a21b9e54a34f93 DIFF: https://github.com/llvm/llvm-project/commit/ce7eb2e05544437af127684030a21b9e54a34f93.diff LOG:

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

rsundahl updated this revision to Diff 501308. rsundahl added a comment. Herald added subscribers: cfe-commits, luke, yaneury, supersymetrie, Chia-hungDuan, pcwang-thead, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7bb9a363923: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] a7bb9a3 - [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap

Author: Haowei Wu Date: 2023-02-28T15:19:23-08:00 New Revision: a7bb9a363923a6bfcc58a60b0442af8326422324 URL: https://github.com/llvm/llvm-project/commit/a7bb9a363923a6bfcc58a60b0442af8326422324 DIFF: https://github.com/llvm/llvm-project/commit/a7bb9a363923a6bfcc58a60b0442af8326422324.diff LOG

[PATCH] D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145010/new/ https://reviews.llvm.org/D145010 ___

[PATCH] D145010: [Fuchsia] Enable LLVM_USE_RELATIVE_PATHS_IN_FILES in bootstrap

haowei created this revision. haowei added reviewers: phosek, abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enables LLVM_USE_RELATIVE_PATHS_IN_FILES when building the bootstrap too

[PATCH] D110899: [Driver][XRay][test] XFAIL on linux with no environment specified

aaronpuchert added a comment. Herald added a project: All. Should be obsolete after 016785d9316d8c5abc5fdf3cdb86479095bbb677 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110899

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt added a comment. In addition to the release notes addition, I also added an entry in LanguageExtensions.rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 __

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt updated this revision to Diff 501297. davidtgoldblatt added a comment. Per comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136515/new/ https://reviews.llvm.org/D136515 Files: clang/docs/LanguageExtensions.rst clang/docs

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

ahatanak added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1093 +StatsFile, EC, +llvm::sys::fs::OF_Append | llvm::sys::fs::OF_TextWithCRLF); if (EC) { `OF_Append` is necessary when the results are written to a single

[PATCH] D144405: [clang][pp] Handle attributes defined by plugin in __has_attribute

erichkeane added a comment. This needs a release note. Otherwise I just have a preference for the 'is this spelling/syntax combo provided by this attribute' being in the plugin infrastructure. It DOES make me wonder however, what happens if TWO plugins provide a different 'true' answer for th

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC)

erichkeane added a comment. I see now having seen the other review, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144404/new/ https://reviews.llvm.org/D144404 ___ cfe-commits mailing list cfe-commi

[PATCH] D144404: [clang] Extract function for generated part of clang::hasAttribute (NFC)

erichkeane added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:39 -#include "clang/Basic/AttrHasAttributeImpl.inc" + int res = hasAttributeImpl(Syntax, Name, ScopeName, Target, LangOpts); + if (res) Why is this not just return `hasAttributeImpl(

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd created this revision. compnerd added reviewers: rnk, mstorsjo. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. Add a set of `-Xmicrosoft` flags to control the Windows SDK and VisualC tools directories. This allows control over the

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

zequanwu added a comment. Thanks for fixing it. Just one comment. Comment at: clang/test/CoverageMapping/terminate-statements.cpp:335 + ( true ? void (0) : abort() ); // CHECK: Gap,File 0, [[@LINE]]:33 -> [[@LINE+1]]:3 = #1 + ( false ? void (0) : abort() ); // CHECK: Gap,F

[clang] ece0b96 - Revert "[X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS"

Author: ManuelJBrito Date: 2023-02-28T21:50:36Z New Revision: ece0b96979c88bab9ec6c53b4d59f7c4b1dce017 URL: https://github.com/llvm/llvm-project/commit/ece0b96979c88bab9ec6c53b4d59f7c4b1dce017 DIFF: https://github.com/llvm/llvm-project/commit/ece0b96979c88bab9ec6c53b4d59f7c4b1dce017.diff LOG:

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau marked an inline comment as done. amurzeau added a comment. I see the build is still marked as failed in phabricator, but succeed in buildkite, do I need to do something, like a rebuild ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14491

[clang] 9e58182 - [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

Author: ManuelJBrito Date: 2023-02-28T21:39:10Z New Revision: 9e58182d6446bb61dbd13c0e6314f291e50d4d7c URL: https://github.com/llvm/llvm-project/commit/9e58182d6446bb61dbd13c0e6314f291e50d4d7c DIFF: https://github.com/llvm/llvm-project/commit/9e58182d6446bb61dbd13c0e6314f291e50d4d7c.diff LOG:

[PATCH] D144884: [clang-format] Only add pragma continuation indentation for 'omp' clauses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG466b4327f8fc: [clang-format] Only add pragma continuation indentation for 'omp' clauses (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] 466b432 - [clang-format] Only add pragma continuation indentation for 'omp' clauses

Author: Joseph Huber Date: 2023-02-28T15:15:44-06:00 New Revision: 466b4327f8fcaf82178b02dffc66a5ff11a150d4 URL: https://github.com/llvm/llvm-project/commit/466b4327f8fcaf82178b02dffc66a5ff11a150d4 DIFF: https://github.com/llvm/llvm-project/commit/466b4327f8fcaf82178b02dffc66a5ff11a150d4.diff

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev planned changes to this revision. v.g.vassilev added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}}

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. The cleanup looks good to me, thanks! Out of curiosity, did just stumble on this, or did an automatic tool gave you an hint? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D140075: [libclang] Expose using shadow types and declarations in libclang.

emilio updated this revision to Diff 501270. emilio added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140075/new/ https://reviews.llvm.org/D140075 Files: clang/include/clang-c/Index.h clang/lib/Sema/SemaCodeComplete.cpp c

[PATCH] D140074: [libclang] Remove redundant return statements in CXType.cpp

emilio updated this revision to Diff 501269. emilio added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140074/new/ https://reviews.llvm.org/D140074 Files: clang/tools/libclang/CXType.cpp Index: clang/tools/libclang/CXType.cp

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:80 -return llvm::StringSwitch(CPUName) -.Case("common", "generic") -.Case("440fp", "440") -.Case("630", "pwr3") -.Case("G3", "

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 501264. qiongsiwu1 added a comment. Update lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! > The __builtin_align_{up,down} code generation could also make use of this > IIRC. I think the reason I didn't do this initially was concerns about > ptrmask not being optimized

[PATCH] D144993: [OpenMP] Emit captured decls for target data if no devices were specified.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacc30a169eab: [OpenMP]Emit captured decls for target data if no devices were specified. (authored by ABataev). Repository: rG LLVM Github Monorepo

[clang] acc30a1 - [OpenMP]Emit captured decls for target data if no devices were specified.

Author: Alexey Bataev Date: 2023-02-28T12:18:00-08:00 New Revision: acc30a169eabae8ae7d46e8dc3b6466abbc53dc4 URL: https://github.com/llvm/llvm-project/commit/acc30a169eabae8ae7d46e8dc3b6466abbc53dc4 DIFF: https://github.com/llvm/llvm-project/commit/acc30a169eabae8ae7d46e8dc3b6466abbc53dc4.diff

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

MaskRay added inline comments. Comment at: clang/test/Driver/config-file3.c:227 +// +// RUN: HOME=%S/Inputs/config %clang --config-user-dir=~ -v 2>&1 | FileCheck %s -check-prefix CHECK-TILDE +// CHECK-TILDE: User configuration file directory: {{.*}}/Inputs/config ---

[clang] 37216b4 - [test] Add missing -### to Driver/config-file3.c

Author: Fangrui Song Date: 2023-02-28T12:16:28-08:00 New Revision: 37216b4b3aaab1fb293b7f628f8dd4999c0abb80 URL: https://github.com/llvm/llvm-project/commit/37216b4b3aaab1fb293b7f628f8dd4999c0abb80 DIFF: https://github.com/llvm/llvm-project/commit/37216b4b3aaab1fb293b7f628f8dd4999c0abb80.diff

[clang] fb166b4 - [Driver] Revert -mcpu=?/-mtune=? and make -mcpu=help/-mtune=help unnamed

Author: Fangrui Song Date: 2023-02-28T12:06:36-08:00 New Revision: fb166b44f9332b2b4365b90ee3ec95cfce9c0ad5 URL: https://github.com/llvm/llvm-project/commit/fb166b44f9332b2b4365b90ee3ec95cfce9c0ad5 DIFF: https://github.com/llvm/llvm-project/commit/fb166b44f9332b2b4365b90ee3ec95cfce9c0ad5.diff

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501250. bob80905 added a comment. - ushort is now unsigned Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. Since `llc` has `-mcpu=help`, it seems fine to have `clang -mcpu=help`. I made a bad suggestion there about `-mcpu=?`. Perhaps I should revert de94ac9357750fdba45e09eefa8f67a650ae6a64 . This `-mcpu=help` patch is good. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:221-225 + if (const Function *Func = S.Current->getFunction(); + Func && (Func->isConstructor() || Func->isDestructor())) { +if (Ptr.block() == S.Current->getThis().block()) + return t

[PATCH] D144309: [HLSL] add max/min library functions

bob80905 updated this revision to Diff 501248. bob80905 added a comment. - add support for these types: i16/u16/i32/u32/i64/u64/f16/f32/f64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309 Files: clang/l

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

michaelmaitland added a comment. In D144914#4159291 , @MaskRay wrote: > Sorry I just saw this but I am not sure this is a good idea. Why can't the > user use `--print-supported-cpus` instead? The additional alias doesn't seem > useful. If you can make G

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau updated this revision to Diff 501247. amurzeau added a comment. Fix clang-format error, release notes and factorize typedefs in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144912/new/ https://reviews.llvm.org/D144912 Files: cla

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

usama54321 accepted this revision. usama54321 added a comment. This revision is now accepted and ready to land. I was verifying that static versions of these libraries are not present on darwin. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D144993: [OpenMP]Emit captured decls for target data if no devices were specified.

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG, thanks a lot for the quick fix. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7294 + // Emit helper decls of the use_device_ptr/use_device_addr clauses. +

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

tlively added a comment. In D139010#4158540 , @aaron.ballman wrote: > Roping in @jfb because I know he's been heavily involve in WebAssembly in the > past and he may have ideas/opinions. > > High-level question: are externref, funcref, and table types a

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. FWIW I think this should be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. Sorry I just saw this but I am not sure this is a good idea. Why can't the user use `--print-supported-cpus` instead? The additional alias doesn't seem useful. If you can make GCC add this as well, it will be different. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D144993: [OpenMP]Emit captured decls for target data if no devices were specified.

ABataev created this revision. ABataev added a reviewer: jhuber6. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ABataev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. If use_devic

[PATCH] D144990: [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ce68969b902: [Sema] Add missing entries to the arrays in GetImplicitConversionName and… (authored by craig.topper). Repository: rG LLVM Github Mo

[clang] 8ce6896 - [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

Author: Craig Topper Date: 2023-02-28T11:16:45-08:00 New Revision: 8ce68969b90288a3dc75c5c15283fc11f97b278a URL: https://github.com/llvm/llvm-project/commit/8ce68969b90288a3dc75c5c15283fc11f97b278a DIFF: https://github.com/llvm/llvm-project/commit/8ce68969b90288a3dc75c5c15283fc11f97b278a.diff

[PATCH] D144990: [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch and nice solution! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144990/new/ https://reviews.llvm.org/D144990 __

[clang] 33e18cb - Revert "Revert "[Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity""

Author: Mark de Wever Date: 2023-02-28T20:03:54+01:00 New Revision: 33e18cb6ce7a478d3c381c1c7ef2501787fed6f4 URL: https://github.com/llvm/llvm-project/commit/33e18cb6ce7a478d3c381c1c7ef2501787fed6f4 DIFF: https://github.com/llvm/llvm-project/commit/33e18cb6ce7a478d3c381c1c7ef2501787fed6f4.diff

[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73c98831f648: [clang][dataflow] Fix missed fields in field set construction. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 73c9883 - [clang][dataflow] Fix missed fields in field set construction.

Author: Yitzhak Mandelbaum Date: 2023-02-28T18:56:54Z New Revision: 73c98831f6482371f9b773592478ea9e51a6b16a URL: https://github.com/llvm/llvm-project/commit/73c98831f6482371f9b773592478ea9e51a6b16a DIFF: https://github.com/llvm/llvm-project/commit/73c98831f6482371f9b773592478ea9e51a6b16a.diff

[PATCH] D144990: [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, erichkeane. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. It appears that ICK_Zero_Queue_Conversion was inserted into the ICK enum without updating this ta

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG003078b62d8d: [Clang][Driver] Add -mcpu=help and -mtune=help to clang (authored by michaelmaitland). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new

[clang] 003078b - [Clang][Driver] Add -mcpu=help and -mtune=help to clang

Author: Michael Maitland Date: 2023-02-28T10:45:35-08:00 New Revision: 003078b62d8d40fc000462a97c3b70e01cbe4458 URL: https://github.com/llvm/llvm-project/commit/003078b62d8d40fc000462a97c3b70e01cbe4458 DIFF: https://github.com/llvm/llvm-project/commit/003078b62d8d40fc000462a97c3b70e01cbe4458.di

[PATCH] D144889: [C2x] Support in freestanding

aaron.ballman added a comment. In D144889#4158935 , @jyknight wrote: >> On the other hand, I think a not-insignificant number of users are >> interested in freestanding environments for one-off/fun/experimental >> projects where ease of access is more i

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actually

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm added a comment. Thanks @aaron.ballman and @erichkeane for the comments. I'll split it into stages and use tablegen more, like you say. In D139028#4150761 , @aaron.ballman wrote: > One thing that might also help is to split this into a fe

[clang] 2ae3990 - Revert "[Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity"

Author: Mark de Wever Date: 2023-02-28T19:36:56+01:00 New Revision: 2ae39902506f38d6368a7dbe3d64109f57ad6f99 URL: https://github.com/llvm/llvm-project/commit/2ae39902506f38d6368a7dbe3d64109f57ad6f99 DIFF: https://github.com/llvm/llvm-project/commit/2ae39902506f38d6368a7dbe3d64109f57ad6f99.diff

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:79 +Opts.PreambleStoragePath = NULL; +Opts.InvocationEmissionPath = getenv("CINDEXTEST_INVOCATION_EMISSION_PATH"); + vedgy wrote: > aaron.ballman wrote: > > vedgy wr

[PATCH] D144961: [NVPTX] Add f16 and v2f16 ldg builtins

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/NVPTX/ldu-ldg.ll:5-6 declare i8 @llvm.nvvm.ldu.global.i.i8.p1(ptr addrspace(1) %ptr, i32 %align) declare i32 @llvm.nvvm.ldu.global.i.i32.p1(pt

[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. When building the set of referenc

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, the modules failures is a previous known issue. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ens

  1   2   >