[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

nridge created this revision. nridge added reviewers: kadircet, hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https:

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 marked 2 inline comments as done. ym1813382441 added a comment. F26630797: Screenshot from 2023-02-24 15-54-21.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144696/new/ https://reviews.llvm.org

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

craig.topper added a comment. You outline your full plan and why you want to do this. We need to see the bigger picture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144696/new/ https://reviews.llvm.org/D144696 __

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. I want to use arrays to maintain the supported version number of each extension, this patch in using the `find` algorithm helps to simplify the code. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:24 + unsigned Minor; + bool operator==(con

[PATCH] D144510: [clang-tidy] improve readability-identifier-naming hungarian options test

carlosgalvezp added a comment. @amurzeau I'm having some trouble downloading the patch, would you mind trying out a rebase on top of latest master? Otherwise I'll try downloading the raw diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144510/n

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

This revision was automatically updated to reflect the committed changes. Closed by commit rG87447bedac34: [clang-tidy] Fix readability-identifer-naming Hungarian CString options (authored by amurzeau, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 87447be - [clang-tidy] Fix readability-identifer-naming Hungarian CString options

Author: Alexis Murzeau Date: 2023-02-24T07:15:19Z New Revision: 87447bedac341f023569f1b444f9b3b62bba5aa6 URL: https://github.com/llvm/llvm-project/commit/87447bedac341f023569f1b444f9b3b62bba5aa6 DIFF: https://github.com/llvm/llvm-project/commit/87447bedac341f023569f1b444f9b3b62bba5aa6.diff LOG

[clang] 255b2d8 - Add test for issue 60486

Author: Chuanqi Xu Date: 2023-02-24T14:32:05+08:00 New Revision: 255b2d8162ead0ad444698506f97484572e574b1 URL: https://github.com/llvm/llvm-project/commit/255b2d8162ead0ad444698506f97484572e574b1 DIFF: https://github.com/llvm/llvm-project/commit/255b2d8162ead0ad444698506f97484572e574b1.diff LO

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:520 auto ExprStartLoc = SM.getTopMacroCallerLoc(E->getBeginLoc()); -auto Decomposed = SM.getDecomposedLoc(ExprStartLoc); +auto Decomposed = SM.getDecomposedExpansionLoc(ExprStartLoc);

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

eopXD added a comment. Thank you for the patch. May you explain how this would help support multi-versioning? Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:24 + unsigned Minor; + bool operator==(const RISCVExtensionVersion &Vers) const { +return this->Major == Ver

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 created this revision. Herald added subscribers: luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, s

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

ChuanqiXu added a comment. Yeah, it looks better indeed to not store additional information. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144626/new/ https://reviews.llvm.org/D144626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

ChuanqiXu updated this revision to Diff 500046. ChuanqiXu added a comment. Address comments: - Don't store the original trailing require clause. Trying to get the trailing require clause of the primary template function when ODR checking instead. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19036 bool Sema::tryCaptureVariable( ValueDecl *Var, SourceLocation ExprLoc, TryCaptureKind Kind, We have a bunch of bugs that crash in the method and it would be good to rescreen thos

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

vitalybuka added subscribers: kstoimenov, vitalybuka. vitalybuka added a comment. One of your patches likely introduced UB https://lab.llvm.org/buildbot/#/builders/85/builds/14558 Can you please take a look? FYI, @kstoimenov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

rupprecht added a comment. This has already been reverted, but I found a breakage (not a crash) caused by this: #include class Base { protected: int member; }; template struct Subclass : public Parent { static_assert(std::is_base_of::value, "Parent

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

shafik added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:537 +if (!CapturedPattern->isParameterPack()) { + ValueDecl *CapturedVar = + LambdaClass->getCapture(Instantiated)->getCapturedVar(); This is just duplicated across the `if

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

ChuanqiXu added a comment. BTW, what is the conclusion for the concern about sanitizers? Would change make sanitizers to perform false positive diagnostics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144680/new/ https://reviews.llvm.org/D144680

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:28 -// We try to save some space by using 6 bits over two PointerIntPairs to store -// the alignment. However, some arches don't support 3 bits in a PointerIntPair -// so we fallback to storing the alignmen

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

shafik added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1301-1302 SourceLocation AttrNameLoc = ConsumeToken(); -Attr.addNew(AttrName, AttrNameLoc, nullptr, AttrNameLoc, nullptr, 0, -ParsedAttr::AS_Keyword); +Attribut

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

ChuanqiXu added a comment. The test should be required here. Comment at: clang/lib/CodeGen/CGExpr.cpp:544 // so that it's unconditional. Don't do this with sanitizers which need // more precise lifetime marks. ConditionalEvaluation *OldConditional = nullptr

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

rupprecht accepted this revision as: rupprecht. rupprecht added a comment. All the things that were broken before are no longer broken, so LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

ahatanak added a comment. I don't have a test case for this change because there is a bug that prevents using the maximum allowed alignment (see https://github.com/llvm/llvm-project/issues/60752). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1446

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

ahatanak created this revision. ahatanak added reviewers: aeubanks, efriedma, rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This fixes a bug introduced in https://reviews.llvm.org/D142584. The patch reduced the number of bits u

[clang-tools-extra] 5a623c2 - Revert "Revert "[Tooling/Inclusion] Handle std::get symbol.""

Author: Kadir Cetinkaya Date: 2023-02-24T01:24:53+01:00 New Revision: 5a623c2a082d007c1cc7a878b666b3581bb8f8dc URL: https://github.com/llvm/llvm-project/commit/5a623c2a082d007c1cc7a878b666b3581bb8f8dc DIFF: https://github.com/llvm/llvm-project/commit/5a623c2a082d007c1cc7a878b666b3581bb8f8dc.dif

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

aeubanks created this revision. aeubanks added reviewers: hans, thakis. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. With recent MSVC releases, STL headers will add /INFERASANLIBS to the drec

[PATCH] D144683: [analyzer] Fix of the initialization list parsing.

earnol created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. earnol requested review of this revision. H

[clang] 21631b5 - [clang] fix intendation in newly added release note

Author: Alex Lorenz Date: 2023-02-23T15:53:07-08:00 New Revision: 21631b567e88b5a1146a74b0a25f7a20afef8afb URL: https://github.com/llvm/llvm-project/commit/21631b567e88b5a1146a74b0a25f7a20afef8afb DIFF: https://github.com/llvm/llvm-project/commit/21631b567e88b5a1146a74b0a25f7a20afef8afb.diff L

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

bruno added a comment. Thanks for working on this Wei! Can you please add a testcase? Comment at: clang/lib/CodeGen/CodeGenFunction.h:336 std::unique_ptr Data; +bool InSuspendBlock = false; CGCoroInfo(); Should this live inside CGCoroData instead

[clang] 7c9b15f - Revert "[Tooling/Inclusion] Handle std::get symbol."

Author: Caroline Tice Date: 2023-02-23T15:18:17-08:00 New Revision: 7c9b15fbaeb2846ad25e797d55ffe1ccef9e1379 URL: https://github.com/llvm/llvm-project/commit/7c9b15fbaeb2846ad25e797d55ffe1ccef9e1379 DIFF: https://github.com/llvm/llvm-project/commit/7c9b15fbaeb2846ad25e797d55ffe1ccef9e1379.diff

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:548 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) MaskRay wrote: > The comment just repea

[clang] 9161043 - [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

Author: Ben Shi Date: 2023-02-24T07:16:31+08:00 New Revision: 91610433907ebc335576f0da286f0c8a7793e3a9 URL: https://github.com/llvm/llvm-project/commit/91610433907ebc335576f0da286f0c8a7793e3a9 DIFF: https://github.com/llvm/llvm-project/commit/91610433907ebc335576f0da286f0c8a7793e3a9.diff LOG:

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rG91610433907e: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D144620?vs=

[clang] ab9b2fe - [Driver] Define BareMetal::HasNativeLLVMSupport to return true

Author: Fangrui Song Date: 2023-02-23T15:06:02-08:00 New Revision: ab9b2fe2a5f817f3bbca0d187a99aaae23e75d6a URL: https://github.com/llvm/llvm-project/commit/ab9b2fe2a5f817f3bbca0d187a99aaae23e75d6a DIFF: https://github.com/llvm/llvm-project/commit/ab9b2fe2a5f817f3bbca0d187a99aaae23e75d6a.diff

[PATCH] D142794: [-Wunsafe-buffer-usage] Fixits for assignment to array subscript expr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2652963b6b: [-Wunsafe-buffer-usage] Fixits for assignments to array subscript expressions (authored by ziqingluo-90). Herald added a project: clang

[clang] cd26529 - [-Wunsafe-buffer-usage] Fixits for assignments to array subscript expressions

Author: Ziqing Luo Date: 2023-02-23T15:02:46-08:00 New Revision: cd2652963b6b97c01329419f15c336e5560afa98 URL: https://github.com/llvm/llvm-project/commit/cd2652963b6b97c01329419f15c336e5560afa98 DIFF: https://github.com/llvm/llvm-project/commit/cd2652963b6b97c01329419f15c336e5560afa98.diff LO

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang created this revision. Herald added subscribers: ChuanqiXu, hoy, wenlei. Herald added a project: All. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144680 F

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b37e48f6f0: [clang] extend external_source_symbol attribute with USR clause (authored by arphaman). Herald added a project: clang. Changed prior t

[clang] c8b37e4 - [clang] extend external_source_symbol attribute with USR clause

Author: Alex Lorenz Date: 2023-02-23T14:59:26-08:00 New Revision: c8b37e48f6f00bb2aa3882ca3cc26082f85ca999 URL: https://github.com/llvm/llvm-project/commit/c8b37e48f6f00bb2aa3882ca3cc26082f85ca999 DIFF: https://github.com/llvm/llvm-project/commit/c8b37e48f6f00bb2aa3882ca3cc26082f85ca999.diff L

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

isuckatcs updated this revision to Diff 40. isuckatcs added a comment. fixed failing test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/util

[PATCH] D144136: Add a "remark" to report on array accesses

kees added a comment. This gets me all 6 reports. The details about the array and the index don't really matter for the basic metrics: diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/Diagnostic SemaKinds.td index ba831c026342..29d2167b504b 100644

[PATCH] D143697: [-Wunsafe-buffer-usage] Create Fix-Its only if they are emitted

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf78c34346635: [-Wunsafe-buffer-usage] Create Fix-Its only if they are emitted (authored by ziqingluo-90). Herald added a project: clang. Herald added

[clang] f78c343 - [-Wunsafe-buffer-usage] Create Fix-Its only if they are emitted

Author: Ziqing Luo Date: 2023-02-23T14:47:43-08:00 New Revision: f78c34346635e25919e2777b1b1cbb9627d5ad43 URL: https://github.com/llvm/llvm-project/commit/f78c34346635e25919e2777b1b1cbb9627d5ad43 DIFF: https://github.com/llvm/llvm-project/commit/f78c34346635e25919e2777b1b1cbb9627d5ad43.diff LO

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

NoQ added a comment. Yeah looks like I replied without properly reading the patch. `TaintBugReport` is brilliant and we already have a precedent for subclassing `BugReport` in another checker. However I'm somewhat worried that once we start doing more of this, we'll eventually end up with multi

[PATCH] D144431: [clang-tidy] Fix readability-identifer-naming Hungarian CString options

amurzeau added a comment. In D144431#4146524 , @carlosgalvezp wrote: > Alright, sounds good, thanks for the clarification! Then I misunderstood the > change in the tests and indeed it belonged together in this patch, sorry for > the confusion. I have a

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

stephenpeckham accepted this revision. stephenpeckham added a comment. This revision is now accepted and ready to land. I don't have issues with this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 499963. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/do

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 499962. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMe

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 499953. michaelplatings added a comment. PrintArgs -> PrintOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp c

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. In D143524#4148344 , @v.g.vassilev wrote: > In D143524#4148271 , @philnik wrote: > >> It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. >> It warns that the ded

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4148271 , @philnik wrote: > It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. > It warns that the deduction guide is unused, but the deduction guide is > required suppress `-Wctad-maybe-

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. > Imaginate that such trivial type could be for example 200KB in size This should be passed by const ref then correct (listed under "Expensive to move (e.g. big BigPOD[]" in the parameter passing guidelines

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

carlosgalvezp added a comment. In D143996#4147759 , @bjosv wrote: > @carlosgalvezp Sorry, I should have mentioned that I don't have push rights > and that this is my first contribution to llvm. > My GitHub user is: bjosv and email: bjorn.a.svens...@e

[clang-tools-extra] 2928746 - [clang-tidy][doc] Remove unused variable

Author: Björn Svensson Date: 2023-02-23T20:07:50Z New Revision: 2928746ac3f1aabbecbe8da1525127443ebec2cf URL: https://github.com/llvm/llvm-project/commit/2928746ac3f1aabbecbe8da1525127443ebec2cf DIFF: https://github.com/llvm/llvm-project/commit/2928746ac3f1aabbecbe8da1525127443ebec2cf.diff LOG

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG2928746ac3f1: [clang-tidy][doc] Remove unused variable (authored by bjosv, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143996/

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. It looks like this warning is incompatible with `-Wctad-maybe-unsupported`. It warns that the deduction guide is unused, but the deduction guide is required suppress `-Wctad-maybe-unsupported`. https://godbolt.org/z/G8bMjYsbn Repository: rC Clang CHANGES SINCE LAST

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

This revision was automatically updated to reflect the committed changes. Closed by commit rG608ee703e530: [SCEV] Ensure SCEV does not replace aliases with their aliasees (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

phosek added inline comments. Comment at: lld/test/ELF/fatlto/Inputs/a-fatLTO.yaml:23 +AddressAlign:0x1 +Content: 4243C0DE35140500620C30244D59BE669DFBB44F1BC8244401320500210C7B020B022100020016000781239141C80449061032399201840C250508191

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

jdoerfert added a comment. We need tests. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7790 + for (const auto *C : S.getClausesOfKind()) { +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { style, also below. Repository: rG

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc21378f90a44: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions (authored by MatzeB). Repository: rG LLVM Github Monorepo CHAN

[clang-tools-extra] c21378f - [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

Author: Matthias Braun Date: 2023-02-23T11:26:41-08:00 New Revision: c21378f90a4442810adc4af924a83a9c222fdc51 URL: https://github.com/llvm/llvm-project/commit/c21378f90a4442810adc4af924a83a9c222fdc51 DIFF: https://github.com/llvm/llvm-project/commit/c21378f90a4442810adc4af924a83a9c222fdc51.diff

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 499922. mysterymath added a comment. Use #if to select between signed and unsigned USHRT_MAX. Add tests for the types of limit macros specified by the standard. Add tests that limit macros can be used in #if. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:548 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax, options:

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added inline comments. Comment at: lld/test/ELF/fatlto/Inputs/a-fatLTO.yaml:23 +AddressAlign:0x1 +Content: 4243C0DE35140500620C30244D59BE669DFBB44F1BC8244401320500210C7B020B022100020016000781239141C80449061032399201840C250508

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. In D143524#4148039 , @philnik wrote: > In D143524#4148024 , @v.g.vassilev > wrote: > >> In D143524#4148006

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. In D143524#4148024 , @v.g.vassilev wrote: > In D143524#4148006 , @philnik wrote: > >> The emitted warnings from the libc++ CI look like a false-positive to me. >> While the functions are

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -template static void f() {} +template static void f() {} // expected-warning {{unused function template}}

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth updated this revision to Diff 499913. paulkirth retitled this revision from "[WIP][Do NOT review] LLD related changes for -ffat-lto-objects support" to "[clang][llvm][lld] FatLTO Prototype". paulkirth edited the summary of this revision. paulkirth added a comment. Rebase revision. Aband

[PATCH] D144115: [clang] Extend pragma dump to support expressions

Endill added a comment. Thank you for reviewing this! In D144115#4147440 , @aaron.ballman wrote: > You should add test coverage for the changes, especially around things like > dependent expressions, ADL use, etc. Also, the changes need a release note

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4148006 , @philnik wrote: > The emitted warnings from the libc++ CI look like a false-positive to me. > While the functions are never called, they are used in an unevaluated > context. I would expect `-Wunused` w

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath marked an inline comment as done. mysterymath added inline comments. Comment at: clang/lib/Headers/limits.h:55 #define UCHAR_MAX (__SCHAR_MAX__*2 +1) -#define USHRT_MAX (__SHRT_MAX__ *2 +1) +#define USHRT_MAX (__SHRT_MAX__ * 2U + 1U) #define UINT_MAX (__INT_MAX__

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

paulkirth commandeered this revision. paulkirth edited reviewers, added: arda; removed: paulkirth. paulkirth added a comment. I'll be updating this patch soon with a rebased version. Likely that will need to be split up into a series of smaller patches. There is also some design work that needs

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

MatzeB updated this revision to Diff 499909. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144599/new/ https://reviews.llvm.org/D144599 Files: clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp Index: clang-tools-extra/clangd/index/remote

[PATCH] D143524: Make the -Wunused-template default.

philnik added a comment. The emitted warnings from the libc++ CI look like a false-positive to me. While the functions are never called, they are used in an unevaluated context. I would expect `-Wunused` warnings to only be emitted when I can just remove the code without problems, which doesn't

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4147578 , @aaron.ballman wrote: > In D143418#4131156 , @vedgy wrote: > >> On second thought, the proposed `clang_getDefaultGlobalOptions()` API >> already offers users a choice

[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

MatzeB added a comment. > Asking as it'd be great to know that we've adoption here, outside of > ourselves. I'm not involved in any of this myself. But @kuganv is :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144599/new/ https://reviews.llvm.o

[PATCH] D143524: Make the -Wunused-template default.

aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. Precommit CI shows issues with the libc++ tests that need to be addressed. This should also come with a release note. Comment at: clang/test/SemaCXX/warn-func-not-needed.cpp:13 namespace test1_template { -

[PATCH] D144616: Skip generating this[:1] map info for non-member variable.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b72a3276243: Skip using this[:1] map info for non-member variable. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144616/new/ https://re

[clang] 1b72a32 - Skip using this[:1] map info for non-member variable.

Author: Jennifer Yu Date: 2023-02-23T09:27:56-08:00 New Revision: 1b72a32762436aad1b7064a8d44681300fd8e380 URL: https://github.com/llvm/llvm-project/commit/1b72a32762436aad1b7064a8d44681300fd8e380 DIFF: https://github.com/llvm/llvm-project/commit/1b72a32762436aad1b7064a8d44681300fd8e380.diff L

[PATCH] D143560: clang-format.el: fix warnings

augfab added a comment. Hi @phst , is anything left for me to do before this patch is merged? This is my first patch to LLVM so I'm not too familiar with the process. Thanks for your help 🙂 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 _

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. Thank you for checking and removing EltTypeBool128. I think you have addressed all of the other comments on this patch too, so it looks good to me! Please can you update the commit m

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. In D141569#4147268 , @ccotter wrote: > Trivial types should not be passed by rvalue reference, but by value per the > diagram under > http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#fcall-parameter-passing. > I fee

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin updated this revision to Diff 499898. cor3ntin added a comment. I played with different diagnostics, we already specialize the literal case, and I didn't find that not saying a static_assert failed improved things. Instead, printing, in addition of that diagnostic, an instantiation stack

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn created this revision. john.brawn added reviewers: rsmith, jansvoboda11, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we warn when MI->isBuiltinMacro, but this is onl

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499896. VitaNuo added a comment. Merge upstream changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extr

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

This revision was automatically updated to reflect the committed changes. VitaNuo marked an inline comment as done. Closed by commit rGe028c9742897: Move the BySpelling map to IncludeStructure. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] e028c97 - Move the BySpelling map to IncludeStructure.

Author: Viktoriia Bakalova Date: 2023-02-23T17:11:31Z New Revision: e028c9742897cc14c47c426893fb40f571f6fad6 URL: https://github.com/llvm/llvm-project/commit/e028c9742897cc14c47c426893fb40f571f6fad6 DIFF: https://github.com/llvm/llvm-project/commit/e028c9742897cc14c47c426893fb40f571f6fad6.diff

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

erichkeane added a comment. Woops, I just saw my fixme :D I forgot we needed to do that for comparison of constraints. That said I dont think you need to store it, I think we can just pick up the 'original' one from the primary template. I did work at one point to make sure that the get-inst

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499886. VitaNuo added a comment. Upload once again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D144626: [C++20] [Modules] Provide OriginalTrailingRequiresClause for serializer to perform ODR-Checking correctly

erichkeane added a comment. I think the problem is more that we are modifying the expression in the AST. I don't think now that we have the 'deferred concepts instantiation' that we should be storing/saving the updated requires clause back to the AST, right? We should be re-evaluating it (wit

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn created this revision. john.brawn added reviewers: mstorsjo, jansvoboda11, DHowett-MSFT, sammccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix two problems happening during deseria

[PATCH] D144447: [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83cd4bea015f: [Clang] Teach buildFMulAdd to peek through fneg to find fmul. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANG

[clang] 83cd4be - [Clang] Teach buildFMulAdd to peek through fneg to find fmul.

Author: Craig Topper Date: 2023-02-23T09:05:59-08:00 New Revision: 83cd4bea015feb5729871832784c424b0743a803 URL: https://github.com/llvm/llvm-project/commit/83cd4bea015feb5729871832784c424b0743a803 DIFF: https://github.com/llvm/llvm-project/commit/83cd4bea015feb5729871832784c424b0743a803.diff

[PATCH] D144613: [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbf149c91b7b: [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D144613?vs=499711&id=499882#toc Repos

[clang] dbf149c - [RISCV] Properly diagnose mixing RVV scalable vectors with GNU vectors.

Author: Craig Topper Date: 2023-02-23T09:00:32-08:00 New Revision: dbf149c91b7bdf08b2d4dd94ab76f3209af4c6d4 URL: https://github.com/llvm/llvm-project/commit/dbf149c91b7bdf08b2d4dd94ab76f3209af4c6d4 DIFF: https://github.com/llvm/llvm-project/commit/dbf149c91b7bdf08b2d4dd94ab76f3209af4c6d4.diff

[PATCH] D143996: [clang-tidy][doc] Remove unused variable

bjosv added a comment. @carlosgalvezp Sorry, I should have mentioned that I don't have push rights and that this is my first contribution. My GitHub user is: bjosv and email: bjorn.a.svens...@est.tech Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143996/new/ https://reviews

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:408 + +bool isFilteredByConfig(const Config &Cfg, llvm::StringRef HeaderSpelling) { + for (auto &Filter : Cfg.Diagnostics.Includes.IgnoreHeader) { kadirce

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 499879. VitaNuo marked 18 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-to

[clang] 1812e13 - Revert "[clang] Add the check of membership for the issue #58674 and improve the lookup process"

Author: Alexander Kornienko Date: 2023-02-23T17:31:04+01:00 New Revision: 1812e13a3d6be9a838672ff74b3d9d383f5a83b5 URL: https://github.com/llvm/llvm-project/commit/1812e13a3d6be9a838672ff74b3d9d383f5a83b5 DIFF: https://github.com/llvm/llvm-project/commit/1812e13a3d6be9a838672ff74b3d9d383f5a83b5

[PATCH] D140992: clang: Add __builtin_elementwise_fma

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Sema/SemaChecking.cpp:17761-17766 + for (int I = 0; I < 3; ++I) { +ExprResult Converted = UsualUnaryConversions(TheCall->getArg

  1   2   >