[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 479898. lime added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/Se

[PATCH] D136078: Use-after-return sanitizer binary metadata

MaskRay added a comment. ` SanitizerBinaryMetadata::createZeroSizedObjectInSection` creates `__dummy_*`, but why is it needed? (There is no comment.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 _

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 created this revision. strimo378 added a project: clang. Herald added subscribers: jeroen.dobbelaere, kosarev. Herald added a project: All. strimo378 requested review of this revision. Herald added a subscriber: cfe-commits. Hi all, this is my first contribution to the LLVM project. Th

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

owenpan added a comment. The refactoring `std::max(0, C.Spaces)` part still looks good though, but probably it's not worth it to have a patch just for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138378/new/ https://reviews.llvm.org/D138378 _

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd created this revision. compnerd added reviewers: aaron.ballman, Mordante, fsb4000. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. MSVC requires that C++23 be available (`_HAS_CXX23`) else the entire content is elided. Conditionalis

[PATCH] D138358: [clang-format] Match all block braces

owenpan added a comment. In D138358#3968759 , @HazardyKnusperkeks wrote: > In D138358#3968610 , @owenpan wrote: > >> Please see D139257 for a different >> approach. > > All my

[PATCH] D139257: [clang-format][NFC] Link braces of a block in UnwrappedLineParser

owenpan updated this revision to Diff 479884. owenpan added a comment. Updated `resetOptional()` to make resetting `Optional` more obvious. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139257/new/ https://reviews.llvm.org/D139257 Files: clang/lib/Format/UnwrappedLineParser.cpp cla

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

shafik added a comment. I realize I am modifying codegen but the test is in sema, I am happy to move the test to somewhere more appropriate if someone has a good suggestion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139261/new/ https://reviews.llvm.org/D139261

[PATCH] D139261: [Clang] Modify sanity check assert in AggExprEmitter::VisitInitListExpr to cover anonymous struct in a union GNU extension

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. `AggExprEmitter::VisitInitListExpr` sanity checks that an empty union is really empty and not a semantic analysis failure. The assert is missing

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a subscriber: tentzen. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitChec

[clang] 2c5d49c - [Driver] llvm::Optional => std::optional

Author: Fangrui Song Date: 2022-12-03T20:17:05Z New Revision: 2c5d49cffc1f2db52e5119bdbb44f0b10a678fb7 URL: https://github.com/llvm/llvm-project/commit/2c5d49cffc1f2db52e5119bdbb44f0b10a678fb7 DIFF: https://github.com/llvm/llvm-project/commit/2c5d49cffc1f2db52e5119bdbb44f0b10a678fb7.diff LOG:

[clang] a41fbb1 - [clang/unittests] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T12:14:19-08:00 New Revision: a41fbb1fc2126e9791fd0f159f21935f6c2f93c4 URL: https://github.com/llvm/llvm-project/commit/a41fbb1fc2126e9791fd0f159f21935f6c2f93c4 DIFF: https://github.com/llvm/llvm-project/commit/a41fbb1fc2126e9791fd0f159f21935f6c2f93c4.diff L

[clang-tools-extra] 059a23c - [clang-tools-extra] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:54:50-08:00 New Revision: 059a23c0f01fd6e5bcef0e403d8108a761ad66f5 URL: https://github.com/llvm/llvm-project/commit/059a23c0f01fd6e5bcef0e403d8108a761ad66f5 DIFF: https://github.com/llvm/llvm-project/commit/059a23c0f01fd6e5bcef0e403d8108a761ad66f5.diff L

[clang-tools-extra] cd8702e - [clang-tidy] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:54:48-08:00 New Revision: cd8702efe7e6cacfd82cc4909e42718224bcd5d0 URL: https://github.com/llvm/llvm-project/commit/cd8702efe7e6cacfd82cc4909e42718224bcd5d0 DIFF: https://github.com/llvm/llvm-project/commit/cd8702efe7e6cacfd82cc4909e42718224bcd5d0.diff L

[PATCH] D139095: [clang] Add test for CWG405

Endill added inline comments. Comment at: clang/test/CXX/drs/dr4xx.cpp:99 +void test3(A::S as) { using A::f; f(as); } // ok +void test4(A::S as) { using B::f; f(as); } // ok +void test5(A::S as) { int f; f(as); } // expected-error {{called object type 'int'}} ---

[PATCH] D138358: [clang-format] Match all block braces

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. In D138358#3968610 , @owenpan wrote: > Please see D139257 for a different > approach. All my hard work... *sniff*. Repository: rG LLVM

[PATCH] D139257: [clang-format][NFC] Link braces of a block in UnwrappedLineParser

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2714 + +static void resetOptional(FormatToken *LBrace) { + if (!LBrace) This should be named differently. For me reset means assigning false. Repository: rG LLVM G

[clang] 0c2f6e3 - [Driver] llvm::None => std::nullopt. NFC

Author: Fangrui Song Date: 2022-12-03T19:43:25Z New Revision: 0c2f6e36f9b2d26a2665e38a76ae8a95c158c4c7 URL: https://github.com/llvm/llvm-project/commit/0c2f6e36f9b2d26a2665e38a76ae8a95c158c4c7 DIFF: https://github.com/llvm/llvm-project/commit/0c2f6e36f9b2d26a2665e38a76ae8a95c158c4c7.diff LOG:

[clang] eeee3fe - [Basic] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:34:27-08:00 New Revision: 3fee37a65d68ebbfcb6e78b6b2e018180b0c URL: https://github.com/llvm/llvm-project/commit/3fee37a65d68ebbfcb6e78b6b2e018180b0c DIFF: https://github.com/llvm/llvm-project/commit/3fee37a65d68ebbfcb6e78b6b2e018180b0c.diff L

[clang] 34e0d05 - [Analysis] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:34:25-08:00 New Revision: 34e0d0579a3a6617b9b3212f2bc63d959c8f56c6 URL: https://github.com/llvm/llvm-project/commit/34e0d0579a3a6617b9b3212f2bc63d959c8f56c6 DIFF: https://github.com/llvm/llvm-project/commit/34e0d0579a3a6617b9b3212f2bc63d959c8f56c6.diff L

[clang] 1806006 - [StaticAnalyzer] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:34:24-08:00 New Revision: 180600660bbbdf8e74f7372a00e24edb219f0868 URL: https://github.com/llvm/llvm-project/commit/180600660bbbdf8e74f7372a00e24edb219f0868 DIFF: https://github.com/llvm/llvm-project/commit/180600660bbbdf8e74f7372a00e24edb219f0868.diff L

[PATCH] D139095: [clang] Add test for CWG405

Endill updated this revision to Diff 479858. Endill retitled this revision from "[clang] Mark CWG405 as a duplicate of CWG218" to "[clang] Add test for CWG405". Endill edited the summary of this revision. Endill added a comment. Reuse a part of CWG218 test, adding cross-references. CHANGES SINC

[clang] bb666c6 - [CodeGen] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:13:43-08:00 New Revision: bb666c69300c962c6a259c9d8e504601e557bc30 URL: https://github.com/llvm/llvm-project/commit/bb666c69300c962c6a259c9d8e504601e557bc30 DIFF: https://github.com/llvm/llvm-project/commit/bb666c69300c962c6a259c9d8e504601e557bc30.diff L

[clang] e31564a - [AST] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:13:41-08:00 New Revision: e31564afc3670d512274ccaa49e4fdd905f6b3d6 URL: https://github.com/llvm/llvm-project/commit/e31564afc3670d512274ccaa49e4fdd905f6b3d6 DIFF: https://github.com/llvm/llvm-project/commit/e31564afc3670d512274ccaa49e4fdd905f6b3d6.diff L

[clang] 8595f2e - [Sema] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-03T11:13:39-08:00 New Revision: 8595f2e54d2df80e8d0f9de415324eaae510a84a URL: https://github.com/llvm/llvm-project/commit/8595f2e54d2df80e8d0f9de415324eaae510a84a DIFF: https://github.com/llvm/llvm-project/commit/8595f2e54d2df80e8d0f9de415324eaae510a84a.diff L

[PATCH] D139258: Remove the enableIncrementalProcesing logic in favor of -fincremental-extensions

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rsmith, shafik. Herald added a subscriber: kristof.beyls. Herald added a project: All. v.g.vassilev requested review of this revision. As we have discussed in https://reviews.llvm.org/D127284 we would like to phase o

[clang] 8c7c20f - Convert Optional to std::optional

Author: Krzysztof Parzyszek Date: 2022-12-03T12:08:47-06:00 New Revision: 8c7c20f033c7036a8bf231ca6f9e02172cb581f0 URL: https://github.com/llvm/llvm-project/commit/8c7c20f033c7036a8bf231ca6f9e02172cb581f0 DIFF: https://github.com/llvm/llvm-project/commit/8c7c20f033c7036a8bf231ca6f9e02172cb581f0

[PATCH] D139167: [clang][Windows]Ignore Options '/d1nodatetime' and '/d1import_no_registry'

aganea added a comment. In D139167#3967123 , @efriedma wrote: > FYI, there's some discussion of /d1nodatetime floating around, even though it > isn't formally documented: it disables the definition of the `__DATE__`, > `__TIME__`, and `__TIMESTAMP__` ma

[PATCH] D135658: demangle OptFunction trace names

Trass3r added a comment. Well last time I checked it this code was still in use. When is it going to be deleted? Also the test has value to ensure the new pass manager emits these entries as before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D138358: [clang-format] Match all block braces

owenpan added a comment. Please see D139257 for a different approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138358/new/ https://reviews.llvm.org/D138358 ___ cfe

[PATCH] D139257: [clang-format][NFC] Link braces of a block in UnwrappedLineParser

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, rymiel, klimek. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This inc

[PATCH] D138358: [clang-format] Match all block braces

owenpan added a comment. This wouldn't work for deeply nested loops: $ cat test.cpp for (;;) { for (;;) { for (;;) { a; } } } $ clang-format -style='{RemoveBracesLLVM: true}' test.cpp for (;;) for (;;) for (;;) a; Expected output: for (;

[clang] 4178671 - [clang][Windows]Ignore Options '/d1'

Author: qfrost Date: 2022-12-03T22:47:59+08:00 New Revision: 4178671b2ed3d8c1ffec6f723808e22572601242 URL: https://github.com/llvm/llvm-project/commit/4178671b2ed3d8c1ffec6f723808e22572601242 DIFF: https://github.com/llvm/llvm-project/commit/4178671b2ed3d8c1ffec6f723808e22572601242.diff LOG: [

[clang] ae918c7 - [clang-format] Add .inc extension to git-clang-format

Author: Alexandre Ganea Date: 2022-12-03T09:24:03-05:00 New Revision: ae918c78b51ae7e19053b9ae9deb9fee35084256 URL: https://github.com/llvm/llvm-project/commit/ae918c78b51ae7e19053b9ae9deb9fee35084256 DIFF: https://github.com/llvm/llvm-project/commit/ae918c78b51ae7e19053b9ae9deb9fee35084256.dif

[PATCH] D138746: [clang-format] Add .inc extension to git-clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit rGae918c78b51a: [clang-format] Add .inc extension to git-clang-format (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138746/new/ https://

[PATCH] D139172: [clang] Mark CWG554 as N/A

Endill added a comment. @shafik Would it be fine by you to proceed without changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139172/new/ https://reviews.llvm.org/D139172 ___ cfe-commits mailing list

[PATCH] D139173: [clang] Add test for CWG600

Endill updated this revision to Diff 479818. Endill added a comment. Add a comment per @shafik request CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173 Files: clang/test/CXX/drs/dr6xx.cpp clang/www/cxx_dr_status.html Index: clang/www/cxx_

[clang] 0604241 - [clang-repl] Fix ambiguous initializer list.

Author: Vassil Vassilev Date: 2022-12-03T08:16:34Z New Revision: 060424178ae3720eeba6a31b579cf2025d47d852 URL: https://github.com/llvm/llvm-project/commit/060424178ae3720eeba6a31b579cf2025d47d852 DIFF: https://github.com/llvm/llvm-project/commit/060424178ae3720eeba6a31b579cf2025d47d852.diff LO