[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92bccf5d3d21: [clang-format] Don't use PPIndentWidth inside multi-line macros (authored by goldstein.w.n, committed by owenpan). Repository: rG LL

[clang] 92bccf5 - [clang-format] Don't use PPIndentWidth inside multi-line macros

Author: Noah Goldstein Date: 2022-11-19T23:53:48-08:00 New Revision: 92bccf5d3d2122d57f12dc07d4781e90edefd7ef URL: https://github.com/llvm/llvm-project/commit/92bccf5d3d2122d57f12dc07d4781e90edefd7ef DIFF: https://github.com/llvm/llvm-project/commit/92bccf5d3d2122d57f12dc07d4781e90edefd7ef.diff

[PATCH] D138376: Use None consistently (NFC)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. `enum class NoneType { None = 1 };` is from 0cd22f9540c0591132ec991c51103cf800cf4e24 (2017) for MSVC workaround. I assume it is no longer needed.. Repository: rG LLVM Github Monore

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3938942 , @owenpan wrote: > In D137181#3938913 , @goldstein.w.n > wrote: > >> Anything left for me todo (can't imagine I have push access). > > See here

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476732. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands created this revision. anderslanglands added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Not sure how to test t

[PATCH] D138376: Use None consistently (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, mtrofin, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks updated this revision to Diff 476722. HazardyKnusperkeks added a comment. Now with the annotated paren. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLine

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

owenpan updated this revision to Diff 476719. owenpan added a comment. Added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unitt

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, MyDeveloperDay, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://gi

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 476716. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s llvm/lib/Target/Mips/MipsAs

[PATCH] D138276: TableGen: require tablegen cl::opts to be registered explicitly

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. This is similar to `mlir::register*Options` and looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D138274: Add version to all LLVM cmake package

stellaraccident accepted this revision. stellaraccident added a comment. As mentioned, the duplication is annoying but I suspect is the least bad way to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org/D138

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

MaskRay added a comment. > Some host relocatable objects may not contain device relocatable objects, > where an empty file is passed to lld, which causes lld to fail. How is an empty file (size=0) passed to lld? If a dummy relocatable object file is parsed to lld, lld can infer the machine type

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: lld/ELF/Driver.cpp:179 .Case("msp430elf", {ELF32LEKind, EM_MSP430}) + .Case("elf64_amdgpu", {ELF64LEKind, EM_AMDGPU})

[PATCH] D138274: Add version to all LLVM cmake package

thopre added a comment. In D138274#3938218 , @arsenm wrote: > I thought we had this already. The amount of boiler plate required repeated > in each component is depressing, but I wouldn't be surprised if it's really > needed I could configure the LLVMV

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/lib/Target/Mips/MipsAsmPrinter.cpp:402 MipsTargetStreamer &TS = getTargetStreamer(); + const MipsTargetMachine &MTM = static_cast(TM); delete blank line Comme

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 _

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:846 + auto AddStream = [&](size_t Task, + Twine ModuleName) -> std::unique_ptr { int FD = -1; `Twine` should only be used as const refer

[clang] d116378 - Remove unused llvm/IRPrinter/IRPrintingPasses.h or reorder #include after D137768

Author: Fangrui Song Date: 2022-11-19T22:09:05Z New Revision: d1163784b5029b4c21ed861d78881d907389b7b7 URL: https://github.com/llvm/llvm-project/commit/d1163784b5029b4c21ed861d78881d907389b7b7 DIFF: https://github.com/llvm/llvm-project/commit/d1163784b5029b4c21ed861d78881d907389b7b7.diff LOG:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. In D137205#3936944 , @firewave wrote: > I still have another false positive with static variables but have not gotten > around reducing it yet. Those false positives no longer appear. So no more open FPs from my side. Great wo

[PATCH] D137101: [CodeView] Replace GHASH hasher by BLAKE3

MaskRay added a comment. Herald added a subscriber: StephenFan. LGTM, I switched to blake3 for --build-id={md5,sha1} for ELF :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137101/new/ https://reviews.llvm.org/D137101

[clang] 2898ba5 - [Basic] Remove deprecated methods in MapEntryOptionalStorage

Author: Kazu Hirata Date: 2022-11-19T12:33:32-08:00 New Revision: 2898ba5d2eb1952dfd816781b3ca8db05e5673ba URL: https://github.com/llvm/llvm-project/commit/2898ba5d2eb1952dfd816781b3ca8db05e5673ba DIFF: https://github.com/llvm/llvm-project/commit/2898ba5d2eb1952dfd816781b3ca8db05e5673ba.diff L

[PATCH] D137101: [CodeView] Replace GHASH hasher by BLAKE3

This revision was automatically updated to reflect the committed changes. aganea marked 2 inline comments as done. Closed by commit rG49e483d3d62f: [CodeView] Replace GHASH hasher by BLAKE3 (authored by aganea). Herald added a reviewer: MaskRay. Herald added a project: clang. Herald added a subscr

[clang] 49e483d - [CodeView] Replace GHASH hasher by BLAKE3

Author: Alexandre Ganea Date: 2022-11-19T15:17:42-05:00 New Revision: 49e483d3d62f6f62beb323e9c4160bab9e0ad619 URL: https://github.com/llvm/llvm-project/commit/49e483d3d62f6f62beb323e9c4160bab9e0ad619 DIFF: https://github.com/llvm/llvm-project/commit/49e483d3d62f6f62beb323e9c4160bab9e0ad619.dif

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. Hi Aaron. Unfortunately, I don't feel I can make a great case for why these extensions should be in Clang. Although there are users of Plan 9 C extensions, I don't see these features being adopted more generally enough to warrant its inclusion in Clang which violates

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#3923643 , @Skylion007 wrote: > The main false positive I also keep seeing is in pybind11 where it suggests > call an std::move() for an implicit conversion, but the target of the > implicit conversion does not have an

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands added a comment. Arg just noticed an issue: clang_Type_getReplacementType should be in the LLVM_16 block in libclang.map not in the LLVM_13 block. I've blown away my local branch so don't know how to fix the patch. Shall I just make a new patch once this is merged? Repository:

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#3936944 , @firewave wrote: > Here's another false positive: > > #include > > void f(const std::string&); > > int main() { > std::string s; > f(s.empty() ? "<>" : s); > } > > > > input.cpp:7:26

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands added a comment. Great, thanks! I've got a couple more things to land once this is merged and I've cleaned them up. Do you wanna show me how to do the merge myself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137818/new/ https://

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry updated this revision to Diff 476692. v1nh1shungry added a comment. - fix qualifiers - fix recursive `decltype` (partly) - support return type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300

[PATCH] D138358: [clang-format] Match all block braces

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138357: [clang-format][NFC] Don't add a load of 0es

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138354: [clang-format][NFC] Remove unneeded braces

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, rymiel, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG0745b0c0354a: Fix incorrect cast in VisitSYCLUniqueStableNameExpr (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138284/new/ https

[clang] 0745b0c - Fix incorrect cast in VisitSYCLUniqueStableNameExpr

Author: Alex Richardson Date: 2022-11-19T11:43:17Z New Revision: 0745b0c0354a0c8e1fefb68a3876d15db6c2e27a URL: https://github.com/llvm/llvm-project/commit/0745b0c0354a0c8e1fefb68a3876d15db6c2e27a DIFF: https://github.com/llvm/llvm-project/commit/0745b0c0354a0c8e1fefb68a3876d15db6c2e27a.diff LO

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry updated this revision to Diff 476667. v1nh1shungry added a comment. Avoid type hints for dependent types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300 Files: clang-tools-extra/clangd/Inla