[PATCH] D135558: [Clang][NFC]Use isa instead of dyn_cast in shouldAddReversedEqEq

liaolucy created this revision. liaolucy added a reviewer: usaxena95. Herald added a project: All. liaolucy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix warning: unused variable ‘MD’ Repository: rG LLVM Github Monorepo https://r

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

anderslanglands created this revision. Herald added a subscriber: arphaman. Herald added a project: All. anderslanglands requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Wraps CXXRecord::needsImplicitDefaultConstructor, needsImplicitCopyCons

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

bigdavedev accepted this revision. bigdavedev added a comment. This revision is now accepted and ready to land. LGTM. All comments addressed and the check world as intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.

[PATCH] D135555: [libclang] CIndex: Visit UsingTypeLoc as TypeRef

kiloalphaindia created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D13

[clang] 6b24bdb - [RISCV] Remove some vsetvli intrinsics under Zve32*.

Author: Craig Topper Date: 2022-10-09T20:40:38-07:00 New Revision: 6b24bdb4a5ecc2f27bfe6aa992e6686bc40c995a URL: https://github.com/llvm/llvm-project/commit/6b24bdb4a5ecc2f27bfe6aa992e6686bc40c995a DIFF: https://github.com/llvm/llvm-project/commit/6b24bdb4a5ecc2f27bfe6aa992e6686bc40c995a.diff

[PATCH] D135519: [RISCV] Remove some vsetvli intrinsics under Zve32*.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b24bdb4a5ec: [RISCV] Remove some vsetvli intrinsics under Zve32*. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135519/new/ htt

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

shafik added inline comments. Comment at: clang/test/AST/Interp/loops.cpp:9 + +namespace WhileLoop { + constexpr int f() { infinite loop w/o a side effect are undefined behavior and so should be ill-formed and generate a diagnostic e.g. `while(1);`, so we shoul

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

shafik added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:128 + + static_assert("foobar"[2] == 'o', ""); + Also `2["foobar"]` Comment at: clang/test/AST/Interp/arrays.cpp:135 + static_assert(u32[1] == U'b', ""); +}; + ---

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

thesamesam added a comment. I could use identical phrasing to `-Wincompatible-function-pointer-types` below (reference how to downgrade the error) but I don't think there's a need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135545/new/ https://

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

thesamesam created this revision. thesamesam added reviewers: aaron.ballman, mgorny, MaskRay. thesamesam added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. thesamesam requested review of this revision. Herald added a subscriber: cfe-commits. -Wimplicit-func

[PATCH] D135544: [clangd] Rename: Allow renaming using declaration introducing multiple symbols [3/3]

tom-anders created this revision. tom-anders added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders updated this revision to Diff 466393. tom-anders added a comment. tom-anders edited the summary of this revision. tom-anders published this

[PATCH] D135543: [clangd] Rename: Allow renaming virtual methods overriding multiple base methods [2/3]

tom-anders created this revision. tom-anders added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders updated this revision to Diff 466392. tom-anders added a comment. tom-anders updated this revision to Diff 466394. tom-anders published thi

[PATCH] D135542: [clangd] Rename: Allow multiple canonical declarations [1/3]

tom-anders created this revision. tom-anders added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders updated this revision to Diff 466391. tom-anders added a comment. tom-anders published this revision for review. Herald added subscribers:

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

jacob-abraham updated this revision to Diff 466386. jacob-abraham added a comment. fixed unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

beanz added a comment. Avoiding argument promotion is one part of what we need, but not all of it. For example if you take this trial code: const RWBuffer In; RWBuffer Out; [numthreads(1,1,1)] void main(uint GI : SV_GroupIndex) { Out[GI] = In[GI].x + In[GI].y; } Following C rul

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

rjmccall added a comment. If your goal is just to pass 16-bit types in some specific way without promotion, you can just do that in the ABI. C only requires `short` arguments to be promoted to `int` in variadic or unprototyped positions, and it's not legal under the C type compatibility rules

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 466382. python3kgae added a comment. Change Category to DocCatVariable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clang/Basic/Address

[PATCH] D127695: [clang] Implement Template Specialization Resugaring

mizvekov added a comment. In D127695#3829020 , @davrec wrote: > The larger issues: > > 1. Performance - can we see some numbers? and There are still work left to do on a couple of enablers, and some other changes, in order to get performance on a level

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

sberg added a comment. I just ran into newly-failing $ cat test.cc struct S1 { bool operator==(int); bool operator!=(int); }; struct S2; bool operator ==(S2, S2); bool f(S1 s) { return 0 == s; } $ clang++ -std=c++20 -fsyntax-only test.cc test.cc:7:25: error: invalid o

[PATCH] D134143: [clang] Misc type sugar preservation improvements

mizvekov updated this revision to Diff 466368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134143/new/ https://reviews.llvm.org/D134143 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaType.cpp Index

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov updated this revision to Diff 466367. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134115/new/ https://reviews.llvm.org/D134115 Files: clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h clang/include/clang/Sema/Init

[PATCH] D134604: [clang] Instiantiate early substituted entities with sugared template arguments

mizvekov updated this revision to Diff 466365. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang-tools-extra/clangd/unittests/HoverTests.cpp clang/include/clang/Sema/Sema.h clang/lib/AST/AS

[PATCH] D135536: [clangd] Hover: Only drop UsingDecl instead of BaseUsingDecl

tom-anders created this revision. tom-anders added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rG69e772768e95: [clang-format] Add support to remove unnecessary semicolons after function… (authored

[clang] 69e7727 - [clang-format] Add support to remove unnecessary semicolons after function definition

Author: mydeveloperday Date: 2022-10-09T11:18:16+01:00 New Revision: 69e772768e957629d41ed53eaf4dcda96fa9dac7 URL: https://github.com/llvm/llvm-project/commit/69e772768e957629d41ed53eaf4dcda96fa9dac7 DIFF: https://github.com/llvm/llvm-project/commit/69e772768e957629d41ed53eaf4dcda96fa9dac7.diff

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac21938fbdfa: [clangd] Fix rename for symbol introduced by UsingDecl (authored by tom-anders). Changed prior to commit: https://reviews.llvm.org/D

[clang-tools-extra] ac21938 - [clangd] Fix rename for symbol introduced by UsingDecl

Author: Tom Praschan Date: 2022-10-09T14:16:12+02:00 New Revision: ac21938fbdfa75f1eb4ca399dac4fbf3e90d472d URL: https://github.com/llvm/llvm-project/commit/ac21938fbdfa75f1eb4ca399dac4fbf3e90d472d DIFF: https://github.com/llvm/llvm-project/commit/ac21938fbdfa75f1eb4ca399dac4fbf3e90d472d.diff

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

tom-anders marked 2 inline comments as done. tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:170 +void filterUsingDecl(llvm::DenseSet& Decls) { + // There should never be more than one UsingDecl here, + // otherwise the rename would b

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:26773 + Style); + + // These tests are here to show a problem that may not be easily owenpan wrote: > owenpan w

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

owenpan accepted this revision. owenpan added a comment. LGTM Comment at: clang/unittests/Format/FormatTest.cpp:26773 + Style); + + // These tests are here to show a problem that may not be easily owenpan wrote: > Add the test case if it will pas

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay updated this revision to Diff 466358. MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. Minor documentation changes based on review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135466/new/ https://reviews.llvm.org/D135466 Files:

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

MyDeveloperDay added a comment. There is a simple fix to allow the empty functions in UnwrappedLineParser::calculateBraceTypes F24856496: image.png by moving this clause out of the "isJavaScript()" clause this will ensure for `foo() {}` the `{` is considere

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

ChuanqiXu added a comment. In D134269#3813568 , @tschuett wrote: > Thanks for doing this! The traditional Clang Header modules call this > implicit and explicit modules. > > Feel free to ignore, but I found this awesome article about implicit and > expl

[clang] b72a364 - [C++20] [Coroutines] Exit early if we found co_await appears in

Author: Chuanqi Xu Date: 2022-10-09T14:59:27+08:00 New Revision: b72a364bb5ccc4ad50f3e28b6706db86987d961b URL: https://github.com/llvm/llvm-project/commit/b72a364bb5ccc4ad50f3e28b6706db86987d961b DIFF: https://github.com/llvm/llvm-project/commit/b72a364bb5ccc4ad50f3e28b6706db86987d961b.diff LO