[clang-tools-extra] 20f0f15 - Use StringRef::contains (NFC)

2022-08-28 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2022-08-28T23:29:02-07:00 New Revision: 20f0f15a4055d66fae494fc79bd76f14dee3954f URL: https://github.com/llvm/llvm-project/commit/20f0f15a4055d66fae494fc79bd76f14dee3954f DIFF: https://github.com/llvm/llvm-project/commit/20f0f15a4055d66fae494fc79bd76f14dee3954f.diff L

[PATCH] D132791: Fix formatting in release notes

2022-08-28 Thread Tobias Hieta via Phabricator via cfe-commits
thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Thanks for doing this pass! Much appreciated. As long as you tried to build the docs after you changes and it passes without any warnings or errors I am happy for you to commit this directly t

[PATCH] D131388: [docs] Add "Standard C++ Modules"

2022-08-28 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D131388#3753522 , @aaronmondal wrote: > @ChuanqiXu Thanks a lot for this! > > We are currently implementing this module logic in the Bazel ruleset rules_ll > . > This page helps clarify th

[PATCH] D131388: [docs] Add "Standard C++ Modules"

2022-08-28 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 456254. ChuanqiXu added a comment. Add contents for "When precompiling a module in one directory and then moving a header included in the global module fragment from the source file, things will break." CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] b31b72a - [test][msan] Simplify tests with --implicit-check-not

2022-08-28 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-08-28T22:43:04-07:00 New Revision: b31b72ad7ed9b75c55771caf1176b989642964eb URL: https://github.com/llvm/llvm-project/commit/b31b72ad7ed9b75c55771caf1176b989642964eb DIFF: https://github.com/llvm/llvm-project/commit/b31b72ad7ed9b75c55771caf1176b989642964eb.diff L

[PATCH] D132821: [clang][Parse] Fix crash when emitting template diagnostic

2022-08-28 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The integer value of the enum here is `6`, which wasn't covered by the diagnostic.

[PATCH] D131388: [docs] Add "Standard C++ Modules"

2022-08-28 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 456244. ChuanqiXu marked 5 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131388/new/ https://reviews.llvm.org/D131388 Files: clang/docs/StandardCPlusPlusModules.rst clang/d

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

2022-08-28 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZc.td:169 + +let isCompressOnly = true in { + This feels wrong to me, but decompression is a bit dodgy if you can have all of Zcb without some of the extensions that its instructions d

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

2022-08-28 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu updated this revision to Diff 456235. VincentWu added a comment. Herald added a subscriber: jdoerfert. Add CompressPats for zcb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/tes

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

2022-08-28 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu updated this revision to Diff 456224. VincentWu marked 2 inline comments as done. VincentWu added a comment. set zcb inst Sched info same as their uncompressed forms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://review

[clang] dcfd627 - [NFC][clang-format] Fix typo

2022-08-28 Thread via cfe-commits
Author: Sheng Date: 2022-08-29T09:34:05+08:00 New Revision: dcfd6273a9993c2ab2c62d665429a0a7b7e3f1f8 URL: https://github.com/llvm/llvm-project/commit/dcfd6273a9993c2ab2c62d665429a0a7b7e3f1f8 DIFF: https://github.com/llvm/llvm-project/commit/dcfd6273a9993c2ab2c62d665429a0a7b7e3f1f8.diff LOG: [N

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

2022-08-28 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Fixed in f051c1ded40970169cda84b0966331ae7ad424ed . It looks like gcc, unlike clang, doesn't allow passing `-Werror=format-security` without passing `-format` too. Repository: rG LLVM Github Monor

[PATCH] D128113: WIP: Clang: fix AST representation of expanded template arguments.

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov retitled this revision from "Clang: fix AST representation of expanded template arguments." to "WIP: Clang: fix AST representation of expanded template arguments.". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 456220. mizvekov planned changes to th

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov retitled this revision from "[clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type." to "[clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type". mizvekov updated this revision to Diff 456217. Repository: rG LLVM Github Monorepo CH

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type.

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 456216. Herald added a subscriber: martong. Herald added a reviewer: shafik. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132816/new/ https://reviews.llvm.org/D1328

[PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 456213. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D132805: [clang-format] Fix a bug in removing braces for the LLVM style

2022-08-28 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf00f2b3e8d40: [clang-format] Fix a bug in removing braces for the LLVM style (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES S

[clang] f00f2b3 - [clang-format] Fix a bug in removing braces for the LLVM style

2022-08-28 Thread via cfe-commits
Author: owenca Date: 2022-08-28T14:22:31-07:00 New Revision: f00f2b3e8d406c503902117669297b99c40207b6 URL: https://github.com/llvm/llvm-project/commit/f00f2b3e8d406c503902117669297b99c40207b6 DIFF: https://github.com/llvm/llvm-project/commit/f00f2b3e8d406c503902117669297b99c40207b6.diff LOG: [

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

2022-08-28 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. We should add a test case for `TT_CastRParen` in `clang/unittests/Format/TokenAnnotatorTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132762/new/ https://reviews.llvm.org/D132762

[PATCH] D132816: [clang] AST: SubstTemplateTypeParmType support for non-canonical underlying type.

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D130308 Signed-off-by: Matheus Iz

[clang] 95dcaef - [Driver][Linux] Pass --hash-style=gnu to ld unless special cased

2022-08-28 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-08-28T12:13:01-07:00 New Revision: 95dcaef00379e893dabc61cf598fe51c9d03414e URL: https://github.com/llvm/llvm-project/commit/95dcaef00379e893dabc61cf598fe51c9d03414e DIFF: https://github.com/llvm/llvm-project/commit/95dcaef00379e893dabc61cf598fe51c9d03414e.diff

[clang] a284f9f - [Driver] Don't pass --enable-new-dtags to ld for Android/openSUSE

2022-08-28 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-08-28T11:38:40-07:00 New Revision: a284f9febd9b8d7b2261f6c1db658292d03490a0 URL: https://github.com/llvm/llvm-project/commit/a284f9febd9b8d7b2261f6c1db658292d03490a0 DIFF: https://github.com/llvm/llvm-project/commit/a284f9febd9b8d7b2261f6c1db658292d03490a0.diff

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. Hello, @roberteg16, are you still interested in working on this patch? I might need a fix for this myself, and also it happened recently that someone else attempted a fix for the same bug. If you are not abandoning it, please let us know! Repository: rG LLVM Github

[PATCH] D128095: [clang] Improve diagnostics for expansion length mismatch

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 456202. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 456201. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/AST

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

2022-08-28 Thread Alvin Wong via Phabricator via cfe-commits
alvinhochun created this revision. Herald added a subscriber: mstorsjo. Herald added a project: All. alvinhochun published this revision for review. alvinhochun added reviewers: rnk, ajpaverd, mstorsjo, aaron.ballman. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. T

[PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 456199. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 456198. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplateDeduc

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 456197. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 456196. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

2022-08-28 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td:19 let UnsupportedFeatures = [HasStdExtZbkb, HasStdExtZbkc, HasStdExtZbkx, - HasStdExtZknd, HasStdExtZkne, HasStdExtZknh, - HasStd

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

2022-08-28 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu added a comment. In D131141#3753861 , @craig.topper wrote: > Are you going to add the CompressPats in a different patch? yes, I plan submit it as CodeGen part. But I can add it into this patch if it is required. Comment at:

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

2022-08-28 Thread Xinlong Wu via Phabricator via cfe-commits
VincentWu updated this revision to Diff 456190. VincentWu marked 10 inline comments as done. VincentWu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D131858: [clang] Track the templated entity in type substitution.

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. llvm-compile-time-tracker stats for this patch: http://llvm-compile-time-tracker.com/compare.php?from=de872a323c8eb1c90d740fc739c8781d41743ead&to=c5cdd76e99ced02ba433e899fb6075fe214a84fd&stat=instructions The difference looks like noise. Repository: rG LLVM Github M

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

2022-08-28 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. llvm-compile-time-tracker stats for this patch: http://llvm-compile-time-tracker.com/compare.php?from=f7a33090a91015836497c75f173775392ab0304d&to=771076b836b331f50f8a852fba1353aa60865e30&stat=instructions For the next one on the stack, which hooks the new mechanism here

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

2022-08-28 Thread Pavel Samolysov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb10a341aa5b0: [Pipelines] Introduce DAE after ArgumentPromotion (authored by psamolysov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128830/new/ https://

[clang] b10a341 - [Pipelines] Introduce DAE after ArgumentPromotion

2022-08-28 Thread Pavel Samolysov via cfe-commits
Author: Pavel Samolysov Date: 2022-08-28T10:47:03+03:00 New Revision: b10a341aa5b0b93b9175a8f11efc9a0955ab361e URL: https://github.com/llvm/llvm-project/commit/b10a341aa5b0b93b9175a8f11efc9a0955ab361e DIFF: https://github.com/llvm/llvm-project/commit/b10a341aa5b0b93b9175a8f11efc9a0955ab361e.dif

[clang] f4feb7d - [NFC] Fix typo

2022-08-28 Thread via cfe-commits
Author: Sheng Date: 2022-08-28T15:16:34+08:00 New Revision: f4feb7dd6ae42e3a50cbe25a71c7f69f1f1acb69 URL: https://github.com/llvm/llvm-project/commit/f4feb7dd6ae42e3a50cbe25a71c7f69f1f1acb69 DIFF: https://github.com/llvm/llvm-project/commit/f4feb7dd6ae42e3a50cbe25a71c7f69f1f1acb69.diff LOG: [N