[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:847-849 +} else if (const auto Iface = + dyn_cast(Decl)) { + if (Iface->isThisDeclarationADefinition()) dgoldman wrot

[PATCH] D127578: [clang-format] Handle deprecated options in dump_format_style.py

owenpan closed this revision. owenpan added a comment. Landed in b1c300f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127578/new/ https://reviews.llvm.org/D127578 ___

[clang] b1c300f - [clang-format] Handle deprecated options in dump_format_style.py

Author: owenca Date: 2022-06-12T23:35:48-07:00 New Revision: b1c300fe6849a053482d117c7d3fa425da9a7430 URL: https://github.com/llvm/llvm-project/commit/b1c300fe6849a053482d117c7d3fa425da9a7430 DIFF: https://github.com/llvm/llvm-project/commit/b1c300fe6849a053482d117c7d3fa425da9a7430.diff LOG: [

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 436281. srishti-pm added a comment. Minor changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: clang/docs/tools/clang-formatted-files.txt mlir/inclu

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. @iains Given @rsmith is too busy, would you like to review this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3576602 , @iains wrote: > @ChuanqiXu - I changed the module ownership name to "ModuleDiscardable" - > because, while we are permitted to discard these, we might choose not to (to > give your better diagnostics) - bu

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added inline comments. Comment at: mlir/include/mlir/Transforms/CommutativityUtils.h:211 +// If `op` is not commutative, do nothing. +if (!op->template hasTrait()) + return failure(); Mogball wrote: > Please move the body `matchAndRewrite` in

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. I haven't thought too hard about the algorithm itself yet. I'm in the camp of "let's move forward if it works". I have mostly trivial comments. Comment at: clang/docs/tools/clang-formatted-files.txt:8451 mlir/lib/Transforms/SymbolPrivatize.cpp +mlir/l

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 436274. srishti-pm added a comment. Addressed all the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: clang/docs/tools/clang-formatted-files.txt

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llvm.org/D125875 ___

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu added a comment. @rjmccall Does this look good to you? I am afraid to break swift's codes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127471/new/ https://reviews.llvm.org/D127471 ___ cfe-com

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

pcwang-thead added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llvm.org/D125875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6632 + "const qualifying the return value prevents move semantics">, + InGroup, DefaultIgnore; +def note_pessimizing_return_by_const : Note< aaron.ballman wrote: > Given th

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. In D107082#3576355 , @mehdi_amini wrote: > This broke the bot here: > https://lab.llvm.org/buildbot/#/builders/61/builds/27616 > > The cmake invocation includes some GPU specific options that you can omit > (`-DMLIR_ENABLE_CUDA

[clang] d4bcb45 - [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible

Author: Jez Ng Date: 2022-06-12T17:24:19-04:00 New Revision: d4bcb45db78dc7ca371224cb01bea8dcb14e0698 URL: https://github.com/llvm/llvm-project/commit/d4bcb45db78dc7ca371224cb01bea8dcb14e0698 DIFF: https://github.com/llvm/llvm-project/commit/d4bcb45db78dc7ca371224cb01bea8dcb14e0698.diff LOG: [

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. d'oh, I see it now. And of course the parent `llvm/test/MC/MachO` directory is gated to x86-only. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains marked 3 inline comments as done. iains added a comment. @ChuanqiXu - I changed the module ownership name to "ModuleDiscardable" - because, while we are permitted to discard these, we might choose not to (to give your better diagnostics) - but we still need to treat them as non-reachable

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains updated this revision to Diff 436245. iains edited the summary of this revision. iains added a comment. this is a rework of the implementation. it now passes all test-cases except one - which is one of the cases added by D113545 ; that test-case now seems t

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

thakis added a comment. I think it should work if you put the test in llvm/test/MC/MachO/AArch64 instead of in llvm/test/MC/MachO, because of: % cat llvm/test/MC/MachO/AArch64/lit.local.cfg if not 'AArch64' in config.root.targets: config.unsupported = True Repository: rG LLVM Gith

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson requested changes to this revision. royjacobson added a reviewer: clang-language-wg. royjacobson added a comment. This revision now requires changes to proceed. Hi Javier, thank you for submitting this patch! As far as I could tell, this patch implements the CWG2171 defect report from

[clang] 571ae1a - fix test expected output (fixes arm buildbot failure) [NFC]

Author: Nuno Lopes Date: 2022-06-12T19:29:00+01:00 New Revision: 571ae1abebb6b102cc2e95e3abf8e81757fba35a URL: https://github.com/llvm/llvm-project/commit/571ae1abebb6b102cc2e95e3abf8e81757fba35a DIFF: https://github.com/llvm/llvm-project/commit/571ae1abebb6b102cc2e95e3abf8e81757fba35a.diff LO

[clang] 4dd1bff - [clang][CodeGen] Switch a few placeholders from UndefValue to PoisonValue

Author: Nuno Lopes Date: 2022-06-12T19:07:59+01:00 New Revision: 4dd1bffc9dac02b34bd1de78808edd9a5955c987 URL: https://github.com/llvm/llvm-project/commit/4dd1bffc9dac02b34bd1de78808edd9a5955c987 DIFF: https://github.com/llvm/llvm-project/commit/4dd1bffc9dac02b34bd1de78808edd9a5955c987.diff LO

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

thakis added a comment. (As long as this builds and passes tests, I don't have an opinion on this change.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215 ___

[clang] f13019f - [clang] Use any_of and none_of (NFC)

Author: Kazu Hirata Date: 2022-06-12T10:17:12-07:00 New Revision: f13019f8367a417075e70effb13dcf58024090b2 URL: https://github.com/llvm/llvm-project/commit/f13019f8367a417075e70effb13dcf58024090b2 DIFF: https://github.com/llvm/llvm-project/commit/f13019f8367a417075e70effb13dcf58024090b2.diff L

[PATCH] D127599: [clang] small speed improvement of Sema::AddArgumentDependentLookupCandidates

Kokan updated this revision to Diff 436234. Kokan added a comment. clang-format applied CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127599/new/ https://reviews.llvm.org/D127599 Files: clang/include/clang/Sema/Lookup.h clang/lib/Sema/SemaOverload.cpp Index: clang/lib/Sema/SemaOv

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436229. junaire added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Inte

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

mehdi_amini added a comment. This broke the bot here: https://lab.llvm.org/buildbot/#/builders/61/builds/27616 The cmake invocation includes some GPU specific options that you can omit (`-DMLIR_ENABLE_CUDA_RUNNER=1` , `-DCMAKE_CUDA_COMPILER=/usr/local/cuda/bin/nvcc`, `-DMLIR_ENABLE_VULKAN_RUN

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Buildbots gave me a bunch of errors of the form /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llvm-mc: error: unable to get target for 'arm64-apple-macos11.0', see --version and --triple. I'm wondering if I'm just missing a REQUIRES line, but th

[clang] d941d59 - Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible"

Author: Jez Ng Date: 2022-06-12T10:47:08-04:00 New Revision: d941d597837d9e1405086f008c9bd6a71e7263c9 URL: https://github.com/llvm/llvm-project/commit/d941d597837d9e1405086f008c9bd6a71e7263c9 DIFF: https://github.com/llvm/llvm-project/commit/d941d597837d9e1405086f008c9bd6a71e7263c9.diff LOG: R

[PATCH] D127599: [clang] small speed improvement of Sema::AddArgumentDependentLookupCandidates

Kokan created this revision. Kokan added a reviewer: clang. Herald added a project: All. Kokan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [clang] Improve speed of Sema::AddArgumentDependentLookupCandidates The Sema::AddArgumentDepende

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : (1 << (int)FloatModeKind::Float) | +

[clang] ef501bf - [MC] Omit DWARF unwind info if compact unwind is present where eligible

Author: Jez Ng Date: 2022-06-12T10:03:56-04:00 New Revision: ef501bf85d8c869248e51371f0e74bcec0e7b229 URL: https://github.com/llvm/llvm-project/commit/ef501bf85d8c869248e51371f0e74bcec0e7b229 DIFF: https://github.com/llvm/llvm-project/commit/ef501bf85d8c869248e51371f0e74bcec0e7b229.diff LOG: [

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef501bf85d8c: [MC] Omit DWARF unwind info if compact unwind is present where eligible (authored by int3). Changed prior to commit: https://reviews

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436219. junaire added a comment. Fix the unintentional format by clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 436217. jolanta.jensen added a comment. Correcting my buggy computation of RealTypeUsesObjCFPRet bit-field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/ https://reviews.llvm.org/D126479 Fil

[PATCH] D127589: [RISCV] Compatible with more RISCV related ld in the test

StephenFan added a comment. Why not use `env PATH=` in the lit run line to clear the `PATH` env variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127589/new/ https://reviews.llvm.org/D127589 ___ cf

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

This revision was automatically updated to reflect the committed changes. Closed by commit rGe43a85a363cf: [docs][clang] Fix a broken link on the APINotes doc (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126599/new/ https:/

[clang] e43a85a - [docs][clang] Fix a broken link on the APINotes doc

Author: Yuki Okushi Date: 2022-06-12T22:53:32+09:00 New Revision: e43a85a363cfd2a4c533fa427d9dbecf0d5c5261 URL: https://github.com/llvm/llvm-project/commit/e43a85a363cfd2a4c533fa427d9dbecf0d5c5261 DIFF: https://github.com/llvm/llvm-project/commit/e43a85a363cfd2a4c533fa427d9dbecf0d5c5261.diff L

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

JohnTitor added a comment. > It seems that other docs are following the GitHub URLs as well. I wish we > could do the relative document link instead of embedding the URL, but if that > is not possible, then this makes sense to do. I couldn't find the URL serving that file and I'm not familiar w

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 436214. junaire added a comment. Address Vassil's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/include/clang/Interpreter/Interpreter.h cl

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/lib/Format/Format.cpp:1314 LLVMStyle.SpaceBeforeParensOptions.AfterIfMacros = true; + LLVMStyle.SpaceBeforeParensOptions.AfterPlacementNew = true; LLVMStyle.SpaceBeforeRangeBasedForLoopColon = true; Hazard

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 436212. cor3ntin added a comment. - Rebase - Cleanup codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/Loo

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); junair

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 436207. Javier-varez added a comment. Herald added a project: clang-tools-extra. Fix clang-tidy tests and run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez created this revision. Herald added a project: All. Javier-varez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. >From [class.copy.ctor]: A non-template constructor for class X is a copy constructor if its first parameter

[PATCH] D127589: [RISCV] Compatible with more RISCV related ld in the test

sunshaoce created this revision. Herald added subscribers: VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, s

[PATCH] D127484: [clang-format] Use tabs on GNU style

owenpan added a comment. In D127484#3576061 , @a4lg wrote: > Interesting. > > I measured some development branch (targeting `*.c`, `*.cc`, `*.cpp` and > `*.h`): > > | Program | prefix: 8 spaces | prefix: 1 tab | 8sp percentage | > | Coreutils | 23494

[PATCH] D127578: [clang-format] Handle deprecated options in dump_format_style.py

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Great thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127578/new/ https://reviews.llvm.org/D127578 ___