[PATCH] D127409: Fix GCC intrinsics "round_mask" names

pengfei requested changes to this revision. pengfei added a comment. This revision now requires changes to proceed. We had a discussion about the builtins between GCC and Clang on D109658 last year. We tried to make sure the same builtins have the same argument

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

carlosgalvezp added a comment. This sounds like great functionality, surely saving a lot of headaches! Any reason why we wouldn't want this active by default? I'd personally even go one step further and make it hard errors - warnings are easy to miss and ignore - but I can see how it can be pro

[clang-tools-extra] b831786 - [clang-tidy][NFC] Tweak identifier-naming options reading/writiing

Author: Nathan James Date: 2022-06-10T07:07:21+01:00 New Revision: b8317862921d8ef5f54804f2d8d5b5af92c530d3 URL: https://github.com/llvm/llvm-project/commit/b8317862921d8ef5f54804f2d8d5b5af92c530d3 DIFF: https://github.com/llvm/llvm-project/commit/b8317862921d8ef5f54804f2d8d5b5af92c530d3.diff

[PATCH] D127390: [clang-format][NFC] Remove unused FormatStyle members

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9f2d47bfe29: [clang-format][NFC] Remove unused FormatStyle members (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127390/new/ https:/

[clang] e9f2d47 - [clang-format][NFC] Remove unused FormatStyle members

Author: owenca Date: 2022-06-09T22:34:31-07:00 New Revision: e9f2d47bfe29c31c7a1b43a2cc503ed9cdc0fbad URL: https://github.com/llvm/llvm-project/commit/e9f2d47bfe29c31c7a1b43a2cc503ed9cdc0fbad DIFF: https://github.com/llvm/llvm-project/commit/e9f2d47bfe29c31c7a1b43a2cc503ed9cdc0fbad.diff LOG: [

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1500 + +assert(WeakRefReferences.empty() && + "Not all WeakRefRefs have been applied"); v.g.vassilev wrote: > It seems that we forgot to move the `WeakRefReferences`? Thank

[clang] 0ecbedc - Also move WeakRefReferences in CodeGenModule::moveLazyEmssionStates

Author: Jun Zhang Date: 2022-06-10T13:11:09+08:00 New Revision: 0ecbedc0986bd4b7b90a60a5f31d32337160d4c4 URL: https://github.com/llvm/llvm-project/commit/0ecbedc0986bd4b7b90a60a5f31d32337160d4c4 DIFF: https://github.com/llvm/llvm-project/commit/0ecbedc0986bd4b7b90a60a5f31d32337160d4c4.diff LOG

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); We sho

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:1142 +VerilogExtraKeywords = +std::unordered_set({kw_always, + kw_always_comb, Now that I ad

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 435788. sstwcw added a comment. - add `kw_` prefix to symbols treated as keywords - use lambda instead of breaking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/D124749 File

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

ChuanqiXu created this revision. ChuanqiXu added reviewers: nikic, rjmccall, ezhulenev. Herald added subscribers: Peiming, bzcheeseman, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435782. junaire added a comment. Allow undo command failed in the edge cases like undoed too many times. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clan

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435781. junaire added a comment. Restore PTU in Interpreter::Undo, this should fix the broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/in

[PATCH] D126934: [clang-format] NFC Sort names of format token types

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126934/new/ https://reviews.llvm.org/D126934 _

[PATCH] D126684: [Interpreter] Implment Interpreter::Restore to clean up lookup table

junaire abandoned this revision. junaire added a comment. work moved to D126682 , so abandon this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126684/new/ https://reviews.llvm.org/D126684

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

junaire updated this revision to Diff 435779. junaire added a subscriber: Purva-Chaudhari. junaire added a comment. Merge D126684 into this patch. Consider D126684 is almost @Purva-Chaudhari 's work, I'll list her as co-author

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435777. sstwcw added a comment. - add brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rst clang/include/clang/Format/Format.h

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435774. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/l

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added inline comments. Comment at: bolt/tools/CMakeLists.txt:11-13 +macro(add_bolt_tool_symlink name) + llvm_add_tool_symlink(BOLT ${ARGV}) +endmacro() mizvekov wrote: > Instead of each project having to define a different macro for this, why not >

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435773. sstwcw added a comment. use isVerilog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rst clang/include/clang/Format/Format.h

[PATCH] D123450: [clang-format] Parse Verilog if statements

sstwcw updated this revision to Diff 435771. sstwcw marked 2 inline comments as done. sstwcw added a comment. add MacroBlockBegin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangF

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. Great! I am not able to debug it this week. This looks good to me after we could solve the bug. I plan to try to test libunifex in the next week since I remember there are many uses of constrains. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ htt

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard added a comment. I uploaded D127465 , weakening the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127267/new/ https://reviews.llvm.org/D127267 ___ cfe-co

[PATCH] D127465: [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386

rprichard added reviewers: tra, yaxunl. rprichard added a subscriber: mgorny. rprichard added a comment. This change is needed to keep the clang/test/Preprocessor/cuda-types.cu test passing after D28213 changes the value of `__CLANG_ATOMIC_LLONG_LOCK_FREE` from

[PATCH] D126934: [clang-format] NFC Sort names of format token types

sstwcw updated this revision to Diff 435760. sstwcw added a comment. use case-insensitive sorting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126934/new/ https://reviews.llvm.org/D126934 Files: clang/lib/Format/FormatToken.h Index: clang/lib

[PATCH] D127465: [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386

rprichard created this revision. Herald added subscribers: mattd, yaxunl. Herald added a project: All. rprichard requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The default host CPU for an i386 triple is typically at least an i586, which ha

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard added a subscriber: jlebar. rprichard added a comment. Ok, I can upload a patch omitting `*_ATOMIC_LLONG_LOCK_FREE` from the macro testing. FWIW, did you see this comment in clang/lib/Basic/Targets/NVPTX.cpp?: // This is a bit of a lie, but it controls __GCC_ATOMIC_XXX_LOCK_FREE, an

[PATCH] D119296: KCFI sanitizer

ychen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2257 + + F->setPrefixData(CreateKCFITypeId(FD->getType())); + F->addFnAttr("kcfi-target"); FYI: using prefix data may not work for the C++ coroutine. (https://github.com/llvm/llvm-pro

[PATCH] D127462: Begin implementing Plan 9 C extensions [V2]

ksaunders created this revision. ksaunders added a reviewer: rsmith. ksaunders added a project: clang. Herald added a project: All. ksaunders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This patch enables the addition of extensions supported by the Plan 9 C

[PATCH] D127409: Fix GCC intrinsics "round_mask" names

GuillaumeGomez added a comment. As you suggested, I opened https://reviews.llvm.org/D127460 to rename `GCCBuiltin` into `ClangBuiltin` to clarify the confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127409/new/ https://reviews.llvm.org/D12

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez added a subscriber: craig.topper. GuillaumeGomez added a comment. As mentioned in https://reviews.llvm.org/D127409, it would avoid confusions to name it `ClangBuiltin` instead of keeping `GCCBuiltin`. cc @craig.topper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez created this revision. Herald added subscribers: kosarev, mattd, gchakrabarti, kerbowa, atanasyan, jrtc27, hiraditya, jvesely, nemanjai, sdardis. Herald added a project: All. GuillaumeGomez requested review of this revision. Herald added subscribers: llvm-commits, libcxx-commits, cf

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

msebor added a comment. Quite a bit more code treats one-element trailing arrays as flexible array members than larger arrays, and may not be able to change (GCC is one example). I wonder if it would be worthwhile to make it possible for code to specify that mode (e.g., by adding two options,

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

steplong added a comment. I don't think /external:Wn behaves exactly like -Wsystem-headers. /external:Wn applies /Wn to the system headers, while -Wsystem-headers applies whatever is on the command line to the system headers. I think /external:Wn behaves more like: // foo.c #pragma clang d

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127452 Files: clang/include/clang/Driver/Options.td

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StoreToImmutableChecker.cpp:43 + + if (!isa(R->getMemorySpace())) +return; zukatsinadze wrote: > NoQ wrote: > > This check catches a lot more regions than the ones produced by the other

[PATCH] D127448: [wip][pseudo] Implement guard extension.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. - define a common data structu

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aeubanks requested changes to this revision. aeubanks added a comment. This revision now requires changes to proceed. IIRC in the past there was a strong preference to not have the pass manager support this sort of thing if you want to support this, there should be an RFC for how the optimization

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

tra added a comment. I think the root cause of the problem here is that CUDA compilation assumes that the GPU-side looks identical to the host side of the compilation. The test was intended to verify that and, AFAICT, it did its job flagging the issue here. AFAICT, __GCC_ATOMIC_LLONG_LOCK_FREE=

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

njames93 added a comment. In D126495#3571403 , @LegalizeAdulthood wrote: > In D126495#3570767 , @aaron.ballman > wrote: > >> In D126495#3569863 , >> @LegalizeAdulthood

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard added a comment. In D127267#3570269 , @yaxunl wrote: > This patch is to fix an issue, right? At least we need a test to prevent that > issue from happening again. Yes, this patch is necessary to keep the clang/test/Preprocessor/cuda-types.cu

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. When submitting patches, please create the diff with context so that the code can be navigated in Phabricator. See https://llvm.org/docs/Phabricator.html#phabricator-reques

[PATCH] D127142: [HIP] Link with clang_rt.builtins

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:684-690 CmdArgs.append( {Args.MakeArgString(StringRef("-L") + RocmInstallation.getLibPath()), "-rpath", Args.MakeArgString(RocmInstallation.getLibPath())}); CmdArgs.push_back("-lam

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM The Thumb1 changes here are complicated, so I'm not sure we found all the issues, but you fixed all the issues I spotted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D127409: Fix GCC intrinsics "round_mask" names

GuillaumeGomez added a comment. Just to have a vague idea of what this change would look like, I pushed it. It would make our lives much simpler if we could rely on `GCCBuiltin` (aka `ClangBuiltin`) though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 435685. samitolvanen added a comment. - Per Fangrui's request, added comments explaining the X86 preamble format, and a note about it to the patch summary. - Switched back to `.weak` for the `__kcfi_typeid_` symbols to fix compatibility with LTO. Whethe

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 marked an inline comment as done. jansvoboda11 added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:8982 // Extension: Add the binary operators =, +=, -=, *=, /= for vector types. for (QualType Vec1Ty : CandidateTypes[0].vector_types())

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

akyrtzi added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:1-2 +// clang-format off + // RUN: %clang_cc1 -fsyntax-only -verify=pre-c2x-cpp2b %s akyrtzi wrote: > aaron.ballman wrote: > > You can remove this -- we don't require t

[PATCH] D127442: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls in C++ base or member initializers

ahatanak created this revision. ahatanak added a reviewer: arphaman. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127442 Files: clang/lib/Sema/SemaAvailability.cpp cla

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3570767 , @aaron.ballman wrote: > In D126495#3569863 , > @LegalizeAdulthood wrote: > >> In D126495#3569029 , @njames93 >>

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong updated this revision to Diff 435680. steplong added a comment. - Added release notes on attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126984/new/ https://reviews.llvm.org/D126984 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

akyrtzi added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:1-2 +// clang-format off + // RUN: %clang_cc1 -fsyntax-only -verify=pre-c2x-cpp2b %s aaron.ballman wrote: > You can remove this -- we don't require test files to be for

[clang-tools-extra] 70d35fe - [pseudo] Fix the broken build of ClangPseudoBenchmark, after c70aeaa.

Author: Haojian Wu Date: 2022-06-09T23:03:54+02:00 New Revision: 70d35fe1257e429266b83025997b400e9f79110e URL: https://github.com/llvm/llvm-project/commit/70d35fe1257e429266b83025997b400e9f79110e DIFF: https://github.com/llvm/llvm-project/commit/70d35fe1257e429266b83025997b400e9f79110e.diff LO

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 updated this revision to Diff 435675. jansvoboda11 added a comment. Introduce `QualifiersAndAtomic` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125349/new/ https://reviews.llvm.org/D125349 Files: clang/include/clang/AST/Type.h c

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435671. hctim added a comment. And some small diff-reducing touch ups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp cla

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435669. hctim added a comment. Remove two unnecessary braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/C

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435667. hctim marked 3 inline comments as done. hctim added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CodeGenModule.c

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked 10 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if (NoSanitizeL.containsLocation(EnabledAsanMa

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); sepavloff wrote:

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

mizvekov added inline comments. Herald added a subscriber: Peiming. Comment at: bolt/tools/CMakeLists.txt:11-13 +macro(add_bolt_tool_symlink name) + llvm_add_tool_symlink(BOLT ${ARGV}) +endmacro() Instead of each project having to define a different macro for th

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:684-690 CmdArgs.append( {Args.MakeArgString(StringRef("-L") + RocmInstallation.getLibPath()), "-rpath", Args.MakeArgString(RocmInstallation.getLibPath())}); CmdArgs.push_back("

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added a comment. In D127142#3570290 , @yaxunl wrote: > In D127142#3568905 , @MaskRay wrote: > >>> These functions are not available in libgcc but in libclang_rt.builtins. >>> Therefore --hip-link needs to

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. I was able to reduce it today. BUT didn't get a chance to debug: template concept Constraint = true; template class completion_handler_async_result { public: template static void initiate(Initiation&& initiation, RawCompletionToken&& token)

[PATCH] D127434: [clang][dataflow] In `optional` model, match call return via hasType

samestep updated this revision to Diff 435649. samestep added a comment. Simplify body using qualType Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127434/new/ https://reviews.llvm.org/D127434 Files: clang/lib/Analysis/FlowSensitive/Models/Unche

[PATCH] D127434: [clang][dataflow] In `optional` model, match call return via hasType

samestep added a comment. A test would definitely be good, but I'm not sure how to add one to `UncheckedOptionalAccessModelTest.cpp`, since the issue disappears when we replace `std::unique_ptr` with our custom simple `smart_ptr`. Any ideas? Comment at: clang/lib/Analysis/Fl

[PATCH] D127434: [clang][dataflow] In `optional` model, match call return via hasType

ymandel added a comment. Is there a test you can add that would cover this change? Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:170 + // multiple overloads of `hasType` match. + ast_matchers::internal::Matcher typeMatcher = anyOf( +

[PATCH] D127434: [clang][dataflow] Match call return via hasType Currently the unchecked-optional-access model fails on this example: #include #include void foo() {

samestep created this revision. samestep added a reviewer: ymandel. Herald added subscribers: tschuett, steakhal, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...::nullopt; } You can v

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. It's getting in really good shape. Nice work. I've got some nits about docs and checker dependencies and also a major comment inline. The documentation needs to be updated to kee

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty marked an inline comment as done. daltenty added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1228 GV->setDLLStorageClass(llvm::GlobalVariable::DLLImportStorageClass); -else if (D->hasAttr() && !GV->isDeclarationForLinker()) +else if ((

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6632 + "const qualifying the return value prevents move semantics">, + InGroup, DefaultIgnore; +def note_pessimizing_return_by_const : Note< Given that this is a `

[PATCH] D126340: [clang][AIX] add option -mdefault-visibility-export-mapping

daltenty updated this revision to Diff 435609. daltenty added a comment. - Don't try to export internal linkage RTTI types - Make shouldMapVisibilityToDLLExport inline and provide a short-circuit evaluation in the case where no mapping is in effect. This should hopefully solve the compile time i

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:979-980 +if (Ty.isConstQualified() && Ty->isArithmeticType()) { // TODO: We could walk the complex types here and see if everything is // constified. + sReg = getGlobals

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal updated this revision to Diff 435611. steakhal marked 2 inline comments as done. steakhal added a comment. - Use `assert` macro for introducing constraints. - Add tests for store binding invalidations, besides constraint invalidations. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

SebastianPerta added a comment. >> Regarding testing, it seems like this should change the diagnostic emitted >> for long x = 'abc' from "Character constant too long for its type" to >> "Multi-character character constant" when the target is AVR? Currently on RL78 it returns this warning withou

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

aaron.ballman added a comment. In D126495#3569863 , @LegalizeAdulthood wrote: > In D126495#3569029 , @njames93 > wrote: > >> It would also be nice if there was a redirect that would dynamically >> translate the

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Herald added a subscriber: Enna1. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUN

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. > Good question. Unless this functionality already has tests (and I'm gathering > it doesn't), I think we can rely on Clang being the test. (Though we should > consider ourselves

[PATCH] D126678: [clang] Allow CLANG_MODULE_CACHE_PATH env var to override module caching behavior

This revision was automatically updated to reflect the committed changes. abrachet marked an inline comment as done. Closed by commit rGfac39d14b129: [clang] Allow CLANG_MODULE_CACHE_PATH env var to override module caching… (authored by abrachet). Herald added a project: clang. Herald added a subs

[clang] fac39d1 - [clang] Allow CLANG_MODULE_CACHE_PATH env var to override module caching behavior

Author: Alex Brachet Date: 2022-06-09T16:55:37Z New Revision: fac39d14b129fa545fc7633ef8e0be9ddf45cab2 URL: https://github.com/llvm/llvm-project/commit/fac39d14b129fa545fc7633ef8e0be9ddf45cab2 DIFF: https://github.com/llvm/llvm-project/commit/fac39d14b129fa545fc7633ef8e0be9ddf45cab2.diff LOG:

[PATCH] D127251: [Lex] Fix `fixits` for typo-corrections of preprocessing directives within skipped blocks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch, thank you for fixing this up! LGTM! Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:1-2 +// clang-format off + // RUN: %clang_cc1 -f

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

v.g.vassilev added a comment. In D126682#3546865 , @junaire wrote: > this depends on https://reviews.llvm.org/D126684 I would prefer to merge them into one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1500 + +assert(WeakRefReferences.empty() && + "Not all WeakRefRefs have been applied"); It seems that we forgot to move the `WeakRefReferences`? Repository: rG LLV

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add the release note when landing. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126984/new/ https://revi

[PATCH] D127393: [Driver] Don't add -lresolv on FreeBSD

kda accepted this revision. kda added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:841 CmdArgs.push_back("-lexecinfo"); // There is no libresolv on Android. + if (!TC.getTriple().isAndroid() && !

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added inline comments. Comment at: llvm/test/Analysis/CostModel/X86/fptoi_sat.ll:852 +; SSE2-NEXT: Cost Model: Found an estimated cost of 3 for instruction: %f16u1 = call i1 @llvm.fptoui.sat.i1.f16(half undef) +; SSE2-NEXT: Cost Model: Found an estimated cost of 5 for

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 435583. pengfei marked an inline comment as done. pengfei added a comment. Address Yuanke's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082 Files: llvm/do

[PATCH] D127411: [AST Matchers] Make dump_ast_matchers.py work on Python 3

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. ...Also updates the output HTML. Fixes llvm#46446 Repository: rG LLVM G

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13591-13595 +if (!Target->isVLSTBuiltinType() && !isa(OriginalTarget)) { + if (S.SourceMgr.isInSystemMacro(CC)) +return; + return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_ve

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

martong added a comment. In D127306#3570170 , @steakhal wrote: > In D127306#3570083 , @martong wrote: > >> In D127306#3566984 , @steakhal >> wrote: >> >>> In D127306#3566

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

rjmccall added a comment. Yeah, that makes sense. Thanks for following that up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125919/new/ https://reviews.llvm.org/D125919 ___ cfe-commits mailing list cf

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435571. jhuber6 added a comment. Fixing bug when capturing a StringRef by reference in a callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files: clang/tool

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

martong accepted this revision. martong added a comment. LGTM, it is a good start for an alpha checker. Comment at: clang/docs/ReleaseNotes.rst:525 +- Added a new checker ``alpha.unix.Errno``. This can find the first read + of ``errno`` after not failed standard function calls

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 updated this revision to Diff 435570. jansvoboda11 added a comment. Herald added a subscriber: MaskRay. Extract `-fdriver-only` into separate patch, ensure output file is consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121997/

[PATCH] D127408: [clang][driver] Introduce new -fdriver-only flag

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, egorzhdan. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch introduces the new -fdriver-only flag whic

[PATCH] D127407: [ubsan][docs] Clarify `objc-cast` is not part of `-fsanitize=undefined`

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was missed on https://reviews.llvm.org/D71491. Fixes llvm#54880 Repository: rG LLVM Github Monorepo https://revi

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

awarzynski updated this revision to Diff 435564. awarzynski added a comment. Add the `FLANG_USE_LEGACY_NAME` cmake option that will control the name of the driver executable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125788/new/ https://review

[PATCH] D125919: Drop qualifiers from return types in C (DR423)

aaron.ballman added a comment. In D125919#3570145 , @rjmccall wrote: > In D125919#3569928 , @aaron.ballman > wrote: > >> In D125919#3560523 , >> @aaron.ballman wrote: >>

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:8978 + } } } Can we do this in a way that's a little more general if we want to include other qualifiers in this combinatoric explosion in the future? I think y

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 435561. ckandeler added a comment. Addressed clang-format complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/SemanticHigh

  1   2   3   >