[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added a comment. > This patch turns on support for CR bit accesses for Power8 and above. The > reason why CR bits are turned on as the default for Power8 and above is that > because later architectures make use of builtins and instructions that > require CR bit accesses (such as the use

[PATCH] D124239: [analyzer] Fix ValistChecker false-positive involving symbolic pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe744da01f9d: [analyzer] Fix ValistChecker false-positive involving symbolic pointers (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] be744da - [analyzer] Fix ValistChecker false-positive involving symbolic pointers

Author: Balazs Benics Date: 2022-04-26T08:49:05+02:00 New Revision: be744da01f9da0675ba5a3958c03bcd1fdc8ad60 URL: https://github.com/llvm/llvm-project/commit/be744da01f9da0675ba5a3958c03bcd1fdc8ad60 DIFF: https://github.com/llvm/llvm-project/commit/be744da01f9da0675ba5a3958c03bcd1fdc8ad60.diff

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire created this revision. junaire added reviewers: dblaikie, nikic, tstellar. Herald added a subscriber: mstorsjo. Herald added a project: All. junaire requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project

[PATCH] D124432: Fix issues with using clangd with C++ modules

kuganv created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. Herald added a project: All. kuganv requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes following

[PATCH] D118409: [OpenMPIRBuilder] Remove ContinuationBB argument from Body callback.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5571-5579 + { +OMPBuilderCBHelpers::InlinedRegionBodyRAII IRB(*this, AllocaIP, + *FiniBB); +EmitStmt(CS->get

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik added a comment. In D123319#3473283 , @dblaikie wrote: > ('scuse the delay) > > Baseline: I'm still not really sure this is the right direction. Is there a > sound argument for why this change is suitable for lambdas, but not for other > types? I

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1261-1263 + Reader.Diag(IVD->getLocation(), diag::err_duplicate_ivar_declaration) + << II; + Reader.Diag(PrevIvar->getLocation(), diag::note_previous_definition); -

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

MTC added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/AtomicChange.h:119 + Replacements &getRefReplacements() { return Replaces; } + IMHO, there is no need to rename the method to get the non-const version. The following code is ok e

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead added a comment. In D112921#3473022 , @ldionne wrote: > (BTW I strongly support this patch, I just think we should do it properly on > all platforms from the start :-) I couldn't agree with you more, but I have no idea how to implement it.

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik added inline comments. Comment at: clang/test/CodeGenCXX/no_auto_return_lambda.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s + erichkeane wrote: > erichkeane wrote: > > So this CodeGen test without a triple is a bit t

[PATCH] D124427: [Serialization] Pack Expr ObjectKind and ValueKind into one VBR.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: usaxena95. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Most Exprs are serialized unab

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

vsapsai updated this revision to Diff 425093. vsapsai added a comment. Rebase and update test to use `ptr` instead of `i64*`. Also now the added test is failing for `implementationIvar`, investigating that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D124422: [Serialization] Improve encoding of small SourceRanges.

sammccall updated this revision to Diff 425089. sammccall added a comment. Switch reader/writer to use sourcerange encoding for all "obvious" ranges. Gain is now 1.75% in my test PCH. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124422/new/ https

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

maryammo updated this revision to Diff 425086. maryammo added a comment. [PowerPC] Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124093/new/ https://reviews.llvm.org/D124093 Files: clang/include/clang/Basic/BuiltinsPP

[clang] 8e4cd72 - [CMake] Update cache file for Win to ARM Linux cross toolchain builders. NFC.

Author: Vladimir Vereschaka Date: 2022-04-25T17:44:35-07:00 New Revision: 8e4cd7295cb56c2baa6fbed1b739ed974738c307 URL: https://github.com/llvm/llvm-project/commit/8e4cd7295cb56c2baa6fbed1b739ed974738c307 DIFF: https://github.com/llvm/llvm-project/commit/8e4cd7295cb56c2baa6fbed1b739ed974738c307

[libunwind] db92019 - [libunwind] Update the test configuration files to support the remote execution.

Author: Vladimir Vereschaka Date: 2022-04-25T17:33:03-07:00 New Revision: db92019ab97b9bb13a3287438c4a2fa3ba375756 URL: https://github.com/llvm/llvm-project/commit/db92019ab97b9bb13a3287438c4a2fa3ba375756 DIFF: https://github.com/llvm/llvm-project/commit/db92019ab97b9bb13a3287438c4a2fa3ba375756

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw updated this revision to Diff 425083. zixuw added a comment. - Rewrite commit message for preparation - Remove shortening paths based on the current working directory: it does not work with angled includes, and unnecessary for our use - XFAIL test known_files_only_hmap.c, as it is not a val

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:134 +if (!SpelledFilename.empty()) + return SpelledFilename.str(); + zixuw wrote: > zixuw wrote: > > One problem I can see in this right now is that there might

[PATCH] D124422: [Serialization] Improve encoding of small SourceRanges.

sammccall added a comment. Bad news: this isn't ready, there are places where ASTWriter calls AddSourceLocation() twice and ASTReader calls ReadSourceRange(). After this change, those are no longer compatible so we have to make them match, and have to audit them all. Good news, there's a bunch

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added inline comments. Comment at: clang/include/clang/AST/TransformTypeTraits.def:27 +TRANSFORM_TYPE_TRAIT_DEF(RemoveVolatile, remove_volatile) +TRANSFORM_TYPE_TRAIT_DEF(EnumUnderlyingType, underlying_type) This file should undef the `TRANSFORM_TYPE_TRAIT

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. ('scuse the delay) Baseline: I'm still not really sure this is the right direction. Is there a sound argument for why this change is suitable for lambdas, but not for other types? I believe all the situations that can happen with other types can happen with lambdas (&

[clang-tools-extra] 2d014b7 - [test][clangd] Use StringRef instead of std::string

Author: Vitaly Buka Date: 2022-04-25T16:38:18-07:00 New Revision: 2d014b72ccb51de9a9627c31667a3edf8cca7616 URL: https://github.com/llvm/llvm-project/commit/2d014b72ccb51de9a9627c31667a3edf8cca7616 DIFF: https://github.com/llvm/llvm-project/commit/2d014b72ccb51de9a9627c31667a3edf8cca7616.diff L

[PATCH] D124422: [Serialization] Improve encoding of small SourceRanges.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of encoding as (start,

[PATCH] D124420: [Serialization] Compress serialized macro expansion SLocEntries

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Macro expansion SLocEntries are significant to PCH size (7-10% in my tests).

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:134 +if (!SpelledFilename.empty()) + return SpelledFilename.str(); + zixuw wrote: > One problem I can see in this right now is that there might be multiple > he

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:134 +if (!SpelledFilename.empty()) + return SpelledFilename.str(); + One problem I can see in this right now is that there might be multiple headermaps that tog

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rjmccall added a comment. Ideally, I think, we would set this up to work something like `ObjCRuntime`, where we're making queries to a common place that contains all the information necessary to decide what runtime features are available. In particular, we shouldn't treat Apple platforms as fo

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne added a comment. (BTW I strongly support this patch, I just think we should do it properly on all platforms from the start :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne added a subscriber: ahatanak. ldionne added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4078-4082 + if (!Args.getLastArg(options::OPT_fsized_deallocation, + options::OPT_fno_sized_deallocation)) +Opts.SizedDeallocation

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

xazax.hun added a comment. Nice! Did you do some measurements? Does this improve the performance or decrease the memory consumption? Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:160 + void addFlowConditionConstraint(AtomicBoolValue &Token,

[PATCH] D124316: [clang-tidy] Modernize-macro-to-enum should skip macros used in other macros

LegalizeAdulthood added a comment. Gentle ping. I have another change based on this that fixes #55055 Enhance modernize-macro-to-enum to recognize constant literal expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

Anastasia added a comment. You should be able to provide an address space of the pointer using the number, see details in: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Builtins.def#L65 However if language address spaces are needed I wonder if the best approach is jus

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw updated this revision to Diff 425017. zixuw added a comment. - Create FileManager in PrepareToExecuteAction - Use FileManager to load headermaps and reverse lookup mappings - Use FileSystem to correctly get working directory and make absolute paths Repository: rG LLVM Github Monorepo CH

[PATCH] D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

This revision was automatically updated to reflect the committed changes. Closed by commit rG0386213352ec: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/ (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 0386213 - [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

Author: Quinn Pham Date: 2022-04-25T15:26:36-05:00 New Revision: 0386213352ec42342c756099fcfc6c1165d99e08 URL: https://github.com/llvm/llvm-project/commit/0386213352ec42342c756099fcfc6c1165d99e08 DIFF: https://github.com/llvm/llvm-project/commit/0386213352ec42342c756099fcfc6c1165d99e08.diff LO

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:420 +auto *FD = IFD ? IFD->getAnonField() : dyn_cast(D); +if (!FD || (FD->isUnnamedBitfield() || FD->isAnonymousStructOrUnion())) + continue; yihanaa wrote: > erichkeane wrote:

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

rsmith added a comment. In D124221#3471645 , @erichkeane wrote: > In D124221#3470550 , @aaron.ballman > wrote: > >> In D124221#3469251 , @rsmith wrote: >> >>> - Take any

[libunwind] 7164c5f - [libunwind] [CMake] Remove leftover no-op cmake variable setting. NFC.

Author: Martin Storsjö Date: 2022-04-25T23:01:22+03:00 New Revision: 7164c5f051a980442f2376af4bae3740710bf347 URL: https://github.com/llvm/llvm-project/commit/7164c5f051a980442f2376af4bae3740710bf347 DIFF: https://github.com/llvm/llvm-project/commit/7164c5f051a980442f2376af4bae3740710bf347.diff

[libunwind] c98d950 - [libunwind] Fix build warnings in Unwind-EHABI.cpp. NFC.

Author: Martin Storsjö Date: 2022-04-25T23:00:52+03:00 New Revision: c98d9502fc6b10caea3cc3db94d85887c38e5892 URL: https://github.com/llvm/llvm-project/commit/c98d9502fc6b10caea3cc3db94d85887c38e5892 DIFF: https://github.com/llvm/llvm-project/commit/c98d9502fc6b10caea3cc3db94d85887c38e5892.diff

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

nikic added a comment. @jberdine See https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm-c/Transforms/PassBuilder.h for C bindings for the new pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124063/new/ https://reviews.ll

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/no_auto_return_lambda.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s + erichkeane wrote: > So this CodeGen test without a triple is a bit troublesome. The o

[clang] 5c90eca - [PS5] Driver test for analyzer defaults

Author: Paul Robinson Date: 2022-04-25T12:42:00-07:00 New Revision: 5c90ecae2db104a816aeb33b6f773aaf782850e7 URL: https://github.com/llvm/llvm-project/commit/5c90ecae2db104a816aeb33b6f773aaf782850e7 DIFF: https://github.com/llvm/llvm-project/commit/5c90ecae2db104a816aeb33b6f773aaf782850e7.diff

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

jberdine added a comment. Apologies if this isn't directly related to this patch in particular, but is there a more informative message that could be given than "Migrate to new pass manager"? In particular, for non-C language bindings that currently call `LLVMPassManagerBuilderPopulateModulePas

[clang] 6035649 - [Serialization] Remove dead TYPE_FUNCTION_PROTO abbreviation. NFC

Author: Sam McCall Date: 2022-04-25T21:16:54+02:00 New Revision: 6035649d4c763dab83376484c5fe515c2469a1bb URL: https://github.com/llvm/llvm-project/commit/6035649d4c763dab83376484c5fe515c2469a1bb DIFF: https://github.com/llvm/llvm-project/commit/6035649d4c763dab83376484c5fe515c2469a1bb.diff LO

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

tahonermann added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1183-1185 +.. option:: -fmodule-header=\[user,system\] + +Build a C++20 header unit, but search for the header in the user or system header search paths respectively. iains w

[PATCH] D124382: [Clang] Recognize target address space in superset calculation

tra added inline comments. Comment at: clang/include/clang/AST/Type.h:486 + bool IsSYCLOrOpenCL = false) { +if (ASMap) { + bool IsATargetAS = false; If A and B are both target AS, we fall through to the code which is

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/no_auto_return_lambda.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - | FileCheck %s + So this CodeGen test without a triple is a bit troublesome. The one we've noticed th

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw added a comment. The problem is that we are trying to shorten the input file paths in `PrepareToExecuteAction`, where the `CompilerInstance` is still primal and doesn't even have a `FileManager` that we could use. That makes it hard (if possible at all) to reverse lookup headermaps and us

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1183-1185 +.. option:: -fmodule-header=\[user,system\] + +Build a C++20 header unit, but search for the header in the user or system header search paths respectively. tahonermann w

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. bump @lhames @JDevlieghere would either of y'all be able to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits m

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

tahonermann added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1183-1185 +.. option:: -fmodule-header=\[user,system\] + +Build a C++20 header unit, but search for the header in the user or system header search paths respectively. Are "us

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

This revision was automatically updated to reflect the committed changes. Closed by commit rG87468e85fcdc: compile commands header to source heuristic lower-cases filenames before… (authored by ishaangandhi, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 87468e8 - compile commands header to source heuristic lower-cases filenames before inferring file types

Author: Ishaan Gandhi Date: 2022-04-25T20:40:56+02:00 New Revision: 87468e85fcdcf1bd5055466e34d17436a79017a2 URL: https://github.com/llvm/llvm-project/commit/87468e85fcdcf1bd5055466e34d17436a79017a2 DIFF: https://github.com/llvm/llvm-project/commit/87468e85fcdcf1bd5055466e34d17436a79017a2.diff

[PATCH] D124396: [HIP] Fix diag msg about sanitizer

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:113-114 def warn_drv_unsupported_option_for_offload_arch_req_feature : Warning< - "ignoring '%0' option as it is not currently supported for " -

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. Alright, a touch more: It looks like the looping through the `CurContext` at line 6084 finds the wrong thing in evaluating this `CXXMethodDecl`! The "broken" version has its CurContext as `bar` in the example above, the "working" versions have `foo` or `foo2`. The

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. Here is the example I'm playing with: template constexpr bool constraint = true; #define BROKE_REQUIRES 1 #define WORKING_REQUIRES 2 #define WORKING_BODY 3 #define TEST BROKE_REQUIRES //#define TEST WORKING_REQUIRES //#define TEST WORKING_BODY

[PATCH] D124396: [HIP] Fix diag msg about sanitizer

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Wording nit. LGTM otherwise. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:113-114 def warn_drv_unsupported_option_for_offload_arch_req_feature : Warning< - "ign

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 424963. erichkeane added a comment. This revision is now accepted and ready to land. Here is my current 'WIP' patch, with only `ChecksMemberVar::foo` failing. I noticed that the problem so far starts in `TransformMemberExpr`, which calls `TransformDecl`

[clang] ef7439b - [Basic] SourceManager docs: macro expansion SLocs aren't a single token. NFC

Author: Sam McCall Date: 2022-04-25T19:57:47+02:00 New Revision: ef7439bdf923e59095449c3bc8cfe72d8101eea5 URL: https://github.com/llvm/llvm-project/commit/ef7439bdf923e59095449c3bc8cfe72d8101eea5 DIFF: https://github.com/llvm/llvm-project/commit/ef7439bdf923e59095449c3bc8cfe72d8101eea5.diff LO

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

zixuw updated this revision to Diff 424959. zixuw added a comment. - Use first match in `getRelativeIncludeName` - Try to get Preprocessor and reverse lookup headermaps in `getRelativeIncludeName` - Use `getRelativeIncludeName` to check for known files in `LocationFileChecker` - Misc fixes & adju

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

asoffer added a comment. In D122920#3471865 , @yihanaa wrote: > In D122920#3471654 , @erichkeane > wrote: > >> @yihanaa : I'd suggest seeing the conversation that @rsmith @aaron.ballman >> and I are having about

[clang] 9727c77 - [NFC] Rename Instrinsic to Intrinsic

Author: David Green Date: 2022-04-25T18:13:23+01:00 New Revision: 9727c77d58ac920a4158d08c15659470e52ddda4 URL: https://github.com/llvm/llvm-project/commit/9727c77d58ac920a4158d08c15659470e52ddda4 DIFF: https://github.com/llvm/llvm-project/commit/9727c77d58ac920a4158d08c15659470e52ddda4.diff L

[PATCH] D124026: [Headers][MSVC] Define wchar_t in stddef.h like MSVC if not using the builtin type

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124026/new/ https://reviews.llvm.org/D124026 ___

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Jake-Egan added a comment. Thanks @sammccall, the test is passing now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250 ___ cfe-commits mailing list cfe-commits@

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi added a comment. In D124262#3472079 , @sammccall wrote: > Thanks! > I can land this for you if you don't have commit access - can you provide the > name/email to use for the commit? Thank you! Ishaan Gandhi ishaangan...@gmail.com CHANGES

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

aeubanks added a comment. I'd first fix up as many in-tree users as nikic pointed out (I'll work on bugpoint soonish since that requires a bit more work) Comment at: llvm/include/llvm-c/Transforms/PassManagerBuilder.h:72 +#ifdef __GNUC__ +__attribute__((deprecated("Migrate to

[PATCH] D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffe03ff75c26: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup. (authored by khchen). Changed prior to commit: https://

[PATCH] D121299: [NVPTX] Disable DWARF .file directory for PTX

probinson added a comment. I'm okay with doing it this way. My impression over the years (as a debug-info guy, not as a ptxas user) is that ptxas evolves slowly and this is not really "busy work." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev updated this revision to Diff 424930. sgatev added a comment. Mark methods as const. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124395/new/ https://reviews.llvm.org/D124395 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnal

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I can land this for you if you don't have commit access - can you provide the name/email to use for the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

yihanaa added a comment. Thank you for inviting me to a discussion on this topic. I have something very confusing as follows: - If the developer already knows all fields info in some struct, wyh doesn't he write a simple function to do the printing(like: print_struct_foo(const struct foo *); )

[PATCH] D124396: [HIP] Fix diag msg about sanitizer

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. Fix the misleading diag msg as the option is ignored for a particular offload arch only. https://reviews.llvm.org/D12439

[PATCH] D121299: [NVPTX] Disable DWARF .file directory for PTX

asavonic added a comment. I'm going to merge the patch in a couple of days, unless anyone has a strong opinion against it. Alternative options: - revert this default back to false (not great for other targets) - add a check for `Triple == NVPTX` directly to llc (tools other than llc will have t

[PATCH] D124395: [clang][dataflow] Optimize flow condition representation

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Represent flow conditions as Token <=> Constraints bic

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall added a comment. 1c65c734c93f8c4d39947e596d7fe89289ce283d will clear the PCH file. If this doesn't fix the problem I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 1c65c73 - Clear temporary file in test, buildbot appears to be reusing an old one.

Author: Sam McCall Date: 2022-04-25T17:26:39+02:00 New Revision: 1c65c734c93f8c4d39947e596d7fe89289ce283d URL: https://github.com/llvm/llvm-project/commit/1c65c734c93f8c4d39947e596d7fe89289ce283d DIFF: https://github.com/llvm/llvm-project/commit/1c65c734c93f8c4d39947e596d7fe89289ce283d.diff LO

Re: [PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Hi Jake, I suspect something about the test/runner is nonhermetic, I'm going to try to fix it in the test. This commit changes the serialized PCH format. It looks like this test is not properly hermetic, and is trying to load the PCH from a previous run of the test. It clears the module dir, but

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. In D122663#3471960 , @hvdijk wrote: > In D122663#3471866 , @erichkeane > wrote: > >> This actually wouldn't be necessary in this case: cxxfilt is already >> 'right', this is just for

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added a comment. In D122663#3471866 , @erichkeane wrote: > This actually wouldn't be necessary in this case: cxxfilt is already 'right', > this is just for humans to be able to see "we changed this from mangling as > to ". That's a good point.

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG37b4782e3e53: [clang][dataflow] Fix `Environment::join`'s handling of flow-condition merging. (authored by

[clang] 37b4782 - [clang][dataflow] Fix `Environment::join`'s handling of flow-condition merging.

Author: Yitzhak Mandelbaum Date: 2022-04-25T15:05:50Z New Revision: 37b4782e3e53cba265d26843f222134ed21e1974 URL: https://github.com/llvm/llvm-project/commit/37b4782e3e53cba265d26843f222134ed21e1974 DIFF: https://github.com/llvm/llvm-project/commit/37b4782e3e53cba265d26843f222134ed21e1974.diff

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:356 + +return V1 == V2 || + Env1.flowConditionImplies(*V1) == Env2.flowConditionImplies(*V2);

[PATCH] D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124389/new/ https://reviews.llvm.org/D124389

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

ymandel updated this revision to Diff 424916. ymandel marked an inline comment as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124104/new/ https://reviews.llvm.org/D124104 Files: clang/lib/Analysi

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:356 + +return V1 == V2 || + Env1.flowConditionImplies(*V1) == Env2.flowConditionImplies(*V2); ymandel

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424914. ishaangandhi added a comment. Made test case reflect that proxies for ".H" files are ".C" files, and not ".c files". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files: clang/lib/Tooling

[PATCH] D124384: [clang] Fix a constant evaluator crash on a NULL-type expr.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is a reasonable immediate fix, but creating null-typed expressions that live *outside* the recoveryexpr seems scary, and likely to violate expected invariants elsewhere too... Rep

[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

Naghasan added a comment. Thanks for your answer, make sense. If we are moving away I won't bother looking fixing my issue upstream as it is very niche (I don't think you can trigger this with the upstream clang driver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi added inline comments. Comment at: clang/unittests/Tooling/CompilationDatabaseTest.cpp:852 + add("other/random/path.cpp"); + // Proxies for ".H" files are ".C" files, and not ".cpp files" + EXPECT_EQ(getProxy("foo/bar/baz/exact.H"), "foo/bar/baz/exact.C"); ---

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Jake-Egan added a comment. Hi, this broke a test on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/903/steps/6/logs/FAIL__Clang__pch-with-module_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

sammccall added a comment. In D124262#3471841 , @ishaangandhi wrote: > Test case added, re-diffed with `-U`, and removed redundant constructor. > Thanks for the quick feedback, @sammccall! > > (I didn't wait for the tests to run locally, I am hoping

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

ymandel marked 7 inline comments as done. ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:356 + +return V1 == V2 || + Env1.flowConditionImplies(*V1) == Env2.flowConditionImplies(*V2);

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

ymandel updated this revision to Diff 424909. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124104/new/ https://reviews.llvm.org/D124104 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. > llvm-cxxfilt has no option to be compatible with earlier incorrect mangling > though, so it would not help with this particular test. But it could help > with other tests, agreed. This actually wouldn't be necessary in this case: cxxfilt is already 'right', this i

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. In D122920#3471654 , @erichkeane wrote: > @yihanaa : I'd suggest seeing the conversation that @rsmith @aaron.ballman > and I are having about this builtin here: https://reviews.llvm.org/D124221 > > In general it looks like the t

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424906. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp clang/unittests/Tooling/CompilationDatabaseTest.cpp Index: clang/unittests/Too

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi marked an inline comment as done. ishaangandhi added a comment. Test case added, re-diffed with `-U`, and removed redundant constructor. Thanks for the quick feedback, @sammccall! (I didn't wait for the tests to run locally, I am hoping to use your CI systems to do that. It see

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi updated this revision to Diff 424904. ishaangandhi added a comment. - Added a test case - Removed redundant "StringRef" constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124262/new/ https://reviews.llvm.org/D124262 Files: cl

[PATCH] D124389: [clang][NFC] Inclusive language: remove use of Whitelist in clang/lib/Analysis/

quinnp created this revision. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] As part of using inclusive language within the llvm project, this patch rewords a comment to replace Whitelist with Allo

  1   2   >