[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:537-543 + static StringRef getPrimaryModuleInterfaceName(StringRef Name) { +return Name.split(':').first; + } + /// Get the primary module interface name from a partition. StringRef getPri

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

mboehme added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; aaron.ballman wrote: > Isn't the same true for this variable? It seems like: > > `trivial` == `savedA

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423542. ChuanqiXu added a comment. Address comments: - Add Cache in isInCurrentModule to avoid too many string comparisons. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files: clang/include/clang/B

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 updated this revision to Diff 423532. int3 added a comment. Herald added a subscriber: dexonsmith. - Use a separate ForceDwarfUnwindInfo flag - Fix the remaining tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.l

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 marked an inline comment as done. int3 added inline comments. Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp:131-132 + size_t Size) { + if (Size == 0) +return; registerEHFramesInProcess(Addr, Size);

[PATCH] D123976: [CUDA][HIP] Fix delete operator for -fopenmp

yaxunl updated this revision to Diff 423515. yaxunl added a comment. remove redundant casts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123976/new/ https://reviews.llvm.org/D123976 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/SemaCUDA/openmp-parallel.cu Index: clang/test/S

[PATCH] D123976: [CUDA][HIP] Fix delete operator for -fopenmp

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: mattd, guansong. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. When new operator is called in OpenMP parallel regi

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423514. jhuber6 added a comment. Removing unnecessary change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D123946: [CUDA][HIP] Fix gpu.used.external

This revision was automatically updated to reflect the committed changes. Closed by commit rGcac4e2fe2582: [CUDA][HIP] Fix gpu.used.external (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123946/new

[clang] cac4e2f - [CUDA][HIP] Fix gpu.used.external

Author: Yaxun (Sam) Liu Date: 2022-04-18T23:10:31-04:00 New Revision: cac4e2fe258239489c12dd5f153da3e69e17ebba URL: https://github.com/llvm/llvm-project/commit/cac4e2fe258239489c12dd5f153da3e69e17ebba DIFF: https://github.com/llvm/llvm-project/commit/cac4e2fe258239489c12dd5f153da3e69e17ebba.dif

[clang] 2d92ee9 - Reapply "[OpenMP] Refactor OMPScheduleType enum."

Author: Michael Kruse Date: 2022-04-18T21:56:47-05:00 New Revision: 2d92ee97f1afb3657579a46a7dd4611b61e9cc16 URL: https://github.com/llvm/llvm-project/commit/2d92ee97f1afb3657579a46a7dd4611b61e9cc16 DIFF: https://github.com/llvm/llvm-project/commit/2d92ee97f1afb3657579a46a7dd4611b61e9cc16.diff

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp: + + const MCSectionELF &ElfSec = static_cast(TextSec); + unsigned Flags = ELF::SHF_LINK_ORDER; nickdesaulniers wrote: > or just `cast`. > https://llvm.org/docs/ProgrammersM

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The script is located in the llvm/ sub-directory, so it is not available for when doing a stand-alone build. Repository: rG

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added a comment. Please add a test where calls to `@llvm.kcfi.check` produce `KCFI_CHECK` during instruction selection. (You can use `-stop-before=finalize-isel` to dump the IR prior to isel; this can stay a .ll test, I think, rather than .mir). Comment at: cl

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#3453565 , @bowang wrote: >> Hi, this patch is just part-1 of Windows SEH feature support. Part-2 work >> had been sitting in https://reviews.llvm.org/D102817/new/ since last May >> 2021. It's been reviewed, and feedba

[PATCH] D123957: Update the developer policy to mention release notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 __

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk marked 2 inline comments as done. hvdijk added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:6031 +bool CXXNameMangler::mangleSubstitution(NestedNameSpecifier *NNS) { + NNS = Context.getASTContext().getCanonicalNestedNameSpecifier(NNS); + return mangleSubs

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk updated this revision to Diff 423482. hvdijk added a comment. Extend test, add assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llvm.org/D122663 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Great, thanks for adding the test case! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122691/new/ https://reviews.llvm.org/D122691 ___

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423479. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Compilation.h clang/include/clang/Driver/Op

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423478. jhuber6 added a comment. Hopefully this is the last time I need to update this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Dr

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Remove constraint that an initializing expression of struct type

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik updated this revision to Diff 423471. shafik marked 4 inline comments as done. shafik added a comment. - Making test more robust - Adding comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 Files: clang/lib/CodeGen/CGDebugInfo.cp

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423470. jhuber6 added a comment. Fix after fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/include/clang/Dri

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423468. jhuber6 added a comment. Sorry for the spam Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Ac

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423466. jhuber6 added a comment. Fix for real after rebasing failure... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423465. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Compila

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423464. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Action.h clang/lib/Driver/Action.cpp clan

[PATCH] D122589: Additionally set f32 mode with denormal-fp-math

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM. I played around with this and it seems to have the overriding behavior I would expect Comment at: clang/test/CodeGen/denormalfpmode-f32.c:21 + +// CHECK-LABEL: main +

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

tahonermann added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1034-1042 + if (T.isNull() || !T->getAs()) +// If the type is invalid or is not a function type, we cannot get +// a block pointer type for it. This isn't i

[PATCH] D123958: [randstruct] Randomize all elements of a record

void created this revision. void added reviewers: aaron.ballman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A record may have more than just FieldDecls i

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

jhuber6 updated this revision to Diff 423461. jhuber6 added a comment. Rebase after making the new driver default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 Files: clang/include/clang/Driver/Actio

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked 3 inline comments as done. aaron.ballman added a subscriber: NoQ. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:124 BENIGN_LANGOPT(ImplicitInt, 1, 0, "C89 implicit 'int'") +LANGOPT(StrictPrototypes , 1, 0, "requi

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 423460. jhuber6 added a comment. Herald added subscribers: mattd, dexonsmith, MaskRay. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/include/

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423459. jhuber6 added a comment. Rebase & update after making the new driver default for OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/includ

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman created this revision. aaron.ballman added a reviewer: lattner. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. As a project, Clang has gotten negative public feedback about our lack of communicating changes to users. There

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

rsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:124 BENIGN_LANGOPT(ImplicitInt, 1, 0, "C89 implicit 'int'") +LANGOPT(StrictPrototypes , 1, 0, "require function types to have a prototype") LANGOPT(Digraphs , 1, 0, "digraphs") ---

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:119 Opts.Digraphs = Std.hasDigraphs(); + Opts.StrictPrototypes = Std.isCPlusPlus() || Std.isC2x(); cor3ntin wrote: > Stupid ques

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

cor3ntin added a comment. Thanks for working on this, Just a few comments Comment at: clang/lib/Basic/LangOptions.cpp:119 Opts.Digraphs = Std.hasDigraphs(); + Opts.StrictPrototypes = Std.isCPlusPlus() || Std.isC2x(); Stupid question, we probably don't wan

[clang] af02851 - Revert "[OpenMP] Refactor OMPScheduleType enum."

Author: Michael Kruse Date: 2022-04-18T14:38:31-05:00 New Revision: af0285122f306573d9bcc4c4ad7f904cfdd4d869 URL: https://github.com/llvm/llvm-project/commit/af0285122f306573d9bcc4c4ad7f904cfdd4d869 DIFF: https://github.com/llvm/llvm-project/commit/af0285122f306573d9bcc4c4ad7f904cfdd4d869.diff

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11243 // We really shouldn't be making a no-proto type here. + if (ArgTypes.empty() && Variadic && !getLangOpts().StrictPrototypes) aaron.ballman wrote: > erichkeane wrote: > > How t

[PATCH] D122663: Mark identifier prefixes as substitutable

rsmith added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:6031 +bool CXXNameMangler::mangleSubstitution(NestedNameSpecifier *NNS) { + NNS = Context.getASTContext().getCanonicalNestedNameSpecifier(NNS); + return mangleSubstitution(reinterpret_cast(NNS));

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman updated this revision to Diff 423451. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123955/new/ https://reviews.llvm.org/D123955 Files: clang/docs/ReleaseNote

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11243 // We really shouldn't be making a no-proto type here. + if (ArgTypes.empty() && Variadic && !getLangOpts().StrictPrototypes)

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11243 // We really shouldn't be making a no-proto type here. + if (ArgTypes.empty() && Variadic && !getLangOpts().StrictPrototypes) How tough would it be to change this to represent

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6389-6391 +Normally the shader type is set by shader target with the -T option like +-Tps_6_1. +When compiling to a library target like lib_6_3, the shader type attribute can aar

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423448. python3kgae added a comment. Fix doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Bas

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman created this revision. aaron.ballman added reviewers: jyknight, eli.friedman, hubert.reinterpretcast, erichkeane, clang-language-wg. Herald added subscribers: dexonsmith, jdoerfert, martong. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11663 X = BO->getLHS(); - D = BO->getRHS(); + D = BO->getRHS()->IgnoreImpCasts(); ABataev wrote: > Why do we need to use `IgnoreImpCasts()` here and in other places? Clang usua

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. LGTM! I would like @rjmccall to take a pass if he ends up having time in the next day or two (perhaps tack on an extra day or two because of Easter), else I'll be willing to approve later in the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk updated this revision to Diff 423445. hvdijk added a comment. Add to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llvm.org/D122663 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae23be84cb60: [OpenMP] Make the new offloading driver the default (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 15e6206 - [Clang][Docs] Update information on the new driver now that it's default

Author: Joseph Huber Date: 2022-04-18T15:05:09-04:00 New Revision: 15e62062c0c919ac1fa28d6f0c9f438063da2286 URL: https://github.com/llvm/llvm-project/commit/15e62062c0c919ac1fa28d6f0c9f438063da2286 DIFF: https://github.com/llvm/llvm-project/commit/15e62062c0c919ac1fa28d6f0c9f438063da2286.diff

[clang] ae23be8 - [OpenMP] Make the new offloading driver the default

Author: Joseph Huber Date: 2022-04-18T15:05:09-04:00 New Revision: ae23be84cb60357829078e832613660bfe98687f URL: https://github.com/llvm/llvm-project/commit/ae23be84cb60357829078e832613660bfe98687f DIFF: https://github.com/llvm/llvm-project/commit/ae23be84cb60357829078e832613660bfe98687f.diff

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ec501da76fc: [OpenMP] Refactor OMPScheduleType enum. (authored by Meinersbur). Changed prior to commit: https://reviews.llvm.org/D123403?vs=42286

[clang] 9ec501d - [OpenMP] Refactor OMPScheduleType enum.

Author: Michael Kruse Date: 2022-04-18T14:03:17-05:00 New Revision: 9ec501da76fc1559cadd6d6dac32766bf4376a3d URL: https://github.com/llvm/llvm-project/commit/9ec501da76fc1559cadd6d6dac32766bf4376a3d DIFF: https://github.com/llvm/llvm-project/commit/9ec501da76fc1559cadd6d6dac32766bf4376a3d.diff

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:764 + int t30[F(__is_bounded_array(void*))]; + int t31[F(__is_bounded_array(cvoid*))]; +} cjdb wrote: > aaron.ballman wrote: > > cjdb wrote: > > > aaron.ballman wrote: > > > > A

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added a comment. In D122663#3457131 , @erichkeane wrote: > Our most recent direction is to document any non-NFC patches in the release > notes if at all sensible, so I think this meets those requirements. Thanks, I'm not finding documentation of

[PATCH] D123907: [HLSL] Add shader attribute

aaron.ballman added a comment. Mostly looks good, just some nits with the documentation. Comment at: clang/include/clang/Basic/AttrDocs.td:6388 +identify the shader type for the entry function. +The format is [shader("shadertype")]. +Normally the shader type is set by shader ta

[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

bulbazord updated this revision to Diff 423437. bulbazord edited the summary of this revision. bulbazord added a comment. Herald added a subscriber: mgorny. Added a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122691/new/ https://reviews.llvm.org/D122691 Files: clang/include/cl

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423433. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D122831 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added a comment. In D123345#3457109 , @rsmith wrote: > I'm working on a fix. I'll revert if it takes me more than a few minutes. If > you'd prefer to not wait, please feel free to revert it yourself. Thanks for your patience, should be fixed in

[clang] e43c93d - Don't treat 'T &forward(T&&)' as builtin.

Author: Richard Smith Date: 2022-04-18T11:11:21-07:00 New Revision: e43c93dd63cca295ef26ab69cd305816a71d45fd URL: https://github.com/llvm/llvm-project/commit/e43c93dd63cca295ef26ab69cd305816a71d45fd DIFF: https://github.com/llvm/llvm-project/commit/e43c93dd63cca295ef26ab69cd305816a71d45fd.diff

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423428. python3kgae added a comment. Add more detail to the doc. Update the attribute name according to the doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 F

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, kpn. Herald added subscribers: dexonsmith, martong. Herald added a reviewer: shafik. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. AST does not ha

[PATCH] D123950: Look through calls to std::addressof to compute pointer alignment.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123950/new/ https://reviews.llvm.org/D123950 ___

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. In D122663#3457130 , @hvdijk wrote: > In D122663#3456507 , @erichkeane > wrote: > >> I believe the answer here is 'yes'. We also likely need release notes. > > Thanks for the feedback

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added a comment. In D122663#3456507 , @erichkeane wrote: > I believe the answer here is 'yes'. We also likely need release notes. Thanks for the feedback. -fclang-abi-compat= support added. Other mangling bugfixes appear to not have made it int

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk updated this revision to Diff 423426. hvdijk added a comment. Herald added a subscriber: dexonsmith. Allow the old mangling with suitable -fclang-abi-compat= value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122663/new/ https://reviews.llv

[PATCH] D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1

tstellar added a comment. In D123850#3453750 , @cor3ntin wrote: > @tstellar I wasn't sure what the procedure was for backporting fixes, so I > made a PR. I think your suggestion of keeping the old signature works well. > This also modifies the serialized

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added a comment. In D123345#3456964 , @paulkirth wrote: > Hi, this is also breaking Fuchsia's clang CI builders > (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8816531831869640417/overview). > If this will be

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:764 + int t30[F(__is_bounded_array(void*))]; + int t31[F(__is_bounded_array(cvoid*))]; +} aaron.ballman wrote: > cjdb wrote: > > aaron.ballman wrote: > > > Any reason there's not a test

[PATCH] D123898: Fix crash in ObjC codegen introduced with 5ab6ee75994d645725264e757d67bbb1c96fb2b6

rjmccall added a comment. In D123898#3455933 , @theraven wrote: > I'd like to. The test case from the original bug report was very large but > I'm not sure how to trigger this with anything comprehensibly small. You > need something where the callee i

[PATCH] D123950: Look through calls to std::addressof to compute pointer alignment.

efriedma created this revision. efriedma added reviewers: jyknight, rsmith, rjmccall. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. This is sort of a followup to D37310 ; that basically fixed the same issue

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM, thanks! If it fails CI we might want to submit the tests and the code change separately, but I'm fine with trying it as one block in the first instance. Repository:

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

rtrieu added a comment. This seems to be acting weird in template instantations. Here's an example where the lambda only errors inside a template. template int foo(int x = 0) { auto lambda = [x = x+1]() -> decltype(x) { return x; }; return -1; } // no tem

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

efriedma abandoned this revision. efriedma added a comment. Opened https://github.com/llvm/llvm-project/issues/54963 to more specifically track the clang issue. With b27430f , it should be easy enough to special-case calls to

[PATCH] D122831: [OpenMP] Make the new offloading driver the default

jhuber6 updated this revision to Diff 423416. jhuber6 added a comment. Herald added a subscriber: mattd. Splitting major changes into two files as per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122831/new/ https://reviews.llvm.org/D1

[PATCH] D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C.

dblaikie added a comment. In D121959#3454606 , @tahonermann wrote: >> This might've caused a regression? >> (https://github.com/llvm/llvm-project/issues/54892) > > @dblaikie, it most definitely did. Note that I'm the author of the patch that > introduc

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

paulkirth added a comment. Hi, this is also breaking Fuchsia's clang CI builders (https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8816531831869640417/overview). If this will be hard to address, would you mind reverting until a patch is ready? Repository: rG

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3885-3888 + bool UseNewOffloadingDriver = + C.isOffloadingHostKind(C.getActiveOffloadKinds()) && + (Args.hasArg(options::OPT_foffload_new_driver) || + Args.hasArg(options::OPT_fopenmp_new_driv

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122335/new/ https://reviews.llvm.org/D122335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

vitalybuka added a comment. It's broken again here https://lab.llvm.org/buildbot/#/builders/74/builds/10427 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 ___

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

xbolva00 added inline comments. Comment at: clang/test/Sema/annotate-type.c:6 +void foo(float * [[clang::annotate_type("foo")]] a) { + int [[clang::annotate_type("bar")]] x1; + int * [[clang::annotate_type("bar")]] x2; Is it possible to typedef int [[clang::ann

[PATCH] D123325: [Clang] Make enabling the new driver more generic

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3885-3888 + bool UseNewOffloadingDriver = + C.isOffloadingHostKind(C.getActiveOffloadKinds()) && + (Args.hasArg(options::OPT_foffload_new_driver) || + Args.hasArg(options::OPT_fopenmp_new_drive

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6409-6411 +- The attribute will not cause any additional data to be output to LLVM IR, + object files or debug information. It is only intended to be consumed using + Clang APIs by source-lev

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3978 +"compute", "raygeneration", "intersection", +"anyhit", "closestHit", "miss", "callable", "mesh", +"amplificat

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik added inline comments. Comment at: clang/test/CodeGenCXX/no_auto_return_lambda.cpp:8 + +// CHECK: !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed) +// CHECK-NOT: !DIBasicType(tag: DW_TAG_unspecified_type, name: "auto") aprantl wrote: > This tes

[PATCH] D123946: [CUDA][HIP] Fix gpu.used.external

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123946/new/ https://reviews.llvm.org/D123946 ___ cfe-commits mailing list cfe-commits

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

aaron.ballman added a comment. Generally looks correct to me, but I did have some questions about the types used in the fix. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:235 SmallVector Files; + std::vector ExpressionNames; FileState *CurrentF

[PATCH] D123946: [CUDA][HIP] Fix gpu.used.external

yaxunl created this revision. yaxunl added reviewers: tra, jhuber6. Herald added a subscriber: mattd. Herald added a project: All. yaxunl requested review of this revision. Rename gpu.used.external as __clang_gpu_used_external as ptxas does not allow . in global variable name. Fixes: https://git

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. Generally looking good to me, mostly just drive-by commentary at this point. Comment at: clang/include/clang/Sema/DeclSpec.h:407 static bool isTypeRep(TST T) { -return (T == TST_typename || T == TST_typeofType || -T == TST_under

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

grandinj added a comment. thanks for the quick response Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. The remediation has landed, sorry again for the trouble this caused, I'll keep an eye out for further issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin added a comment. @aaron.ballman @erichkeane Thanks for the review - I've landed it. Hopefully the remediation should be enough so that libstdc++ is no longer affected but we should still keep an eye out for further issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaa6d7b250ed: [Clang] Use of decltype(capture) in parameter-declaration-clause (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGE

[clang] daa6d7b - [Clang] Use of decltype(capture) in parameter-declaration-clause

Author: Corentin Jabot Date: 2022-04-18T15:58:25+02:00 New Revision: daa6d7b250edb81ffef7770a71049d7af211698b URL: https://github.com/llvm/llvm-project/commit/daa6d7b250edb81ffef7770a71049d7af211698b DIFF: https://github.com/llvm/llvm-project/commit/daa6d7b250edb81ffef7770a71049d7af211698b.diff

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:537-543 + static StringRef getPrimaryModuleInterfaceName(StringRef Name) { +return Name.split(':').first; + } + /// Get the primary module interface name from a partition. StringRef getPrimary

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

cor3ntin updated this revision to Diff 423370. cor3ntin added a comment. ... and we don't need a local variable anymore either Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123909/new/ https://reviews.llvm.org/D123909 Files: clang/docs/ReleaseNo

[PATCH] D122663: Mark identifier prefixes as substitutable

erichkeane added a comment. @rjmccall is the expert on the Itanium ABI. Code wise, I have no real comments, though he might. As far as: >> Question: does this need to be covered by -fclang-abi-compat= when the prior >> mangling resulted in names that even llvm-cxxfilt agreed made no sense? (I

  1   2   >