[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire updated this revision to Diff 421695. junaire added a comment. Add a missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123447/new/ https://reviews.llvm.org/D123447 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/Par

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); void wrote: > MaskRay wrote: > > Why is -frandomi

[clang] ca68038 - Reland "[Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON""

Author: Fangrui Song Date: 2022-04-08T23:40:18-07:00 New Revision: ca68038d12a23fa7ebb2b1ccbda93c321635e6bf URL: https://github.com/llvm/llvm-project/commit/ca68038d12a23fa7ebb2b1ccbda93c321635e6bf DIFF: https://github.com/llvm/llvm-project/commit/ca68038d12a23fa7ebb2b1ccbda93c321635e6bf.diff

[PATCH] D123447: [Clang] Fix unknown type attributes diagnosed twice with [[]] spelling

junaire created this revision. junaire added reviewers: aaron.ballman, rsmith, erichkeane. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't warn on unknown type attributes in Parser::ProhibitCXX11At

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421692. void added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h clang/incl

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4244 + if (const Arg *A = Args.getLastArg(OPT_frandomize_layout_seed_file_EQ)) { +std::ifstream SeedFile(A->getValue(0)); MaskRay wrote: > Why is -frandomize-layout-seed-file

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440383 , @MaskRay wrote: > Windows test is still failing after the std::shuffle => llvm::shuffle change, > guess time for revert. > > ../../clang/unittests/AST/RandstructTest.cpp(165): error: Expected equality > of th

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG187ccc66fa5d: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 187ccc6 - [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

Author: Jennifer Yu Date: 2022-04-08T21:19:38-07:00 New Revision: 187ccc66fa5d0b04189cdbd8266fc386e60f48aa URL: https://github.com/llvm/llvm-project/commit/187ccc66fa5d0b04189cdbd8266fc386e60f48aa DIFF: https://github.com/llvm/llvm-project/commit/187ccc66fa5d0b04189cdbd8266fc386e60f48aa.diff L

[PATCH] D123441: [CUDA][HIP] Fix host used external kernel in archive

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. For -fgpu-rdc, a host function may call an external kernel which is defined in an archive of bitcode. Since this external kernel is only referenced in host function, t

[PATCH] D123438: [Clang] Move Hexagon / VE IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault

brad created this revision. brad added reviewers: bcain, kparzysz, simoll. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Move enabling of IAS back to Generic_GCC::IsIntegratedAssemblerDefault(). Repository:

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

junaire created this revision. junaire added reviewers: aaron.ballman, RKSimon, dblaikie. Herald added a subscriber: arphaman. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. BitstreamCursors are heavy-w

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:156 + // Produce the new ordering of the elements from the Buckets. + SmallVector FinalOrder; + for (const std::unique_ptr &B : Buckets) { Comment at: clang/lib/Driver/

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 ___

[PATCH] D123431: [CSKY] Remove redundant enabling of IAS for Clang, NFC

brad created this revision. brad added a reviewer: zixuan-wu. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. Generic_GCC::IsIntegratedAssemblerDefault() already takes care of CSKY. Repository: rG LLVM Github

[clang] a58d0af - Revert D121556 "[randstruct] Add randomize structure layout support"

Author: Fangrui Song Date: 2022-04-08T18:37:26-07:00 New Revision: a58d0af058038595c93de961b725f86997cf8d4a URL: https://github.com/llvm/llvm-project/commit/a58d0af058038595c93de961b725f86997cf8d4a DIFF: https://github.com/llvm/llvm-project/commit/a58d0af058038595c93de961b725f86997cf8d4a.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. Windows test is still failing after the std::shuffle => llvm::shuffle change, guess time for revert. ../../clang/unittests/AST/RandstructTest.cpp(165): error: Expected equality of these values: Expected Which is: { "lettuce", "bacon", "mayonnaise", "tomato"

[clang] 46b2a46 - [randstruct] Use llvm::shuffle to avoid STL impl difference after D121556

Author: Fangrui Song Date: 2022-04-08T18:14:21-07:00 New Revision: 46b2a463bdef1bd1d80abee869b09f95ca5a4fc2 URL: https://github.com/llvm/llvm-project/commit/46b2a463bdef1bd1d80abee869b09f95ca5a4fc2 DIFF: https://github.com/llvm/llvm-project/commit/46b2a463bdef1bd1d80abee869b09f95ca5a4fc2.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

MaskRay added a comment. You can use llvm::shuffle to avoid STL impl difference Comment at: clang/lib/AST/Randstruct.cpp:160 +if (!B->isBitfieldRun()) + std::shuffle(std::begin(RandFields), std::end(RandFields), RNG); + `llvm::shuffle` to avoid Repo

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

jyu2 updated this revision to Diff 421657. jyu2 added a comment. Add test in cfg-openmp.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 Files: clang/include/clang/AST/OpenMPClause.h clang/include/

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. Why? This is a fairly small CL. It should be easy to reland, and there shouldn't be any rebasing pain. You should at least check with your reviewers that they're fine relanding this without test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440308 , @thakis wrote: > It's more important to remove it from the cmakelists file than to delete the > source file ;) > > Please revert the whole thing instead of just removing the test coverage > though. You can rela

[clang] 2a2149c - [randstruct] Remove RandstructTest.cpp from list

Author: Bill Wendling Date: 2022-04-08T17:41:36-07:00 New Revision: 2a2149c754f96376ddf8fed248102dd8e6092a22 URL: https://github.com/llvm/llvm-project/commit/2a2149c754f96376ddf8fed248102dd8e6092a22 DIFF: https://github.com/llvm/llvm-project/commit/2a2149c754f96376ddf8fed248102dd8e6092a22.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. It's more important to remove it from the cmakelists file than to delete the source file ;) Please revert the whole thing instead of just removing the test coverage though. You can reland when the test is figured out, and that makes sure this doesn't stay in without cov

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440290 , @thakis wrote: > Looks like this breaks tests on mac: http://45.33.8.238/macm1/32938/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Ugh! This sucks. I just removed the test unt

[clang] 8d7595b - [randstruct] temporarily remove test that's failing

Author: Bill Wendling Date: 2022-04-08T17:04:22-07:00 New Revision: 8d7595be1dd41d7f7470ec90867936ca5e4e0d82 URL: https://github.com/llvm/llvm-project/commit/8d7595be1dd41d7f7470ec90867936ca5e4e0d82 DIFF: https://github.com/llvm/llvm-project/commit/8d7595be1dd41d7f7470ec90867936ca5e4e0d82.diff

[clang] c8e1c94 - Add some function prototypes; NFC

Author: Aaron Ballman Date: 2022-04-08T19:55:19-04:00 New Revision: c8e1c94983421c934556bb3f0418fe654fc2a839 URL: https://github.com/llvm/llvm-project/commit/c8e1c94983421c934556bb3f0418fe654fc2a839 DIFF: https://github.com/llvm/llvm-project/commit/c8e1c94983421c934556bb3f0418fe654fc2a839.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/32938/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llv

[clang] a60e9b3 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV after fa34951fbc9bde75

Author: Nico Weber Date: 2022-04-08T19:43:40-04:00 New Revision: a60e9b373f30ff1fc2af96cf6730d4ca461d1ba5 URL: https://github.com/llvm/llvm-project/commit/a60e9b373f30ff1fc2af96cf6730d4ca461d1ba5 DIFF: https://github.com/llvm/llvm-project/commit/a60e9b373f30ff1fc2af96cf6730d4ca461d1ba5.diff LO

[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

MaskRay accepted this revision. MaskRay added a subscriber: aaron.ballman. MaskRay added a comment. llvm-tblgen only depends on LLVMSupport. As analogy, clang-tblgen depending on the new clangSupport makes sense to me. Target-specific files in a `*Support` library is still a bit weird, but I can

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG549e118e93c6: [PowerPC] Support 16-byte lock free atomics on pwr8 and up (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 549e118 - [PowerPC] Support 16-byte lock free atomics on pwr8 and up

Author: Kai Luo Date: 2022-04-08T23:25:56Z New Revision: 549e118e93c666914a1045fde38a2cac33e1e445 URL: https://github.com/llvm/llvm-project/commit/549e118e93c666914a1045fde38a2cac33e1e445 DIFF: https://github.com/llvm/llvm-project/commit/549e118e93c666914a1045fde38a2cac33e1e445.diff LOG: [Powe

[clang] e2e6899 - [randstruct] disable test for Windows for now.

Author: Bill Wendling Date: 2022-04-08T16:00:41-07:00 New Revision: e2e6899452998932b37f0fa9e66d104a02abe3e5 URL: https://github.com/llvm/llvm-project/commit/e2e6899452998932b37f0fa9e66d104a02abe3e5 DIFF: https://github.com/llvm/llvm-project/commit/e2e6899452998932b37f0fa9e66d104a02abe3e5.diff

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG88a7508b1fd8: [clang-tidy] Deal with keyword tokens in preprocessor conditions (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] 88a7508 - [clang-tidy] Deal with keyword tokens in preprocessor conditions

Author: Richard Date: 2022-04-08T16:06:06-06:00 New Revision: 88a7508b1fd87c7dd7f155cb1541c61f4c1f1bc8 URL: https://github.com/llvm/llvm-project/commit/88a7508b1fd87c7dd7f155cb1541c61f4c1f1bc8 DIFF: https://github.com/llvm/llvm-project/commit/88a7508b1fd87c7dd7f155cb1541c61f4c1f1bc8.diff LOG:

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

ABataev added a comment. Add a test to Analysis/cfg-openmp.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers added a comment. I'll address, thanks for the comments. Comment at: clang/docs/analyzer/checkers.rst:69-74 +Check for dereferences of null pointers. This checker specifically does +not report null pointer dereferences for x86 and x86-64 targets when the +address spac

[clang] 893e1c1 - [randstruct] add expected output for WIN64

Author: Bill Wendling Date: 2022-04-08T14:42:12-07:00 New Revision: 893e1c18b98d8bbc7b8d7d22cc2c348f65c72ad9 URL: https://github.com/llvm/llvm-project/commit/893e1c18b98d8bbc7b8d7d22cc2c348f65c72ad9 DIFF: https://github.com/llvm/llvm-project/commit/893e1c18b98d8bbc7b8d7d22cc2c348f65c72ad9.diff

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

jyu2 updated this revision to Diff 421639. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/cla

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

jyu2 updated this revision to Diff 421637. jyu2 added a comment. Thanks Alexey, for the review! This patch addresses his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123402/new/ https://reviews.llvm.org/D123402 Files: clang/include/c

[clang] fa34951 - Reland "[MTE] Add -fsanitize=memtag* and friends."

Author: Mitch Phillips Date: 2022-04-08T14:28:33-07:00 New Revision: fa34951fbc9bde7592897b0e81e99abd84c0bfd7 URL: https://github.com/llvm/llvm-project/commit/fa34951fbc9bde7592897b0e81e99abd84c0bfd7 DIFF: https://github.com/llvm/llvm-project/commit/fa34951fbc9bde7592897b0e81e99abd84c0bfd7.diff

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

rZhBoYao added a comment. Revisiting @ChuanqiXu 's code suggestion... Comment at: clang/include/clang/Sema/Sema.h:2899-2909 +/// C++ [dcl.fct.def.general]p1 +/// function-body: +/// = delete ; +/// = default ; +Delete, +Default, + er

[PATCH] D123353: [CUDA][HIP] Externalize kernels in anonymous name space

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overall. Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13 + +// CHECK: define weak_odr {{.*}}void @[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]]( +// CHECK: @[[STR:

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3440089 , @dyung wrote: > Hi, the test you added is failing on the PS4 Windows bot > https://lab.llvm.org/buildbot/#/builders/216/builds/2647. > > Can you take a look? Crud! I thought I got all of the Windows issues. I'l

[PATCH] D121556: [randstruct] Add randomize structure layout support

dyung added a comment. Hi, the test you added is failing on the PS4 Windows bot https://lab.llvm.org/buildbot/#/builders/216/builds/2647. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

LegalizeAdulthood updated this revision to Diff 421628. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123349/new/ https://reviews.llvm.org/D123349 Files: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp clang

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281 +inline StringRef getTokenName(const Token &Tok) { + return Tok.is(tok::raw_identifier) ? Tok.getRawIdentifier() aaron.ballman wrote: > Legaliz

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281 +inline StringRef getTokenName(const Token &Tok) { + return Tok.is(tok::raw

[PATCH] D122992: Remove wrong warning. Fix for https://github.com/llvm/llvm-project/issues/54625

MaskRay added a comment. > Remove wrong warning. Fix for > https://github.com/llvm/llvm-project/issues/54625 It's sufficient to reference https://github.com/llvm/llvm-project/issues/54625 in the commit message body. For the subject line, just use some shorter IDs, e.g. `issue 54625` Repositor

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

This revision was automatically updated to reflect the committed changes. Closed by commit rG11da1b53d8cd: [C89/C2x] Improve diagnostics around strict prototypes in C (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D122895?vs=419853&id=421627#toc Repository: rG

[clang] 11da1b5 - [C89/C2x] Improve diagnostics around strict prototypes in C

Author: Aaron Ballman Date: 2022-04-08T16:19:58-04:00 New Revision: 11da1b53d8cd3507959022cd790d5a7ad4573d94 URL: https://github.com/llvm/llvm-project/commit/11da1b53d8cd3507959022cd790d5a7ad4573d94 DIFF: https://github.com/llvm/llvm-project/commit/11da1b53d8cd3507959022cd790d5a7ad4573d94.diff

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. Thanks, I'll take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

aaron.ballman added a comment. I'm sorry, but I had to revert this (in 4aaf25b4f7d7695ada313a3159d234b84d2896b2 ) as it broke the bots. https://lab.llvm.org/buildbot/#/builders/109/builds/36233 Repository: rG LLVM Github

[clang] 4aaf25b - Revert "[MTE] Add -fsanitize=memtag* and friends."

Author: Aaron Ballman Date: 2022-04-08T16:15:58-04:00 New Revision: 4aaf25b4f7d7695ada313a3159d234b84d2896b2 URL: https://github.com/llvm/llvm-project/commit/4aaf25b4f7d7695ada313a3159d234b84d2896b2 DIFF: https://github.com/llvm/llvm-project/commit/4aaf25b4f7d7695ada313a3159d234b84d2896b2.diff

[PATCH] D123422: [AST] Cleanup on getting the underlying decl of using-shdow decl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This should be a NFC cleanup. It removes a unnecessary loop to get the underlying decl, and add an assertion. The underlying dec

[PATCH] D121556: [randstruct] Add randomize structure layout support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f0587d0c668: [randstruct] Add randomize structure layout support (authored by connorkuehl, committed by void). Repository: rG LLVM Github Monorep

[clang] 3f0587d - [randstruct] Add randomize structure layout support

Author: Connor Kuehl Date: 2022-04-08T12:48:30-07:00 New Revision: 3f0587d0c668202bb89d29a25432aa290e551a31 URL: https://github.com/llvm/llvm-project/commit/3f0587d0c668202bb89d29a25432aa290e551a31 DIFF: https://github.com/llvm/llvm-project/commit/3f0587d0c668202bb89d29a25432aa290e551a31.diff

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added a comment. In D121556#3438722 , @aaron.ballman wrote: > Precommit CI is failing on one test: > > Failed Tests (1): > > Clang :: Misc/pragma-attribute-supported-attributes-list.test > > but with that test fixed, this LGTM! (Feel free to land

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 421616. void added a comment. Fix simple test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Decl.h cl

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:907 +__OMP_RTL_ATTRS(__kmpc_alloc_aggregate_arg, DefaultAttrs, ReturnPtrAttrs, +ParamAttrs(NoCaptureAttrs, NoCaptureAttrs)) + NoCapture attributes for the

[PATCH] D123398: [VFS] RedirectingFileSystem only replace path if not already mapped

bnbarham added a comment. Does `clang/test/VFS/external-names-multi-overlay.c` need to be formatted or is it fine? It uses split-file so I'd really like to avoid the format here (makes it pretty silly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 78a6f59 - [RGT] Use GTEST_SKIP instead of just returning

Author: Paul Robinson Date: 2022-04-08T12:20:20-07:00 New Revision: 78a6f59c2cef58c01a13ba4e587b30cd1dbd6475 URL: https://github.com/llvm/llvm-project/commit/78a6f59c2cef58c01a13ba4e587b30cd1dbd6475 DIFF: https://github.com/llvm/llvm-project/commit/78a6f59c2cef58c01a13ba4e587b30cd1dbd6475.diff

[PATCH] D123370: [CUDA/HIP] Remove argument from module ctor/dtor signatures

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123370/new/ https://reviews.llvm.org/D123370 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa1490513f1: [MTE] Add -fsanitize=memtag* and friends. (authored by hctim). Changed prior to commit: https://reviews.llvm.org/D118948?vs=421593&i

[clang] 8aa1490 - [MTE] Add -fsanitize=memtag* and friends.

Author: Mitch Phillips Date: 2022-04-08T12:13:15-07:00 New Revision: 8aa1490513f111afd407d87c3f07d26f65c8a686 URL: https://github.com/llvm/llvm-project/commit/8aa1490513f111afd407d87c3f07d26f65c8a686 DIFF: https://github.com/llvm/llvm-project/commit/8aa1490513f111afd407d87c3f07d26f65c8a686.diff

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 421607. jhuber6 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Compilation.h clang/include/clang/Drive

[PATCH] D123353: [CUDA][HIP] Externalize kernels in anonymous name space

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13 + +// CHECK: define weak_odr {{.*}}void @[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]]( +// CHECK: @[[STR:.*]] = {{.*}} c"[[KERN]]\00" --

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

LegalizeAdulthood updated this revision to Diff 421603. LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123349/new/ https://reviews.llvm.org/D123349 Files: clang-tools-ext

[PATCH] D123349: [clang-tidy] Deal with keyword tokens in preprocessor conditions

LegalizeAdulthood marked 4 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:281 +inline StringRef getTokenName(const Token &Tok) { + return Tok.is(tok::raw_identifier) ? Tok.getRawIdentifi

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 421598. cor3ntin added a comment. Missed a comment in Scope.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang/docs/ReleaseNotes.rst clang/include/cl

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 421596. cor3ntin marked 6 inline comments as done. cor3ntin added a comment. Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119136/new/ https://reviews.llvm.org/D119136 Files: clang

[PATCH] D123353: [CUDA][HIP] Externalize kernels in anonymous name space

tra added inline comments. Comment at: clang/test/CodeGenCUDA/kernel-in-anon-ns.cu:13 + +// CHECK: define weak_odr {{.*}}void @[[KERN:_ZN12_GLOBAL__N_16kernelEv\.anon\..*]]( +// CHECK: @[[STR:.*]] = {{.*}} c"[[KERN]]\00" Will the externalized names be uniquified

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 421595. jhuber6 added a comment. Fix misplaced logic symbol that broke tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Comp

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack' requires hardware support (+memta

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 421593. hctim marked an inline comment as done. hctim added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDr

[clang] 7dcd698 - Use writable temporary file for test compiler output instead of hardcoded name. NFCI.

Author: Jorge Gorbe Moya Date: 2022-04-08T10:57:27-07:00 New Revision: 7dcd698875cc6c73a9b10acad1b55aeb08bc9fca URL: https://github.com/llvm/llvm-project/commit/7dcd698875cc6c73a9b10acad1b55aeb08bc9fca DIFF: https://github.com/llvm/llvm-project/commit/7dcd698875cc6c73a9b10acad1b55aeb08bc9fca.di

[PATCH] D122981: [Clang] CWG 1394: Incomplete types as parameters of deleted functions

rZhBoYao updated this revision to Diff 421589. rZhBoYao marked 2 inline comments as done. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao added a comment. Reordered enumerators. Does this look good to you, @ChuanqiXu ? Repository: rG LLVM Github Monorepo CH

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

eugenis accepted this revision. eugenis added a comment. LGTM Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:475 def err_stack_tagging_requires_hardware_feature : Error< - "'-fsanitize=memtag' requires hardware support (+memtag)">; + "'-fsanitize=memtag-stack

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added a comment. Some drive by comments, I plan to do a more thorough review when I have the chance. Comment at: clang/docs/ReleaseNotes.rst:97 and `51641 `_. -- The builtin function __builtin_dump_struct woul

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 421587. MosheBerman added a comment. - Changed the ShowFixIts flag to be per-checker. - Added support for syntax sugar (`nullable` vs `_Nullable`) - Pass FixItHint through, so we can do that. - Changed tests to use `-fdiagnostics-parseable-fixits`. This

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman added a comment. In D123352#3439390 , @steakhal wrote: > tldr; static-analyzer fixits are not completely implemented. Where can I learn more about this? Would it be possible and idiomatically/architecturally sounds to write a clang-tidy tha

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123405/new/ https://reviews.llvm.org/D123405 ___

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim added a comment. Over to @eugenis for any final touches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 421581. hctim added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clan

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:814-815 +diagExportedUnnamedDecl(S, UnnamedDeclKind::Namespace, D, BlockStart); + else +; // We allow an empty named namespace decl. +} else if (DC->getRedeclContext()->isFileCont

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. If you need a -static-libstdc++ not subject to unused argument warning, D53238 -static=c++stdlib may be a better choice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 __

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3678e16155: [Clang] [Docs] Add HLSLSupport page (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 9e3678e - [Clang] [Docs] Add HLSLSupport page

Author: Chris Bieneman Date: 2022-04-08T12:17:45-05:00 New Revision: 9e3678e161553f29df1408f1b7c7ffc14fc0ef17 URL: https://github.com/llvm/llvm-project/commit/9e3678e161553f29df1408f1b7c7ffc14fc0ef17 DIFF: https://github.com/llvm/llvm-project/commit/9e3678e161553f29df1408f1b7c7ffc14fc0ef17.diff

[clang] 0f6cbde - [clang-offload-bundler] fix "no output file" issue with -outputs

Author: Siu Chi Chan Date: 2022-04-08T17:11:27Z New Revision: 0f6cbdee576160a3b40139bf66b864ce05a1e28f URL: https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f DIFF: https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f.diff LOG:

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6cbdee5761: [clang-offload-bundler] fix "no output file" issue with -outputs (authored by scchan, committed by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

ABataev added a comment. I think it worth it to add the analysis test for the clause Comment at: clang/lib/AST/OpenMPClause.cpp:1465 + + OMPHasDeviceAddrClause *Clause = + new (Mem) OMPHasDeviceAddrClause(Locs, Sizes); `auto *` Comment

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 421564. erichkeane marked an inline comment as done. erichkeane added a comment. rebase for CI + comment change requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 Files: clang/docs/ReleaseNote

[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 421562. cor3ntin added a comment. Add fix hint tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang

[PATCH] D123405: [dllexport] odr-use constexpr default args for constructor closures

hans created this revision. hans added reviewers: rnk, mstorsjo, thakis. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. InstantiateDefaultCtorDefaultArgs() is supposed to mark default constructor args as odr-used, since those args will be used

[PATCH] D123387: [clang-offload-bundler] fix "no output file" issue with -outputs

saiislam accepted this revision. saiislam added a comment. In D123387#3439069 , @yaxunl wrote: > Does this mean without this fix clang-offload-bundler emits an error if > -outputs option not given? How could the lit tests passed? I think lit tests were

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon updated this revision to Diff 421556. RKSimon added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGBuiltin.

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

steakhal added reviewers: Szelethus, steakhal. steakhal added a comment. tldr; static-analyzer fixits are not completely implemented. We don't even have tests for it, which is a shame. When I passed the `apply-fixits`, it modified the input source file - as I expected. Then I tried the `-analyze

[PATCH] D120273: [OpenMP] Allow CUDA to be linked with OpenMP using the new driver

jhuber6 updated this revision to Diff 421555. jhuber6 added a comment. Update handling for fatbinaries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120273/new/ https://reviews.llvm.org/D120273 Files: clang/tools/clang-linker-wrapper/ClangLinke

[PATCH] D123403: [OpenMP] Refactor OMPScheduleType enum.

Meinersbur created this revision. Meinersbur added reviewers: peixin, tianshilei1992, jdoerfert, sriharikrishna, Leporacanthicus, kiranchandramohan, clementval. Meinersbur added a project: OpenMP. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, ormris, dcaballe,

[PATCH] D123402: [clang][OpenMP5.1] Initial parsing/sema for has_device_addr

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice, jdoerfert. jyu2 added projects: clang, OpenMP. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. jyu2 requested review of this revision. Herald added subsc

  1   2   >