[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396274. zwliew added a comment. Add a test for inheritance from parent config with base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files: clang/docs/ClangFormat.r

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3393 if (!ChildFormatTextToApply.empty()) { assert(ChildFormatTextToApply.size() == 1); Is there a reason for this to be limited to 1? I came across this case during testing, but I c

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew updated this revision to Diff 396273. zwliew added a comment. Support inheritance from parent configs via `BasedOnStyle: InheritParentConfig` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files:

[PATCH] D116014: [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D116014#3210212 , @CodaFi wrote: > C API changes LGTM. Thanks for your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116014/new/ https://reviews.l

[PATCH] D116014: [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec501f15a8b8: [clang][CodeGen] Remove the signed version of createExpression (authored by achieveartificialintelligence). Changed prior to commit:

[clang] ec501f1 - [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Shao-Ce SUN via cfe-commits
Author: Shao-Ce SUN Date: 2021-12-27T14:16:08+08:00 New Revision: ec501f15a8b8ace2b283732740d6d65d40d82e09 URL: https://github.com/llvm/llvm-project/commit/ec501f15a8b8ace2b283732740d6d65d40d82e09 DIFF: https://github.com/llvm/llvm-project/commit/ec501f15a8b8ace2b283732740d6d65d40d82e09.diff L

[PATCH] D116299: [clang-format] Apply multiple children configs on fallback style

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew created this revision. zwliew requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow multiple children configs to be applied on top of the fallback style. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116299 File

[PATCH] D116298: Add option to specify explicit config file

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew created this revision. zwliew requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specify a specific config file using --style=file:path/to/config/file Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116298 Files: c

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

2021-12-26 Thread Zhao Wei Liew via Phabricator via cfe-commits
zwliew added inline comments. Comment at: clang/lib/Format/Format.cpp:3067 + if (!ChildFormatTextToApply.empty()) { +assert(ChildFormatTextToApply.size() == 1); + Is there a reason behind limiting the number of children configs to 1 in this case? When the f

[PATCH] D116014: [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Robert Widmann via Phabricator via cfe-commits
CodaFi accepted this revision. CodaFi added a comment. This revision is now accepted and ready to land. C API changes LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116014/new/ https://reviews.llvm.org/D116014

[PATCH] D116294: [CodeCompletion] (mostly) fix completion in incomplete C++ ctor initializers.

2021-12-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. C++ member function bodies (including ctor ini

[PATCH] D116014: [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116014/new/ https://reviews.llvm.org/D116014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

2021-12-26 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 396248. cjdb edited the summary of this revision. cjdb added a comment. adds more type traits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 Files: clang/include/clan

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

2021-12-26 Thread Adrian Vogelsgesang via Phabricator via cfe-commits
avogelsgesang added reviewers: MyDeveloperDay, HazardyKnusperkeks, aaron.ballman, curdeius, sammccall, owenpan. avogelsgesang added a comment. Adding reviewers from D69764 to this change because I think it falls into the same category: It replaces tokens and cou

[clang] 31cfb3f - [clang] Remove redundant calls to c_str() (NFC)

2021-12-26 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2021-12-26T13:31:40-08:00 New Revision: 31cfb3f4f6446512fa0170092af46783a0de9139 URL: https://github.com/llvm/llvm-project/commit/31cfb3f4f6446512fa0170092af46783a0de9139 DIFF: https://github.com/llvm/llvm-project/commit/31cfb3f4f6446512fa0170092af46783a0de9139.diff L

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

2021-12-26 Thread Adrian Vogelsgesang via Phabricator via cfe-commits
avogelsgesang updated this revision to Diff 396237. avogelsgesang added a comment. Fix code formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116290/new/ https://reviews.llvm.org/D116290 Files: clang/docs/ClangFormatStyleOptions.rst cla

[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

2021-12-26 Thread Adrian Vogelsgesang via Phabricator via cfe-commits
avogelsgesang created this revision. Herald added a subscriber: mgorny. avogelsgesang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Template argument types can be introduced using either the `class` or the `typename` argument. While there

[clang-tools-extra] 0542d15 - Remove redundant string initialization (NFC)

2021-12-26 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2021-12-26T09:39:26-08:00 New Revision: 0542d15211cb1fb45bcd79d485d122c69cd23f28 URL: https://github.com/llvm/llvm-project/commit/0542d15211cb1fb45bcd79d485d122c69cd23f28 DIFF: https://github.com/llvm/llvm-project/commit/0542d15211cb1fb45bcd79d485d122c69cd23f28.diff L

[PATCH] D115976: [clang] Fix a crash case when reporting an uninitialized field.

2021-12-26 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 396225. hliao added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115976/new/ https://reviews.llvm.org/D115976 Files: clang/include/clang/AST/Expr.h clang/lib/Sema/SemaInit.cpp clang/test

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-26 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. you need to add a unit test int clang/unittest/Format/FormatTest.cpp (we tend to not use lit tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 ___

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

2021-12-26 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 396219. njames93 added a comment. Herald added a subscriber: carlosgalvezp. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files: clang-tools-extra/clang-tid

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-26 Thread Rajat Bajpai via Phabricator via cfe-commits
rajatbajpai created this revision. rajatbajpai added a reviewer: MyDeveloperDay. rajatbajpai added a project: clang-format. rajatbajpai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds an option AfterOperatorOverloading in S