Maintenance works in LLVM Lab today at 11:00 PM PDT

2021-09-25 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM Lab and the build bot will be unavailable today, September 25th, for about 30 minutes starting from 11:00 PM PDT due to some maintenance work. Thank you for your understanding and patience. Galina ___ cfe-commits mailing list cfe-c

[PATCH] D94380: [InstCombine] Update transformations to use poison for insertelement/shufflevector's placeholder value (1/2)

2021-09-25 Thread Juneyoung Lee via Phabricator via cfe-commits
aqjune abandoned this revision. aqjune added a comment. I abandon this patch because (1) shufflevector parts are covered in D110226 , D110227 , D110230 , and (2) insertelement parts will be cov

[PATCH] D93817: [InstCombine] Update transformations to use poison for insertelement/shufflevector's placeholder value (2/2)

2021-09-25 Thread Juneyoung Lee via Phabricator via cfe-commits
aqjune abandoned this revision. aqjune added a comment. I abandon this patch because (1) shufflevector parts are covered in D110226 , D110227 , D110230 , and (2) insertelement parts will be cov

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

2021-09-25 Thread Fred Grim via Phabricator via cfe-commits
feg208 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" HazardyKnusperkeks wrote: > Here is no alignment, maybe add another

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

2021-09-25 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. Repeating my question from an earlier comment: would a header glob list (similar to how the format of the `-checks=` flag) be enough for the use cases folks have? On the one hand glob list doesn't support all the features of regular expressions, but are they all useful f

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 375065. cor3ntin added a comment. Update cxx_status.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clan

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 375064. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Basic/Diagnost

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

2021-09-25 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17805 + "Section{\n" + "0, bar(),\n" + "}\n" Here is no alignment, maybe add another case with anothe

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

2021-09-25 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev updated this revision to Diff 375050. v.g.vassilev added a comment. add forgotten test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110484/new/ https://reviews.llvm.org/D110484 Files: clang/include/clang/Frontend/CompilerInstance.h clang/lib/Frontend/CompilerInst

[PATCH] D110484: [clang-repl] Allow loading of plugins in clang-repl.

2021-09-25 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, teemperor, sgraenitz, john.brawn, klimek, bkramer. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. https://reviews.llvm.org/D110484 Files: clang/include/clang/Frontend/CompilerInstance.

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 375046. cor3ntin added a comment. Fix tests formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clang/include/clang/

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 375045. cor3ntin added a comment. Remove untested clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110482/new/ https://reviews.llvm.org/D110482 Files: clang/include/clang/AST/Stmt.h clan

[PATCH] D110392: [clang-format] Left/Right alignment fixer can cause false positive replacements when they don't actually change anything

2021-09-25 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2ec5dd20953: [clang-format] Left/Right alignment fixer can cause false positive replacements… (authored by MyDeveloperDay). Repository: rG LLVM G

[clang] c2ec5dd - [clang-format] Left/Right alignment fixer can cause false positive replacements when they don't actually change anything

2021-09-25 Thread via cfe-commits
Author: mydeveloperday Date: 2021-09-25T17:35:41+01:00 New Revision: c2ec5dd209532b1d618958ade6a7d550a0c31ea5 URL: https://github.com/llvm/llvm-project/commit/c2ec5dd209532b1d618958ade6a7d550a0c31ea5 DIFF: https://github.com/llvm/llvm-project/commit/c2ec5dd209532b1d618958ade6a7d550a0c31ea5.diff

[PATCH] D110482: [clang] Implement if consteval (P1938)

2021-09-25 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added subscribers: wenlei, martong. Herald added a reviewer: shafik. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Modify the IfStmt node to tuppoort constant evaluated expressions. Add a n

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

2021-09-25 Thread Fred Grim via Phabricator via cfe-commits
feg208 created this revision. feg208 added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, klimek, djasper, tinloaf. feg208 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. bug 51926 identified an issue where a dangling comma cause

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

2021-09-25 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit added a comment. In D110068#3013636 , @dexonsmith wrote: > I'm a bit hesitant to trust lack of tests as proof that old FIXMEs can be > resolved safely. Can you add some background information about why this was > originally a specifier, an

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

2021-09-25 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit added a comment. In D110068#3013636 , @dexonsmith wrote: > I'm a bit hesitant to trust lack of tests as proof that old FIXMEs can be > resolved safely. Can you add some background information about why this was > originally a specifier, an

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

2021-09-25 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit updated this revision to Diff 375035. gAlfonso-bit marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110068/new/ https://reviews.llvm.org/D110068 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp ===

[PATCH] D110068: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

2021-09-25 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:161-163 +else if (const ArrayType *ATy = dyn_cast(BaseType)) BaseType = ATy->getElementType(); +else if (const FunctionType *FTy = BaseType->getAs()) dexonsmith wrote: >

[PATCH] D110252: Added note about Whatstyle and Unformat

2021-09-25 Thread Volker Weißmann via Phabricator via cfe-commits
Volker-Weissmann added a comment. In D110252#3018375 , @MyDeveloperDay wrote: > Whatstyle has not been updated since Dec 2020, is it going to cover the > latest style configuration options? No it doesn't. As I wrote, both work on a best-effort basis.

[clang] 0b61f43 - [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-25 Thread Markus Böck via cfe-commits
Author: Markus Böck Date: 2021-09-25T13:13:11+02:00 New Revision: 0b61f43b6096a9e98652991cba34e8ad44d35101 URL: https://github.com/llvm/llvm-project/commit/0b61f43b6096a9e98652991cba34e8ad44d35101 DIFF: https://github.com/llvm/llvm-project/commit/0b61f43b6096a9e98652991cba34e8ad44d35101.diff L

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

2021-09-25 Thread Markus Böck via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0b61f43b6096: [CMake] Consistently use the LibXml2::LibXml2 target instead of… (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109975/n

[PATCH] D110392: [clang-format] Left/Right alignment fixer can cause false positive replacements when they don't actually change anything

2021-09-25 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 375023. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Address review comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110392/new/ https://reviews.llvm.org/D110392 Files: clang/lib/Format/QualifierAli

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

2021-09-25 Thread Manas Gupta via Phabricator via cfe-commits
manas added a comment. @vsavchenko should we land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106416/new/ https://reviews.llvm.org/D106416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106416: [analyzer] Fix build dependency issues for SATest

2021-09-25 Thread Manas Gupta via Phabricator via cfe-commits
manas updated this revision to Diff 375017. manas added a comment. Upgrade cmake to 3.21.3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106416/new/ https://reviews.llvm.org/D106416 Files: clang/utils/analyzer/Dockerfile Index: clang/utils/ana