[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 361915. kito-cheng marked an inline comment as done. kito-cheng added a comment. Changes: - Address @frasercrmck's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 361913. sriharikrishna marked an inline comment as done. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna marked an inline comment as done. sriharikrishna added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6330-6331 + if (const auto *C = S.getSingleClause()) { +llvm::Value *InteropvarPtr = +EmitLValue(C->getInteropVar()).getPointer(*this

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe updated this revision to Diff 361908. FreddyYe added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106849/new/ https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: clang/test/CodeGen/attr-t

[PATCH] D106849: [NFC][X86] add missing tests in clang/test/CodeGen/attr-target-mv.c

FreddyYe created this revision. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106849 Files: clang/test/CodeGen/attr-target-mv.c Index: clang/test/CodeGen/attr-

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:604 + const bool HasSysRoot = !D.SysRoot.empty(); + if (HasSysRoot) { SmallString<128> P(D.SysRoot); MaskRay wrote: > To match Linux.cpp, this code block should be uncondition

[PATCH] D106738: [RISCV] Use getNaturalPointeeTypeAlignment to get alignment for stores created for vector builtins.

craig.topper updated this revision to Diff 361899. craig.topper added a comment. Also remove calls to getPointerElementType which will be removed eventually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106738/new/ https://reviews.llvm.org/D106738

[clang] 531b19a - [dfsan][NFC] Fix doc format

Author: Jianzhou Zhao Date: 2021-07-27T04:22:20Z New Revision: 531b19a49e66de5c4b35fc89eebc078c13eb9a85 URL: https://github.com/llvm/llvm-project/commit/531b19a49e66de5c4b35fc89eebc078c13eb9a85 DIFF: https://github.com/llvm/llvm-project/commit/531b19a49e66de5c4b35fc89eebc078c13eb9a85.diff LOG:

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

tahonermann added inline comments. Comment at: clang/include/clang/AST/Expr.h:1846-1871 + std::string getStringAsChar() const { +assert(getCharByteWidth() == 1 && + "This function is used in places that assume strings use char"); +return std::string(getTrailing

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

pengfei added inline comments. Comment at: clang/lib/Headers/prfchwintrin.h:54 +#pragma clang diagnostic ignored "-Wcast-qual" + __builtin_prefetch ((const void*)__P, 1, 3 /* _MM_HINT_T0 */); +#pragma clang diagnostic pop Can we declare `__builtin_prefetch` to v

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2906247 , @Bigcheese wrote: > For future reference this was very difficult to merge into external changes. > It looks like you resorted this at the same time as renaming it, and that > messes up git's rename logic.

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

thakis added inline comments. Comment at: clang/test/LibClang/symbols.test:2 +# Check that there are no unversioned clang symbols in libclang.so +RUN: llvm-nm -Dj --defined-only %libclang | grep -v -e '@@LLVM_[0-9]\+$' | not grep '^clang' + thakis wrote: > I thi

[clang] 494f1e6 - [dfsan][NFC] Fix doc format

Author: Jianzhou Zhao Date: 2021-07-27T02:07:53Z New Revision: 494f1e6706481ec49942c07ebf48697872919612 URL: https://github.com/llvm/llvm-project/commit/494f1e6706481ec49942c07ebf48697872919612 DIFF: https://github.com/llvm/llvm-project/commit/494f1e6706481ec49942c07ebf48697872919612.diff LOG:

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

Bigcheese added a comment. For future reference this was very difficult to merge into external changes. It looks like you resorted this at the same time as renaming it, and that messes up git's rename logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

thakis added inline comments. Comment at: clang/test/LibClang/symbols.test:2 +# Check that there are no unversioned clang symbols in libclang.so +RUN: llvm-nm -Dj --defined-only %libclang | grep -v -e '@@LLVM_[0-9]\+$' | not grep '^clang' + I think it's possible

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:67 set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.exports) +set(LIBCLANG_VERSION_SCRIPT_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map) thakis wrote: > This is s

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

thakis added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:67 set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.exports) +set(LIBCLANG_VERSION_SCRIPT_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map) This is still set to CURREN

[clang] 0300e16 - libclang: Fixes for the python script that generates the export list

Author: Tom Stellard Date: 2021-07-26T18:39:53-07:00 New Revision: 0300e16eb0a8e7bd980b6b14b6a3bae38786651d URL: https://github.com/llvm/llvm-project/commit/0300e16eb0a8e7bd980b6b14b6a3bae38786651d DIFF: https://github.com/llvm/llvm-project/commit/0300e16eb0a8e7bd980b6b14b6a3bae38786651d.diff

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh updated this revision to Diff 361871. chh added a comment. add skip-headers-3.cpp test to show that checking only Decl locations is not enough to skip some warnings in header files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files: cl

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, LocFilter

chh updated this revision to Diff 361870. chh added a comment. add skip-headers-3.cpp test to show that checking only Decl locations is not enough to skip some warnings in header files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98709/new/ https://reviews.llvm.org/D98709 Files: cl

[clang] e69a8c4 - [dfsan] Fix doc build errors

Author: Jianzhou Zhao Date: 2021-07-27T00:29:55Z New Revision: e69a8c42135606e60446d5e78144357a9e429c77 URL: https://github.com/llvm/llvm-project/commit/e69a8c42135606e60446d5e78144357a9e429c77 DIFF: https://github.com/llvm/llvm-project/commit/e69a8c42135606e60446d5e78144357a9e429c77.diff LOG:

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a3bf2953a92: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor)… (authored by akhuang). Repository: rG LLVM Github Mon

[clang] 1a3bf29 - [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

Author: Amy Huang Date: 2021-07-26T17:24:42-07:00 New Revision: 1a3bf2953a9209fdc4dbb6e99678e02a7fec019d URL: https://github.com/llvm/llvm-project/commit/1a3bf2953a9209fdc4dbb6e99678e02a7fec019d DIFF: https://github.com/llvm/llvm-project/commit/1a3bf2953a9209fdc4dbb6e99678e02a7fec019d.diff LOG

[PATCH] D106833: [dfsan][NFC] Add compile flags and environment variables to doc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b7638dfee5: [dfsan][NFC] Add compile flags and environment variables to doc (authored by Jianzhou Zhao ). Repository: rG

[clang] c7b7638 - [dfsan][NFC] Add compile flags and environment variables to doc

Author: Jianzhou Zhao Date: 2021-07-27T00:20:22Z New Revision: c7b7638dfee54053553d9b22eeb8912ca42a06ec URL: https://github.com/llvm/llvm-project/commit/c7b7638dfee54053553d9b22eeb8912ca42a06ec DIFF: https://github.com/llvm/llvm-project/commit/c7b7638dfee54053553d9b22eeb8912ca42a06ec.diff LOG:

[PATCH] D106833: [dfsan][NFC] Add compile flags and environment variables to doc

stephan.yichao.zhao updated this revision to Diff 361859. stephan.yichao.zhao marked 2 inline comments as done. stephan.yichao.zhao retitled this revision from " [dfsan][NFC] Add compile flags and environment variables to doc" to "[dfsan][NFC] Add compile flags and environment variables to doc".

[clang] 0d7596c - libclang: Add missing export to python script that generates export list

Author: Tom Stellard Date: 2021-07-26T17:06:08-07:00 New Revision: 0d7596c348842af2c34b13cfd9e5b3480e6c8b0e URL: https://github.com/llvm/llvm-project/commit/0d7596c348842af2c34b13cfd9e5b3480e6c8b0e DIFF: https://github.com/llvm/llvm-project/commit/0d7596c348842af2c34b13cfd9e5b3480e6c8b0e.diff

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

joerg added a comment. > I still don't fully understand the original comment from Joerg. The encoding > of `L'a'` cannot change at runtime; it's a literal whose encoding is decided > entirely at compile time. @joerg -- did you mean that Clang produces a > different literal encoding depending on

[clang] 69daca0 - libclang.so: Fix version script to work with gold

Author: Tom Stellard Date: 2021-07-26T16:52:27-07:00 New Revision: 69daca022ad71f5f697008e0b028c52023abe61b URL: https://github.com/llvm/llvm-project/commit/69daca022ad71f5f697008e0b028c52023abe61b DIFF: https://github.com/llvm/llvm-project/commit/69daca022ad71f5f697008e0b028c52023abe61b.diff

[PATCH] D106817: [PowerPC] Changed sema checking range for tdw td builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18526b0d661f: [PowerPC] Changed sema checking range for tdw td builtin (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 18526b0 - [PowerPC] Changed sema checking range for tdw td builtin

Author: Albion Fung Date: 2021-07-26T18:44:33-05:00 New Revision: 18526b0d661f28e79cb70bfd712cedf9e7085154 URL: https://github.com/llvm/llvm-project/commit/18526b0d661f28e79cb70bfd712cedf9e7085154 DIFF: https://github.com/llvm/llvm-project/commit/18526b0d661f28e79cb70bfd712cedf9e7085154.diff L

[PATCH] D106833: [dfsan][NFC] Add compile flags and environment variables to doc

gbalats accepted this revision. gbalats added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/DataFlowSanitizer.rst:153 +If the flag is true, the label of ``v`` is the union of the label of ``p`` and +the label of ``*p``. If the flag is fa

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b3a91017d2: libclang.so: Make SONAME independent from LLVM version (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] c7b3a91 - libclang.so: Make SONAME independent from LLVM version

Author: Tom Stellard Date: 2021-07-26T16:37:26-07:00 New Revision: c7b3a91017d26266d7556b1ac7c49b06f0109b91 URL: https://github.com/llvm/llvm-project/commit/c7b3a91017d26266d7556b1ac7c49b06f0109b91 DIFF: https://github.com/llvm/llvm-project/commit/c7b3a91017d26266d7556b1ac7c49b06f0109b91.diff

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. yep, should be good now - I'll commit it soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 ___ cfe-commits mailing list cfe-commits@

[clang] f9f5648 - [DebugInfo] Use per-enumerator signedness for DIEnumerator

Author: Reid Kleckner Date: 2021-07-26T16:14:28-07:00 New Revision: f9f56488e02d1c09a9cd4acde61ce1c712e71405 URL: https://github.com/llvm/llvm-project/commit/f9f56488e02d1c09a9cd4acde61ce1c712e71405 DIFF: https://github.com/llvm/llvm-project/commit/f9f56488e02d1c09a9cd4acde61ce1c712e71405.diff

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:839 + SVal V = Call.getArgSVal(I); + if (V.getAsSymbol() == Sym) +return emitNote(N); Actually you know what, I'm curious about some IRL data on this. Wi

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a comment. In D106585#2905663 , @dblaikie wrote: > In D106585#2902588 , @dblaikie > wrote: > >> Preserving existing behavior sounds OK - maybe some comment about that it >> might be good to remove so t

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added a comment. In D105320#2905887 , @rnk wrote: > Yes, I filed https://bugs.llvm.org/show_bug.cgi?id=51221 for it. I plan to > disable the test under asan for now. :-( Thanks for taking care of it though! Repository: rG LLVM Github Monor

[clang] a9b114c - Disable the new enum i128 test under ASan, it uncovers an existing leak

Author: Reid Kleckner Date: 2021-07-26T15:48:32-07:00 New Revision: a9b114c5dd68685e0e68dd9144454b44509c2f5f URL: https://github.com/llvm/llvm-project/commit/a9b114c5dd68685e0e68dd9144454b44509c2f5f DIFF: https://github.com/llvm/llvm-project/commit/a9b114c5dd68685e0e68dd9144454b44509c2f5f.diff

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

rnk added a comment. Yes, I filed https://bugs.llvm.org/show_bug.cgi?id=51221 for it. I plan to disable the test under asan for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 __

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 361831. beanz added a comment. Fixing handling of #ifdef, #ifndef, and defined() All tests pass this time :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 Files: c

[PATCH] D106833: [dfsan][NFC] Add compile flags and environment variables to doc

stephan.yichao.zhao created this revision. stephan.yichao.zhao added a reviewer: gbalats. stephan.yichao.zhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106833 Files:

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94098/new/ https://reviews.llvm.org/D94098 ___ cfe-commits mailing list cfe-commits

[PATCH] D106715: Thread safety analysis: Drop special block handling

aaronpuchert updated this revision to Diff 361820. aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. Drop `SpecialBlocks` and fix clang-tidy issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106715/new/ https://reviews

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c to have -flto on AIX

Whitney added inline comments. Comment at: clang/test/Profile/gcc-flag-compatibility.c:10 +// On AIX, -flto is required with -fprofile-generate +// XFAIL: aix Add in the comment that gcc-flag-compatibility-aix.c is used to do the testing on AIX. Repository:

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

jyknight added a comment. In D106577#2904960 , @rsmith wrote: > One benefit we don't get with this approach is providing the right value for > the macro (without paying the cost of always including `stdc-predefs.h`). What do you mean by "right value", t

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added a comment. I received this report from one of the bots: https://lab.llvm.org/buildbot/#/builders/5/builds/9633/steps/13/logs/stdio ` FAIL: Clang :: CodeGenCXX/debug-info-enum-i128.cpp (5356 of 77963) TEST 'Clang :: CodeGenCXX/debug-info-enum-i128.cpp' F

[PATCH] D106817: [PowerPC] Changed sema checking range for tdw td builtin

amyk accepted this revision as: amyk. amyk added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106817/new/ https://reviews.llvm.org/D106817 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie accepted this revision. dblaikie added a comment. Sounds like this is good for Google and Sony, and Apple doesn't use `-fno-standalone-debug`/`-flimit-debug-info` anyway, so probably about ready to move forward, then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf000197c421: [OpenMP] Always inline the OpenMP outlined function (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] af00019 - [OpenMP] Always inline the OpenMP outlined function

Author: Joseph Huber Date: 2021-07-26T17:27:59-04:00 New Revision: af000197c4214926bd7d0862d86f89aed5f20da6 URL: https://github.com/llvm/llvm-project/commit/af000197c4214926bd7d0862d86f89aed5f20da6 DIFF: https://github.com/llvm/llvm-project/commit/af000197c4214926bd7d0862d86f89aed5f20da6.diff

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie added a comment. In D106585#2902588 , @dblaikie wrote: > Preserving existing behavior sounds OK - maybe some comment about that it > might be good to remove so the next person who looks at it knows there's > something not-quite-fully-reasoned h

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

dblaikie added a comment. Just a thought (nothing to hold up this patch/suggest a revert/suggest any immediate action), but: > The problem with extending this to non-system headers is that you need a way > to tell which headers are allowed to include the detail headers and which > ones are not

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong updated this revision to Diff 361793. martong added a comment. - Rename test functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106823/new/ https://reviews.llvm.org/D106823 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong added a comment. F18155698: image.png For more details please check out this html file: F18155704: stats.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106823/new

[PATCH] D106823: [analyzer][solver] Iterate to a fixpoint during symbol simplification with constants

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[libunwind] e95cd94 - [libc++abi/unwind] NFC: Normalize how we set target properties

Author: Louis Dionne Date: 2021-07-26T16:38:05-04:00 New Revision: e95cd94f7edf50367d650410b8e534342eb0e5cb URL: https://github.com/llvm/llvm-project/commit/e95cd94f7edf50367d650410b8e534342eb0e5cb DIFF: https://github.com/llvm/llvm-project/commit/e95cd94f7edf50367d650410b8e534342eb0e5cb.diff

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2972116923a: [OpenMP] Add a driver flag to enable the new device runtime library (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[clang] d297211 - [OpenMP] Add a driver flag to enable the new device runtime library

Author: Joseph Huber Date: 2021-07-26T16:35:56-04:00 New Revision: d2972116923a124de71cea006eca3068bdc381ea URL: https://github.com/llvm/llvm-project/commit/d2972116923a124de71cea006eca3068bdc381ea DIFF: https://github.com/llvm/llvm-project/commit/d2972116923a124de71cea006eca3068bdc381ea.diff

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 abandoned this revision. josemonsalve2 added a subscriber: jhuber6. josemonsalve2 added a comment. This has been completed by @jhuber6 in D97680 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

josemonsalve2 updated this revision to Diff 361777. josemonsalve2 added a comment. Rebasing to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/new/ https://reviews.llvm.org/D106298 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/l

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20555a15a596: [clang] P2266 implicit moves STL workaround (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 20555a1 - [clang] P2266 implicit moves STL workaround

Author: Matheus Izvekov Date: 2021-07-26T22:21:31+02:00 New Revision: 20555a15a596012ef827e29b665db53a4fc0b86c URL: https://github.com/llvm/llvm-project/commit/20555a15a596012ef827e29b665db53a4fc0b86c DIFF: https://github.com/llvm/llvm-project/commit/20555a15a596012ef827e29b665db53a4fc0b86c.dif

[PATCH] D104854: Introduce intrinsic llvm.isnan

efriedma added a comment. In D104854#2904826 , @sepavloff wrote: > In D104854#2886328 , @efriedma > wrote: > >>> The options '-ffast-math' and '-fno-honor-nans' imply that FP operation >>> operands are never NaNs

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf84c70a37939: [CodeView] Saturate values bigger than supported by APInt. (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3167 + + // TODO: Need to support bigger ints like __int128. + OS.AddComment("Value"); rnk wrote: > I don't think we need a TODO here. If Microsoft ever adds an encoding f

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin added a comment. In D106577#2905027 , @aaron.ballman wrote: >> That doesn't help the fact that wide char literals are effectively broken on >> those OSes, but oh well. Maybe someday they'll decide to switch to a >> consistent/documented wchar

[PATCH] D106817: [PowerPC] Changed sema checking range for tdw td builtin

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106817/new/ https://reviews.llvm.org/D106817

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/TextMarks.h:22 +/// Represents a programmer specified mark/note, typically used to easily locate +/// or differentiate code. e.g. a `pragma mark`, a `TODO`. +/// sammccall wrote: > dgoldman wro

[PATCH] D106734: Eliminate clang man page generation warning for missing .rst files

scott.linder accepted this revision. scott.linder added a comment. This revision is now accepted and ready to land. LGTM, I see no reason why this shouldn't apply for all generators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106734/new/ https:/

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. In D106793#2904771 , @JonChesterfield wrote: > Can we call this something other than new? We don't tend to remove command > line arguments and

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

jhuber6 updated this revision to Diff 361764. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106799/new/ https://reviews.llvm.org/D106799 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/nvptx_target

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 361761. beanz added a comment. Updates based on feedback from @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106732/new/ https://reviews.llvm.org/D106732 Files: clang/docs/LanguageExtensions.rst

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with minor comment adjustments Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3167 + + // TODO: Need to support bigger ints like __int128. + OS.AddComment("Value"

[PATCH] D106585: Fix clang debug info irgen of i128 enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG323049329939: Fix clang debug info irgen of i128 enums (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106585/new/ https://reviews.llvm.org

[clang] 3230493 - Fix clang debug info irgen of i128 enums

Author: Reid Kleckner Date: 2021-07-26T12:25:29-07:00 New Revision: 323049329939becf690adbeeff9f5f7e219075ec URL: https://github.com/llvm/llvm-project/commit/323049329939becf690adbeeff9f5f7e219075ec DIFF: https://github.com/llvm/llvm-project/commit/323049329939becf690adbeeff9f5f7e219075ec.diff

[PATCH] D106817: [PowerPC] Changed sema checking range for tdw td builtin

Conanap updated this revision to Diff 361754. Conanap added a comment. Herald added a subscriber: kbarton. Updated test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106817/new/ https://reviews.llvm.org/D106817 Files: clang/lib/Sema/SemaCh

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

rnk added a comment. In D106721#2902586 , @efriedma wrote: > We won't call compiler-rt for i128 multiply on aarch64. It's not worthwhile > under any circumstances. > > Pattern-matching 64/64->128 multiply in SelectionDAG legalization has been > reliabl

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new/ https://reviews.llvm.org/D105951 ___ cfe-commits mailing li

[PATCH] D106817: [PowerPC] Changed sema checking range for tdw td builtin

Conanap created this revision. Herald added subscribers: steven.zhang, shchenz, nemanjai. Conanap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To match xlc behaviour and definition in the PowerPC ISA3.1, it is a better idea to have the c

[PATCH] D106298: [OpenMP] Creating the `omp_target_num_teams` and `omp_target_thread_limit` attributes to outlined functions

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. The codegen changes look sensible and the tests show only attributes changed. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106298/ne

[clang] 0fb16d5 - Fix clang regression test after 5c486ce0

Author: Eli Friedman Date: 2021-07-26T11:59:40-07:00 New Revision: 0fb16d5ad126a14213ceee6b20b86c721ea49d4e URL: https://github.com/llvm/llvm-project/commit/0fb16d5ad126a14213ceee6b20b86c721ea49d4e DIFF: https://github.com/llvm/llvm-project/commit/0fb16d5ad126a14213ceee6b20b86c721ea49d4e.diff

[PATCH] D106799: [OpenMP] Always inline the OpenMP outlined function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. One test needs to be fixed. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106799/new/ https://reviews.llvm.org/D106799 ___

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think my concerns from D96033 are all addressed by now, so this LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

jdoerfert added a comment. > I think changing the BC name is something we can do any time, so just calling > it libomptarget-new is fine for now. Yes, let's not disrupt old workflows. The "default" runtime keeps it's name always and we swap it out at some point and remove the option (or make it

[PATCH] D106793: [OpenMP] Add a driver flag to enable the new device runtime library

ye-luo added a comment. In D106793#2904943 , @jhuber6 wrote: > In D106793#2904661 , @ye-luo wrote: > >> Not clear from the summary what is the new driver option. > > It's a rewrite of the current device runtime. T

[PATCH] D106815: Update: clang/test/Profile/gcc-flag-compatibility.c upstream to have -flto on AIX

madanial created this revision. madanial added reviewers: Whitney, dnovillo, xur. madanial added a project: LLVM. Herald added a subscriber: inglorion. madanial requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit: https://reviews.llvm.or

[PATCH] D106790: prfchwintrin.h: Make _m_prefetchw take a pointer to volatile (PR49124)

rnk added a comment. Does this match GCC? They also provide this Intel intrinsic. Seems reasonable in principle, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106790/new/ https://reviews.llvm.org/D106790 __

[PATCH] D106791: [clang-cl] Expose -fmodules and related flags in the driver (PR43391)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106791/new/ https://reviews.llvm.org/D106791 ___ cfe-c

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

efriedma added a comment. gcc apparently lowers this sort of construct to a volatile load/store followed by a trap. Not sure where the trap is coming from. I'm not sure this solves any problem that really needs to be solved. LLVM isn't going to optimize out a volatile load/store to null. Wel

[PATCH] D106788: [clang][driver] NFC: Expose InputInfo in Job instead of plain filenames

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106788/new/ https://reviews.llvm.org/D106788 __

[PATCH] D106787: [clang][driver] NFC: Move InputInfo.h from lib to include

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106787/new/ https://reviews.llvm.org/D106787 __

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 _

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. In D105821#2904870 , @NoQ wrote: > `std::make_unique` isn't actually getting modeled but inlined instead (I have > all your patches pulled and this patch applied; and the > object-under-construction seems to be available later, in b

[PATCH] D105695: [clang][tooling] Accept Clang invocations with multiple jobs

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Seeing the `-fembed-bitcode` case made me think of `-save-temps`. I think this will work since `-x cpp-output` should return false for `isSrcFile()`... but probably worth adding a test

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

aaron.ballman added a comment. In D106577#2904724 , @jyknight wrote: > Perhaps a reasonable path forward here to address the BSD issue can be to add > a targetinfo method: > > /* Returns true if the expected encoding of wchar_t changes at runtime >

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

v.g.vassilev created this revision. v.g.vassilev added reviewers: teemperor, rsmith, lhames, hfinkel, sgraenitz. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. We have the basic infrastructure in place. We can recover from simple errors (recovering from errors

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 361734. tstellar added a comment. Add test case for local symbols and reformat version script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: clang/test/CM

  1   2   >