[clang] dac582a - DebugInfo: Name class templates with default arguments consistently (both direct naming, and as a template argument for a function template)

2021-07-17 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2021-07-17T23:58:15-07:00 New Revision: dac582ad3a78b18bdd2e6615f1ec105ee05adfe1 URL: https://github.com/llvm/llvm-project/commit/dac582ad3a78b18bdd2e6615f1ec105ee05adfe1 DIFF: https://github.com/llvm/llvm-project/commit/dac582ad3a78b18bdd2e6615f1ec105ee05adfe1.diff

[PATCH] D106119: [Driver] Detect libstdc++ include paths for native gcc on 32-bit non-Debian Linux

2021-07-17 Thread Luke Benes via Phabricator via cfe-commits
lbenes added a comment. Updated OpenSUSE which bumped gcc from 10 to 11. Still failing with the latest patch. https://controlc.com/c4a19d64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106119/new/ https://reviews.llvm.org/D106119 __

[PATCH] D105911: [CallGraphSection] Introduce CGSectionFuncComdatCreator pass

2021-07-17 Thread Necip Fazil Yildiran via Phabricator via cfe-commits
necipfazil abandoned this revision. necipfazil added a comment. In D105911#2878345 , @morehouse wrote: > Are comdats needed? Can we get proper dead stripping with just > `SHF_LINK_ORDER`? It looks like we can. I am abandoning this revision. I will shor

[PATCH] D105907: [CallGraphSection] Add call graph section options and documentation

2021-07-17 Thread Necip Fazil Yildiran via Phabricator via cfe-commits
necipfazil updated this revision to Diff 359592. necipfazil added a comment. Change call graph section layout - Changed the call graph section layout - Extended the example - Updated the documentation In the previous version, the call graph section layout was optimized for entries with unique ty

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

2021-07-17 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 updated this revision to Diff 359590. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/ https://reviews.llvm.org/D103426 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/FormatString.h clang/include/clang/AST/Type.h clang/lib/AST/Expr.cpp cl

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

2021-07-17 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 added inline comments. Comment at: clang/include/clang/AST/Expr.h:1846-1871 + std::string getStringAsChar() const { +assert(getCharByteWidth() == 1 && + "This function is used in places that assume strings use char"); +return std::string(getTrai

[PATCH] D106227: Fix duplicate checks in clangd documentation

2021-07-17 Thread Elton Leander Pinto via Phabricator via cfe-commits
1ntEgr8 created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. 1ntEgr8 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

2021-07-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K&R-related > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer modes. > It ma

[clang] 6225d0c - [OpaquePtr] Remove uses of CreateInBoundsGEP() without element type

2021-07-17 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-07-17T21:27:16+02:00 New Revision: 6225d0cc6e6e3eef63261dda1efaf10689e33db7 URL: https://github.com/llvm/llvm-project/commit/6225d0cc6e6e3eef63261dda1efaf10689e33db7 DIFF: https://github.com/llvm/llvm-project/commit/6225d0cc6e6e3eef63261dda1efaf10689e33db7.diff

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

2021-07-17 Thread namazso via Phabricator via cfe-commits
namazso added a comment. I don't have commit access, could someone commit this for me? Thanks in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106210/new/ https://reviews.llvm.org/D106210 ___ cf

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

2021-07-17 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106210/new/ https://reviews.llvm.org/D106210 ___

[PATCH] D106184: [BPF] Use elementtype attribute for preserve.array/struct.index intrinsics

2021-07-17 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. I just tested the patch with kernel bpf selftests and it works fine. The patch looks good to me too. Comment at: llvm/lib/Target/BPF/BPFAbstractMemberAccess.cpp:303 CInfo.RecordAlignment = DL->getABITypeAlign(CInfo.Base->getType()->

[clang] 4ace600 - [OpaquePtr] Remove uses of CreateStructGEP() without element type

2021-07-17 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-07-17T18:48:21+02:00 New Revision: 4ace6008f2fde781c1bedc7515e6380e449cb56a URL: https://github.com/llvm/llvm-project/commit/4ace6008f2fde781c1bedc7515e6380e449cb56a DIFF: https://github.com/llvm/llvm-project/commit/4ace6008f2fde781c1bedc7515e6380e449cb56a.diff

[clang] 6d3e7c7 - [OpaquePtr] Remove uses of CreateConstGEP1_32() without element type

2021-07-17 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-07-17T18:32:36+02:00 New Revision: 6d3e7c783b98e5663741152f046f14c934bcf612 URL: https://github.com/llvm/llvm-project/commit/6d3e7c783b98e5663741152f046f14c934bcf612 DIFF: https://github.com/llvm/llvm-project/commit/6d3e7c783b98e5663741152f046f14c934bcf612.diff

[clang] 5071360 - [OpaquePtr] Remove uses of CGF.Builder.CreateConstInBoundsGEP1_64() without type

2021-07-17 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-07-17T17:07:46+02:00 New Revision: 5071360eb1cf4a93ab72fd4ba47680a9eda98e39 URL: https://github.com/llvm/llvm-project/commit/5071360eb1cf4a93ab72fd4ba47680a9eda98e39 DIFF: https://github.com/llvm/llvm-project/commit/5071360eb1cf4a93ab72fd4ba47680a9eda98e39.diff

[clang] 357756e - [OpaquePtr] Remove uses of CreateConstGEP1_64() without element type

2021-07-17 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-07-17T16:43:20+02:00 New Revision: 357756ecf67817c3db81b285b9fce0663d9ed875 URL: https://github.com/llvm/llvm-project/commit/357756ecf67817c3db81b285b9fce0663d9ed875 DIFF: https://github.com/llvm/llvm-project/commit/357756ecf67817c3db81b285b9fce0663d9ed875.diff

[clang] 4737eeb - [OpaquePtr] Remove uses of CreateConstInBoundsGEP2_64() without type

2021-07-17 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2021-07-17T16:42:10+02:00 New Revision: 4737eebc0d05a42bd5a27e325d3846bd90a4d1b5 URL: https://github.com/llvm/llvm-project/commit/4737eebc0d05a42bd5a27e325d3846bd90a4d1b5 DIFF: https://github.com/llvm/llvm-project/commit/4737eebc0d05a42bd5a27e325d3846bd90a4d1b5.diff

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

2021-07-17 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 359559. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Lex/Lit

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

2021-07-17 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 359558. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106216/new/ https://reviews.llvm.org/D106216 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaCXX/cxx2a-explicit

[PATCH] D106216: Disallow narrowing conversions to bool in explicit specififers.

2021-07-17 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Completes the support for P1401R5 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D106216 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D105926: [PowerPC] Extra test case for LDARX

2021-07-17 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. Sorry for raising an unrelated topic here, but I can't reach @Conanap directly via the mail from the git commits: @Conanap could you please create the git branches for your patches in your own Github fork instead of the main LLVM repo? LLVM's policy is to have working

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

2021-07-17 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements P2362 , which has not het been approved by the C++ committee, but because wide-multi character literal

[PATCH] D106184: [BPF] Use elementtype attribute for preserve.array/struct.index intrinsics

2021-07-17 Thread Nikita Popov via Phabricator via cfe-commits
nikic closed this revision. nikic added a comment. Landed as https://github.com/llvm/llvm-project/commit/be5af50e7d028849bf2fab5f4b0f2ad36ae56e11, missed the "Differential Revision" tag. For the record, the problem with the autoupgrade test was PEBKAC: The textual diff that gets uploaded to Ph

[PATCH] D106210: [MS] Preserve base register %esi around movs[bwl]

2021-07-17 Thread namazso via Phabricator via cfe-commits
namazso updated this revision to Diff 359550. namazso added a comment. fix linter warnings, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106210/new/ https://reviews.llvm.org/D106210 Files: clang/lib/Headers/intrin.h clang/test/Co