[PATCH] D105708: [analyzer][NFC] Display the correct function name even in crash dumps

2021-07-11 Thread Balázs Benics via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd3e14fafc69a: [analyzer][NFC] Display the correct function name even in crash dumps (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105

[clang] d3e14fa - [analyzer][NFC] Display the correct function name even in crash dumps

2021-07-11 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2021-07-12T09:06:46+02:00 New Revision: d3e14fafc69a07e3dab9ddb91f1d810bb5f8d7a0 URL: https://github.com/llvm/llvm-project/commit/d3e14fafc69a07e3dab9ddb91f1d810bb5f8d7a0 DIFF: https://github.com/llvm/llvm-project/commit/d3e14fafc69a07e3dab9ddb91f1d810bb5f8d7a0.diff

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

2021-07-11 Thread luxufan via Phabricator via cfe-commits
StephenFan added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:115 + return make_filter_range(SupportedExtensionInfos, + [&](const RISCVSupportedExtensionInfo &ExtInfo) { + return ExtInfo.Name == ExtName; ---

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

2021-07-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert reopened this revision. jdoerfert added a comment. Herald added a subscriber: dexonsmith. > A pthread_create() related test is XFAIL-ed, as it relied on it being > recognized as a builtin based on its name. > The builtin declaration syntax is too restrictive and doesn't allow custom >

[PATCH] D104619: [clang] Respect PrintingPolicy::FullyQualifiedName when printing a template-id

2021-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 357827. nridge added a comment. Rebase on top of refactor patch changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 Files: clang/lib/AST/TypePrinter.cpp clang/

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

2021-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added inline comments. Comment at: clang/unittests/AST/DeclPrinterTest.cpp:59 + return PrintedNodeMatches(Code, Args, NodeMatch, ExpectedPrinted, + FileName, PrinterType{PrintDecl}, + PolicyModifier, AllowE

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

2021-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 357826. nridge marked 3 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457 Files: clang/unittes

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

2021-07-11 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:310 +struct DeclFilter { + DeclFilter(ClangTidyContext &Ctx, SourceManager &SM) + : Context(Ctx), Sources(SM) { sammccall wrote: > Ctx is ultimately unused, just take the rege

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

2021-07-11 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 357824. chh marked 7 inline comments as done. chh added a comment. sync up latest clang/llvm source; more format/style changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files: clang-tools-extra/clang-tid

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

2021-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:159 +// indexed, we walk further up because Ref::Container should always be +// an indexed symbol. +const Decl *getRefContainer(const Decl *Enclos

[PATCH] D105083: [clangd] Ensure Ref::Container refers to an indexed symbol

2021-07-11 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 357823. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105083/new/ https://reviews.llvm.org/D105083 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp c

[PATCH] D104420: thread_local support for AIX

2021-07-11 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGenCXX/cxx11-thread-local-reference.cpp:13 // LINUX: @_ZTH1r ={{.*}} alias void (), void ()* @__tls_init +// AIXX: @_ZTH1r ={{.*}} alias void (), void ()* @__tls_init // DARWIN: @_ZTH1r = internal alias vo

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

2021-07-11 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I believe that your failing test case is because you are attempting to emit code for these builtins in the target independent code and the values just happen to match up.

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2021-07-11 Thread Luís Marques via Phabricator via cfe-commits
luismarques added a comment. This patch is nearly there! Just address the remaining review comments and it LGTM. BTW, please mark all addressed inline comments as done. I think a few were missed, and it's helpful for a large patch like this. Comment at: llvm/lib/Target/RISCV

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

2021-07-11 Thread Luís Marques via Phabricator via cfe-commits
luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 __

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

2021-07-11 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] 5922f23 - Revert "[clang-repl] Implement partial translation units and error recovery."

2021-07-11 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2021-07-11T14:40:10Z New Revision: 5922f234c8c95f61534160a31db15dfc10da9b60 URL: https://github.com/llvm/llvm-project/commit/5922f234c8c95f61534160a31db15dfc10da9b60 DIFF: https://github.com/llvm/llvm-project/commit/5922f234c8c95f61534160a31db15dfc10da9b60.diff LO

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

2021-07-11 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 357643. Ericson2314 added a comment. Herald added a subscriber: whisperity. rebased, fixed some new DESTINATION Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 File

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

2021-07-11 Thread Vassil Vassilev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6775fc6ffa3c: [clang-repl] Implement partial translation units and error recovery. (authored by v.g.vassilev). Herald added a project: clang. Reposi

[clang] 6775fc6 - [clang-repl] Implement partial translation units and error recovery.

2021-07-11 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2021-07-11T10:23:41Z New Revision: 6775fc6ffa3ca1c36b20c25fa4e7f48f81213cf2 URL: https://github.com/llvm/llvm-project/commit/6775fc6ffa3ca1c36b20c25fa4e7f48f81213cf2 DIFF: https://github.com/llvm/llvm-project/commit/6775fc6ffa3ca1c36b20c25fa4e7f48f81213cf2.diff LO