[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/StmtCXX.h:356-359 Expr *Allocate = nullptr; Expr *Deallocate = nullptr; +Expr *AlignedAllocate = nullptr; +Expr *AlignedDeallocate = nullptr; ychen wrote: > ChuanqiXu wrote: >

[clang] 92f9852 - [clang-repl] Recommit "Land initial infrastructure for incremental parsing"

Author: Vassil Vassilev Date: 2021-05-13T06:30:29Z New Revision: 92f9852fc99b0a18e8d1329341f36f1708343f05 URL: https://github.com/llvm/llvm-project/commit/92f9852fc99b0a18e8d1329341f36f1708343f05 DIFF: https://github.com/llvm/llvm-project/commit/92f9852fc99b0a18e8d1329341f36f1708343f05.diff LO

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:528-547 CGF.EmitBlock(FreeBB); CGF.EmitStmt(Deallocate); - -auto *AfterFreeBB = CGF.createBasicBlock("after.coro.free"); -CGF.EmitBlock(AfterFreeBB); +CGF.Builder.CreateBr(AfterFreeBB

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/include/clang/AST/StmtCXX.h:356-359 Expr *Allocate = nullptr; Expr *Deallocate = nullptr; +Expr *AlignedAllocate = nullptr; +Expr *AlignedDeallocate = nullptr; ChuanqiXu wrote: > ychen wrote: > > Ch

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:528-547 CGF.EmitBlock(FreeBB); CGF.EmitStmt(Deallocate); - -auto *AfterFreeBB = CGF.createBasicBlock("after.coro.free"); -CGF.EmitBlock(AfterFreeBB); +CGF.Builder.CreateBr(AfterFreeBB

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

phosek added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3293 +static bool SupportsRelativeCXXVTables(const llvm::Triple &T) { + return T.isOSFuchsia(); +} Could we instead enable it inside `FuchsiaCXXABI`? Repository: rG LLVM Gith

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/StmtCXX.h:356-359 Expr *Allocate = nullptr; Expr *Deallocate = nullptr; +Expr *AlignedAllocate = nullptr; +Expr *AlignedDeallocate = nullptr; ychen wrote: > ChuanqiXu wrote: >

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 345053. ychen marked an inline comment as done. ychen added a comment. - Address feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/include/clang/A

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen marked an inline comment as done. ychen added inline comments. Comment at: clang/include/clang/AST/StmtCXX.h:356-359 Expr *Allocate = nullptr; Expr *Deallocate = nullptr; +Expr *AlignedAllocate = nullptr; +Expr *AlignedDeallocate = nullptr; ---

[clang] f690715 - Revert "[clang-repl] Land initial infrastructure for incremental parsing"

Author: Vassil Vassilev Date: 2021-05-13T04:44:19Z New Revision: f6907152db3d70606817ffe28274c6a90b331bbc URL: https://github.com/llvm/llvm-project/commit/f6907152db3d70606817ffe28274c6a90b331bbc DIFF: https://github.com/llvm/llvm-project/commit/f6907152db3d70606817ffe28274c6a90b331bbc.diff LO

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. Thanks everybody for reviewing and help making this patch better!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cfe-commits m

[clang] 44a4000 - [clang-repl] Land initial infrastructure for incremental parsing

Author: Vassil Vassilev Date: 2021-05-13T04:23:24Z New Revision: 44a4000181e1a25027e87f2ae4e71cb876a7a275 URL: https://github.com/llvm/llvm-project/commit/44a4000181e1a25027e87f2ae4e71cb876a7a275 DIFF: https://github.com/llvm/llvm-project/commit/44a4000181e1a25027e87f2ae4e71cb876a7a275.diff LO

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44a4000181e1: [clang-repl] Land initial infrastructure for incremental parsing (authored by v.g.vassilev). Herald added a project: clang. Changed pr

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur added a comment. Removed [WIP] flag; ready to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 345029. Meinersbur added a comment. - Preserve relative order between OriginalInits and interleaved transformation's PreInits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.o

[clang] a0ca4c4 - [Debug-Info] add -gstrict-dwarf support in backend

Author: Chen Zheng Date: 2021-05-12T23:00:52-04:00 New Revision: a0ca4c46ca35957a38a6023fa84afda2fc9ba0ec URL: https://github.com/llvm/llvm-project/commit/a0ca4c46ca35957a38a6023fa84afda2fc9ba0ec DIFF: https://github.com/llvm/llvm-project/commit/a0ca4c46ca35957a38a6023fa84afda2fc9ba0ec.diff LO

[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with comment. Comment at: clang/test/Parser/altivec-zvector-bool.c:20-23 +__vector _Bool char Bc; +__vector _Bool short Bsh; +__vector _B

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. Additionally, `forCallable(functionDecl())` is not equivalent to `forFunction()` (the former silently matches less stuff). So anybody who had `functionDecl()` spelled out explicitly in their code will observe a silent change in behavior. I think that most of the time the di

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

NoQ updated this revision to Diff 345018. NoQ added a comment. We do actually have variadic `isa<>`! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102294/new/ https://reviews.llvm.org/D102294 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-tools-extra/test/

[clang] ce6cc87 - [clang] Minor fix for MarkVarDeclODRUsed

Author: Yaxun (Sam) Liu Date: 2021-05-12T22:32:10-04:00 New Revision: ce6cc87ce9e96eaa5e5ef0c1f5dc07b41381996d URL: https://github.com/llvm/llvm-project/commit/ce6cc87ce9e96eaa5e5ef0c1f5dc07b41381996d DIFF: https://github.com/llvm/llvm-project/commit/ce6cc87ce9e96eaa5e5ef0c1f5dc07b41381996d.dif

[clang] e1aa528 - Handle unexpanded packs appearing in type-constraints.

Author: Richard Smith Date: 2021-05-12T18:45:34-07:00 New Revision: e1aa528d3aaf5fcf9c50d1e34b39dbde1e63801d URL: https://github.com/llvm/llvm-project/commit/e1aa528d3aaf5fcf9c50d1e34b39dbde1e63801d DIFF: https://github.com/llvm/llvm-project/commit/e1aa528d3aaf5fcf9c50d1e34b39dbde1e63801d.diff

[clang] 2f9d8b0 - PR50306: When instantiating a generic lambda with a constrained 'auto',

Author: Richard Smith Date: 2021-05-12T18:45:33-07:00 New Revision: 2f9d8b08ea658b612065cbf7d4b0fbd7f28bb36a URL: https://github.com/llvm/llvm-project/commit/2f9d8b08ea658b612065cbf7d4b0fbd7f28bb36a DIFF: https://github.com/llvm/llvm-project/commit/2f9d8b08ea658b612065cbf7d4b0fbd7f28bb36a.diff

[clang] e0acfed - Clean up handling of constrained parameters in lambdas.

Author: Richard Smith Date: 2021-05-12T18:45:33-07:00 New Revision: e0acfed7ed5173b437868f75fc394084487e390a URL: https://github.com/llvm/llvm-project/commit/e0acfed7ed5173b437868f75fc394084487e390a DIFF: https://github.com/llvm/llvm-project/commit/e0acfed7ed5173b437868f75fc394084487e390a.diff

[clang] 4c88cfb - Add test for substitutability of variable templates in closure type

Author: Richard Smith Date: 2021-05-12T18:45:33-07:00 New Revision: 4c88cfb1dc79227be78f8dade966934384914e5e URL: https://github.com/llvm/llvm-project/commit/4c88cfb1dc79227be78f8dade966934384914e5e DIFF: https://github.com/llvm/llvm-project/commit/4c88cfb1dc79227be78f8dade966934384914e5e.diff

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

thakis added a comment. We share obj files built on linux and on windows. So that's a goal for us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102339/new/ https://reviews.llvm.org/D102339 ___ cfe-commi

[clang] 10c779d - [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

Author: Pushpinder Singh Date: 2021-05-13T01:34:03Z New Revision: 10c779d2065f7e216660f1687244269afcee13b1 URL: https://github.com/llvm/llvm-project/commit/10c779d2065f7e216660f1687244269afcee13b1 DIFF: https://github.com/llvm/llvm-project/commit/10c779d2065f7e216660f1687244269afcee13b1.diff L

[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

This revision was automatically updated to reflect the committed changes. Closed by commit rG10c779d2065f: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102065/new/ https://

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jdoerfert added a comment. tests missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102361/new/ https://reviews.llvm.org/D102361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

eugenis added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO: Use -m

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan created this revision. leonardchan added a project: clang. Herald added subscribers: dang, phosek. leonardchan requested review of this revision. All fuchsia targets will now use the relative-vtables ABI by default. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

aganea added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. amccarth wrote: > rnk wrote: > > I feel like this should somehow be a property of

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/Sanitizers.def:55-59 +// Utilize Intel LAM in sanitizers. Currently only used in combination with +// -fsanitize=hwaddress. This is an experimental flag which may be removed in +// the future. +// TODO: Use

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

amccarth added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. rnk wrote: > I feel like this should somehow be a property of the input virtual

[PATCH] D102369: [ASTMatchers][NFC] Remove runtime checks where compile time is sufficient

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, alexfh. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some polymorphic matchers use dyn_cast in cases where we know the type from the TemplateParam

[PATCH] D101156: [Clang] Support a user-defined __dso_handle

asavonic added a comment. In D101156#2724789 , @rjmccall wrote: > What's the crash exactly/ Is IRGen just unhappy about processing the user > definition when we've generated a declaration with a different type? Because > we're already supposed to be b

[PATCH] D102270: [CUDA][HIP] Fix device template variables

yaxunl closed this revision. yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17145 }; -if (Var && Var->hasGlobalStorage() && !IsEmittedOnDeviceSide(Var)) { - SemaRef.targetDiag(Loc, diag::err_ref_bad_tar

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl updated this revision to Diff 344949. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Teresa's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 Files: clang/include/clang/Driver/Driver.h clang/inclu

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionImport.cpp:496 dbgs() << "ignored! No qualifying callee with summary found.\n"); continue; } tejohnson wrote: > yaxunl

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added inline comments. Comment at: clang/test/CodeGen/extend-arg-64.c:19 + +int vararg(int, ...); + aaron.ballman wrote: > Can you also add a test for K&R C functions? e.g., `int knr();` `sum = > knr(sum, u32, s32, u16, s16, u8, s8);` > > Also, can you

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 344939. AndreyChurbanov added a comment. Addressed review comments. Fixed tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 Files: clang/lib/CodeGen/CGOp

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 344941. v.g.vassilev added a comment. clang-tidy and clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clang/CodeGen/CodeGenAction.h clang/include/clang/Frontend/Fron

[PATCH] D102337: [clang-tidy] Fix test that requires Windows platofrm

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102337/new/ https://reviews.llvm.org/D102337 ___ cfe-commits mailing list cfe-comm

[PATCH] D101968: Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb7e81c64bd: Fix bad mangling of for a closure in the initializer of a… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 5bb7e81 - Fix bad mangling of for a closure in the initializer of a variable at global namespace scope.

Author: Richard Smith Date: 2021-05-12T13:13:21-07:00 New Revision: 5bb7e81c64bd29edd1c9ebadd4e4717919def0bf URL: https://github.com/llvm/llvm-project/commit/5bb7e81c64bd29edd1c9ebadd4e4717919def0bf DIFF: https://github.com/llvm/llvm-project/commit/5bb7e81c64bd29edd1c9ebadd4e4717919def0bf.diff

[PATCH] D102361: [OpenMP] Add Module metadata for OpenMP compilation

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds a module level metadata flag indicating that th

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:467 + if (!CalleeMD->isDefined()) { +CGM.ErrorUnsupported(ThunkGD.getDecl(), "thunk for forward declaration"); +return; lebedev.ri wrote: > efriedma wrote: > > "IsUnprototyped" m

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:467 + if (!CalleeMD->isDefined()) { +CGM.ErrorUnsupported(ThunkGD.getDecl(), "thunk for forward declaration"); +return; efriedma wrote: > "IsUnprototyped" means that we have to

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG08ba9ce1ef72: Suppress Deferred Diagnostics in discarded statements. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D102251?vs=344813&id=344920#toc Repository: rG LLVM Gi

[clang] 08ba9ce - Suppress Deferred Diagnostics in discarded statements.

Author: Erich Keane Date: 2021-05-12T12:48:47-07:00 New Revision: 08ba9ce1ef7214623d4104e72d817c73644a0884 URL: https://github.com/llvm/llvm-project/commit/08ba9ce1ef7214623d4104e72d817c73644a0884 DIFF: https://github.com/llvm/llvm-project/commit/08ba9ce1ef7214623d4104e72d817c73644a0884.diff L

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 344918. jdoerfert added a comment. Herald added a subscriber: jvesely. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 Files: clang/lib/CodeGen/CGOpe

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy created this revision. Herald added a subscriber: wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++ constructors/destructors need to go through a different constructor to construct a GlobalDecl object in order to retrieve

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. I'm also mildly worried that Function is not the technically correct term. Maybe we should mark the old matcher as deprecated instead? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 __

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/src/omptarget.cu:195 + +EXTERN __attribute__((weak)) +int32_t __kmpc_target_init(ident_t *Ident, bool IsSPMD, jdoerfert wrote: > JonChesterfield wrote: > > why are these weak

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I'm not certain what this 'aligned' limitation for nvptx syncthreads is, but can't think of a corresponding one for amdgcn. So we may not need the LDS barrier construction, a

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. The breakage is loud; the code will no longer compile when the intermediate `decl()` (or `namedDecl()`, or whatever) is not present. The more annoying part is that when you add `namedDecl()` back (or if you had it spelled out this way from the start, which doesn't make much

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 344904. aabbaabb marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101139/new/ https://reviews.llvm.org/D101139 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/tools/CMakeLists.txt clang/tools/scan-build-py/C

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

erichkeane added inline comments. Comment at: clang/include/clang/AST/EvaluatedExprVisitor.h:37 + // 'constexpr-if'. + bool shouldVisitDiscardedCase() const { return true; } #define PTR(CLASS) typename Ptr::type rsmith wrote: > Maybe `shouldVisitDiscardedStmt`

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

rsmith added inline comments. Comment at: clang/test/Sema/pointer-addition.cpp:5-6 + char *f = (char*)0; + f = (char*)((char*)0 - f); // expected-warning {{performing pointer arithmetic on a null pointer has undefined behavior}} + f = (char*)(f - (char*)0); // expected-warnin

[PATCH] D102168: Use an allow list on reserved macro identifiers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102168/new/ https://reviews.llvm.org/D102168 ___ cfe-commits mailing lis

[clang-tools-extra] 99d63cc - Add type information to integral template argument if required.

Author: Pratyush Das Date: 2021-05-12T19:00:08Z New Revision: 99d63ccff04b672694f8a2b3eed024b873dc163d URL: https://github.com/llvm/llvm-project/commit/99d63ccff04b672694f8a2b3eed024b873dc163d DIFF: https://github.com/llvm/llvm-project/commit/99d63ccff04b672694f8a2b3eed024b873dc163d.diff LOG:

[PATCH] D77598: Integral template argument suffix and cast printing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99d63ccff04b: Add type information to integral template argument if required. (authored by reikdas, committed by v.g.vassilev). Repository: rG LLV

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:262-264 +/// Unprototyped integer arguments are extended to 32 bits. +ExtendTo32, +/// Unprototyped integer arguments are extended to 64 bits. The comments aren't

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] d8c227b - Revert "Produce warning for performing pointer arithmetic on a null pointer."

Author: Nico Weber Date: 2021-05-12T14:53:50-04:00 New Revision: d8c227ba05d065046bdb8671f1df73dabaffa222 URL: https://github.com/llvm/llvm-project/commit/d8c227ba05d065046bdb8671f1df73dabaffa222 DIFF: https://github.com/llvm/llvm-project/commit/d8c227ba05d065046bdb8671f1df73dabaffa222.diff LO

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

This revision was automatically updated to reflect the committed changes. Closed by commit rG211761332e43: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in… (authored by Stephen, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang-tools-extra] 2117613 - [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

Author: Stephen Concannon Date: 2021-05-12T20:51:25+02:00 New Revision: 211761332e4381c37edd91be7c59fc048014ff4e URL: https://github.com/llvm/llvm-project/commit/211761332e4381c37edd91be7c59fc048014ff4e DIFF: https://github.com/llvm/llvm-project/commit/211761332e4381c37edd91be7c59fc048014ff4e.d

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri added a comment. In D100388#2754872 , @efriedma wrote: >> Would it be reasonable to instead start with a stopgap measure of not adding >> attributes for this/return of thunks? > > You mean, add align attributes to "this" on regular methods, bu

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

rnk added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:145 + StringRef SearchPath; +#ifdef _WIN32 + // Make the search insensitive to case and separators. I feel like this should somehow be a property of the input virtual filesystem: we s

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

efriedma added a comment. > Would it be reasonable to instead start with a stopgap measure of not adding > attributes for this/return of thunks? You mean, add align attributes to "this" on regular methods, but not thunks? I can't see how that could do any harm. Comment at:

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman added a comment. In D102213#2754495 , @NoQ wrote: > I totally agree that changing `forFunction()` to work correctly is the right > solution but backwards compatibility breakage is very real because > `forFunction()` accepts a `Matcher` whe

[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99543/new/ https://reviews.llvm.org/D99543 _

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. If this is a problem for you, please revert it and I will take a look when I return. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

efriedma added a comment. @thakis if this is an issue for you, please revert; like you said, we can figure out the issues later. Looking at the warning you showed, we might want to consider suppressing that specific pattern, in addition to (or instead of?) suppressing it in system headers. The

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + hoy wrote: > aaron.ballman wrote: > > hoy wrote: > > > aaron.ballman wrote: > > > > dblaikie wro

[clang] 56f7e5a - [cmake] Add support for multiple distributions

Author: Shoaib Meenai Date: 2021-05-12T11:13:18-07:00 New Revision: 56f7e5a822b43578e086c40d063af2a2c0d214ee URL: https://github.com/llvm/llvm-project/commit/56f7e5a822b43578e086c40d063af2a2c0d214ee DIFF: https://github.com/llvm/llvm-project/commit/56f7e5a822b43578e086c40d063af2a2c0d214ee.diff

[PATCH] D89177: [cmake] Add support for multiple distributions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56f7e5a822b4: [cmake] Add support for multiple distributions (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:700 CurCodeDecl = D; - if (const auto *FD = dyn_cast_or_null(D)) -if (FD->usesSEHTry()) - CurSEHParent = FD; + const FunctionDecl *FD = dyn_cast_or_null(D); + if (FD && FD->usesSEHTry(

[PATCH] D102343: [clang][patch][FPEnv} Initialization of C++ globals not strictfp aware

mibintc created this revision. mibintc added reviewers: kpn, rjmccall, aaron.ballman, pcc. Herald added a subscriber: martong. Herald added a reviewer: shafik. mibintc requested review of this revision. Herald added a project: clang. In the proposed patch https://reviews.llvm.org/D81178 @kpn point

[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

rsmith accepted this revision. rsmith added inline comments. Comment at: clang/include/clang/AST/EvaluatedExprVisitor.h:37 + // 'constexpr-if'. + bool shouldVisitDiscardedCase() const { return true; } #define PTR(CLASS) typename Ptr::type Maybe `shouldVisitDis

[PATCH] D100388: [BROKEN][clang] Try to fix thunk function types

lebedev.ri updated this revision to Diff 344877. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. In D100388#2749115 , @efriedma wrote: > Made a couple suggestions to make this easier to review. > > The test changes you've made so

Re: [clang] 1470b85 - Remove AST inclusion from Basic include

Thanks! On Wed, May 12, 2021 at 8:56 PM Benjamin Kramer via cfe-commits wrote: > > > Author: Benjamin Kramer > Date: 2021-05-12T19:51:21+02:00 > New Revision: 1470b8587f6fdc357163c2258747b77ae9ad6d7a > > URL: > https://github.com/llvm/llvm-project/commit/1470b8587f6fdc357163c2258747b77ae9ad6d7a

[PATCH] D102244: [llvm][AsmPrinter] Restore source location to register clobber warning

ychen added a comment. Looks good except for one suggestion and the patch need rebasing on an upstream commit. Comment at: llvm/include/llvm/IR/LLVMContext.h:300 + /// with "warning: " and should not end with a ".". + void emitWarning(unsigned LocCookie, const Twine &Warning

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

saudi created this revision. saudi added reviewers: rnk, thakis, dexonsmith, Bigcheese. saudi added a project: clang. saudi requested review of this revision. Herald added a subscriber: cfe-commits. We noticed that the dependency collectors of `clang` may report duplicate paths under Windows, whe

[clang] 1470b85 - Remove AST inclusion from Basic include

Author: Benjamin Kramer Date: 2021-05-12T19:51:21+02:00 New Revision: 1470b8587f6fdc357163c2258747b77ae9ad6d7a URL: https://github.com/llvm/llvm-project/commit/1470b8587f6fdc357163c2258747b77ae9ad6d7a DIFF: https://github.com/llvm/llvm-project/commit/1470b8587f6fdc357163c2258747b77ae9ad6d7a.dif

[PATCH] D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered

logan-5 created this revision. logan-5 added reviewers: erik.pilkington, rsmith, arphaman. logan-5 added a project: clang. logan-5 requested review of this revision. Herald added a subscriber: cfe-commits. Always search the full function scope context if a potential availability violation is enco

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. (Now completed the reply, see phab.) In D98798#2754635 , @xbolva00 wrote: > You dont have to use -Wno-… > > You can use pragma to disable this warning for certain location in the code, > eg include of commctrl.h. commctrl.h is in

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

xbolva00 added a comment. You dont have to use -Wno-… You can use pragma to disable this warning for certain location in the code. -1 for revert just because of this reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. (sorry, accidentally hit cmd-enter, not actually done writing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing lis

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

thakis added a comment. In D98798#2754449 , @jamieschmeiser wrote: > @thakis, I have some questions about your comments. > Are you sure this is coming from a system header? The path that you gave has > third_party as a directory in the path. Yes. `thir

[clang] 2d84195 - [NFCI][clang][Codegen] CodeGenVTables::addVTableComponent(): use getGlobalDecl

Author: Roman Lebedev Date: 2021-05-12T20:39:54+03:00 New Revision: 2d84195d60b0cb5ea43b18ab8f6770a84bf32da4 URL: https://github.com/llvm/llvm-project/commit/2d84195d60b0cb5ea43b18ab8f6770a84bf32da4 DIFF: https://github.com/llvm/llvm-project/commit/2d84195d60b0cb5ea43b18ab8f6770a84bf32da4.diff

[clang] 81f56a2 - [NFC][clang][Codegen] Split ThunkInfo into it's own header

Author: Roman Lebedev Date: 2021-05-12T20:39:54+03:00 New Revision: 81f56a2eb3797eb5be61d65a8f7d7e19456e67d1 URL: https://github.com/llvm/llvm-project/commit/81f56a2eb3797eb5be61d65a8f7d7e19456e67d1 DIFF: https://github.com/llvm/llvm-project/commit/81f56a2eb3797eb5be61d65a8f7d7e19456e67d1.diff

[PATCH] D102322: [clang-tidy] Add '-target' CLI option to override target triple

jubnzv abandoned this revision. jubnzv added a comment. Thank you, I didn't know that it is possible to set the target triple using `--extra-arg`. I created a new revision with this fix: https://reviews.llvm.org/D102337. For some reasons, the `--target=unknown-windows` doesn't work for me with t

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bf1acab5b45: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D102090?vs=343758&id=344866#toc Repository:

[clang] 3bf1aca - [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

Author: Fangrui Song Date: 2021-05-12T10:34:31-07:00 New Revision: 3bf1acab5b454ad7fb2074b34663108b53620695 URL: https://github.com/llvm/llvm-project/commit/3bf1acab5b454ad7fb2074b34663108b53620695 DIFF: https://github.com/llvm/llvm-project/commit/3bf1acab5b454ad7fb2074b34663108b53620695.diff

[PATCH] D102337: [clang-tidy] Fix test that requires Windows platofrm

jubnzv created this revision. jubnzv added reviewers: aaron.ballman, njames93. jubnzv added a project: clang-tools-extra. Herald added subscribers: kbarton, xazax.hun, nemanjai. jubnzv requested review of this revision. This commit fixes the `cppcoreguidelines-pro-type-vararg` test when it runs o

[PATCH] D101139: Create install targets for scan-build-py.

phosek added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:1-7 +set (BinFiles + "analyze-build" + "analyze-c++" + "analyze-cc" + "intercept-build" + "intercept-c++" + "intercept-cc") Shouldn't this list also contain

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added a comment. I think the best method is to In D86671#2750957 , @dougpuob wrote: > Hi @njames93: > Could you do me a favor? Because it is my first patch, something I'm not > sure. I'm confused about can I land this patch now? I read the "LLVM

[PATCH] D102270: [CUDA][HIP] Fix device template variables

tra accepted this revision. tra added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17145 }; -if (Var && Var->hasGlobalStorage() && !IsEmittedOnDeviceSide(Var)) { - SemaRef.targetDiag(Loc, diag::err_ref_bad_target) - << /*host*/ 2 << /*variable*/

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added a comment. I totally agree that changing `forFunction()` to work correctly is the right solution but backwards compatibility breakage is very real because `forFunction()` accepts a `Matcher` whereas `forCallable()` accepts `Matcher` which is a smaller set of matchers. Eg., `forFuncti

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names-dwarf.c:34-39 +static int go(a) int a; +{ + return glob + a; +} + + aaron.ballman wrote: > hoy wrote: > > aaron.ballman wrote: > > > dblaikie wrote: > > > > hoy wrote: > > >

  1   2   >