[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point

hokein added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:3026 const bool ConditionalTrue = DER.Conditional; + // Lexer might become invalid if we hit code completion point while evulating + // expression. evulating => evaluating IIUC, `CurPP

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap updated this revision to Diff 343969. Conanap marked 2 inline comments as done. Conanap added a comment. Added big-endian pattern CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100782/new/ https://reviews.llvm.org/D100782 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/te

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. > which should be correct. It is implemented by > CodeGenFunction::EmitBuiltinAlignTo. I agree it is correct. I just want to say we should comment it to avoid confusing. Since the patch could handle the case if the frontend tries to search `::operator new(size_t, al

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

OikawaKirie created this revision. OikawaKirie added reviewers: steakhal, gamesh411, martong, balazske. OikawaKirie added a project: clang. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, mgorny.

[PATCH] D102148: [clangd] Type hints for variables with 'auto' type

nridge added a comment. Here's a first draft of an implementation of type hints. It provided hints for variable declarations that use `auto` (possibly with const, &, etc.) as the type. There are additional places in which type hints could be useful, such as: - Functions with deduced return typ

[PATCH] D102148: [clangd] Type hints for variables with 'auto' type

nridge updated this revision to Diff 343963. nridge added a comment. test formatting fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102148/new/ https://reviews.llvm.org/D102148 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extr

[PATCH] D102148: [clangd] Type hints for variables with 'auto' type

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Githu

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

alexfh added a comment. BTW, any ideas why "patch application failed"? (See the Build status in the Diff Detail section) It would be really nice to get pre-merge checks to work for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

alexfh added a comment. Thanks for the great work! This is mostly looking fine, but I've added a few comments. I could only make a quite superficial review so far, but I'll try to take a deeper look into this soon. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwap

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ychen created this revision. ychen added reviewers: rjmccall, EricWF, GorNishanov. Herald added subscribers: ChuanqiXu, dexonsmith, lxfind, dang. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Default off. The allocation/deallocatio

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 343959. ychen added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/include/clang/AST/StmtCXX.h clang/lib/AST/StmtCXX.cpp clang/lib

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 343956. ychen added a comment. - rebase on D102145 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuilti

[clang] 9ffd492 - [NFC][Coroutines] Fix two tests by removing hardcoded SSA value.

Author: Yuanfang Chen Date: 2021-05-09T19:06:16-07:00 New Revision: 9ffd4924e8e1a056760256c4cd5ffde38ccdf010 URL: https://github.com/llvm/llvm-project/commit/9ffd4924e8e1a056760256c4cd5ffde38ccdf010 DIFF: https://github.com/llvm/llvm-project/commit/9ffd4924e8e1a056760256c4cd5ffde38ccdf010.diff

[PATCH] D102086: [RISCV] Validate the SEW and LMUL operands to __builtin_rvv_vsetvli(max)

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102086/new/ https://reviews.llvm.org/D102086 __

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343949. smeenai added a comment. Helper function to get install arg. TODO: Address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

jdoerfert added a comment. In D101030#2746770 , @gregmiller wrote: > In D101030#2745513 , @jdoerfert > wrote: > >> In D101030#2745429 , @gregmiller >> wrote: >> >>> Hel

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343946. smeenai added a comment. Herald added subscribers: dcaballe, cota, teijeong. Rebase (comments not addressed yet; uploading a pure rebase for easier version comparison) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 343932. cynecx added a comment. actually run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D102125: [Matrix] Implement static cast for matrix types

SaurabhJha added a comment. In D102125#2746764 , @fhahn wrote: > LGTM from the mechanical aspect. Please wait a few days with committing, in > case there are any conceptual issues with supporting matrix casts here. Sure, sounds good. Repository: rG

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

gregmiller added a comment. In D101030#2745513 , @jdoerfert wrote: > In D101030#2745429 , @gregmiller > wrote: > >> Hello, We are maintaining a downstream version of the monorepo based on the >> LLVM main branch

[PATCH] D102125: [Matrix] Implement static cast for matrix types

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM from the mechanical aspect. Please wait a few days with committing, in case there are any conceptual issues with supporting matrix casts here. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 343924. cynecx added a comment. Fix assertion and clang-format patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/TargetInfo.cpp

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux and the BSDs

hvdijk added inline comments. Comment at: clang/lib/Basic/Targets/Sparc.cpp:246-256 + if (getTriple().getOS() == llvm::Triple::Linux) { Builder.defineMacro("__sparc_v9__"); -Builder.defineMacro("__sparcv9__"); + } else { +Builder.defineMacro("__sparcv9"); +// S

[PATCH] D102118: [BPF] add support for 32 bit registers in inline asm

yonghong-song added a comment. Generally looks good. One suggestion and a few nits. Thanks! Comment at: clang/lib/Basic/Targets/BPF.cpp:54 +if (Feature == "+alu32") { + HasAlu32 = true; +} -mcpu=v3 also enables alu32. See below llvm code ``` void B

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 updated this revision to Diff 343920. pooja2299 added a comment. Made some corrections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134 Files: clang/include/clang/Basic/AttrDocs.td Index: cla

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 updated this revision to Diff 343919. pooja2299 added a comment. Amended the flat_work_group_size section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134 Files: clang/include/clang/Basic/Attr

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

pooja2299 created this revision. pooja2299 added a reviewer: xgupta. Herald added a subscriber: tpr. Herald added a reviewer: aaron.ballman. pooja2299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed the documentation of amdgpu_flat_

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert added a comment. In D101976#2743470 , @JonChesterfield wrote: > In D101976#2742919 , @jdoerfert > wrote: > >> So what do you wnat me to change for this patch now? > > Equivalent change to amdgpu target

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

h-joo added a comment. In D101239#2746644 , @njames93 wrote: > LGTM, thanks. @njames93, I appreciate your time for the review. May I ask one more thing? I do not have commit rights. Would it be possible for you to make the commit? Thank you!! CHANGE

[PATCH] D101239: [clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101239/new/ https://reviews.llvm.org/D101239 ___ cfe-commits mailing list

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann marked an inline comment as done. mgartmann added a comment. @njames93 thanks a lot for your answer! I extracted the STD IO stream and C-like function names according to your comment. In your opinion, is there something else in this patch that has to be improved to make this request m

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 343911. mgartmann added a comment. Extracted STD IO stream and C-like IO function names into vectors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files: clang-t

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 343909. reikdas added a comment. Herald added subscribers: usaxena95, kadircet. Herald added a project: clang-tools-extra. Fix API usage in clangd and fix bug introduced in patch where printing of manually specified default template argument is omitted. CHA

[PATCH] D102125: [Matrix] Implement static cast for matrix types

SaurabhJha added a comment. I have commit access so I can get this into main branch after its approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102125/new/ https://reviews.llvm.org/D102125 ___ cfe-

[PATCH] D102125: [Matrix] Implement static cast for matrix types

SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements static casts for matrix types. This patch finishes all the work needed for https://bugs