[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay, @craig.topper, @skan, reviewers, I've addressed your comments. Any more concerns? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 __

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

Jim added a reviewer: Jim. Jim added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:993 +defm vmv_v : RVVOutBuiltinSet<"vmv_v_v", "csil", + [["v", "Uv", "UvUv"]]>; +defm vmv_v : RVVOutBuiltinSet<"vmv_v_v", "csilfd"

[clang-tools-extra] 2dd22da - [libtooling][clang-tidy] Fix compiler warnings in testcase [NFC]

Author: Mikael Holmen Date: 2021-04-12T08:26:46+02:00 New Revision: 2dd22da965ffc1623421cb8163947d7e679ce187 URL: https://github.com/llvm/llvm-project/commit/2dd22da965ffc1623421cb8163947d7e679ce187 DIFF: https://github.com/llvm/llvm-project/commit/2dd22da965ffc1623421cb8163947d7e679ce187.diff

[PATCH] D71541: [NFC] [Clang]: fix spelling mistake in assert message

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a2d375a77bf: [NFC] [Clang]: fix spelling mistake in assert message (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 8a2d375 - [NFC] [Clang]: fix spelling mistake in assert message

Author: Jim Lin Date: 2021-04-12T14:10:52+08:00 New Revision: 8a2d375a77bfd9d73f7dbb12bed5c8a014aa2a53 URL: https://github.com/llvm/llvm-project/commit/8a2d375a77bfd9d73f7dbb12bed5c8a014aa2a53 DIFF: https://github.com/llvm/llvm-project/commit/8a2d375a77bfd9d73f7dbb12bed5c8a014aa2a53.diff LOG:

[PATCH] D71541: [NFC] [Clang]: fix spelling mistake in assert message

Jim updated this revision to Diff 336752. Jim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71541/new/ https://reviews.llvm.org/D71541 Files: clang/lib/AST/VTableBuilder.cpp Index: clang/lib/AST/VTableBuilder.cpp ==

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

rjmccall added a comment. We don't have so many coroutine-emitting frontends that it's unreasonable to modify them all. Swift can make this change; it's not on you to do it. (I also work on the Swift frontend, so don't worry, I'm signing my own teammates up for work here.) Repository: rG

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

ChuanqiXu added a comment. In D100282#2682297 , @lxfind wrote: >> Ah, if the pass does more than just setting the attribute, then sure, it >> makes sense to keep it. But I do think we should be requiring the attribute >> to be added by frontends, since

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

lxfind added a comment. > Ah, if the pass does more than just setting the attribute, then sure, it > makes sense to keep it. But I do think we should be requiring the attribute > to be added by frontends, since it's really an IR invariant that it's present > on all unlowered coroutines. By th

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

ChuanqiXu added a comment. This patch looks OK to me. > The best we can do is lower the coroutine and then inline the ramp function, > which is not really the same thing. So warning about marking a coroutine > always_inline does make some sense. It makes sense to emit a warning instead of an e

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

rjmccall added a comment. In D100282#2682269 , @lxfind wrote: > In D100282#2682251 , @rjmccall > wrote: > >> Why does this pass even exist? We should just expect the frontend to set >> the attribute. It's not

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

lxfind added a comment. In D100282#2682251 , @rjmccall wrote: > Why does this pass even exist? We should just expect the frontend to set the > attribute. It's not like frontends don't have to otherwise know that they're > emitting a coroutine; a ton o

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

rjmccall added a comment. Why does this pass even exist? We should just expect the frontend to set the attribute. It's not like frontends don't have to otherwise know that they're emitting a coroutine; a ton of things about the expected entire IR pattern are different. Repository: rG LLVM

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

lxfind created this revision. lxfind added reviewers: junparser, dongAxis1944, rjmccall, ChuanqiXu. Herald added subscribers: hoy, modimo, wenlei, hiraditya. lxfind requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Presplit

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336738. FreddyYe added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic/Targets/X86.cpp clang/test/CodeGen/attr-target-mv

[PATCH] D100279: [X86] Remove FeatureCLWB from FeaturesICLClient

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cb47be41045: [X86] Remove FeatureCLWB from FeaturesICLClient (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100279/new/ https://revi

[clang] 5cb47be - [X86] Remove FeatureCLWB from FeaturesICLClient

Author: Freddy Ye Date: 2021-04-12T12:08:59+08:00 New Revision: 5cb47be4104558b2a69dc3df667dbe046bdcce6d URL: https://github.com/llvm/llvm-project/commit/5cb47be4104558b2a69dc3df667dbe046bdcce6d DIFF: https://github.com/llvm/llvm-project/commit/5cb47be4104558b2a69dc3df667dbe046bdcce6d.diff LOG

[PATCH] D100279: [X86] Remove FeatureCLWB from FeaturesICLClient

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100279/new/ https://reviews.llvm.org/D100279 ___

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3140 +/// \param ReturnType This is the return type of the function. +void Sema::updNRVOResultWithRetType(NRVOResult &Res, QualType ReturnType) { + if (!Res.Candida

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 336736. mizvekov marked an inline comment as done. mizvekov added a comment. - Removes code that tried to allow copy elision for functions with dependent 'auto' return types. The reason is explained in new comments. Will try to address these in future work.

[PATCH] D100279: [X86] Remove FeatureCLWB from FeaturesICLClient

FreddyYe updated this revision to Diff 336735. FreddyYe added a comment. update lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100279/new/ https://reviews.llvm.org/D100279 Files: clang/test/Preprocessor/predefined-arch-macros.c llvm/li

[PATCH] D97533: [Clang][Coroutine][DebugInfo] remove useless debug info for coroutine parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a6a80b641bc: [Clang][Coroutine][DebugInfo] In c++ coroutine, clang will emit different debug… (authored by yifeng.dongyifeng

[clang] 3a6a80b - [Clang][Coroutine][DebugInfo] In c++ coroutine, clang will emit different debug info variables for parameters and move-parameters.

Author: yifeng.dongyifeng Date: 2021-04-12T11:10:47+08:00 New Revision: 3a6a80b641bcffc570d5bc187b45f7bb9a2e7ce2 URL: https://github.com/llvm/llvm-project/commit/3a6a80b641bcffc570d5bc187b45f7bb9a2e7ce2 DIFF: https://github.com/llvm/llvm-project/commit/3a6a80b641bcffc570d5bc187b45f7bb9a2e7ce2.d

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing marked an inline comment as done. tianqing added a comment. Does anyone has further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D100279: [X86] Remove FeatureCLWB from FeaturesICLClient

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100279 Files: clang

[PATCH] D100127: [RISCV][Clang] Add some RVV Permutation intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59d5b8c27b43: [RISCV][Clang] Add some RVV Permutation intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D99965: [RISCV][Clang] Add more RVV load/store intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5a821926407: [RISCV][Clang] Add more RVV load/store intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99965/new/ htt

[PATCH] D99964: [RISCV][Clang] Add all RVV Reduction intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc680b0dabf36: [RISCV][Clang] Add all RVV Reduction intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98a3ff9d0525: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG007ea0e73643: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGccc624bfd417: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. In D100085#2682080 , @craig.topper wrote: > Thanks. I also found this > https://github.com/gcc-mirror/gcc/commit/c422e5f81f42a0fc197f0715f4fcd81f1be90bff >can you create a new patch to do the same for llvm/clang and rebase

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added a comment. Thanks. I also found this https://github.com/gcc-mirror/gcc/commit/c422e5f81f42a0fc197f0715f4fcd81f1be90bff can you create a new patch to do the same for llvm/clang and rebase this patch on top of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB,

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe marked an inline comment as done. FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB,

[PATCH] D100276: [clang] p1099 using enum part 1

urnathan created this revision. urnathan added reviewers: rsmith, Quuxplusone, bruno. urnathan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for p1099's 'using SCOPED_ENUM::MEMNER;' functionality, bringing a member of an

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 336690. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 Files: clang-tools-extra/clang-query/CMakeLists.txt clang-tools-extra/clan

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

rjmccall added a reviewer: t.p.northover. rjmccall added a comment. You should probably talk it over with AArch64 backend folks, but yes, abstractly it seems reasonable. CC'ing Tim Northover. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100225/ne

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1585-1586 InitializedEntity Entity = InitializedEntity::InitializeVariable(GroDecl); - ExprResult Res = S.PerformMoveOrCopyInitialization(Entity, nullptr, GroType, -

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

asavonic added a comment. So we can just remove this rounding from `classifyReturnType`? Thanks a lot John! I will upload this change as a separate review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100225/new/ https://reviews.llvm.org/D100225

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

rjmccall added a comment. AArch64 only has 64-bit integer registers, so of course the algorithm is specified that way. LLVM could nonetheless choose to return an `i32`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100225/new/ https://reviews.llv

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

asavonic added a comment. In D100225#2681809 , @rjmccall wrote: > Why does the ABI "require" this to be returned as an i64 if some of the bits > are undefined? AArch64 ABI requires return values (of composite types) to be rounded up to 64 bits (see `AA

[PATCH] D100225: [Clang][AArch64] Coerce integer return values through an undef vector

rjmccall added a comment. Why does the ABI "require" this to be returned as an i64 if some of the bits are undefined? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100225/new/ https://reviews.llvm.org/D100225 _

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,

[PATCH] D99965: [RISCV][Clang] Add more RVV load/store intrinsic functions.

khchen updated this revision to Diff 33. khchen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99965/new/ https://reviews.llvm.org/D99965 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. I simplified the description at the top in light of feedback (some harder issues we are just punting on for now). @compnerd does this now look good to you then? Does anyone want to approve the libunwind said of things? Anything else this is waiting on? Repository:

[PATCH] D99231: [AST] Add introspection support for more base nodes

njames93 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2270 SourceLocation getEllipsisLoc() const { -assert(isPackExpansion() && "Initializer is not a pack expansion"); +if (!isPackExpansion()) + return {}; I'm not sure abou

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 336652. steveire added a comment. Herald added a subscriber: mgorny. Herald added a project: clang-tools-extra. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire updated this revision to Diff 336651. steveire added a comment. Add locations for CXXBaseSpecifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 Files: clang/include/clang/AST/DeclCXX.h clang

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri added a subscriber: aaron.ballman. lebedev.ri added a comment. ping @rsmith @rjmccall @aaron.ballman To spell this out explicitly: i'm afraid i'm not really sure how to fix this preexisting thunk irgen bug. I think it should be fixed in `CodeGenVTables::maybeEmitThunk()`, likely in `

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:742 FeatureGFNI, FeatureCLWB, FeatureRDPID,