[PATCH] D99663: [clang-cl] [Sema] Do not prefer integral conversion over floating-to-integral for MS compatibility 19.28 and higher.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ec7f639c49f: [clang-cl] [Sema] Do not prefer integral conversion over floating-to-integral… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 2ec7f63 - [clang-cl] [Sema] Do not prefer integral conversion over floating-to-integral for MS compatibility 19.28 and higher.

Author: Marek Kurdej Date: 2021-04-02T08:58:22+02:00 New Revision: 2ec7f639c49fdee8956a09994d1cf99ef4282746 URL: https://github.com/llvm/llvm-project/commit/2ec7f639c49fdee8956a09994d1cf99ef4282746 DIFF: https://github.com/llvm/llvm-project/commit/2ec7f639c49fdee8956a09994d1cf99ef4282746.diff

[PATCH] D99190: [SYCL] Add design document for SYCL mode

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/docs/SYCLSupport.md:51 +virtual calls), generates LLVM IR for the device code only and an "integration +header" which provides information like kernel name, parameters order and data +type for

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked an inline comment as done. benshi001 added a comment. In D97669#2661560 , @Anastasia wrote: > Is `stdio.h` used by anything? No. `stdio.h` is not used. But if I do `#include `, then `-I /usr/lib/avr/include` must be specified in the com

[PATCH] D99711: [RISCV] [1/2] Add intrinsic for Zbc extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM. We can adjust the builtin names in the future if we need to do something different to match gcc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D99009: [RISCV] [1/2] Add intrinsic for Zbr extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM. We can adjust the builtin names in the future if we need to do something different to match gcc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. I'm going to approve this. If we need to change the builtin names in the future that's easy enough to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added a comment. I added tests for all the cases you mentioned. PTAL. Comment at: clang/lib/CodeGen/CGCall.cpp:5315-5317 +// TODO(haberman): insert checks/assertions to verify that this early exit +// is safe. We tried to verify this in Sema but we should doubl

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 334890. haberman marked 6 inline comments as done. haberman added a comment. - Addressed more comments for musttail. - Reject constructors and destructors from musttail. - Fixed a few bugs and fixed the tests. - Added Obj-C test. Repository: rG LLVM Githu

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:356 +void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, + ArgStringList &CC1Args) const

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

NoQ added a comment. What about `clang_analyzer_getExtent(&x[2])` then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99658/new/ https://reviews.llvm.org/D99658 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D99659: [analyzer][taint] Extent of heap regions should get taint sometimes

NoQ added a comment. This will be obsoleted by D69726 because they are going to be the same symbol to begin with. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99659/new/ https://reviews.llvm.org/D99659 _

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I don't see any further bugs so I think this is good to go! I think you should separate out the NFC / debugging facility changes before committing. Comment at: clang/lib/StaticAn

[PATCH] D99237: [AVR][clang] Fix wrong calling convention in functions return struct type

benshi001 updated this revision to Diff 334885. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99237/new/ https://reviews.llvm.org/D99237 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/struct.c ==

[PATCH] D99712: [RISCV] [2/2] Add intrinsic for Zbc extension

LevyHsu updated this revision to Diff 334883. LevyHsu added a comment. 1. clang/lib/Headers/riscv_zbc_intrin.h - Renaming clmul_h clmul_r to clmulh clmulr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99712/new/ https://reviews.llvm.org/D99712 F

[PATCH] D99711: [RISCV] [1/2] Add intrinsic for Zbc extension

LevyHsu updated this revision to Diff 334882. LevyHsu marked 2 inline comments as done. LevyHsu added a comment. 1. clang/include/clang/Basic/BuiltinsRISCV.def clang/lib/CodeGen/CGBuiltin.cpp llvm/include/llvm/IR/IntrinsicsRISCV.td clang/test/CodeGen/RISCV/rvb-intrinsics/riscv32-zbc.c clang/tes

[PATCH] D99711: [RISCV] [1/2] Add intrinsic for Zbc extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:22 +TARGET_BUILTIN(__builtin_riscv_clmul, "LiLiLi", "nc", "experimental-zbc") +TARGET_BUILTIN(__builtin_riscv_clmul_h, "LiLiLi", "nc", "experimental-zbc") +TARGET_BUILTIN(__builtin_riscv_c

[clang] f026e1f - [debug-info][XCOFF] set `-gno-column-info` by default for DBX

Author: Chen Zheng Date: 2021-04-01T21:29:11-04:00 New Revision: f026e1f5205562aad32e3d78b75140798b0dd60a URL: https://github.com/llvm/llvm-project/commit/f026e1f5205562aad32e3d78b75140798b0dd60a DIFF: https://github.com/llvm/llvm-project/commit/f026e1f5205562aad32e3d78b75140798b0dd60a.diff LO

[PATCH] D98912: Fix -Winteger-overflow to diagnose regardless of the top-level syntactic form.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:972-973 +// Determine if we might warn that the given expression exhibits undefined +// behavior. +bool mightWarnOnUndefinedBehavior(const Expr *E) { vsapsai wrote: > I'm not e

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

probinson added a reviewer: dblaikie. probinson added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArc

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

probinson added a comment. FastISel is normally used only at -O0, I wouldn't expect any parameters to be optimized out at -O0. The test is running llc with default optimization, which is -O2, and forcing fast-isel; this is not a usual combination and I wouldn't expect us to spend any effort mak

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. > Would you be ok with reverting this change until I can sort that out, or can > we disable the pass for those targets until then? I will disable the pass for those targets for now. When the issue is resolved, I would like to enable it for those targets as well. ==

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. I agree with you. If it's not going to work, maybe there should have been a warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99661/new/ https://reviews.llvm.org/D99661 ___

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 334855. tentzen added a comment. Removed some files (mostly for Part 2 of this feature) that were accidentally put in last revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llv

[PATCH] D99775: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3db73341ae: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2c3db73 - [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

Author: Thomas Preud'homme Date: 2021-04-02T00:39:21+01:00 New Revision: 2c3db73341aea084e44600400e9fe39690416923 URL: https://github.com/llvm/llvm-project/commit/2c3db73341aea084e44600400e9fe39690416923 DIFF: https://github.com/llvm/llvm-project/commit/2c3db73341aea084e44600400e9fe39690416923.

[PATCH] D99771: [OpenMP, test] Fix use of undef DECL FileCheck var

This revision was automatically updated to reflect the committed changes. Closed by commit rG58e458935ba6: [OpenMP, test] Fix use of undef DECL FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99771/new/ https://revi

[clang] 58e4589 - [OpenMP, test] Fix use of undef DECL FileCheck var

Author: Thomas Preud'homme Date: 2021-04-02T00:36:56+01:00 New Revision: 58e458935ba6debed11edd9baa98862db0a12651 URL: https://github.com/llvm/llvm-project/commit/58e458935ba6debed11edd9baa98862db0a12651 DIFF: https://github.com/llvm/llvm-project/commit/58e458935ba6debed11edd9baa98862db0a12651.

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd222a07d3023: [OpenMP, test] Fix uses of undef S*VAR FileCheck var (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] d222a07 - [OpenMP, test] Fix uses of undef S*VAR FileCheck var

Author: Thomas Preud'homme Date: 2021-04-02T00:36:14+01:00 New Revision: d222a07d3023599b8090ed20ca9137b128f5af6c URL: https://github.com/llvm/llvm-project/commit/d222a07d3023599b8090ed20ca9137b128f5af6c DIFF: https://github.com/llvm/llvm-project/commit/d222a07d3023599b8090ed20ca9137b128f5af6c.

[PATCH] D99775: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99775/new/ https://reviews.llvm.org/D99775 ___ c

[PATCH] D99775: [OpenMP, test] Fix use of undef VAR_PRIV FileCheck var

thopre created this revision. thopre added reviewers: ABataev, mikerice, jdoerfert, MaskRay. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Remove the CHECK-NOT directive referrin

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT updated this revision to Diff 334848. oToToT added a comment. Remove redundant trailing spaces. Sorry for not checking this at the first time I submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new/ https://reviews.llvm.org/D99407

[clang] cba4222 - [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

Author: cchen Date: 2021-04-01T18:07:12-05:00 New Revision: cba422264c7fdb7ba717144c94d48d46d72d8479 URL: https://github.com/llvm/llvm-project/commit/cba422264c7fdb7ba717144c94d48d46d72d8479 DIFF: https://github.com/llvm/llvm-project/commit/cba422264c7fdb7ba717144c94d48d46d72d8479.diff LOG: [O

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcba422264c7f: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

thopre updated this revision to Diff 334846. thopre added a comment. Fix one more testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99770/new/ https://reviews.llvm.org/D99770 Files: clang/test/OpenMP/for_firstprivate_codegen.cpp clang/tes

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

rsmith added a comment. Thanks, this makes sense. Comment at: clang/lib/AST/Decl.cpp:2192 DefinitionKind Kind = isThisDeclarationADefinition(); - if (Kind != TentativeDefinition) + if (Kind != TentativeDefinition || hasDefinition()) return nullptr; Is

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen updated this revision to Diff 334844. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/parallel_ast_print.cpp

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT updated this revision to Diff 334840. oToToT added a comment. Updated tests to check mangled type name. However, I not sure whether it is proper to put the tests here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new/ https://reviews

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

aganea added a comment. I am still concerned by the fact that this patch doesn't fix the issue mentionned in https://reviews.llvm.org/D96363#2650460 Was the intention to fix that issue? Will the fix be done in a subsequent patch? Comment at: llvm/lib/Support/Windows/Path.inc:1

[PATCH] D99771: [OpenMP, test] Fix use of undef DECL FileCheck var

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99771/new/ https://reviews.llvm.org/D99771 _

[PATCH] D99758: [index] Improve macro indexing support

benlangmuir updated this revision to Diff 334837. benlangmuir added a comment. Fix clang-tidy warnings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99758/new/ https://reviews.llvm.org/D99758 Files: clang/include/clang/Index/DeclOccurrence.h clang/include/clang/Index/IndexingOption

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D99426#2664883 , @abhina.sreeskantharajan wrote: > In D99426#2664841 , @MaskRay wrote: > >> /// The fil

[PATCH] D99771: [OpenMP, test] Fix use of undef DECL FileCheck var

thopre created this revision. thopre added reviewers: cchen, ABataev, MaskRay. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. OpenMP test targe

[PATCH] D99770: [OpenMP, test] Fix uses of undef S*VAR FileCheck var

thopre created this revision. thopre added reviewers: ABataev, MaskRay, jdoerfert. Herald added subscribers: guansong, yaxunl. thopre requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Fix the many cases of use of undefined SIVAR/SVAR

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added a comment. In the future, please include `Differential Revision: ` for relands so that the `Commits` line displays the associated commits :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 __

[clang] 6fe7de9 - [Driver] -nostdinc -nostdinc++: don't warn for -Wunused-command-line-argument

Author: Fangrui Song Date: 2021-04-01T14:37:34-07:00 New Revision: 6fe7de90b9e4e466a5c2baadafd5f72d3203651d URL: https://github.com/llvm/llvm-project/commit/6fe7de90b9e4e466a5c2baadafd5f72d3203651d DIFF: https://github.com/llvm/llvm-project/commit/6fe7de90b9e4e466a5c2baadafd5f72d3203651d.diff

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added inline comments. Comment at: polly/cmake/CMakeLists.txt:82-96 +set(POLLY_INSTALL_PREFIX "") set(POLLY_CONFIG_LLVM_CMAKE_DIR "${LLVM_BINARY_DIR}/${LLVM_INSTALL_PACKAGE_DIR}") -set(POLLY_CONFIG_CMAKE_DIR "${POLLY_INSTALL_PREFIX}/${POLLY_INSTALL_PACKAGE_DIR}") -s

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

hjl.tools added a comment. In D99708#2664372 , @craig.topper wrote: > In D99708#2664351 , @hjl.tools wrote: > >> In D99708#2664218 , @craig.topper >> wrote: >> >>> In D9970

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

phosek added a comment. @beanz do you know if `clang/runtime` is still being used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99755/new/ https://reviews.llvm.org/D99755 ___ cfe-commits mailing list cf

[PATCH] D99663: [clang-cl] [Sema] Do not prefer integral conversion over floating-to-integral for MS compatibility 19.28 and higher.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Slowly we will peel back the layers of compatibility hacks until both compilers conform. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99663/

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 added a comment. Relanded without -fno-initegrated-as case at https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 ___

[PATCH] D99758: [index] Improve macro indexing support

benlangmuir updated this revision to Diff 334820. benlangmuir added a comment. Fix the incomplete type issue with PointerUnion in DeclOccurrence. h. I'm not actually sure how that code compiles without error with other versions of clang. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[clang] 76d9bc7 - Reland "Add support to -Wa,--version in clang""

Author: Jian Cai Date: 2021-04-01T13:47:56-07:00 New Revision: 76d9bc72784d88f4dd57b9939e52c73739438af5 URL: https://github.com/llvm/llvm-project/commit/76d9bc72784d88f4dd57b9939e52c73739438af5 DIFF: https://github.com/llvm/llvm-project/commit/76d9bc72784d88f4dd57b9939e52c73739438af5.diff LOG:

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. In D99037#2665082 , @SaurabhJha wrote: > Hi Florian and John, > > Thanks for the comments so far. I figure it would be easier for further > discussion if I have something concrete. Here's what I have right now: > > - A new CK_Matrix

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 334815. SaurabhJha added a comment. Herald added a subscriber: martong. Hi Florian and John, Thanks for the comments so far. I figure it would be easier for further discussion if I have something concrete. Here's what I have right now: - A new CK_MatrixC

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

On Thu, Apr 1, 2021 at 8:11 PM David Blaikie wrote: > On Thu, Apr 1, 2021 at 1:16 AM Florian Hahn wrote: > > > > Hi, > > > > On Tue, Mar 30, 2021 at 7:52 PM David Blaikie > wrote: > >> > >> Is there a more reliable remark that could be tested for? (Clang > shouldn't be testing all remarks - jus

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. In D99037#2665030 , @SaurabhJha wrote: > Hey, elementary question about arcanist. I followed the steps here > https://llvm.org/docs/Contributing.html#how-to-submit-a-patch and did > > arc diff --edit --verbatim > > on my current b

[PATCH] D99758: [index] Improve macro indexing support

benlangmuir updated this revision to Diff 334808. benlangmuir added a comment. Fixed clang-format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99758/new/ https://reviews.llvm.org/D99758 Files: clang/include/clang/Index/DeclOccurrence.h clang/include/clang/Index/IndexingOpti

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. Hey, elementary question about arcanist. I followed the steps here https://llvm.org/docs/Contributing.html#how-to-submit-a-patch and did arc diff --edit --verbatim on my current branch. Probably one mistake I did was to do a `git reset HEAD~1` and create a new com

[PATCH] D99455: [AST] Store regular ValueDecl* in BindingDecl

aaronpuchert added a comment. Ping @rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99455/new/ https://reviews.llvm.org/D99455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D99765: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha added a comment. Sorry, this revision was created by mistake. I just wanted to update https://reviews.llvm.org/D99037 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99765/new/ https://reviews.llvm.org/D99765

[PATCH] D99765: [Matrix] Implement explicit type conversions for matrix types

SaurabhJha created this revision. Herald added subscribers: martong, tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [Matrix] Implement explicit type conversions for MatrixType. Bugzilla ticket is here: https://bugs.llv

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3974 + // Microsoft debuggers don't handle missing end columns well, and the AIX + // debugger DBX a

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

This revision was automatically updated to reflect the committed changes. Closed by commit rG69ca50bd7dfd: [OpenMP] Pass mapping names to add components in a user defined mapper (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D996

[clang] 69ca50b - [OpenMP] Pass mapping names to add components in a user defined mapper

Author: Joseph Huber Date: 2021-04-01T15:51:03-04:00 New Revision: 69ca50bd7dfdb54aab8b0b262df635e25cf6baf0 URL: https://github.com/llvm/llvm-project/commit/69ca50bd7dfdb54aab8b0b262df635e25cf6baf0 DIFF: https://github.com/llvm/llvm-project/commit/69ca50bd7dfdb54aab8b0b262df635e25cf6baf0.diff

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

erik.pilkington updated this revision to Diff 334801. erik.pilkington added a comment. In D99661#2662601 , @ahatanak wrote: > Should we try to restore the behavior prior to > https://reviews.llvm.org/rG09abecef7bbfda18d34f046954eaa4d491062839 as much > a

[PATCH] D99762: [OPENMP]Fix PR49777: Clang should not try to specialize orphaned directives in device codegen.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Compiler supports generic code emission, but in some cases may erroneously

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added a comment. I've tried to think of some more exotic corner cases. I'd like to see a test for this: void f(); struct A { ~A() { [[clang::musttail]] return f(); } }; ... even though we reject that for a reason unrelated to musttail. We should also reject this: struct B {}; voi

[clang] d4e9fe8 - [OpenCL][Docs] Update links to the C++ for OpenCL documentation

Author: Anastasia Stulova Date: 2021-04-01T20:38:24+01:00 New Revision: d4e9fe813f4fabc260f8e859cf2846cb34e0ad3b URL: https://github.com/llvm/llvm-project/commit/d4e9fe813f4fabc260f8e859cf2846cb34e0ad3b DIFF: https://github.com/llvm/llvm-project/commit/d4e9fe813f4fabc260f8e859cf2846cb34e0ad3b.d

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2664841 , @MaskRay wrote: > /// The file should be opened in text mode on platforms like z/OS that make > /// this distinction. > OF_Text = 1, > F_Text = 1, // For compatibility > > /// The fi

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334792. abhina.sreeskantharajan added a comment. Update comment in FileSystem.h for OF_TextWithCRLF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426 File

Re: [clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

On Thu, Apr 1, 2021 at 1:16 AM Florian Hahn wrote: > > Hi, > > On Tue, Mar 30, 2021 at 7:52 PM David Blaikie wrote: >> >> Is there a more reliable remark that could be tested for? (Clang shouldn't >> be testing all remarks - just that the remark infrastructure in general is >> wired up (specifi

[PATCH] D99758: [index] Improve macro indexing support

benlangmuir created this revision. benlangmuir added reviewers: akyrtzi, sammccall. Herald added a subscriber: arphaman. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The major change here is to index macro occurrences in more

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. /// The file should be opened in text mode on platforms like z/OS that make /// this distinction. OF_Text = 1, F_Text = 1, // For compatibility /// The file should use a carriage linefeed '\r\n'. /// Only makes a difference on windows. OF_CRLF = 2, //

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. @MaskRay is there still any confusion about the problem this patch is trying to solve and concerns about the renaming? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D9942

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

rjmccall added a comment. In D99037#2662414 , @fhahn wrote: > In D99037#2659477 , @SaurabhJha > wrote: > >>> What code do you want to get out of this? Are there e.g. vectorized >>> float->double conversions we ca

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 updated this revision to Diff 334780. Ericson2314 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Also remove `clang/runtime` from a TODO comment elsewhere in the tree I put `runtimes` in there as it's evidentially its spiritual successor. Rep

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/${CM

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:95 set(COMPILER_RT_LIBRARY_INSTALL_DIR -${COMPILER_RT_INSTALL_PATH}) +"") else(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR) I'm a bit confused we'd ever want too install libs

[PATCH] D99755: Remove clang/runtime and `COMPILER_RT_INSTALL_PATH`

Ericson2314 created this revision. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch removes those in order to simplify things for D99484

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia added inline comments. Comment at: clang/docs/SYCLSupport.md:830 +Similar to other single-source C++-based GPU programming modes like +OpenMP/CUDA/HIP, SYCL uses clang's "default" address space for types with no +address space attributes. This design has two important f

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. I haven't looked extensively yet, but why import noinline functions? Also, please add a patch description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99683/new/ https://reviews.llvm.org/D99683 ___ cfe-commits ma

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99681/new/ https://reviews.llvm.org/D99681 ___

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

jhuber6 updated this revision to Diff 334768. jhuber6 added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99681/new/ https://reviews.llvm.org/D99681 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMP

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334765. Ericson2314 added a comment. Rebase now that previous diff landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/

[PATCH] D99740: Avoid calling ParseCommandLineOptions in BackendUtil if possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60854c328d87: Avoid calling ParseCommandLineOptions in BackendUtil if possible (authored by teemperor). Herald added a subscriber: cfe-commits. Repo

[clang] 60854c3 - Avoid calling ParseCommandLineOptions in BackendUtil if possible

Author: Raphael Isemann Date: 2021-04-01T19:41:16+02:00 New Revision: 60854c328d8729b2ef10b9bb4dcbcc282f43c5e7 URL: https://github.com/llvm/llvm-project/commit/60854c328d8729b2ef10b9bb4dcbcc282f43c5e7 DIFF: https://github.com/llvm/llvm-project/commit/60854c328d8729b2ef10b9bb4dcbcc282f43c5e7.dif

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

kito-cheng added a comment. Created an issue for continue discuses on riscv-c-api-doc https://github.com/riscv/riscv-c-api-doc/issues/19 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99320/new/ https://reviews.llvm.org/D99320 _

[PATCH] D99683: [HIP] Support ThinLTO

tra accepted this revision. tra added a subscriber: tejohnson. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Please give LTO folks some time to chime in case they have any feedback. @tejohnson: Just a FYI that we're tinkering with LTO on GPUs here. ===

[PATCH] D93095: Introduce -Wreserved-identifier

rsmith added a comment. In D93095#2663639 , @serge-sans-paille wrote: > Warn on friend functions. I failed to support friend classes, but they are > only declared and not defined, so that should be fine, right? They can still conflict, so I think we sho

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

jdoerfert added a comment. A test please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99681/new/ https://reviews.llvm.org/D99681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added a comment. In D99556#2664426 , @nickdesaulniers wrote: > In D99556#2662990 , @jcai19 wrote: > >> We can probably remove the -fno-integraetd-as case. > > Or split it out into a separate test file with

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. In D99556#2662990 , @jcai19 wrote: > We can probably remove the -fno-integraetd-as case. Or split it out into a separate test file with `// REQUIRES: linux`. Either actually is fine by me. Repository: rG LLVM Github

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. In D93822#2664157 , @aaron.ballman wrote: > The CI is showing build failures and there are some clang-tidy nits to be > addressed as well. Thank you for taking a look! =

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334713. Ericson2314 added a comment. Rebase on newer version of previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/t

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

craig.topper added a comment. In D99708#2664351 , @hjl.tools wrote: > In D99708#2664218 , @craig.topper > wrote: > >> In D99708#2664164 , @hjl.tools >> wrote: >> >>> In D99

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

hjl.tools added a comment. In D99708#2664218 , @craig.topper wrote: > In D99708#2664164 , @hjl.tools wrote: > >> In D99708#2664076 , @LuoYuanke >> wrote: >> >>> In D99708#2

[PATCH] D99688: [CUDA][HIP] rename -fcuda-flush-denormals-to-zero

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/cuda-flush-denormals-to-zero.cu:2 // Checks that cuda compilation does the right thing when passed -// -fcuda-flush-denormals-to-zero. This shoul

[PATCH] D99738: [HIP] remove overloaded abs in header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85ff35a9529a: [HIP] remove overloaded abs in header (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHAN

  1   2   >