[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + aaronpuchert wrote: > jlebar wrote: > > aaronpuchert wrote: > > > Why not in the following `if`? I assume we want to show a long

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge added a comment. Ok, I've made `HeuristicResolver` nullable, in the sense that I've added null checks arounds its use in `TargetFinder`. I haven't refactored the tests to pass in a null resolver / annotate the ones that do or don't need one. Would you like that done in this patch, or a

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge updated this revision to Diff 323886. nridge marked 10 inline comments as done. nridge added a comment. Rebase and address remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 Files:

[PATCH] D96751: [clangd] Populate detail field in document symbols

lightmelodies created this revision. lightmelodies added reviewers: sammccall, kadircet. lightmelodies added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lightmelodies requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. H

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

poelmanc created this revision. poelmanc added reviewers: MyDeveloperDay, hokein, sammccall. poelmanc added projects: clang-tools-extra, clang-format. poelmanc requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most modern libraries and applic

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 -The improvements are... +- New :doc:`bugprone-thread-canceltype-asynchronous + ` check. Please add subsections for new checks and aliases. Looks like they were remove

[PATCH] D96738: [docs] Fix doxygen comments wrongly attached to the clang namespace

nicolas17 created this revision. Herald added a subscriber: zzheng. nicolas17 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looking at the Doxygen-generated documentation for the clang namespace currently shows several random comments fro

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

nridge abandoned this revision. nridge added a comment. Abandoning as this was superseded by D77811 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66990/new/ https://reviews.llvm.org/D66990 ___

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

nridge abandoned this revision. nridge added a comment. Abandoning as this was superseded by { D77811 , D95701 , D95706 }. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D95753: Store compilation dir separately in coverage mapping

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1131 NegFlag, BothFlags<[CoreOption]>>; +def fcoverage_compilation_dir : Separate<["-"], "fcoverage-compilation-dir">, +Group, Flags<[CC1Option, CC1AsOption, CoreOption]>, Us

[PATCH] D95753: Store compilation dir separately in coverage mapping

MaskRay added a comment. (I haven't read through the discussion.) -fprofile-prefix-map has been added. Does this option has overlap with that option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 __

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

njames93 added a comment. I'm a little confused here, Typically if a commit is breaking bots a review doesn't need to be opened to revert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665 ___

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

njames93 added a comment. In D96142#2547418 , @steveire wrote: > In D96142#2545078 , @njames93 wrote: > >> I'm not sure about this. The warning is good and addresses a real problem. > > Well, I've made the diagnosti

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

aaronpuchert added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + jlebar wrote: > aaronpuchert wrote: > > Why not in the following `if`? I assume we want to show a long list not > > necess

[PATCH] D96222: [clang-tidy] Simplify redundant smartptr get check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp:21-45 + return expr( + anyOf(cxxMemberCallExpr( + on(expr(anyOf(hasType(OnClass), + hasType(q

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

steveire accepted this revision. steveire added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-using.cpp:305 }; + +extern "C" { njames93 wrote: > steveire wrote: > > Can you

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:19 +AST_MATCHER(Decl, isInExternC) { + return Node.getDeclContext()->isExternCContext(); This matcher may be useful for other checks, for example, `mode

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. One more mention. There are a lot of popups like this which stops the process untill press OK. F15539777: test_err.png That's very annoying. Please revert or fix this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96138/new/ https://reviews.llvm.org/D96138 _

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-using.cpp:305 }; + +extern "C" { steveire wrote: > Can you add tests for typedefs in other scopes like > > ``` > > extern "C" { > typedef int CType; > > stru

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov reopened this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. This patch causes fails in a bunch of test files. When I roll it back, it passes. Below you can see fail out

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5215 + Expr *NegIncAmount = + AssertSuccess(Actions.BuildUnaryOp(nullptr, {}, UO_Minus, NewStep)); + Expr *BackwardDist = AssertSuccess( Meinersbur wrote: > jdenny wrot

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

sammccall accepted this revision. sammccall added a comment. Thanks! Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:101 // Compute absolute paths to all ancestors (substrings of P.Path). llvm::StringRef Parent = path::parent_path(P.Path); llvm::Sma

[PATCH] D96730: [clangd] Modules can have a public API. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Mono

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

kadircet updated this revision to Diff 323820. kadircet added a comment. - Expose absoluteParent instead of whole traverse action - Use helper in existing places that use path::parent_path for traversal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

kadircet marked an inline comment as done. kadircet added a comment. > maybe we should expose absoluteParent instead? doing that instead. also updating tidyprovider and configyamlparser to make use of this helper now, PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang-tools-extra] 4d700fb - [clangd] Pass raw client capabilities to modules. NFC

Author: Sam McCall Date: 2021-02-15T20:57:14+01:00 New Revision: 4d700fb0603e6fbdd6f597443b29414f7e133912 URL: https://github.com/llvm/llvm-project/commit/4d700fb0603e6fbdd6f597443b29414f7e133912 DIFF: https://github.com/llvm/llvm-project/commit/4d700fb0603e6fbdd6f597443b29414f7e133912.diff LO

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

steveire added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-using.cpp:305 }; + +extern "C" { Can you add tests for typedefs in other scopes like ``` extern "C" { typedef int CType; struct CAnother { }; typedef struct

[PATCH] D95814: [NFC] Simplify test to use multiple FileCheck prefixes.

aschwaighofer accepted this revision. aschwaighofer added a comment. This revision is now accepted and ready to land. LGTM Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95814/new/ https://reviews.llvm.org/D95814 ___

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 323810. sammccall added a comment. Remove fixedme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ https://reviews.llvm.org/D96717 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-

[PATCH] D96726: [clangd] Give modules access to filesystem, scheduler, and index.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This finally makes it possible to

[PATCH] D95928: [OpenMP] Delay more diagnostics of potentially non-emitted code

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jdoerfert marked 2 inline comments as done. Closed by commit rG1dd66e6111a8: [OpenMP] Delay more diagnostics of potentially non-emitted code (authored by jdoerfert). R

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9286b434b76: [OpenMP] Attribute target diagnostics properly (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 1dd66e6 - [OpenMP] Delay more diagnostics of potentially non-emitted code

Author: Johannes Doerfert Date: 2021-02-15T13:17:05-06:00 New Revision: 1dd66e6111a8247c6c7931143251c0cf1442b905 URL: https://github.com/llvm/llvm-project/commit/1dd66e6111a8247c6c7931143251c0cf1442b905 DIFF: https://github.com/llvm/llvm-project/commit/1dd66e6111a8247c6c7931143251c0cf1442b905.d

[clang] f9286b4 - [OpenMP] Attribute target diagnostics properly

Author: Johannes Doerfert Date: 2021-02-15T13:16:55-06:00 New Revision: f9286b434b764b366f1aad9249c04e7741ed5518 URL: https://github.com/llvm/llvm-project/commit/f9286b434b764b366f1aad9249c04e7741ed5518 DIFF: https://github.com/llvm/llvm-project/commit/f9286b434b764b366f1aad9249c04e7741ed5518.d

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b2f19d0bc28: [OpenMP][NFC] Pre-commit test changes regarding PR48933 (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3b2f19d - [OpenMP][NFC] Pre-commit test changes regarding PR48933

Author: Johannes Doerfert Date: 2021-02-15T13:16:44-06:00 New Revision: 3b2f19d0bc2803697526191a8a607efa0b38f7e4 URL: https://github.com/llvm/llvm-project/commit/3b2f19d0bc2803697526191a8a607efa0b38f7e4 DIFF: https://github.com/llvm/llvm-project/commit/3b2f19d0bc2803697526191a8a607efa0b38f7e4.d

[PATCH] D95928: [OpenMP] Delay more diagnostics of potentially non-emitted code

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95928/new/ https://reviews.llvm.org/D95928

[PATCH] D96360: [CMake] Delete LLVM_RUNTIME_BUILD_ID_LINK_TARGETS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02413b097e72: [CMake] Delete LLVM_RUNTIME_BUILD_ID_LINK_TARGETS (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 02413b0 - [CMake] Delete LLVM_RUNTIME_BUILD_ID_LINK_TARGETS

Author: Fangrui Song Date: 2021-02-15T11:06:23-08:00 New Revision: 02413b097e72a3aab17e0504af135a95c0d300a1 URL: https://github.com/llvm/llvm-project/commit/02413b097e72a3aab17e0504af135a95c0d300a1 DIFF: https://github.com/llvm/llvm-project/commit/02413b097e72a3aab17e0504af135a95c0d300a1.diff

[PATCH] D95928: [OpenMP] Delay more diagnostics of potentially non-emitted code

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18345 if (LangOpts.OpenMPIsDevice) { +// In OpenMP device mode we will not emit host only functions, or functions +// we don't need due to their linkage

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert updated this revision to Diff 323799. jdoerfert marked an inline comment as done. jdoerfert added a comment. Rename variable as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95912/new/ https://reviews.llvm.org/D95912 Files: c

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

njames93 updated this revision to Diff 323796. njames93 added a comment. Newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96725/new/ https://reviews.llvm.org/D96725 Files: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp clang-to

[PATCH] D96725: [clang-tidy] Fix modernize-use-using in extern C code

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check currently erroneously flags typedefs in extern "C" blo

[PATCH] D96705: [clang][cli] Add explicit round-trip test

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96705/new/ https://reviews.llvm.org/D96705

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

isthismyaccount accepted this revision. isthismyaccount added a comment. This revision is now accepted and ready to land. LGTM on my part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commit

[PATCH] D96608: [clangd] Delay binding LSP methods until initialize. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c5f17e701ff: [clangd] Delay binding LSP methods until initialize. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 6c5f17e - [clangd] Delay binding LSP methods until initialize. NFC

Author: Sam McCall Date: 2021-02-15T19:33:40+01:00 New Revision: 6c5f17e701ff586d69a43b3cfc1e25314b84892d URL: https://github.com/llvm/llvm-project/commit/6c5f17e701ff586d69a43b3cfc1e25314b84892d DIFF: https://github.com/llvm/llvm-project/commit/6c5f17e701ff586d69a43b3cfc1e25314b84892d.diff LO

[PATCH] D96608: [clangd] Delay binding LSP methods until initialize. NFC

sammccall updated this revision to Diff 323793. sammccall marked an inline comment as done. sammccall added a comment. address comments & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96608/new/ https://reviews.llvm.org/D96608 Files: clan

[PATCH] D96608: [clangd] Delay binding LSP methods until initialize. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:165 return false; -if (!Server.Server) { - elog("Notification {0} before initialization", Method); -} else if (Method == "$/ca

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:224 + if (const auto *C = dyn_cast(&ND)) +return printObjCContainer(*C); I'm not sure this fits with the contract of printName, which really is to print the name of the symbol r

[PATCH] D95928: [OpenMP] Delay more diagnostics of potentially non-emitted code

JonChesterfield added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:18345 if (LangOpts.OpenMPIsDevice) { +// In OpenMP device mode we will not emit host only functions, or functions +// we don't need due to their linkage. What catches a stat

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for addressing my comments. LGTM! Please add missing `newline` chars before merging ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. I agree this is an improvement on the current status and should land. Reading through it has made me nervous about our current semantic checking. In particular, I'm not sure

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

jdoerfert added a comment. Thanks for taking a look! Comment at: clang/lib/Sema/Sema.cpp:1798 + FunctionDecl *FD = + isa(C) ? cast(C) : dyn_cast(D); auto CheckType = [&](QualType Ty) { Fznamznon wrote: > So, we assume that lexical context is a function

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

ASDenysPetrov reopened this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. Hi, @abhina.sreeskantharajan. I've just updated my repo and got this patch. After your changes I caught a test fail specifically in my domain of Clang Static Analyzer. Here is out

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

jansvoboda11 added a comment. In D96572#2561216 , @delcypher wrote: > @jansvoboda11 I noticed that the `Options.td` file is making use of some > fancy mixins that mean the option gets automatically marshalled by the > frontend into the codegen options :)

[PATCH] D95754: [clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

jlebar added a comment. Thank you for your comments, Aaron! Comment at: clang/lib/Sema/Sema.cpp:2310 + S.Diags.noteNumOverloadCandidatesShown(ShownOverloads); + aaronpuchert wrote: > Why not in the following `if`? I assume we want to show a long list not >

[PATCH] D96719: [clang-tidy] Add new check 'bugprone-thread-canceltype-asynchronous' and alias 'cert-pos47-c'.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity, mgorny. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Simple check, code based on 'bugprone-bad-signal-to-ki

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The redundancy around work-done-progress

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

tskeith added inline comments. Comment at: clang/include/clang/Driver/Options.td:4231 +def flarge_sizes : Flag<["-"],"flarge-sizes">, Group, + HelpText<"Set the default KIND for INTEGER to 8.">; } That's not what -flarge-sizes does. Here is the description fro

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

jansvoboda11 added a comment. @Bigcheese I have addressed your feedback with the latest update. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95790/new/ https://reviews.llvm.org/D95790 ___ cfe-comm

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

jansvoboda11 updated this revision to Diff 323766. jansvoboda11 added a comment. Fix typos, add section heading above the list of marshalling classes, add new section (high-level overview of adding new command line option) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D96483: [flang][driver] Add options for unparsing

FarisRehman accepted this revision. FarisRehman added a comment. This revision is now accepted and ready to land. Thanks for clarifying Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 __

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D96483: [flang][driver] Add options for unparsing

awarzynski added a comment. In D96483#2563323 , @FarisRehman wrote: > Do you know what the use of `GetActionKindName` in `FrontendOptions.h` is, as > it is currently not being called anywhere and whilst this patch currently > does not update that method

[PATCH] D96483: [flang][driver] Add options for unparsing

awarzynski updated this revision to Diff 323756. awarzynski added a comment. Updated lit.cfg.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 Files: clang/include/clang/Driver/Options.td flang/include

[PATCH] D95912: [OpenMP] Attribute target diagnostics properly

Fznamznon added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1798 + FunctionDecl *FD = + isa(C) ? cast(C) : dyn_cast(D); auto CheckType = [&](QualType Ty) { So, we assume that lexical context is a function and if it is not, we assume that the va

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

steakhal added a comment. @ASDenysPetrov Could you please rebase this? `git apply` does not seem to apply this patch on top of `llvm/main`. If it depends on any parent revisions please document them as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.o

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 323746. arnamoy10 added a comment. Addressed latest reviewer's comments, no longer using a pointer for `defaultKinds` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Op

[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

pengfei created this revision. pengfei added reviewers: arlosi, rnk, thakis, ajpaverd, theraven, pcc. Herald added subscribers: dexonsmith, dang. Herald added a reviewer: jansvoboda11. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-comm

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added a comment. In D95877#2563383 , @davezarzycki wrote: > The test seems to be broken on Fedora 33 (x86-64 with clang-11): > > XPASS: Clang :: Analysis/reinterpret-cast-pointer-to-member.cpp (6531 of > 74360) > TEST

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. In D95877#2563383 , @davezarzycki wrote: > The test seems to be broken on Fedora 33 (x86-64 with clang-11): > > XPASS: Clang :: Analysis/reinterpret-cast-pointer-to-member.cpp (6531 of > 74360) > TEST 'C

[PATCH] D96690: [clangd] Treat paths case-insensitively depending on the platform

sammccall added a comment. Thanks for the important fix. This contains a mixture of changing comparison-of-paths to be case insensitive, and case-normalizing stored paths so we can use case-sensitive comparisons. I think we should stick to *only* changing comparison-of-path logic as much as po

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

davezarzycki added a comment. The test seems to be broken on Fedora 33 (x86-64 with clang-11): XPASS: Clang :: Analysis/reinterpret-cast-pointer-to-member.cpp (6531 of 74360) TEST 'Clang :: Analysis/reinterpret-cast-pointer-to-member.cpp' FAILED S

[PATCH] D96597: [DebugInfo] Keep the DWARF64 flag in the module metadata

ikudrin added a comment. Thank you, @dblaikie! Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:396 + bool Dwarf64 = + (Asm->TM.Options.MCOptions.Dwarf64 || MMI->getModule()->isDwarf64()) && + DwarfVersion >= 3 && // DWARF64 was introduced in DWARFv3. ---

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

Anastasia added a comment. FYI I have created `PR49191` for the issues with address spaces I have highlighted earlier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 __

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 __

[PATCH] D96483: [flang][driver] Add options for unparsing

FarisRehman added a comment. Thanks for working on this @awarzynski Could you please clarify the situation regarding `GetActionKindName` in `FrontendOptions.h` as it is currently not being used anywhere and this patch currently does not update that method with the 2 new cases. Other than that, l

[PATCH] D96112: [Syntax] No crash on OpaqueValueExpr.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96112/new/ https://reviews.llvm.org/D96112 __

[PATCH] D96123: [clangd] Expose actOnAllPArentDirectories helper

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/support/Path.h:33 +// deepest directory and going up to root. Stops whenever action succeeds. +void actOnAllParentDirectories(P

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

aganea added a comment. In D95534#2550998 , @thakis wrote: > In D95534#2534510 , @smeenai wrote: > >> I saw this on LLVM Weekly, and I like it a lot :) >> >> Now if only Windows could case-correct their SDKs so we d

[clang] 6f21ada - [analyzer][NFC] Fix test failures for builds w/o assertions

Author: Valeriy Savchenko Date: 2021-02-15T16:38:15+03:00 New Revision: 6f21adac6dd7082f7231ae342d40ed04f4885e79 URL: https://github.com/llvm/llvm-project/commit/6f21adac6dd7082f7231ae342d40ed04f4885e79 DIFF: https://github.com/llvm/llvm-project/commit/6f21adac6dd7082f7231ae342d40ed04f4885e79.d

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/lib/Basic/OpenCLOptions.cpp:24 + auto CLVer = LO.OpenCLCPlusPlus ? 200 : LO.OpenCLVersion; + return CLVer >= 300 ? isEnabled("__opencl_c_fp64") : isEnabled("cl_khr_fp64"); +} azabaznov wrote: > Anastasia wrote

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

Szelethus added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96705: [clang][cli] Add explicit round-trip test

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a test that verifies all `CompilerInvocation` members are filled correctl

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/implicit-none.f90:10 +! RUN: not %flang-new -fsyntax-only -fimplicit-none %s 2>&1 | FileCheck %s --check-prefix=ALWAYS +! RUN: %flang-new -fsyntax-only -fno-implicit-none %s 2>&1 | FileCheck %s --allow-emp

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman updated this revision to Diff 323717. FarisRehman marked 2 inline comments as done. FarisRehman added a comment. Address review comment This revision addresses a review comment by @awarzynski Summary of changes: - Rebase off the latest D96344 revisi

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. In D95877#2563220 , @RKSimon wrote: > @RedDocMD Please can you take a look at this buildbot failure: > http://lab.llvm.org:8011/#/builders/124 Yes. Thanks for the ping 😀 Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RKSimon added a comment. @RedDocMD Please can you take a look at this buildbot failure: http://lab.llvm.org:8011/#/builders/124 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 _

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski added a comment. LGTM, thank you for working on this @arnamoy10 ! I left a few _minor_ comments. These can be addressed in the actual commit. Comment at: clang/include/clang/Driver/Options.td:4224-4231 +def fdefault_double_8 : Flag<["-"],"fdefault-double-8">, Group,

[PATCH] D90691: [analyzer] Add new checker for unchecked return value.

balazske added a comment. There is a clang-tidy check bugprone-unused-return-value that may be confusing in relation to this checker. It does similar job for a selected set of functions and with different reason.

[PATCH] D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe54811ff7e0b: Restore diagnostic handler after CodeGenAction::ExecuteAction (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES

[clang] e54811f - Restore diagnostic handler after CodeGenAction::ExecuteAction

Author: Marco Antognini Date: 2021-02-15T10:33:00Z New Revision: e54811ff7e0bc99f337bcbb569311bb166187322 URL: https://github.com/llvm/llvm-project/commit/e54811ff7e0bc99f337bcbb569311bb166187322 DIFF: https://github.com/llvm/llvm-project/commit/e54811ff7e0bc99f337bcbb569311bb166187322.diff LO

[PATCH] D96625: [clangd] Allow modules to bind LSP methods/notifications/commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b55ecce45d7: [clangd] Allow modules to bind LSP methods/notifications/commands (authored by sammccall). Repository: rG LLVM Github Monorepo CHAN

[clang-tools-extra] 0b55ecc - [clangd] Allow modules to bind LSP methods/notifications/commands

Author: Sam McCall Date: 2021-02-15T11:00:14+01:00 New Revision: 0b55ecce45d7cc79b614bcb91cd070ab257227fc URL: https://github.com/llvm/llvm-project/commit/0b55ecce45d7cc79b614bcb91cd070ab257227fc DIFF: https://github.com/llvm/llvm-project/commit/0b55ecce45d7cc79b614bcb91cd070ab257227fc.diff LO

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 323696. reikdas added a comment. Address @rsmith comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td cl

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 7 inline comments as done. Closed by commit rG5786f64a4ec8: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC (authored by samm

[clang-tools-extra] 5786f64 - [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

Author: Sam McCall Date: 2021-02-15T10:48:14+01:00 New Revision: 5786f64a4ec806877f39fa0c28dcb90f9492b68c URL: https://github.com/llvm/llvm-project/commit/5786f64a4ec806877f39fa0c28dcb90f9492b68c DIFF: https://github.com/llvm/llvm-project/commit/5786f64a4ec806877f39fa0c28dcb90f9492b68c.diff LO

[PATCH] D96693: [Syntax] Model FunctionDefinition.

hokein updated this revision to Diff 323691. hokein added a comment. Fix and simplify the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96693/new/ https://reviews.llvm.org/D96693 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/in

  1   2   >