[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

nridge added a comment. (This patch should be ready for another round of review.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92290/new/ https://reviews.llvm.org/D92290 ___ cfe-commits mailing list cfe

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet created this revision. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes only allow modifications to local file containing the diagnostics, with Cod

[PATCH] D96244: [clangd][RFC] Introudce Plugins

kadircet created this revision. Herald added subscribers: usaxena95, arphaman, mgorny. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Plugins can be used to augment clangd's behaviours in various features. I

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 322033. poelmanc added a comment. Update one one comment, hopefully trigger HarborMaster to rerun. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682 Files: clang-tools-extra/clang-tidy/readability/Redundant

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

kadircet added a comment. It looks like premerge tests skipped your last diff with id 321451 (https://reviews.llvm.org/harbormaster/?after=87950). You can re-trigger by uploading a new diff, in the meantime i would also file a bug to https://github.com/google/llvm-premerge-checks/issues. mentio

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl updated this revision to Diff 322021. yaxunl marked 3 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments. Use CUID hash as postfix for static variable name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85223/ne

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11446-11447 bool ASTContext::mayExternalizeStaticVar(const Decl *D) const { - return !getLangOpts().GPURelocatableDeviceCode && + return (!getLangOpts().CUID.empty()

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl updated this revision to Diff 322020. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Jon and Artem's comments. Removed check of CUID value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95007/new/ https://reviews.llvm.org/D95007 Files: clang/includ

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei added a comment. In D93179#2547306 , @RKSimon wrote: > @pengfei I'm sorry I haven't gotten back to looking at this yet - it makes > sense to create a patch to revert the fadd/fmul reduction changes for > trunk/12.x. Thanks @RKSimon, I had a try

[PATCH] D96231: [X86] Always assign reassoc flag for intrinsics *reduce_add/mul_ps/pd.

pengfei created this revision. pengfei added reviewers: RKSimon, craig.topper, spatel. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Intrinsics *reduce_add/mul_ps/pd have assumption that the elements in the vector are reassociable

[PATCH] D94251: [scan-build-py] Update scan-build-py to allow outputing as SARIF.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd72859ffa237: [scan-build-py] Update scan-build-py to allow outputing as SARIF (authored by Daniel Hwang , committed by haowei). Herald added a project: clang. Herald added a subscriber:

[clang] d72859f - [scan-build-py] Update scan-build-py to allow outputing as SARIF

Author: Daniel Hwang Date: 2021-02-07T18:25:50-08:00 New Revision: d72859ffa237bbb82c1ef7302f2d99534183f8ca URL: https://github.com/llvm/llvm-project/commit/d72859ffa237bbb82c1ef7302f2d99534183f8ca DIFF: https://github.com/llvm/llvm-project/commit/d72859ffa237bbb82c1ef7302f2d99534183f8ca.diff

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 322005. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by James, Artem, and John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang/include/clang/Basic/Dia

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D71726#2537378 , @jyknight wrote: > In D71726#2537101 , @yaxunl wrote: > >> For amdgpu target, we do need diagnose unsupported atomics (not limited

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

njames93 added a comment. In D95771#2547467 , @poelmanc wrote: > Thanks for the commit, and thanks for the heads-up! I've now added the > address in my github account. Its updated now and the commit is linked to your account. Repository: rG LLVM Gith

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

jrtc27 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:380 ve::getVETargetFeatures(D, Args, Features); +break; } Unrelated Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1541 + // NOTE: If you add any additional spellings, ARMInterrupt's, MipsInterrupt's + // and AnyX86Interrupt's spellings must match. + let Spellings = [GNU<"interrupt">]; Do you need

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

poelmanc added a comment. In D95771#2547366 , @njames93 wrote: > In D95771#2547160 , @poelmanc wrote: > >> In D95771#2547102 , @njames93 wrote: >> >>> Should this be committe

[PATCH] D96224: [clang-itdy] Simplify virtual near-miss check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added a subscriber: nullptr.cpp. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Diagnose the problem in templates in the context of the temp

[PATCH] D96223: [clang-tidy] Simplify static assert check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D96222: [clang-tidy] Simplify redundant smartptr get check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire added a comment. In D96142#2545078 , @njames93 wrote: > I'm not sure about this. The warning is good and addresses a real problem. Well, I've made the diagnostic better anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire updated this revision to Diff 321997. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96142/new/ https://reviews.llvm.org/D96142 Files: clang-tools-extra/clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

dblaikie added a comment. In D94735#2547370 , @jdoerfert wrote: > In D94735#2546968 , @dblaikie wrote: > >> This patch is about a clang synthesized `struct`. >> `clang/lib/CodeGen/CGOpenMPRuntime.cpp:3463` has a sy

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdoerfert added a comment. I have a single last comment/request. @jdenny I'll take it you finish the review and accept as you see fit. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:986 + if (BodyGenCB) +BodyGenCB(CL->getBodyIP(), CL->getIndVar()); --

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

jdoerfert added a comment. In D94735#2546968 , @dblaikie wrote: > This patch is about a clang synthesized `struct`. > `clang/lib/CodeGen/CGOpenMPRuntime.cpp:3463` has a synthesized `union` > (`distinct !DICompositeType(tag: DW_TAG_union_type, name: "kmp_

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 added a comment. Unfortunately this broke the search order for clang-tidy files in root directories in favour or subdirectories. This wasn't caught as we didn't have tests for this. I've put a fix for this in D96204 with appropriate tests. Repository

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

njames93 added a comment. In D95771#2547160 , @poelmanc wrote: > In D95771#2547102 , @njames93 wrote: > >> Should this be committed using `poelmanc `? > > That or `Conrad Poelman ` would be great, thanks. I committ

[clang-tools-extra] 5229edd - [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

Author: poelmanc Date: 2021-02-07T16:36:34Z New Revision: 5229edd66742aeed407f774d77d437fa80347ad1 URL: https://github.com/llvm/llvm-project/commit/5229edd66742aeed407f774d77d437fa80347ad1 DIFF: https://github.com/llvm/llvm-project/commit/5229edd66742aeed407f774d77d437fa80347ad1.diff LOG: [cla

[PATCH] D95771: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[]

This revision was automatically updated to reflect the committed changes. Closed by commit rG5229edd66742: [clang-tidy] fix modernize-loop-convert to retain needed array-like operator[] (authored by poelmanc, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D96114: [ASTMatchers] Fix parent-child traversal between functions and parms

steveire updated this revision to Diff 321991. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96114/new/ https://reviews.llvm.org/D96114 Files: clang/include/clang/AST/RecursiveASTVisitor.h clang/lib/AST/ParentM

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

steveire updated this revision to Diff 321990. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96113/new/ https://reviews.llvm.org/D96113 Files: clang/include/clang/AST/ParentMapContext.h clang/lib/AST/ParentMapC

[clang] ddca007 - Add code complete support for mapAnyOf

Author: Stephen Kelly Date: 2021-02-07T16:03:05Z New Revision: ddca007a291b0e224fe5a492ae8d78c6a933b4fe URL: https://github.com/llvm/llvm-project/commit/ddca007a291b0e224fe5a492ae8d78c6a933b4fe DIFF: https://github.com/llvm/llvm-project/commit/ddca007a291b0e224fe5a492ae8d78c6a933b4fe.diff LOG:

[PATCH] D94880: Add clang-query support for mapAnyOf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04b69d9a6013: Add clang-query support for mapAnyOf (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94880?vs=320774&

[clang] 04b69d9 - Add clang-query support for mapAnyOf

Author: Stephen Kelly Date: 2021-02-07T15:40:15Z New Revision: 04b69d9a6013cbc39321452fa09e24fed4c98bc7 URL: https://github.com/llvm/llvm-project/commit/04b69d9a6013cbc39321452fa09e24fed4c98bc7 DIFF: https://github.com/llvm/llvm-project/commit/04b69d9a6013cbc39321452fa09e24fed4c98bc7.diff LOG:

[clang] 816cc43 - [ASTMatchers] Extract parsing of bind token from the bind id

Author: Stephen Kelly Date: 2021-02-07T15:40:15Z New Revision: 816cc432812724627835e66ed94a20a2478edef8 URL: https://github.com/llvm/llvm-project/commit/816cc432812724627835e66ed94a20a2478edef8 DIFF: https://github.com/llvm/llvm-project/commit/816cc432812724627835e66ed94a20a2478edef8.diff LOG:

[clang] 8021078 - [ASTMatchers] Change internal method API

Author: Stephen Kelly Date: 2021-02-07T15:37:35Z New Revision: 8021078bc993073d703b91eae8f9b9ed8de478dc URL: https://github.com/llvm/llvm-project/commit/8021078bc993073d703b91eae8f9b9ed8de478dc DIFF: https://github.com/llvm/llvm-project/commit/8021078bc993073d703b91eae8f9b9ed8de478dc.diff LOG:

[clang] 45e210d - [ASTMatchers] Make it possible to build mapAnyOf through the registry

Author: Stephen Kelly Date: 2021-02-07T15:36:15Z New Revision: 45e210dbebfae916b213e52be15c276032aeb60d URL: https://github.com/llvm/llvm-project/commit/45e210dbebfae916b213e52be15c276032aeb60d DIFF: https://github.com/llvm/llvm-project/commit/45e210dbebfae916b213e52be15c276032aeb60d.diff LOG:

[PATCH] D93800: [clangd] Add caching behaviour for clang-format config

njames93 updated this revision to Diff 321988. njames93 added a comment. Add unittests for provider. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93800/new/ https://reviews.llvm.org/D93800 Files: clang-tools-extra/clangd/CMakeLists.txt clang-

[clang] d3bccdc - [ASTMatchers ]Make MatcherDescriptors indicate the node type they match

Author: Stephen Kelly Date: 2021-02-07T15:13:28Z New Revision: d3bccdcd50e392469c5d115eda29a308914e19ae URL: https://github.com/llvm/llvm-project/commit/d3bccdcd50e392469c5d115eda29a308914e19ae DIFF: https://github.com/llvm/llvm-project/commit/d3bccdcd50e392469c5d115eda29a308914e19ae.diff LOG:

[clang] e12d827 - Make it possible to store NodeKinds in ArgKind

Author: Stephen Kelly Date: 2021-02-07T14:00:45Z New Revision: e12d8279915c323f3727085ccfd0f2c54ad82bdd URL: https://github.com/llvm/llvm-project/commit/e12d8279915c323f3727085ccfd0f2c54ad82bdd DIFF: https://github.com/llvm/llvm-project/commit/e12d8279915c323f3727085ccfd0f2c54ad82bdd.diff LOG:

[clang] 79fedad - [ASTMatchers] Add static constructor for ArgKinds of Matchers

Author: Stephen Kelly Date: 2021-02-07T13:43:04Z New Revision: 79fedadd6af84701e8c873c8d7b507e323d15a5e URL: https://github.com/llvm/llvm-project/commit/79fedadd6af84701e8c873c8d7b507e323d15a5e DIFF: https://github.com/llvm/llvm-project/commit/79fedadd6af84701e8c873c8d7b507e323d15a5e.diff LOG:

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. @pengfei I'm sorry I haven't gotten back to looking at this yet - it makes sense to create a patch to revert the fadd/fmul reduction changes for trunk/12.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ https:/

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. @vsavchenko are there some more changes you want done? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 ___ cfe-commits mailing list cfe-