[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc1dee60019: [clang-format] Add StatementAttributeLikeMacros option (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGE

[clang] bcc1dee - [clang-format] Add StatementAttributeLikeMacros option

Author: Björn Schäpers Date: 2021-01-18T06:54:31+01:00 New Revision: bcc1dee60019f3a488a04dc7f701f7a692040fed URL: https://github.com/llvm/llvm-project/commit/bcc1dee60019f3a488a04dc7f701f7a692040fed DIFF: https://github.com/llvm/llvm-project/commit/bcc1dee60019f3a488a04dc7f701f7a692040fed.diff

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

HazardyKnusperkeks updated this revision to Diff 317268. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Sorting corrected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 updated this revision to Diff 317258. tianshilei1992 added a comment. Added a new test case for device only compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94871/new/ https://reviews.llvm.org/D94871 Files: clang/lib/Code

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng added a comment. That's my fault, I didn't specify the behavior of sub-extension clearly on the spec, but I think it would be great if we also define sub-extension marcos, since it would be easier to check when some core only implement sub-extension, and the code can just check the s

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. In D90448#2504022 , @condy wrote: > The tests failed though Which? Do you mean the unit test? It seems to be irrelevant with this revision. This revision doesn't change the code covered by that test. The failure should be cause

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:95 // uint3). This function is defined after we pull in vector_types.h. - __attribute__((device)) operator dim3() const; - __attribute__((device)) operator uint3() const; + DEVI

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 updated this revision to Diff 317255. tianshilei1992 added a comment. Fixed compilation in C mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94884 Files: clang/lib/Headers/__clang_cuda_built

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

condy added a comment. The tests failed though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D94403: [RISCV] Implement new architecture extension macros

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 ___ c

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 added a comment. C is still broken as the header is written in C++ where a struct can have member functions, either static or not. Need to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers updated this revision to Diff 317252. vabridgers added a comment. Rebase, commandeer this patch from Ilya. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 Files: clang/include/clang/Sema/Sema.h

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 updated this revision to Diff 317251. tianshilei1992 added a comment. Use macro `DEVICE` to control the attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94884 Files: clang/lib/Headers/__

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/avx512dq-builtins-constrained.c:3 +// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-apple-darwin -target-feature +avx512dq -emit-llvm -o - -Wall -Werror | FileCheck %s --check-pre

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

nridge added a comment. In D94785#2501806 , @usaxena95 wrote: > Although now that I enabled this in all SymbolCollectorTests, this causes a > regression in RefContainers. > > void f2() { > (void) $ref1a[[f1]](1); > auto fptr = &$ref1b[[f

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

jdoerfert added a reviewer: tra. jdoerfert added a comment. I can see that we want this but I guess the errors show the problem, replace `__attribute((device))` with `DEVICE` and define it based on CUDA vs OpenMP properly. Comment at: clang/lib/Headers/__clang_cuda_builtin_va

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

jdoerfert added a comment. Here is a minimal reproducer for the issue even without standalone device compilation (and I can build the situation in various other ways as well): https://godbolt.org/z/T1h9b5 Can you add it as a test, I am also curious how the IR looks like with this patch. Repos

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 created this revision. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Current OpenMP wrapper header `__clang_openmp_devi

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 updated this revision to Diff 317235. tianshilei1992 added a comment. Also updated for `registerTargetRegionEntryInfo` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94871/new/ https://reviews.llvm.org/D94871 Files: clang/lib/CodeG

[clang] 9a7fb08 - NFC: Minor cleanup of function calls

Author: Stephen Kelly Date: 2021-01-17T18:47:17Z New Revision: 9a7fb0848771e3d38baf10e4d1078b50dd884265 URL: https://github.com/llvm/llvm-project/commit/9a7fb0848771e3d38baf10e4d1078b50dd884265 DIFF: https://github.com/llvm/llvm-project/commit/9a7fb0848771e3d38baf10e4d1078b50dd884265.diff LOG:

[PATCH] D94881: WIP: Add a way to define matcher builders in the dynamic registry

steveire added a comment. This is WIP because there is still some error handling and code completion handling to do. Pushed the patch though to complete the series : https://github.com/steveire/llvm-project/commits/mapAnyOf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D94881: WIP: Add a way to define matcher builders in the dynamic registry

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94881 Files: clang/include/clang/ASTMatch

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94880 Files: clang/lib/ASTMatchers/Dynami

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reduces template bloat, but more importantly, makes it possible to construct one from clang-query withou

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94878 Files: clang/include/clang/ASTMatch

[PATCH] D94877: Add API to retrieve a clade kind from ASTNodeKind

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94877 Files: clang/include/clang/AST/ASTT

[PATCH] D94876: Remove TypedMatcherOps from VariantValue

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It provides no features or advantage over ASTNodeKind-based handling. Repository: rG LLVM Github Monorepo

[PATCH] D94875: [clangd] ignore parallelism level for quick tasks

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This allows quick ta

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

qchateau added a comment. You're right, I probably got carried away for the sake of completeness. Allocating extra memory for a feature nobody is going to use is definitely not worth it. Though maybe we can take advantage of what's already been done and if we remove the `RevRefs` map, and pay t

[clang-tools-extra] 9abbc05 - [clangd] Use !empty() instead of size()>0

Author: Utkarsh Saxena Date: 2021-01-17T15:26:40+01:00 New Revision: 9abbc050974ff117b79e8e049c52c56db3f49aec URL: https://github.com/llvm/llvm-project/commit/9abbc050974ff117b79e8e049c52c56db3f49aec DIFF: https://github.com/llvm/llvm-project/commit/9abbc050974ff117b79e8e049c52c56db3f49aec.diff

[clang-tools-extra] 0f9908a - [clangd] Use empty() instead of size()>0

Author: Utkarsh Saxena Date: 2021-01-17T15:13:01+01:00 New Revision: 0f9908a7c9c547f2675e00f88cc11ec02ca28e8d URL: https://github.com/llvm/llvm-project/commit/0f9908a7c9c547f2675e00f88cc11ec02ca28e8d DIFF: https://github.com/llvm/llvm-project/commit/0f9908a7c9c547f2675e00f88cc11ec02ca28e8d.diff

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. I think the revision whilst it does what is needed to structs doesn't address the many other times this forms appear. I think we need something a little more extensiv

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Please address the "not done" comment (regarding the sorting), but other than that its LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D9

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG00dc97f16708: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 00dc97f - [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

Author: mydeveloperday Date: 2021-01-17T11:14:33Z New Revision: 00dc97f16708aad67834552285c0af01b37303d6 URL: https://github.com/llvm/llvm-project/commit/00dc97f16708aad67834552285c0af01b37303d6 DIFF: https://github.com/llvm/llvm-project/commit/00dc97f16708aad67834552285c0af01b37303d6.diff LOG

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay added a comment. Sorry but due to the following issue raised by @RatTac , I'm reverting this prior to the LLVM 12 branch out so I can work on it further. I also think this would impact #pragma's in any ifdef code which I envisage would be significant. #if defined(WIN32) #pra

[clang] 9af0386 - [clang-format] Revert e9e6e3b34a8e

Author: mydeveloperday Date: 2021-01-17T11:07:31Z New Revision: 9af03864df746aa9a9cf3573da952ce6c5d902cd URL: https://github.com/llvm/llvm-project/commit/9af03864df746aa9a9cf3573da952ce6c5d902cd DIFF: https://github.com/llvm/llvm-project/commit/9af03864df746aa9a9cf3573da952ce6c5d902cd.diff LOG

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:103 /// - /// This will align C/C++ preprocessor macros of consecutive lines. - /// Will result in formattings like + /// ``Consecutive`` will result

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added a comment. Thank you for changing the dump_style to make this clearer F15070790: image.png F15070797: image.png F15070803: image.png F15070810: image.png

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

MyDeveloperDay added a comment. Thie LGTM, just to check a few nits /usr/bin/sphinx-build -n ./docs ./html /clang/llvm-project/clang/docs/ClangFormatStyleOptions.rst:330: WARNING: Bullet list ends without a blank line; unexpected unindent. /clang/llvm-project/clang/docs/ClangFormatStyleOpt