[PATCH] D94873: [clang] [driver] Remove obsolete unistd.h include

2021-01-16 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: rsmith, aaron.ballman, dlj. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was needed for a call to `getuid()`, but that call is gone these days, so remove the include a

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

2021-01-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Clang is trying to avoid using non-byte-multiple integer types for memory accesses in LLVM IR, whereas Swift isn't. If you take your test case and make the field non-atomic, you'll see that: Clang is accessing the field as an `i8` and Swift is accessing it as an `i1`.

[libunwind] 3cbd476 - [VE] Support VE in libunwind

2021-01-16 Thread Kazushi Marukawa via cfe-commits
Author: Kazushi (Jam) Marukawa Date: 2021-01-17T15:35:02+09:00 New Revision: 3cbd476c54886e8ebac64b4145d4517732a71023 URL: https://github.com/llvm/llvm-project/commit/3cbd476c54886e8ebac64b4145d4517732a71023 DIFF: https://github.com/llvm/llvm-project/commit/3cbd476c54886e8ebac64b4145d4517732a71

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

2021-01-16 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev, grokos. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. D94745

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

2021-01-16 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple added a comment. > The way you'd test it on the Clang side would be to just write a test case > that passes such an aggregate and tests that it's passed as an `i8`. Ah, I just noticed an attribute `__attribute__((swiftcall))` that is used in some test cases, I can add a test f

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

2021-01-16 Thread Nathan James via Phabricator via cfe-commits
njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. Can you either update the description of this patch to include the binaryOperation changes, or remove those changes from here. Comment at: clang-tools-extra/c

[PATCH] D94131: [clang-tidy] Use new mapAnyOf matcher

2021-01-16 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 317177. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94131/new/ https://reviews.llvm.org/D94131 Files: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp clang-t

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

2021-01-16 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94865 Files: clang/docs/LibASTMatchersRef

[PATCH] D94864: [ASTMatchers] Re-order the internals to allow another use-case

2021-01-16 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add an operator overload to ArgumentAdaptingMatcherFunc to allow use of mapAnyOf within hasAncestor, hasParen

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

2021-01-16 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Not what I had in mind, but for me that's okay. I can not say anything to the change of the script though. What I hat in mind was explaining (maybe in length) the enum and for the alignment settings just show an example with `None` and one of the other optio

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

2021-01-16 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb765eaf9a617: [ASTMatchers] Add support for CXXRewrittenBinaryOperator (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.o

[clang] b765eaf - [ASTMatchers] Add support for CXXRewrittenBinaryOperator

2021-01-16 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2021-01-16T13:44:22Z New Revision: b765eaf9a617bd3da30f47ece731b33593929885 URL: https://github.com/llvm/llvm-project/commit/b765eaf9a617bd3da30f47ece731b33593929885 DIFF: https://github.com/llvm/llvm-project/commit/b765eaf9a617bd3da30f47ece731b33593929885.diff LOG:

[PATCH] D94129: [ASTMatchers] Add binaryOperation matcher

2021-01-16 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe810e95e4bb9: [ASTMatchers] Add binaryOperation matcher (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94129?vs=31

[clang] e810e95 - [ASTMatchers] Add binaryOperation matcher

2021-01-16 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2021-01-16T13:44:09Z New Revision: e810e95e4bb908d1c8844e2c6f7da999732cabc9 URL: https://github.com/llvm/llvm-project/commit/e810e95e4bb908d1c8844e2c6f7da999732cabc9 DIFF: https://github.com/llvm/llvm-project/commit/e810e95e4bb908d1c8844e2c6f7da999732cabc9.diff LOG:

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

2021-01-16 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbe056c2e37f: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary… (authored by stephenkelly). Changed prior to commit: http

[clang] dbe056c - [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

2021-01-16 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2021-01-16T12:53:11Z New Revision: dbe056c2e37f00b9f33ab63bba73dbb004e13562 URL: https://github.com/llvm/llvm-project/commit/dbe056c2e37f00b9f33ab63bba73dbb004e13562 DIFF: https://github.com/llvm/llvm-project/commit/dbe056c2e37f00b9f33ab63bba73dbb004e13562.diff LOG:

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

2021-01-16 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7101450a42e: [ASTMatchers] Add mapAnyOf matcher (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94127?vs=316712&id

[clang] a710145 - [ASTMatchers] Add mapAnyOf matcher

2021-01-16 Thread Stephen Kelly via cfe-commits
Author: Stephen Kelly Date: 2021-01-16T12:53:11Z New Revision: a7101450a42e4f1ed5af1a38a6def08f1b5b58fe URL: https://github.com/llvm/llvm-project/commit/a7101450a42e4f1ed5af1a38a6def08f1b5b58fe DIFF: https://github.com/llvm/llvm-project/commit/a7101450a42e4f1ed5af1a38a6def08f1b5b58fe.diff LOG:

[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

2021-01-16 Thread Lukas Barth via Phabricator via cfe-commits
tinloaf updated this revision to Diff 317166. tinloaf added a comment. Fixed documentation for the `AlignConsecutive*` options. I have used the suggested approach: Remove all documentation from `AlignConsecutiveStyle` and instead put the documentation of the possible values and what they do in t

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

2021-01-16 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/test/CodeGen/attr-mustprogress-1.cpp:32 // void f1() { for (; 1;) Test for (; 42; )? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94366/new/ https://reviews.

[PATCH] D94366: [Clang] Emit mustprogress for infinite C++ loops

2021-01-16 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:797 if (llvm::ConstantInt *C = dyn_cast(BoolCondVal)) { if (C->isOne()) { EmitBoolCondBranch = false; Anything non-zero? Comment at: clang/test/CodeGen/attr

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2021-01-16 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM apart from the minor comment. But I'd like @mydeveloperday to have a look too. Comment at: clang/lib/Format/FormatToken.h:54 TYPE(FunctionTypeLParen)