[PATCH] D94753: [clangd] exclude symbols from document outline which do not originate from the main file

ilya-golovenko created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ilya-golovenko requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > hoy wrote: > > wmi wrote: > >

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

usaxena95 updated this revision to Diff 316853. usaxena95 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://reviews.llvm.org/D94473 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clan

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

wmi added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType hoy wrote: > wmi wrote: > > hoy wrote: > >

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

MaskRay updated this revision to Diff 316845. MaskRay retitled this revision from "CGDebugInfo: Drop unneeded line number for CreatedLimitedType" to "CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location". MaskRay edited the summary of this revision. MaskRay added a

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for CreatedLimitedType

dblaikie added a comment. In D94735#2500132 , @MaskRay wrote: > In D94735#2500129 , @dblaikie wrote: > >> Ah, seems I was confused by the patch title - it looks like these values >> aren't used for FlagFwdDecl reco

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay added a comment. In D94735#2500129 , @dblaikie wrote: > Ah, seems I was confused by the patch title - it looks like these values > aren't used for FlagFwdDecl records - forward declarations bail out 3356, not > using the file/line created on 3338

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

dblaikie added a comment. Ah, seems I was confused by the patch title - it looks like these values aren't used for FlagFwdDecl records - forward declarations bail out 3356, not using the file/line created on 3338/3339. Seems like this change might lead to a situation of files but no line number

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2500124 , @jdoerfert wrote: > In D93078#2500122 , @mtrofin wrote: > >> In D93078#2500114 , @jdoerfert >> wrote: >> >>> In D93078#2500040 <

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#2500122 , @mtrofin wrote: > In D93078#2500114 , @jdoerfert wrote: > >> In D93078#2500040 , @mtrofin wrote: >> >>> In D93078#2500032

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2500114 , @jdoerfert wrote: > In D93078#2500040 , @mtrofin wrote: > >> In D93078#2500032 , @jdoerfert >> wrote: >> >>> In D93078#246 <

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#2500040 , @mtrofin wrote: > In D93078#2500032 , @jdoerfert wrote: > >> In D93078#246 , @mtrofin wrote: >> >>> In D93078#245

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2500032 , @jdoerfert wrote: > In D93078#246 , @mtrofin wrote: > >> In D93078#245 , @jdoerfert >> wrote: >> >>> In D93078#2499982 <

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

pengfei added a comment. > What is the reason for treating this differently in LLVM? I'm not sure if it is related to this. I think one difference is that LLVM is supporting MS inline assembly. Although it uses Intel dialect, it has different representation in input, output, clobber etc. with G

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

dblaikie added a comment. Bit out of my wheelhouse hopefully @rsmith or @rnk could chime in at some point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92136/new/ https://reviews.llvm.org/D92136 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#246 , @mtrofin wrote: > In D93078#245 , @jdoerfert wrote: > >> In D93078#2499982 , @mtrofin wrote: >> >>> In D93078#2499666

[PATCH] D93703: [libTooling] Change `addInclude` to use expansion locs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fabe6e51917: [libTooling] Change `addInclude` to use expansion locs. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 1fabe6e - [libTooling] Change `addInclude` to use expansion locs.

Author: Yitzhak Mandelbaum Date: 2021-01-15T03:08:56Z New Revision: 1fabe6e51917bcd7a1242294069c682fe6dffa45 URL: https://github.com/llvm/llvm-project/commit/1fabe6e51917bcd7a1242294069c682fe6dffa45 DIFF: https://github.com/llvm/llvm-project/commit/1fabe6e51917bcd7a1242294069c682fe6dffa45.diff

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3339 // Get overall information about the record type for the debug info. llvm::DIFile *DefUnit = getOrCreateFile(RD->getLocation()); - const unsigned Line = - getLineNumber(RD->getLocat

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#245 , @jdoerfert wrote: > In D93078#2499982 , @mtrofin wrote: > >> In D93078#2499666 , @jdoerfert >> wrote: >> >>> I think this caused

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert added a comment. In D93078#2499982 , @mtrofin wrote: > In D93078#2499666 , @jdoerfert wrote: > >> I think this caused a lot of problems for the Attributor tests. I get the >> "conflict output" warning all

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. In D93078#2499666 , @jdoerfert wrote: > I think this caused a lot of problems for the Attributor tests. I get the > "conflict output" warning all the time now :( > > These two `UpdateTestChecks` tests also generate the warning. I

[PATCH] D92037: clang: Pass -platform-version to new MachO LLD

rsmith added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:341 // Add the deployment target. - if (Version[0] >= 520) + if (Version[0] >= 520 || LinkerIsLLDDarwinNew) MachOTC.addPlatformVersionArgs(Args, CmdArgs); Not a regression

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3339 // Get overall information about the record type for the debug info. llvm::DIFile *DefUnit = getOrCreateFile(RD->getLocation()); - const unsigned Line = - getLineNumber(RD->getLoca

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay added a comment. diff - [30] .debug_abbrev PROGBITS ec7533c 616a22 00 0 0 1 - [31] .debug_info PROGBITS f28bd5e 50f9770b 00 0 0 1 - [32] .debug_ranges PROGBITS 60223469 285e9b0

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay created this revision. MaskRay added reviewers: debug-info, aprantl, dblaikie. Herald added a subscriber: pengfei. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tested with stage 2 -DCMAKE_BUILD_TYPE=Debug clang, the only

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm In D94639#2497031 , @dblaikie wrote: > (I'm generally good with this - llvm & clang changes should be committed > separately & maybe the linkage part t

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a comment. Ping @rsmith . Are you ok if I rebase and push this change? Or do you have specific items that require attention? I've spoken to @ilya , he's ok if I clean this up and push with credit to him. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

tra created this revision. tra added reviewers: HAPPY, yaxunl. Herald added a subscriber: bixia. tra requested review of this revision. Herald added a project: clang. Defaulted destructor was treated inconsistently, compared to other compiler-generated functions. When Sema::IdentifyCUDATarget()

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1525 unsigned TwoXLenInBytes = (2 * XLen) / 8; if (!IsFixed && ArgFlags.getOrigAlign() == TwoXLenInBytes && DL.getTypeAllocSize(OrigTy) == TwoXLenInBytes) { lenary

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

jrtc27 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10323 + bool EABI) + : DefaultABIInfo(CGT), XLen(XLen), FLen(FLen) { +if (EABI) I think it'd be better to have a `NumArgGPRs(EAABI ? 6 : 8)` here as having a defaul

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5346 +AST_POLYMORPHIC_SUPPORTED_TYPES(BinaryOperator, CXXOperatorCallExpr, +CXXRewrittenBinaryOperator)) {

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

jdoerfert reopened this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I think this caused a lot of problems for the Attributor tests. I get the "conflict output" warning all the time now :( These two `UpdateTestChecks` tests also generate the warning. I wo

[clang-tools-extra] 4183999 - [clangd] Reduce logspam for CDB scanning

Author: Sam McCall Date: 2021-01-14T23:55:02+01:00 New Revision: 4183999e0fe1ffbc8bdb2f06f2e5f210a0c94e35 URL: https://github.com/llvm/llvm-project/commit/4183999e0fe1ffbc8bdb2f06f2e5f210a0c94e35 DIFF: https://github.com/llvm/llvm-project/commit/4183999e0fe1ffbc8bdb2f06f2e5f210a0c94e35.diff LO

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

modimo added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } wenlei wrote: > nit: any special reason for adding this? doesn't seem consistent with other > remarks we have. If you grab the remark outputs via `-Rpass=inl

[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. And mark a couple to be retired a

[PATCH] D94724: [clangd] Remove the recovery-ast options.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. These force a couple of flags or

[PATCH] D94699: [clangd] Set correct CWD when using compile_flags.txt

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yikes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94699/new/ https://reviews.llvm.org/D94699 _

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

akhuang updated this revision to Diff 316779. akhuang edited the summary of this revision. akhuang added a comment. Remove llvm change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94639/new/ https://reviews.llvm.org/D94639 Files: clang/lib/Cod

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only. + if (CGM.getCodeGenOpts().hasReducedDebugInfo()) +Identifier = getTypeIdentifier(Ty, CGM, TheCU); rnk wrote: > I s

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

saudi added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92136/new/ https://reviews.llvm.org/D92136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D94719: [clangd] Make ExpandAutoType not available on template params.

adamcz created this revision. adamcz added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. We cannot expand auto when used inside a t

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 316768. saudi edited the summary of this revision. saudi added a comment. Updated the tests for clang-cl command lines: I moved the input files to end of command line, with `--`, to avoid linux-style paths conflict with clang-cl arguments. I also had to fix th

[clang-tools-extra] f85b153 - Add -fexceptions to test as it uses them and fails on platforms where it is not on by default (like the PS4).

Author: Douglas Yung Date: 2021-01-14T13:27:06-08:00 New Revision: f85b1531666d12e6ca9b29217b5c5da30dfd93cf URL: https://github.com/llvm/llvm-project/commit/f85b1531666d12e6ca9b29217b5c5da30dfd93cf DIFF: https://github.com/llvm/llvm-project/commit/f85b1531666d12e6ca9b29217b5c5da30dfd93cf.diff

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:143 bool tryToParseSimpleAttribute(); - void addUnwrappedLine(); + void addUnwrappedLine(bool RemoveLevel = true); bool eof() const; HazardyKnusperkeks wrote: > A `bool` para

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3758 + // Normally -gsplit-dwarf is only useful with -gN. For -gsplit-dwarf in the + // backend phase of a distributed ThinLTO which does object file generation + // and no IR generation, -gN sho

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg updated this revision to Diff 316753. tomrittervg retitled this revision from "[PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior" to "PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior". tomrittervg e

[PATCH] D94130: [ASTMatchers] Add support for CXXRewrittenBinaryOperator

steveire updated this revision to Diff 316751. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94130/new/ https://reviews.llvm.org/D94130 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST/AST

[PATCH] D94129: [ASTMatchers] Add binaryOperation matcher

steveire updated this revision to Diff 316749. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94129/new/ https://reviews.llvm.org/D94129 Files: clang/docs/LibASTMatchersReference.html clang/docs/tools/dump_ast_m

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

inglorion added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3758 + // Normally -gsplit-dwarf is only useful with -gN. For -gsplit-dwarf in the + // backend phase of a distributed ThinLTO which does object file generation + // and no IR generation, -gN sh

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

steveire updated this revision to Diff 316743. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94128/new/ https://reviews.llvm.org/D94128 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[clang] a71877e - [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.

Author: Adam Czachorowski Date: 2021-01-14T21:20:06+01:00 New Revision: a71877edfbb7094584f6d20d93f6091e7d374024 URL: https://github.com/llvm/llvm-project/commit/a71877edfbb7094584f6d20d93f6091e7d374024 DIFF: https://github.com/llvm/llvm-project/commit/a71877edfbb7094584f6d20d93f6091e7d374024.d

[PATCH] D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa71877edfbb7: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base. (authored by adamcz). Repository: rG LLVM Github Monorepo CHA

[PATCH] D94128: [ASTMatchers] Make cxxOperatorCallExpr matchers API-compatible with n-ary operators

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1994 + return None; +return FD->getNumParams() > 0 ? UO_PostInc : UO_PreInc; + } aaron.ballman wrote: > Not certain how much we want to care about it, but

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

MaskRay added a comment. In D94647#2499153 , @inglorion wrote: > Can we not just make -gsplit-dwarf set the DwarfFissionKind without also > looking at other things? That way, we don't have to worry about detecting the > right mix of -g, -g2, -fthinlto-in

[PATCH] D94647: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for -fthinlto-index=

inglorion added a comment. Can we not just make -gsplit-dwarf set the DwarfFissionKind without also looking at other things? That way, we don't have to worry about detecting the right mix of -g, -g2, -fthinlto-index, -x ir, bitcode input, etc. If there is some reason why this doesn't work, I wo

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

ldionne accepted this revision as: libc++abi. ldionne added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4009 +// mangling. Previously, it used a special-cased nonstandard extension. +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +

[PATCH] D92403: [LSan][RISCV] Enable LSan for RISCV64

MaskRay accepted this revision. MaskRay added inline comments. Comment at: compiler-rt/test/sanitizer_common/print_address.h:11 #if defined(__x86_64__) || defined(__aarch64__) || defined(__powerpc64__) || \ -defined(__s390x__) +defined(__s390x__) || (defined(__riscv) &&

[PATCH] D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94704/new/ https://reviews.llvm.org/D94704 __

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17874 + verifyFormat("class C {\n" + "int i;\n" + "};\n", So this is indented 4 because the Access modifier is 4? when the IndentWidth is 2?

[PATCH] D94704: [clang] Do not crash when CXXRecordDecl has a non-CXXRecordDecl base.

adamcz created this revision. adamcz added a reviewer: hokein. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This can happen on some invalid code, like the included test case. Repository: rG LLVM Github Monorepo https://review

[PATCH] D93452: [clangd] Trim memory periodically

qchateau added a comment. If you look back at my original comment, you'll notice I originally trimmed the memory after `FileSymbols::buildIndex` which seemed to be the "end of the peak" memory usage, the goal was to counteract exactly what you describe: a huge memory usage when clangd warms-up

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType wmi wrote: > hoy wrote: > > wmi wrote: > >

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b9af92a482: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94655/

[clang] e3b9af9 - [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

Author: Fangrui Song Date: 2021-01-14T11:46:22-08:00 New Revision: e3b9af92a4821fec25c207e2d1e443e09ff6b11e URL: https://github.com/llvm/llvm-project/commit/e3b9af92a4821fec25c207e2d1e443e09ff6b11e DIFF: https://github.com/llvm/llvm-project/commit/e3b9af92a4821fec25c207e2d1e443e09ff6b11e.diff

[clang] 9e53c94 - [NFC] Update test to not check for 'opaque' in the file name.

Author: Erich Keane Date: 2021-01-14T11:24:06-08:00 New Revision: 9e53c94d8dd737fcedb543d6ac687ea9696db8a6 URL: https://github.com/llvm/llvm-project/commit/9e53c94d8dd737fcedb543d6ac687ea9696db8a6 DIFF: https://github.com/llvm/llvm-project/commit/9e53c94d8dd737fcedb543d6ac687ea9696db8a6.diff L

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

dblaikie accepted this revision. dblaikie added a comment. In D94655#2498811 , @MaskRay wrote: > In D94655#2498669 , @dblaikie wrote: > >> In D94655#2498548 , @MaskRay wrote:

[PATCH] D94127: [ASTMatchers] Add mapAnyOf matcher

steveire updated this revision to Diff 316712. steveire added a comment. Changed the implementation a bit to make clang-query integration easier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94127/new/ https://reviews.llvm.org/D94127 Files: clan

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

wmi added inline comments. Comment at: llvm/include/llvm/IR/PseudoProbe.h:41 // [18:3] - probe id - // [25:19] - reserved + // [25:19] - probe distribution factor // [28:26] - probe type, see PseudoProbeType hoy wrote: > wmi wrote: > > hoy wrote: > >

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fffbc150cca: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization. (authored by zequanwu). Repository: rG LLVM Github Monorepo

[clang] 4fffbc1 - [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

Author: Zequan Wu Date: 2021-01-14T10:37:35-08:00 New Revision: 4fffbc150cca1638051b8ad2a20f4b8240df0869 URL: https://github.com/llvm/llvm-project/commit/4fffbc150cca1638051b8ad2a20f4b8240df0869 DIFF: https://github.com/llvm/llvm-project/commit/4fffbc150cca1638051b8ad2a20f4b8240df0869.diff LOG

[PATCH] D93062: [HIP] Add signbit(long double) decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe40c12040a0: [HIP] Add signbit(long double) decl (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] be40c12 - [HIP] Add signbit(long double) decl

Author: Aaron En Ye Shi Date: 2021-01-14T18:23:37Z New Revision: be40c12040a0d5551bf3430cbb184b5ef23e25fd URL: https://github.com/llvm/llvm-project/commit/be40c12040a0d5551bf3430cbb184b5ef23e25fd DIFF: https://github.com/llvm/llvm-project/commit/be40c12040a0d5551bf3430cbb184b5ef23e25fd.diff LO

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

MaskRay added a comment. In D94655#2498669 , @dblaikie wrote: > In D94655#2498548 , @MaskRay wrote: > >> In D94655#2498504 , @dblaikie wrote: >> >>> Is there any way to condi

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

hans added a comment. In D82862#2498242 , @uweigand wrote: > Hi @hans , we're having some issues with using the AssemblerDialect mechanism > to support both the GNU assembler and the IBM HLASM assembler in the SystemZ > back-end. See also the discuss

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94646/new/ https://reviews.llvm.org/D94646 ___ cfe-com

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu updated this revision to Diff 316695. zequanwu marked an inline comment as done. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94646/new/ https://reviews.llvm.org/D94646 Files: clang/lib/Sema/S

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

rnk added a comment. Thanks, this seems like the right spot. Comment at: clang/lib/Sema/SemaTemplate.cpp:9767 +if (Context.getTargetInfo().getCXXABI().isMicrosoft() && +Def->hasAttr()) { Let's remove this condition. There will only ever be inherit

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu added inline comments. Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:151-159 +namespace pr48687 { +template struct A { + T value; + static constexpr auto address = &A::value; +}; +extern template class A; +template class A; zequa

[PATCH] D94646: [clang][MSVC] Fix missing MSInheritanceAttr in template specialization.

zequanwu updated this revision to Diff 316694. zequanwu added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94646/new/ https://reviews.llvm.org/D94646 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/CodeGenCXX/mi

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

dblaikie added a comment. In D94655#2498548 , @MaskRay wrote: > In D94655#2498504 , @dblaikie wrote: > >> Is there any way to condition this on the type of the output, rather than >> the input? (or, more specifical

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

mtrofin added a comment. In D94644#2498638 , @aeubanks wrote: > It's not an emergency. > The issue with InlineAdvisorAnalysis is that the ModuleInlineWrapperPass > presets the InliningAdvisorMode of the InlineAdvisorAnalysis. We could force > override it

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks added a comment. It's not an emergency. The issue with InlineAdvisorAnalysis is that the ModuleInlineWrapperPass presets the InliningAdvisorMode of the InlineAdvisorAnalysis. We could force override it, but then what's the point of InlineAdvisorAnalysis? Can't we just create an InlineA

[clang-tools-extra] 8b09cf7 - [clangd] Trivial: Documentation fix in ASTSignals.

Author: Utkarsh Saxena Date: 2021-01-14T18:38:42+01:00 New Revision: 8b09cf7956d8abc722fa736874e4cea667a9d3cb URL: https://github.com/llvm/llvm-project/commit/8b09cf7956d8abc722fa736874e4cea667a9d3cb DIFF: https://github.com/llvm/llvm-project/commit/8b09cf7956d8abc722fa736874e4cea667a9d3cb.diff

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f395b7092bd: [clangd] Make AST-based signals available to runWithPreamble. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 2f395b7 - [clangd] Make AST-based signals available to runWithPreamble.

Author: Utkarsh Saxena Date: 2021-01-14T18:34:50+01:00 New Revision: 2f395b7092bdac0e39bb4e2bb5e6b03e521a45dd URL: https://github.com/llvm/llvm-project/commit/2f395b7092bdac0e39bb4e2bb5e6b03e521a45dd DIFF: https://github.com/llvm/llvm-project/commit/2f395b7092bdac0e39bb4e2bb5e6b03e521a45dd.diff

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class``, ``struct``, ``union``) curdeius wrote: > curdeius wrote: > > The name `IndentAccessM

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316683. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added newline at end of new file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316681. usaxena95 added a comment. Addressed comments. Ready for landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tools-extra/clangd/ASTSignals

[PATCH] D94699: [clangd] Set correct CWD when using compile_flags.txt

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This fixes a bug where clangd would attempt to set CWD to the compile_flags

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4009 +// mangling. Previously, it used a special-cased nonstandard extension. +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) { ---

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94682/new/ https://reviews.llvm.org/D94682 __

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

MaskRay added a comment. In D94655#2498504 , @dblaikie wrote: > Is there any way to condition this on the type of the output, rather than the > input? (or, more specifically, on whether machine code is being generated) > > Or maybe we could always pass th

[PATCH] D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94681/new/ https://reviews.llvm.org/D94681 __

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. A better sampling strategy was used to gener

[PATCH] D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94680/new/ https://reviews.llvm.org/D94680 __

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1831 + MarshallingInfoString, +!strconcat(open_cl.KeyPath, " ? LangOptions::LaxVectorConversionKind::None" +" : Lan

[PATCH] D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94679/new/ https://reviews.llvm.org/D94679 __

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

dblaikie added a comment. Is there any way to condition this on the type of the output, rather than the input? (or, more specifically, on whether machine code is being generated) Or maybe we could always pass the split-dwarf-file down through LLVM and not need to conditionalize it at all? It'd

[PATCH] D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM with the comment. Comment at: clang/include/clang/Driver/Options.td:5210-5213 def finclude_default_header : Flag<["-"], "finclude-default-header">, - HelpText<"I

  1   2   >