[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. I have run clang static analysis on random open source projects. The very first finding that I look at seems (to me) to be a false positive. :-( My code seems to think that a variable `print_count` has the value INT_MAX for some reason and to me that seems impos

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

craig.topper added inline comments. Comment at: clang/lib/Headers/mmintrin.h:1264 { -return (__m64)__builtin_ia32_pcmpgtw((__v4hi)__m1, (__v4hi)__m2); +return (__m64)((__v4hi)__m1 > (__v4hi)__m2); } jyknight wrote: > craig.topper wrote: > > Same here >

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

balazske updated this revision to Diff 315055. balazske added a comment. Removing unrelated (for the bug fix) change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D92812: [X86] Update tests for znver3

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbfc1ac4d86c: [X86] Update tests for znver3 (authored by GGanesh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812

[clang] dbfc1ac - [X86] Update tests for znver3

Author: Ganesh Gopalasubramanian Date: 2021-01-07T11:51:50+05:30 New Revision: dbfc1ac4d86c1c08dc5ccd90a0389254e13c6d01 URL: https://github.com/llvm/llvm-project/commit/dbfc1ac4d86c1c08dc5ccd90a0389254e13c6d01 DIFF: https://github.com/llvm/llvm-project/commit/dbfc1ac4d86c1c08dc5ccd90a0389254e13

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby marked 2 inline comments as done. DavidTruby added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5137 + + if (!isHomogeneousAggregateForABI(CXXRD)) +return false; rnk wrote: > Apologies for moving the goalposts, but after r

[PATCH] D92751: [clang][aarch64] Precondition isHomogeneousAggregate on isCXX14Aggregate

DavidTruby updated this revision to Diff 315042. DavidTruby added a comment. Refactor based on review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92751/new/ https://reviews.llvm.org/D92751 Files: clang/lib/CodeGen/CGCXXABI.h clang/lib/CodeGe

[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

jyknight created this revision. jyknight added reviewers: craig.topper, spatel, RKSimon. Herald added subscribers: dang, pengfei. jyknight requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This set of instructions was only s

[PATCH] D86855: Convert __m64 intrinsics to unconditionally use SSE2 instead of MMX instructions.

jyknight marked 7 inline comments as done. jyknight added a comment. Herald added a subscriber: pengfei. I've finally got back to moving this patch forward -- PTAL, thanks! To start with, I wrote a simple test-suite to verify the functionality of these changes. I've included the tests I wrote un

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:784 +} + } + 1) If we would need this, remove the Counter stuff everywhere, if you want to iterate a container: `for (const T& : Container)` 2) `BlockParents` seems to be

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 added a comment. In D93978#2479440 , @sammccall wrote: > Ah, thanks for working on this! > > A few thoughts: > > - when we're pseudoparsing the file we're going to modify as we do here, > using the new content is strictly better, no downside :-)

[clang-tools-extra] 3505d8d - [clangd][NFC] Use PathRef for getCorrespondingHeaderOrSource

Author: Nathan James Date: 2021-01-07T02:41:19Z New Revision: 3505d8dc07427b3d9165538d8f1cee574ea66804 URL: https://github.com/llvm/llvm-project/commit/3505d8dc07427b3d9165538d8f1cee574ea66804 DIFF: https://github.com/llvm/llvm-project/commit/3505d8dc07427b3d9165538d8f1cee574ea66804.diff LOG:

[PATCH] D92270: [ConstantFold] Fold more operations to poison

thakis added a comment. It turned out to be UB in our code as far as I can tell, see https://bugs.chromium.org/p/angleproject/issues/detail?id=5500#c36 and the follow-on. (If this is known to trigger an existing bug more often, it might still be a good idea to undo it until that existing bug i

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(doub

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(doub

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek created this revision. rjelonek added reviewers: rsmith, rnk. rjelonek created this object with visibility "All Users". rjelonek created this object with edit policy "Members of Project: clang". rjelonek added a project: clang-format. rjelonek requested review of this revision. Herald adde

[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e83bc6db3a: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy (authored by varungandhi-apple). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 37e83bc - [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

Author: Varun Gandhi Date: 2021-01-06T16:44:50-08:00 New Revision: 37e83bc6db3ad7d9a5d182694ebe71ebbc6120de URL: https://github.com/llvm/llvm-project/commit/37e83bc6db3ad7d9a5d182694ebe71ebbc6120de DIFF: https://github.com/llvm/llvm-project/commit/37e83bc6db3ad7d9a5d182694ebe71ebbc6120de.diff

[PATCH] D93868: [analyzer] Update Fuchsia checker to catch when releasing unowned handles.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8deaec122ec6: [analyzer] Update Fuchsia checker to catch releasing unowned handles. (authored by Daniel Hwang , committed by haowei). Herald added a project: clang. Herald added a subscr

[clang] 8deaec1 - [analyzer] Update Fuchsia checker to catch releasing unowned handles.

Author: Daniel Hwang Date: 2021-01-06T16:23:49-08:00 New Revision: 8deaec122ec68746c53ec2afb893873124053d8d URL: https://github.com/llvm/llvm-project/commit/8deaec122ec68746c53ec2afb893873124053d8d DIFF: https://github.com/llvm/llvm-project/commit/8deaec122ec68746c53ec2afb893873124053d8d.diff

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(double

[PATCH] D92270: [ConstantFold] Fold more operations to poison

aqjune added a comment. To fix the old bug quite a few patches in LLVM have landed so far and it is still ongoing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92270/new/ https://reviews.llvm.org/D92270 __

[PATCH] D92270: [ConstantFold] Fold more operations to poison

aqjune added a comment. In D92270#2482741 , @thakis wrote: > We bisected a test failure to this > (https://bugs.chromium.org/p/angleproject/issues/detail?id=5500#c17). Can you > expand a bit on what this patch means in practice? I'm guessing it makes UB

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark

rjelonek created this revision. rjelonek added reviewers: rsmith, rnk. rjelonek created this object with visibility "All Users". rjelonek created this object with edit policy "Members of Project: clang". rjelonek added a project: clang-format. rjelonek requested review of this revision. Herald adde

[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

dschuff added inline comments. Comment at: llvm/lib/CodeGen/WasmEHPrepare.cpp:374-375 + // be lowered to wasm 'catch' instruction. We do this mainly because + // instruction selection cannot handle wasm.get.exception intrinsic's token + // argument. + Instruction *CatchCI = -

[PATCH] D93095: Introduce -Wreserved-identifier

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:377 + "%0 is a reserved identifier">, + InGroup, DefaultIgnore; + If you leave it like this, you //will// receive multiple bug reports per year about how in some co

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

phosek added a comment. In D93668#2482995 , @rnk wrote: > I guess a triple of -fuchsia-itanium would be a reasonable way of expressing > this. > > Why would we want a feature flag for the wasm C++ ABI? Is there a use case > for using the webassembly C++

[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94196/new/ https://reviews.llvm.org/D94196 _

[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

varungandhi-apple updated this revision to Diff 315005. varungandhi-apple added a comment. Appease clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94196/new/ https://reviews.llvm.org/D94196 Files: clang/include/clang/AST/APValue.h cl

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(doub

[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

varungandhi-apple created this revision. varungandhi-apple added a reviewer: rjmccall. varungandhi-apple requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The implementation for (de)serialization of APValues can be shared between Clang and Sw

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(double

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

sdesmalen added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3034 +integer and the type of vectorization can be specified with an optional +second parameter. In this case 'fixed' is the default and refers to fixed width +vectorization, whereas 'scalable' indicat

[PATCH] D93587: [hip] Fix HIP version parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a29ce303451: [hip] Fix HIP version parsing. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93587/new/ https://reviews.llvm.org/D93587

[clang] 2a29ce3 - [hip] Fix HIP version parsing.

Author: Michael Liao Date: 2021-01-06T17:00:14-05:00 New Revision: 2a29ce303451375bbf1de7c971296553ef5d9beb URL: https://github.com/llvm/llvm-project/commit/2a29ce303451375bbf1de7c971296553ef5d9beb DIFF: https://github.com/llvm/llvm-project/commit/2a29ce303451375bbf1de7c971296553ef5d9beb.diff

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(doub

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

rnk added a comment. I guess a triple of -fuchsia-itanium would be a reasonable way of expressing this. Why would we want a feature flag for the wasm C++ ABI? Is there a use case for using the webassembly C++ ABI on non-wasm ISAs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

phosek added a comment. I'd prefer to use the target triple rather than introducing a custom flag. With dedicated flags, you might eventually end up in a similar situation as D85802 , that is in the extreme case you might end up with `-f[no-]fuchsia-c++-abi`, `-

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L marked 9 inline comments as done. Xiangling_L added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:893 +def warn_pragma_pack_identifer_not_supported : Warning< + "specifying an identifier within pragma pack is not supported, identifier

[PATCH] D92954: [clang-offload-bundler] Add option -list

This revision was automatically updated to reflect the committed changes. Closed by commit rG90bf3ecef4bb: [clang-offload-bundler] Add option -list (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D929

[clang] 90bf3ec - [clang-offload-bundler] Add option -list

Author: Yaxun (Sam) Liu Date: 2021-01-06T16:23:01-05:00 New Revision: 90bf3ecef4bb1e214a718aebcee730c24199c8ba URL: https://github.com/llvm/llvm-project/commit/90bf3ecef4bb1e214a718aebcee730c24199c8ba DIFF: https://github.com/llvm/llvm-project/commit/90bf3ecef4bb1e214a718aebcee730c24199c8ba.dif

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

dexonsmith added a comment. Please also update the commit message to explain why this is safe (that `-fp-exception-behavior` fully encapsulates the semantics for `-cc1`) rather than just saying the options were ignored (which sounds like a bug). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

dexonsmith accepted this revision. dexonsmith added a comment. LGTM. I've just done a careful audit myself, and I'm now confident this patch is correct and that there is no latent bug -- that it's correct to ignore `-f*trapping-math` on the `-cc1` command-line since `-fp-exception-mode` will al

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews.llvm.org/D93901 ___

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 314962. thezbyg added a comment. Switched `EmptyLineBeforeAccessModifierStyle` option from bool to enum. `EmptyLineBeforeAccessModifierStyle` option can now have one of four values: `Never`, `DontModify`, `LogicalBlock`, `Always`. `Never` removes all empty li

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

Anastasia added a comment. This patch is uploaded on top of https://reviews.llvm.org/D93942 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94188/new/ https://reviews.llvm.org/D94188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. (Marking as "Request Changes" to drop this from my queue; feel free to reach out if the direction I suggested isn't working well...) Repository: rG LLVM Github Monorepo C

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

jtmott-intel updated this revision to Diff 314965. jtmott-intel added a comment. Updated comments to reflect "outside of" instead of "before". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92892/new/ https://reviews.llvm.org/D92892 Files: clang/lib/AST/ExprConstant.cpp clang/test/C

[PATCH] D93701: [clang][cli] NFC: Pass an ignoring DiagnosticsEngine instead of nullptr to ParseDiagnosticArgs

dexonsmith added a comment. With the above adjustment, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93701/new/ https://reviews.llvm.org/D93701 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D93701: [clang][cli] NFC: Pass an ignoring DiagnosticsEngine instead of nullptr to ParseDiagnosticArgs

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1400-1402 bool clang::ParseDiagnosticArgs(DiagnosticOptions &Opts, ArgList &Args, -DiagnosticsEngine *Diags, +DiagnosticsEngine

[PATCH] D94188: [OpenCL] add documentation for experimental C++ libraries support

Anastasia created this revision. Anastasia added a reviewer: mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Started a new doc section about the OpenCL experimental features and described ongoing work on C++ libraries e.g. type traits. https:/

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e874fc014be: [OpenCL] Add clang extension for variadic functions. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D94027?vs=314869&id=314964#to

[PATCH] D94021: [OpenCL] Add clang extension for function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fde2b6a0c08: [OpenCL] Add clang extension for function pointers. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D94021?vs=314411&id=314963#toc

[clang] 0e874fc - [OpenCL] Add clang extension for variadic functions.

Author: Anastasia Stulova Date: 2021-01-06T20:39:57Z New Revision: 0e874fc014be818a9c6782729f2c8e8273a7a906 URL: https://github.com/llvm/llvm-project/commit/0e874fc014be818a9c6782729f2c8e8273a7a906 DIFF: https://github.com/llvm/llvm-project/commit/0e874fc014be818a9c6782729f2c8e8273a7a906.diff

[clang] 4fde2b6 - [OpenCL] Add clang extension for function pointers.

Author: Anastasia Stulova Date: 2021-01-06T20:39:57Z New Revision: 4fde2b6a0c080cb2a598383b5850038d67ca6833 URL: https://github.com/llvm/llvm-project/commit/4fde2b6a0c080cb2a598383b5850038d67ca6833 DIFF: https://github.com/llvm/llvm-project/commit/4fde2b6a0c080cb2a598383b5850038d67ca6833.diff

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702

[PATCH] D94172: [clang][cli] NFC: Move parseSimpleArgs

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94172/new/ https://reviews.llvm.org/D94172

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: clang/include/clang/Driver/Options.td:1193-1195 +defm caret_diagnostics : BoolFOption<"caret-diagnostics", + "DiagnosticOpts->ShowCarets", DefaultsToTrue, + ChangedBy, ResetBy>, IsDiag; There was one thing in the or

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl updated this revision to Diff 314957. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92954/new/ https://reviews.llvm.org/D92954 Files: clang/test/Driver/clang-offload-bundler.c clang/

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:176 + /// List bundle IDs in \a Input. + virtual Error listBundleIDs(MemoryBuffer &Input) { +if (Error Err = ReadHeader(Input)) -

[PATCH] D92270: [ConstantFold] Fold more operations to poison

thakis added a comment. We bisected a test failure to this (https://bugs.chromium.org/p/angleproject/issues/detail?id=5500#c17). Can you expand a bit on what this patch means in practice? I'm guessing it makes UB in C++ code have bad effects more often? If so, what type of UB? Repository: r

[clang-tools-extra] 0bfe100 - [NFC] Test case refactor

Author: Nathan James Date: 2021-01-06T20:00:15Z New Revision: 0bfe100145634988e4a914da776b55509ba0bec0 URL: https://github.com/llvm/llvm-project/commit/0bfe100145634988e4a914da776b55509ba0bec0 DIFF: https://github.com/llvm/llvm-project/commit/0bfe100145634988e4a914da776b55509ba0bec0.diff LOG:

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482730 , @tmsriram wrote: > In D93747#2482726 , @hoy wrote: > >> In D93747#2482519 , @tmsriram wrote: >> >>> In D93747#2481494

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2482726 , @hoy wrote: > In D93747#2482519 , @tmsriram wrote: > >> In D93747#2481494 , @dblaikie wrote: >> >>> In D93747#2481383

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314955. hoy added a comment. Renaming debug linkage name if it preexisits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2482519 , @tmsriram wrote: > In D93747#2481494 , @dblaikie wrote: > >> In D93747#2481383 , @hoy wrote: >> >>> In D93747#2481304

[PATCH] D94186: [FPEnv][PowerPC] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn created this revision. kpn added reviewers: steven.zhang, nemanjai. kpn added a project: clang. Herald added subscribers: shchenz, kbarton. kpn requested review of this revision. Herald added a subscriber: cfe-commits. Currently clang is not correctly retrieving from the AST the metadata for

[PATCH] D94185: [OpenMP][Docs] Mark finished features as done

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94185/new/ https://reviews.llvm.org/D94185 ___ c

[PATCH] D93587: [hip] Fix HIP version parsing.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM overall. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:92 +// Parse and extract version numbers from `.hipVersion`. Return `true` if +// the parsing fails. +bool RocmInst

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

rnk added a comment. Generally makes sense, but I had a concern. Comment at: clang/include/clang/Basic/LangOptions.h:333 + /// the -ffuchsia-c++-abi flag. + bool UseFuchsiaCXXABI; + Why isn't this part of the LangOptions.def xmacro list? Repository: rG LL

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

apazos added a comment. Can you confirm when the GNU toolchain will have this flag supported in their assembler? Compatibility between LLVM and GNU toolchains is important. Stephen - I think we can abandon this review. Users will need to be made aware of this additional assembler flag when buil

[PATCH] D94185: [OpenMP][Docs] Mark finished features as done

jdoerfert created this revision. jdoerfert added a reviewer: ABataev. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

tra added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inline)) +__HOST_DEVICE__ double _Cosh(double

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

jdoerfert added a comment. In D94123#2482636 , @MaskRay wrote: > If you use `arc diff`, you can obtain `Reviewed-by:` line from Phabricator. > It is more useful than `Reviewers: ` (a list of reviewers do not mean they > endorse or accept the patch) `arc

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

MaskRay added a comment. If you use `arc diff`, you can obtain `Reviewed-by:` line from Phabricator. It is more useful than `Reviewers: ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Headers/__clang_hip_runtime_wrapper.h:73-74 +#define __HOST_DEVICE__ \ + static __host__ __device__ inline __attribute__((always_inl

[PATCH] D93638: [hip] Enable HIP compilation with ` on MSVC.

hliao updated this revision to Diff 314943. hliao added a comment. Only mark HD attributes in ymath.h wrapper header when compiled with MSVC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93638/new/ https://reviews.llvm.org/D93638 Files: clang/l

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ca5e68aa07e: [NVPTX] Fix debugging information being added to NVPTX target if remarks are… (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 1ca5e68 - [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

Author: Joseph Huber Date: 2021-01-06T13:43:22-05:00 New Revision: 1ca5e68aa07e30567c6aa2409c5641e0a2d77355 URL: https://github.com/llvm/llvm-project/commit/1ca5e68aa07e30567c6aa2409c5641e0a2d77355 DIFF: https://github.com/llvm/llvm-project/commit/1ca5e68aa07e30567c6aa2409c5641e0a2d77355.diff

[PATCH] D93587: [hip] Fix HIP version parsing.

hliao updated this revision to Diff 314941. hliao marked an inline comment as done. hliao added a comment. Revise following reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93587/new/ https://reviews.llvm.org/D93587 Files: clan

[PATCH] D93587: [hip] Fix HIP version parsing.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:97 for (auto Part : VersionParts) { auto Splits = Part.split('='); +if (Splits.first == "HIP_VERSION_MAJOR") { tra wrote: > `Part.t

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___ cfe-co

[PATCH] D89490: Introduce __attribute__((darwin_abi))

rjmccall added a comment. I'm not calling Wine a niche use-case, I'm calling this feature a niche use-case. The lack of this feature has not blocked Wine from being a successful project. The feature has to stand on its own and be more broadly useful than the momentary convenience of a few dev

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

rjmccall added a comment. In D93377#2481957 , @hubert.reinterpretcast wrote: > In D93377#2481312 , @rjmccall wrote: > >> Are you committed to the name `__ibm128`? > > Insofar as that's what GCC on Power (for exampl

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2481494 , @dblaikie wrote: > In D93747#2481383 , @hoy wrote: > >> In D93747#2481304 , @tmsriram wrote: >> >>> In D93747#2481223

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

rjmccall added a comment. In D94092#2481857 , @aaron.ballman wrote: > In D94092#2481276 , @rjmccall wrote: > >> Without bothering to look it up, I would guess that the attribute-parsing >> code used to generically

[PATCH] D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled

jdoerfert added a comment. OK with me, @tra ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94123/new/ https://reviews.llvm.org/D94123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ef9139a391a: [Clang] Remove unnecessary Attr.isArgIdent checks. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 7ef9139 - [Clang] Remove unnecessary Attr.isArgIdent checks.

Author: Florian Hahn Date: 2021-01-06T18:01:41Z New Revision: 7ef9139a391a6d526afab0216a97f9d65a6b5563 URL: https://github.com/llvm/llvm-project/commit/7ef9139a391a6d526afab0216a97f9d65a6b5563 DIFF: https://github.com/llvm/llvm-project/commit/7ef9139a391a6d526afab0216a97f9d65a6b5563.diff LOG:

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. LGTM, perhaps wait a day with committing in case there are more comments. Comment at: clang/include/clang/Basic/Attr.td:3356 EnumArgument<"State", "LoopHintState", - ["en

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2901 + // Skip the declaration if injected type is already set. + if (isa(RI->getTypeForDecl())) +continue; balazske wrote: > shafik wrote: > > Is this to fix th

[PATCH] D92892: [clang] Change builtin object size to be compatible with GCC when sub-object is invalid

george.burgess.iv accepted this revision. george.burgess.iv added a comment. This revision is now accepted and ready to land. thanks for working on this! just one tiny nit and lgtm Comment at: clang/lib/AST/ExprConstant.cpp:11408 // If we point to before the start of the

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/test/Sema/reserved-identifier.c:9 +int _foo() { return 0; }// expected-warning {{'_foo' is a reserved identifier}} + +// This one is explicitly skipped by -Wreserved-identifier Can you add a test tha

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfd3384feeca: [InstCombine] Update valueCoversEntireFragment to use TypeSize (authored by fpetrogalli, committed by peterwaller-arm). Repository:

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

Xiangling_L updated this revision to Diff 314911. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Add pre-committing tests with the incorrect behaviour as part of the NFC patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews.llvm.org/

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3040 -#define OPTION_WITH_MARSHALLING( \ -PREFIX_TYPE, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ -HELPTEXT, ME

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return MarshallingInfo:

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm added a comment. Hi everyone, I realise that most people have probably been on holiday recently, but just a gentle ping here to see if anyone could take another look? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new/ https://reviews.llvm.org/D89031 ___

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314907. jansvoboda11 added a comment. Use arrow instead of dot in keypath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/Diagno

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7809fa204000: [flang][driver] Add support for `-D`, `-U` (authored by FarisRehman, committed by awarzynski). Changed prior to commit: https://revi

  1   2   >