[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

2020-12-26 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau updated this revision to Diff 313767. qchateau added a comment. - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/ https://reviews.llvm.org/D93829 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

2020-12-26 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgrang. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The implementation is ver

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2020-12-26 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1241 if (TheTok.getIdentifierInfo() == VariadicParamII) { -TStream.injectRange(PrevParamMap.at(VariadicParamII)); +if (PrevParamMap.find(VariadicPar

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2020-12-26 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Thanks @steakhal , I found your Bugzilla bug only after I submitted this patch. I'll revise based on your comments and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D9

[PATCH] D93595: [analyzer] Fix extraction of punned and known scalar SVals

2020-12-26 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Thanks for the comments, @NoQ . I'll carefully review and update. BTW, I found an old Bugzilla case that seems to relate to this change directly -> https://bugs.llvm.org/show_bug.cgi?id=2820. Once this change is evolved and accepted, I'll update that Bugzilla issue a

[PATCH] D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation

2020-12-26 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc7dcc4c72588: [clang-format] PR48569 clang-format fails to align case label with `switch`… (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D93806?vs=313699&id=313746#toc

[clang] c7dcc4c - [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation

2020-12-26 Thread via cfe-commits
Author: mydeveloperday Date: 2020-12-26T15:19:03Z New Revision: c7dcc4c72588db9ffb7ae379983450193b943f5b URL: https://github.com/llvm/llvm-project/commit/c7dcc4c72588db9ffb7ae379983450193b943f5b DIFF: https://github.com/llvm/llvm-project/commit/c7dcc4c72588db9ffb7ae379983450193b943f5b.diff LOG

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

2020-12-26 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri created this revision. lebedev.ri added reviewers: rsmith, aaron.ballman, rjmccall, erichkeane, dblaikie. lebedev.ri added a project: LLVM. lebedev.ri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Overflows are never fun. In m

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

2020-12-26 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. We are using this patch in llvm/clang for VE and the patch is really helpful to implement intrinsic instructions using vector mask registers. This works fine in backend since backend supports vXi1. I wish people working on clang think this patch is reasonable. ===

[PATCH] D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation

2020-12-26 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. In D93806#2471738 , @MyDeveloperDay wrote: > This is the closest I could find thus far > http://bitsavers.informatik.uni-stuttgart.de/pdf/chromatics/CGC_7900_C_Programmers_Manual_Mar82.pdf > > and the very few examples from the

[PATCH] D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation

2020-12-26 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. This is the closest I could find thus far http://bitsavers.informatik.uni-stuttgart.de/pdf/chromatics/CGC_7900_C_Programmers_Manual_Mar82.pdf and the very few examples from the manual show the case is aligned with the switch F14838781: image.png

[PATCH] D78058: option to write files to memory instead of disk

2020-12-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. @dexonsmith thanks for sharing! Some initial thoughts since abstracting outputs is something we're starting to care about too... This doesn't appear to be an extension point - you can write to an InMemoryFS or to real disk, but not to anything else. If we're going to