[PATCH] D87981: [X86] AMX programming model prototype.

2020-11-14 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke updated this revision to Diff 305345. LuoYuanke added a comment. Rename type name __tile to __tile1024i. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/Builtins

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

2020-11-14 Thread Shane via Phabricator via cfe-commits
smhc added a comment. I updated it to use XXShortSizeThreshold. But I was thinking.. perhaps a more generic approach could be "xxIgnoreRegex", this would allow you to do things such as : VariableIgnoreRegex: ([a-z]{2}|index) ClassIgnoreRegex: (Special_CASE|CommonOther.*) etc. it would be more

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

2020-11-14 Thread Shane via Phabricator via cfe-commits
smhc updated this revision to Diff 305341. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h clang-tools

[PATCH] D91489: BPF: make __builtin_btf_type_id() return 64bit int

2020-11-14 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. yonghong-song requested review of this revision. Linux kernel recently added support for kernel modules https:/

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

2020-11-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a subscriber: dexonsmith. Herald added a project: clang. rsmith requested review of this revision. For the Itanium ABI, this implements the mangling rule suggested in https://github.com/itanium-cxx-abi/cxx-abi/issues/47,

[PATCH] D90329: [PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets

2020-11-14 Thread George Koehler via Phabricator via cfe-commits
kernigh updated this revision to Diff 305335. kernigh retitled this revision from "[PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets" to "[PowerPC] Fix va_arg in C++, Objective-C on 32-bit ELF targets". kernigh edited the summary of this revision. kernigh added a comment. I have updated

[PATCH] D54986: Make CodeGen choose when to emit vtables.

2020-11-14 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. @rsmith, what was the fate of this patch? I thought it landed but cannot find a trace of it in the master... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54986/new/ https://reviews.llvm.org/D54986 _

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

2020-11-14 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in aca191cce1c4dbab28a65cfe4caa6348e698a2b3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 _

[PATCH] D34912: Handle cases where the value is too large to fit into the underlying type.

2020-11-14 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Closing this in favor of D77598 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34912/new/ https://reviews.llvm.org/D34912 ___ cfe-commits mai

[PATCH] D53925: [modules] Defer emission of inline key functions.

2020-11-14 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev abandoned this revision. v.g.vassilev added a comment. Landed as D54986 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53925/new/ https://reviews.llvm.org/D53925 ___ cfe-co

[PATCH] D91485: [clang-tidy] ElseAfterReturn check wont suggest fixes if preprocessor branches are involved

2020-11-14 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 requested review of this revision. Consider this code: if (Cond) { #ifdef X_SUPPORTED X(); #else return; #endi

[clang] 23cc838 - Add forgotten in 888d06d file.

2020-11-14 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2020-11-14T21:32:23Z New Revision: 23cc838099e10b13a32e54105f4db0f1b7e3a842 URL: https://github.com/llvm/llvm-project/commit/23cc838099e10b13a32e54105f4db0f1b7e3a842 DIFF: https://github.com/llvm/llvm-project/commit/23cc838099e10b13a32e54105f4db0f1b7e3a842.diff LO

[clang] 888d06d - Move the test compiler setup in a common place. NFCI

2020-11-14 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2020-11-14T21:30:30Z New Revision: 888d06dfb8b55c4fd41fa4febe22c6fc4111c118 URL: https://github.com/llvm/llvm-project/commit/888d06dfb8b55c4fd41fa4febe22c6fc4111c118 DIFF: https://github.com/llvm/llvm-project/commit/888d06dfb8b55c4fd41fa4febe22c6fc4111c118.diff LO

[PATCH] D91061: Move the test compiler setup in a common place. NFCI

2020-11-14 Thread Vassil Vassilev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG888d06dfb8b5: Move the test compiler setup in a common place. NFCI (authored by v.g.vassilev). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

[clang] c35448b - [Driver][test] Fix cc1-spawnprocess.c

2020-11-14 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-11-14T09:53:34-08:00 New Revision: c35448ba80bdaddaf4d4f7d2076da3b24135148a URL: https://github.com/llvm/llvm-project/commit/c35448ba80bdaddaf4d4f7d2076da3b24135148a DIFF: https://github.com/llvm/llvm-project/commit/c35448ba80bdaddaf4d4f7d2076da3b24135148a.diff

Re: [PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

2020-11-14 Thread Faisal Vali via cfe-commits
yay! Thanks Thorsten - if no one else does it - i'll try and commit this for you later today :) Faisal Vali On Sat, Nov 14, 2020 at 11:08 AM Thorsten via Phabricator < revi...@reviews.llvm.org> wrote: > tschuett added a comment. > > I started with specifiers.h here: https://reviews.llvm.org/D

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

2020-11-14 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I started with specifiers.h here: https://reviews.llvm.org/D91409, but it is not yet committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91035/new/ https://reviews.llvm.org/D91035 ___

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

2020-11-14 Thread Faisal Vali via Phabricator via cfe-commits
faisalv updated this revision to Diff 305317. faisalv added a comment. This diff makes the following changes to the previous patch (based on feedback from Richard, Aaron and Wyatt): - avoid introducing an initialism (FDK) into the clang namespace and unabbreviated each corresponding use to 'Fun

[clang] 0a6e051 - [NFC] Small refactor to CompilationDatabase

2020-11-14 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-11-14T14:03:35Z New Revision: 0a6e051a9b30cc1eade2c7a5045c9c643598499b URL: https://github.com/llvm/llvm-project/commit/0a6e051a9b30cc1eade2c7a5045c9c643598499b DIFF: https://github.com/llvm/llvm-project/commit/0a6e051a9b30cc1eade2c7a5045c9c643598499b.diff LOG:

[clang] db6f7e0 - [git-clang-format] Process CUDA header files

2020-11-14 Thread via cfe-commits
Author: mydeveloperday Date: 2020-11-14T12:39:16Z New Revision: db6f7e0e9ec20049bfbb7c965baa90e1b9e56d3f URL: https://github.com/llvm/llvm-project/commit/db6f7e0e9ec20049bfbb7c965baa90e1b9e56d3f DIFF: https://github.com/llvm/llvm-project/commit/db6f7e0e9ec20049bfbb7c965baa90e1b9e56d3f.diff LOG

[PATCH] D90780: [git-clang-format] Process CUDA header files

2020-11-14 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb6f7e0e9ec2: [git-clang-format] Process CUDA header files (authored by MyDeveloperDay). Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D91351: [tooling] Implement determinsitic ordering of CompilationDatabasePlugins

2020-11-14 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I'm hesitant to land this right away, want to see what happens with D91454 and its related mailing list . In my mind thats a much nicer way to fix this issue. Reposi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

2020-11-14 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Reverted in rG6861d938e5c946cc7079d9849ef7560d07aa2d80 , looking forward to the rework! Repository: rL LLVM CH

[clang] bc7df03 - Make -fintegrated-cc1 work with cc1as

2020-11-14 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-11-14T01:16:16-08:00 New Revision: bc7df035ae68648fe39304d9e77cd7618812cca8 URL: https://github.com/llvm/llvm-project/commit/bc7df035ae68648fe39304d9e77cd7618812cca8 DIFF: https://github.com/llvm/llvm-project/commit/bc7df035ae68648fe39304d9e77cd7618812cca8.diff

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

2020-11-14 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: llvm/test/Transforms/Inline/inline_nossp.ll:3 +; RUN: opt -passes='cgscc(inline)' %s -S | FileCheck %s +; RUN: opt -always-inline -o - -S %s | FileCheck %s + This test fails with the NPM, `opt -passes=always-inline ...`