[PATCH] D91129: Print source location in the error message when parens are missing around sizeof typename and the expression is inside macro expansion

shivanshu3 created this revision. shivanshu3 added reviewers: zahen, hans, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. shivanshu3 requested review of this revision. Given the following code: void Foo(int); #define Bar(x) Foo(x) void Baz() {

[PATCH] D89790: [clangd] Add basic conflict detection for the rename.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaa736da10fd: [clangd] Add basic conflict detection for the rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] daa736d - [clangd] Add basic conflict detection for the rename.

Author: Haojian Wu Date: 2020-11-10T08:52:30+01:00 New Revision: daa736da10fd340d63fa828e86e4f4bd6961d6f3 URL: https://github.com/llvm/llvm-project/commit/daa736da10fd340d63fa828e86e4f4bd6961d6f3 DIFF: https://github.com/llvm/llvm-project/commit/daa736da10fd340d63fa828e86e4f4bd6961d6f3.diff LO

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

kadircet updated this revision to Diff 304060. kadircet added a comment. - Preserve location of external block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90748/new/ https://reviews.llvm.org/D90748 Files: clang-tools-extra/clangd/ConfigFragme

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

rjmccall added a comment. This is great work, thank you. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5349 +def note_because_captured_by_block : Note< + "because it is captured by a block used in its own initializer">; + This will read okay on

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

ArcsinX added a comment. In D90116#2383999 , @kbobyrev wrote: > Sigh, this doesn't work because we have things like > https://docs.microsoft.com/en-us/windows/win32/api/traceloggingprovider/nf-traceloggingprovider-tracelogging_define_provider > and > ht

[clang] 724877e - Roll otherwise-unused variable into assert

Author: David Blaikie Date: 2020-11-09T23:27:47-08:00 New Revision: 724877e219cd219c4b757f10ac4484193cd30c6a URL: https://github.com/llvm/llvm-project/commit/724877e219cd219c4b757f10ac4484193cd30c6a DIFF: https://github.com/llvm/llvm-project/commit/724877e219cd219c4b757f10ac4484193cd30c6a.diff

[PATCH] D91111: [CodeGen] Mark calls to objc_autorelease as tail

rjmccall added a comment. Alright. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] b637148 - [c++20] For P0732R2 / P1907R1: Basic code generation and name

Author: Richard Smith Date: 2020-11-09T22:10:27-08:00 New Revision: b637148ecb62b900872b34eedd78b923bb43c378 URL: https://github.com/llvm/llvm-project/commit/b637148ecb62b900872b34eedd78b923bb43c378 DIFF: https://github.com/llvm/llvm-project/commit/b637148ecb62b900872b34eedd78b923bb43c378.diff

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb637148ecb62: [c++20] For P0732R2 / P1907R1: Basic code generation and name (authored by rsmith). Changed prior to commit: https://reviews.llvm.or

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

lebedev.ri added a comment. In D90392#2362118 , @njames93 wrote: > IIUC, this is handling the case where `Ptr.reset(new int)` which is different > to `Ptr.reset(new int())` because the former doesn't initialise the int while > the latter default(zero) in

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 304048. nridge added a comment. Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/X

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Support for outgoing calls is left for a f

[PATCH] D89296: [clangd] Implement call hierarchy (incoming calls)

nridge updated this revision to Diff 304045. nridge added a comment. Split patch as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files: clang-tools-extra/clangd/Protocol.cpp clang-tools-ext

[PATCH] D72281: [Matrix] Add matrix type to Clang.

rsmith added inline comments. Herald added a subscriber: dang. Comment at: clang/lib/AST/ItaniumMangle.cpp:3353-3371 + auto &ASTCtx = getASTContext(); + unsigned BitWidth = ASTCtx.getTypeSize(ASTCtx.getSizeType()); + llvm::APSInt Rows(BitWidth); + Rows = T->getNumRows(); + m

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly updated this revision to Diff 304034. ckennelly added a comment. Applied feedback from review - reduced test cases to verify functionality - updated release notes - updated docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ ht

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly added a comment. In D91009#2381590 , @njames93 wrote: > You don't really need to duplicate every single `std::string` test. Just > enough so that it detects it, kind of like `::out::TestString`. Also can you > update the docs and release notes

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. njames93: Ping Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-make-shared.cpp:51 // CHECK-FIXES: std::shared_ptr P1 = std::make_shared(); + std::shared_ptr P2 = std::shared_ptr(new int); steveire wrote: > cken

[clang] d93287c - [scan-build] Supprot relative 'file' in cdb.

Author: Haowei Wu Date: 2020-11-09T20:06:20-08:00 New Revision: d93287cac89fd50a105ac4a59c079884b8e53e49 URL: https://github.com/llvm/llvm-project/commit/d93287cac89fd50a105ac4a59c079884b8e53e49 DIFF: https://github.com/llvm/llvm-project/commit/d93287cac89fd50a105ac4a59c079884b8e53e49.diff LOG

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. With this change in its current state, it's ok to add callbacks, as long as they don't add passes at -O0. Polly adds some callbacks. When I first submitted this, polly would add some callbacks to VectorizerStartEPCallbacks. Those callbacks didn't actually add any passe

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added inline comments. Comment at: clang/docs/ClangPlugins.rst:119 + +Attribute plugin to mark a virtual method as call_super, sub-classes must call it in overridden the method. + aaron.ballman wrote: > aaron.ballman wrote: > > Should add backticks aro

[clang] 979a4d2 - [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

Author: Qiu Chaofan Date: 2020-11-10T10:52:13+08:00 New Revision: 979a4d268a48c27d9c0dce642912bcf648614ef8 URL: https://github.com/llvm/llvm-project/commit/979a4d268a48c27d9c0dce642912bcf648614ef8 DIFF: https://github.com/llvm/llvm-project/commit/979a4d268a48c27d9c0dce642912bcf648614ef8.diff L

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG979a4d268a48: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. In D91107#2384191 , @tstellar wrote: > This code could be improved, but I don't think adding a specific environment > variable for this a good solution. You can use the existing > C

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added a comment. My point is that it is possible for a pass plugin (such as `llvm/examples/Bye`) that can add themselves to the -O0 pipeline. If those plugins are linked statically, it will break tests that assume that no passes are added at those extension points. I don't quite und

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as done. gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > gu

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. In D89158#2384337 , @Meinersbur wrote: > In D89158#2384156 , @aeubanks wrote: > >> Are there passes that should be running at -O0 that aren't target specific? >> Otherwise the callbacks sh

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added a comment. In D89158#2384156 , @aeubanks wrote: > Are there passes that should be running at -O0 that aren't target specific? > Otherwise the callbacks should only add passes if the optimization level > isn't -O0. At least for the legac

[clang] e5dba2d - [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Author: Michael Kruse Date: 2020-11-09T19:35:11-06:00 New Revision: e5dba2d7e5a6ab8266954e13844355d795c8c88b URL: https://github.com/llvm/llvm-project/commit/e5dba2d7e5a6ab8266954e13844355d795c8c88b DIFF: https://github.com/llvm/llvm-project/commit/e5dba2d7e5a6ab8266954e13844355d795c8c88b.diff

[PATCH] D91111: [CodeGen] Mark calls to objc_autorelease as tail

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, jkorous. ahatanak requested review of this revision. This enables a method sending an autorelease message to an object and returning the object in MRR to avoid

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

fghanim accepted this revision. fghanim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91109/new/ https://reviews.llvm.org/D91109 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Meinersbur updated this revision to Diff 304011. Meinersbur added a comment. Missed reference of Create in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91109/new/ https://reviews.llvm.org/D91109 Files: llvm/include/llvm/Frontend/Op

[PATCH] D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable

tstellar added a comment. This code could be improved, but I don't think adding a specific environment variable for this a good solution. You can use the existing CCC_OVERRIDE_OPTIONS to get the same effect. e.g. CCC_OVERRIDE_OPTIONS=^--gcc-toolchain=/path/to/gcc More documentation can be fo

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. The failure seems unrelated to my changes. Trying locally it fails with latest upstream even without my changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 __

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. Are there passes that should be running at -O0 that aren't target specific? Otherwise the callbacks should only add passes if the optimization level isn't -O0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ htt

[PATCH] D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable

tianshilei1992 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Currently, GCC toolchain can only be set via the option `--gcc-too

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added subscribers: serge-sans-paille, Meinersbur. Meinersbur added a comment. Did you consider just removing the `-NEXT` suffix? Polly might not be the only case, other statically linked pass-plugins may also insert themselves at extension points. @serge-sans-paille might have some i

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 304000. Herald added subscribers: steven_wu, hiraditya. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/inc

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo added a comment. In D90507#2378015 , @ikudrin wrote: > 1. The patch needs tests to check the added functionality. > 2. DWARF64 can be generated only for a limited number of targets. There > should be diagnostics for invalid switch combinations to

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3552-3554 +using BodyGenCallbackTy = +llvm::function_ref; Instead of duplicating it here, why not using `OpenMPIRBuilder::BodyGenCallbackTy`? Comment

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 added a comment. In D91103#2384048 , @jingham wrote: > IIUC, the expression parser part of this change suppresses any Fixits that > are clang-tidy type rewrites, is that right? If so that is indeed the > correct behavior. But the fact that thi

[clang] dbfa69c - Port some floating point options to new option marshalling infrastructure

Author: Jan Svoboda Date: 2020-11-09T18:00:10-05:00 New Revision: dbfa69c5024cfe58b8029a3766ec46c857cddb1e URL: https://github.com/llvm/llvm-project/commit/dbfa69c5024cfe58b8029a3766ec46c857cddb1e DIFF: https://github.com/llvm/llvm-project/commit/dbfa69c5024cfe58b8029a3766ec46c857cddb1e.diff L

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbfa69c5024c: Port some floating point options to new option marshalling infrastructure (authored by jansvoboda11, committed by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D82756?vs=3

[clang] 09c6259 - Revert "[Syntax] Add minimal TableGen for syntax nodes. NFC"

Author: Sam McCall Date: 2020-11-09T23:59:11+01:00 New Revision: 09c6259d6d0eb51b282f6c3a28052a8146bc095b URL: https://github.com/llvm/llvm-project/commit/09c6259d6d0eb51b282f6c3a28052a8146bc095b DIFF: https://github.com/llvm/llvm-project/commit/09c6259d6d0eb51b282f6c3a28052a8146bc095b.diff LO

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added a comment. @martong since you hard expressed interest in the "user-visible" version of the data types for the notes, I opted to get them out first. This set of data types are user-facing rather than the previous one that were mistook for them. Subsequent changes will actually a

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd created this revision. compnerd added reviewers: martong, MForster, gribozavr2. Herald added subscribers: rnkovacs, mgorny. Herald added a project: clang. compnerd requested review of this revision. This adds internal representation of the attributes in a more usable form. This is meant

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

jingham added a comment. IIUC, the expression parser part of this change suppresses any Fixits that are clang-tidy type rewrites, is that right? If so that is indeed the correct behavior. But that fact that this change implements that behavior is entirely non-obvious at the call site. Could

[clang] 55120f7 - [Syntax] Add minimal TableGen for syntax nodes. NFC

Author: Sam McCall Date: 2020-11-09T23:45:50+01:00 New Revision: 55120f74ca12faea0e90fe552c85c14485f1fd91 URL: https://github.com/llvm/llvm-project/commit/55120f74ca12faea0e90fe552c85c14485f1fd91 DIFF: https://github.com/llvm/llvm-project/commit/55120f74ca12faea0e90fe552c85c14485f1fd91.diff LO

[PATCH] D90540: [Syntax] Add minimal TableGen for syntax nodes. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rG55120f74ca12: [Syntax] Add minimal TableGen for syntax nodes. NFC (authored by sammccall). Changed prior

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 created this revision. njames93 added reviewers: rsmith, aaron.ballman, klimek, alexfh. Herald added subscribers: lldb-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLDB. njames93 requested review of this revision. Herald added a subscriber: JDevlieghere. Implementing a

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kbobyrev added a comment. Sigh, this doesn't work because we have things like https://docs.microsoft.com/en-us/windows/win32/api/traceloggingprovider/nf-traceloggingprovider-tracelogging_define_provider and https://docs.microsoft.com/en-us/windows/win32/tracelogging/tracelogging-native-quick-st

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

NoQ added a comment. In D52957#2383373 , @steakhal wrote: > In D52957#2379330 , @NoQ wrote: > >> The argument value can be computed by taking the size of the type (and >> aligning to the requested alignment, i gues

[clang-tools-extra] 142c6f8 - [clang] Simplify buildSyntaxTree API

Author: Kirill Bobyrev Date: 2020-11-09T22:49:54+01:00 New Revision: 142c6f82fda8d406ed26f1205d22dc1782653b32 URL: https://github.com/llvm/llvm-project/commit/142c6f82fda8d406ed26f1205d22dc1782653b32 DIFF: https://github.com/llvm/llvm-project/commit/142c6f82fda8d406ed26f1205d22dc1782653b32.diff

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG142c6f82fda8: [clang] Simplify buildSyntaxTree API (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D90672: [clang] Simplify buildSyntaxTree API

kbobyrev updated this revision to Diff 303984. kbobyrev marked an inline comment as done. kbobyrev added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90672/new/ https://reviews.llvm.org/D90672 Files: clang-tools-extra

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d81c8adb6ed: [llvm] CMake: Force MSVC to read code as UTF-8 (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D90775: [clangd] ExternalIndex turns off BackgroundIndex only if it isn't set

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:308 + if (C.Index.Background == Config::BackgroundPolicy::Auto) +C.Index.Background = Config::BackgroundPolicy::Skip; }); sammccall wrote: > doesn

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Still WIP, moving test changes to a separate chain of patches (starts with D91102 ) to make review easier and start the pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D90747: [clangd] Mark AsyncTaskRunner::runAsync as const

kadircet abandoned this revision. kadircet added a comment. SG, gonna abandon this one and mark the threadpool as mutable in the ProjectAwareIndex instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90747/new/ https://reviews.llvm.org/D90747 _

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.llvm.org/D90116

[PATCH] D89296: [clangd] Implement call hierarchy (incoming calls)

kadircet added a comment. Thanks, I skimmed over it (again) and I think this looks pretty great in general. I couldn't take a look at the details yet, I would really appreciate it if you could chop this one into smaller pieces (i know, i asked it before, but this is still too big). I suppose so

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev updated this revision to Diff 303980. kbobyrev added a comment. Move NewName constant to class field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91102/new/ https://reviews.llvm.org/D91102 Files: clang-tools-extra/clangd/unittests/Ren

[PATCH] D91102: [clangd] Enhance Clangd rename testing coverage

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. We plan to eliminate error-prone and obsolete

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

bsaleil updated this revision to Diff 303973. bsaleil added a comment. Simplify control flow and improve test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 Files: clang/include/clang/Basic/Builtin

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

ldionne added a comment. I proposed a revert here for those who are interested: https://reviews.llvm.org/D91099 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42459/new/ https://reviews.llvm.org/D42459 ___ cfe-commits m

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:252 + + llvm::Expected makeAbsolute(std::string Path, + llvm::Stri

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. In D82756#2383317 , @jansvoboda11 wrote: > Thanks, `Jan Svoboda` and `jan_svob...@apple.com` is fine. Is it possible to > add @dang as a co-author? `git log` says he uses `Daniel Grumberg` and > `dany.grumb...@gmail.com`. I

[clang-tools-extra] 7df6340 - [clangd] Fix shared-lib builds

Author: Kadir Cetinkaya Date: 2020-11-09T22:15:08+01:00 New Revision: 7df6340e6fff36346423c4cdb7f27afb603c136c URL: https://github.com/llvm/llvm-project/commit/7df6340e6fff36346423c4cdb7f27afb603c136c DIFF: https://github.com/llvm/llvm-project/commit/7df6340e6fff36346423c4cdb7f27afb603c136c.dif

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

ldionne added a comment. In D42459#2383794 , @hintonda wrote: > In D42459#2383753 , @ldionne wrote: > >> @hintonda Is there a reason why this was done except for "standardizing the >> usage across projects"? > > I

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

hintonda added a comment. In D42459#2383753 , @ldionne wrote: > @hintonda Is there a reason why this was done except for "standardizing the > usage across projects"? It was just for standardization. Please feel free to rollback or modify as necessary.

[PATCH] D90747: [clangd] Mark AsyncTaskRunner::runAsync as const

sammccall added a comment. This isn't a hill I'm going to die on, it doesn't matter a great deal - so if this solves But I don't think this is an appropriate use of const - it changes the object in a significant way. "significant" is vague, but i think "wait()ing on a threadpool will now block

[PATCH] D90885: Tooling: Remove dead code for ToolingInvocation::mapVirtualFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGc56ec7bedeb8: Tooling: Remove dead code for ToolingInvocation::mapVirtualFile (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] c56ec7b - Tooling: Remove dead code for ToolingInvocation::mapVirtualFile

Author: Duncan P. N. Exon Smith Date: 2020-11-09T15:45:35-05:00 New Revision: c56ec7bedeb8b90cfef4c3ea8db3addfa34fde68 URL: https://github.com/llvm/llvm-project/commit/c56ec7bedeb8b90cfef4c3ea8db3addfa34fde68 DIFF: https://github.com/llvm/llvm-project/commit/c56ec7bedeb8b90cfef4c3ea8db3addfa34f

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

smeenai added a comment. In D45639#2360619 , @smeenai wrote: > In D45639#2360267 , @ldionne wrote: > >> - AppleClang prefers the headers in the SDK, and the library in the SDK. >> (The headers are currently still s

[PATCH] D42459: [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

ldionne added a comment. @hintonda Is there a reason why this was done except for "standardizing the usage across projects"? I'm asking because this change prevents us from being able to avoid having a rpath completely when building libc++. That is the behavior we want when building libc++ as

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1837 /// Actually a FunctionDefinitionKind. - unsigned FunctionDefinition : 2; + FunctionDefinitionKind FunctionDefinition : 2; faisalv wrote: > aaron.ballman wrote: > > I

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

faisalv added a comment. In D91035#2383167 , @wchilders wrote: > Generally agree with this direction; Are there plans for migrating > https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Basic/Specifiers.h > in a similar fashion, for cons

[PATCH] D90747: [clangd] Mark AsyncTaskRunner::runAsync as const

kadircet added a comment. In D90747#2379406 , @sammccall wrote: > AsyncTaskRunner is definitely threadsafe, but const doesn't exactly mean > threadsafe... Right, I was also trying to punt on the idea of "writes are synchronized" rather than promising th

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

kadircet updated this revision to Diff 303956. kadircet added a comment. - Define an ExternalIndexSpec structure, and populate that during compile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90749/new/ https://reviews.llvm.org/D90749 Files: c

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:256 + diag(Error, "At least one of File or Server must be specified.", + llvm::SMRange()); + return; sammccall wr

[PATCH] D90976: Fixed an issue where diagnostics printed expressions in a roundabout way

wchilders updated this revision to Diff 303953. wchilders added a comment. Formatting fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90976/new/ https://reviews.llvm.org/D90976 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/Expr.h clang/include/clan

[clang-tools-extra] 2c2680a - [clangd] NFC: Fix a typo in Tracer name

Author: Kirill Bobyrev Date: 2020-11-09T21:18:35+01:00 New Revision: 2c2680a470b59df84db16c4cd876efce91d7d4f2 URL: https://github.com/llvm/llvm-project/commit/2c2680a470b59df84db16c4cd876efce91d7d4f2 DIFF: https://github.com/llvm/llvm-project/commit/2c2680a470b59df84db16c4cd876efce91d7d4f2.diff

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

tra added a comment. Ouch. This is definitely a bug. https://godbolt.org/z/faPWcv Granted, the compilation will eventually fail in most cases due to ptxas failing to resolve the reference to the variable we do not generate on the device, but it's something we should catch in Sema. Filed https

[clang] 23f17ab - Fix use of directly-nested traverse() matchers

Author: Stephen Kelly Date: 2020-11-09T19:23:17Z New Revision: 23f17ab5ff64c993c6242551de44af58c5b43b23 URL: https://github.com/llvm/llvm-project/commit/23f17ab5ff64c993c6242551de44af58c5b43b23 DIFF: https://github.com/llvm/llvm-project/commit/23f17ab5ff64c993c6242551de44af58c5b43b23.diff LOG:

[clang] 8f35471 - Change algorithms to return iterators

Author: Stephen Kelly Date: 2020-11-09T19:12:38Z New Revision: 8f354711ae92be1319190d8ede8992168a682f4e URL: https://github.com/llvm/llvm-project/commit/8f354711ae92be1319190d8ede8992168a682f4e DIFF: https://github.com/llvm/llvm-project/commit/8f354711ae92be1319190d8ede8992168a682f4e.diff LOG:

[clang] 121d51d - Fix trailing whitespace

Author: Stephen Kelly Date: 2020-11-09T19:12:38Z New Revision: 121d51dc835bf9db363f3f90c042f939076b23d3 URL: https://github.com/llvm/llvm-project/commit/121d51dc835bf9db363f3f90c042f939076b23d3 DIFF: https://github.com/llvm/llvm-project/commit/121d51dc835bf9db363f3f90c042f939076b23d3.diff LOG:

[PATCH] D90983: Change algorithms to return iterators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f354711ae92: Change algorithms to return iterators (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy

bruno accepted this revision. bruno added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91011/new/ https://reviews.llvm.org/D91011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90116: [llvm] CMake: Force MSVC to read code as UTF-8

kbobyrev updated this revision to Diff 303942. kbobyrev marked an inline comment as done. kbobyrev added a comment. Omit CXX_COMPILER_ID:MSVC since we're within MSVC section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90116/new/ https://reviews.

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 303940. kbobyrev added a comment. Finish fields canonicalization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/lambda-reference-var.cu:61 + [=](){ +int &ref = global_device_var; +ref++; tra wrote: > Do we have current Sema tests that verify that we we would not allow > accessing host vars here? cur

[PATCH] D91049: [clangd][remote] Check an index file correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bbf87e22a73: [clangd][remote] Check an index file correctly (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1bbf87e - [clangd][remote] Check an index file correctly

Author: Aleksandr Platonov Date: 2020-11-09T21:40:45+03:00 New Revision: 1bbf87e22a73011fdea411baf8fe768f854d497c URL: https://github.com/llvm/llvm-project/commit/1bbf87e22a73011fdea411baf8fe768f854d497c DIFF: https://github.com/llvm/llvm-project/commit/1bbf87e22a73011fdea411baf8fe768f854d497c.

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

hans added a comment. Please take a look. Comment at: clang/lib/Sema/SemaDecl.cpp:13996 } + if (auto *Ctor = dyn_cast(FD)) { I was searching for the right place to do this, looking mostly in the sema template code, but ended up here as an explicit specia

[PATCH] D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811)

hans created this revision. hans added reviewers: rnk, zahiraam. Herald added a project: clang. hans requested review of this revision. For dllexported default constructors with default arguments, we export default constructor closures which pass in the default args. (See D8331

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

steakhal added a comment. In D52957#2379330 , @NoQ wrote: > You cannot have an argument expression because there's no argument expression > anywhere in the AST. There's an argument, but it's not computed as a value of > any syntactic expression. If there

[libunwind] 2c481f1 - [libunwind] Delete unused codeOffsetAtStackDecrement/registersInOtherRegisters/sameValueUsed

Author: Fangrui Song Date: 2020-11-09T10:19:12-08:00 New Revision: 2c481f128cad043498dc404bc7f6d6128bb7c223 URL: https://github.com/llvm/llvm-project/commit/2c481f128cad043498dc404bc7f6d6128bb7c223 DIFF: https://github.com/llvm/llvm-project/commit/2c481f128cad043498dc404bc7f6d6128bb7c223.diff

[PATCH] D91088: [CUDA][HIP] Fix capturing reference to host variable

tra added a subscriber: rsmith. tra added a comment. The use case in the tests makes sense, but I'd like to have a second opinion on whether it may have unintended consequences. Lambdas tend to bring interesting corner cases. @rsmith Richard, do you see any issues with this approach? ===

  1   2   >