[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

balazske added a comment. In D82561#2115578 , @xazax.hun wrote: > The analyzer inlines small functions within a TU regardless of the > thresholds. I think it would be sensible to do the same across TUs in the > case we don't do this already. That means

[PATCH] D82606: [clangd] Config: config struct propagated through Context

kadircet added a comment. Thanks, LGTM. Just a question around the order of config vs other mangling. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compatible. + for (auto &Edit : const_cast(Config::cu

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! This was also my final plan after investigating in https://reviews.llvm.org/D81920, but then I forgot ... Comment at: clang/CMakeLists.txt:398 + if (CMAK

[clang] a7db230 - [X86] Add CMPXCHG16B feature to amdfam10 in the frontend.

Author: Craig Topper Date: 2020-06-25T22:55:36-07:00 New Revision: a7db230d752be4a104c496eb68a82a5acb4bb35c URL: https://github.com/llvm/llvm-project/commit/a7db230d752be4a104c496eb68a82a5acb4bb35c DIFF: https://github.com/llvm/llvm-project/commit/a7db230d752be4a104c496eb68a82a5acb4bb35c.diff

[PATCH] D82506: [HIP] Add missing options for lto

This revision was automatically updated to reflect the committed changes. Closed by commit rG8013ce449022: [HIP] Add missing options for lto (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D82506?vs=273424&id=273588#toc Repository: rG LL

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

vvereschaka added a comment. Hello Eduardo, sorry, but one of your these commits break the clang unit tests on the following builders: - http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/18313 - http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/256 - http://lab

[clang] 8013ce4 - [HIP] Add missing options for lto

Author: Yaxun (Sam) Liu Date: 2020-06-26T00:26:05-04:00 New Revision: 8013ce4490225faf8aae911ee88087ce445e604c URL: https://github.com/llvm/llvm-project/commit/8013ce4490225faf8aae911ee88087ce445e604c DIFF: https://github.com/llvm/llvm-project/commit/8013ce4490225faf8aae911ee88087ce445e604c.dif

[clang] 471c806 - [hip] Refine `clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu`

Author: Michael Liao Date: 2020-06-25T23:57:08-04:00 New Revision: 471c806a45bbac2f0f4274d8bea383d06d397a84 URL: https://github.com/llvm/llvm-project/commit/471c806a45bbac2f0f4274d8bea383d06d397a84 DIFF: https://github.com/llvm/llvm-project/commit/471c806a45bbac2f0f4274d8bea383d06d397a84.diff

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGed398c3ca404: [NFC] Extract unifyTargetFeatures (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

fpetrogalli added a comment. Reviewers, I have added 2 parent revision with the last two set of intrinsics that are enabled by the macro introduced in this patch. I will update those tests in this patch once the patches are in. Meanwhile, please double check that my interpretation of the featur

[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, c-rhodes, kmclaughlin, SjoerdMeijer. Herald added subscribers: cfe-commits, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. fpetrogalli added parent revi

[clang] ed398c3 - [NFC] Extract unifyTargetFeatures

Author: Yaxun (Sam) Liu Date: 2020-06-25T23:17:08-04:00 New Revision: ed398c3ca404f9ec50b134863a227555a9e374df URL: https://github.com/llvm/llvm-project/commit/ed398c3ca404f9ec50b134863a227555a9e374df DIFF: https://github.com/llvm/llvm-project/commit/ed398c3ca404f9ec50b134863a227555a9e374df.dif

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c02dc9800e: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector… (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D80970?vs=267775&id=273581#toc Reposito

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

JakeMerdichAMD created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. JakeMerdichAMD added reviewers: MyDeveloperDay, curdeius, sammccall, jbcoe. JakeMerdichAMD added a project: clang-format. https://bugs.llvm.org/show_bug.cgi?id=46383 When the

[clang] e0c02dc - [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

Author: Amy Kwan Date: 2020-06-25T21:34:41-05:00 New Revision: e0c02dc9800ebd317d1369848f4e74c8f783533a URL: https://github.com/llvm/llvm-project/commit/e0c02dc9800ebd317d1369848f4e74c8f783533a DIFF: https://github.com/llvm/llvm-project/commit/e0c02dc9800ebd317d1369848f4e74c8f783533a.diff LOG:

[clang] 0723b18 - [hip] Re-enable `clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu`

Author: Michael Liao Date: 2020-06-25T22:29:27-04:00 New Revision: 0723b1891fac8f79f92549e3bcac9112be4ebd43 URL: https://github.com/llvm/llvm-project/commit/0723b1891fac8f79f92549e3bcac9112be4ebd43 DIFF: https://github.com/llvm/llvm-project/commit/0723b1891fac8f79f92549e3bcac9112be4ebd43.diff

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk updated this revision to Diff 273578. amyk added a comment. Addressed Anil's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82609/new/ https://reviews.llvm.org/D82609 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Headers/altivec.h clang/test/CodeGen/bui

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP requested changes to this revision. JohelEGP added a comment. This revision now requires changes to proceed. `BreakBeforeBraces: Allman` isn't respected. template friend constexpr auto operator*(const size2d& l, const units::quantity& r) noexcept( noexcept(l.w* r)) requires(

[clang] d3f437d - [hip] Disable test temporarily due to failures on build servers.

Author: Michael Liao Date: 2020-06-25T22:04:20-04:00 New Revision: d3f437d35189f7567294daf3e60e08326e64994a URL: https://github.com/llvm/llvm-project/commit/d3f437d35189f7567294daf3e60e08326e64994a DIFF: https://github.com/llvm/llvm-project/commit/d3f437d35189f7567294daf3e60e08326e64994a.diff

[PATCH] D82604: No nested namespaces in Clang-Tidy checkers

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. As the warnings suggest, nested name definitions can't be used because llvm-project is still using C++14. `llvm.org` as a reviewer doesn't work. You can use `git log` and find acti

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

sammccall created this revision. sammccall added reviewers: kadircet, uabelho, bjope. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Currently this warning is on for both clang and GCC, when building clang. It's off for the rest of LLVM, so my sense is it isn't that

[PATCH] D79732: AMDGPU/HIP: Don't replace pointer types in kernel argument structs

arsenm abandoned this revision. arsenm added a comment. I think this is obsoleted now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79732/new/ https://reviews.llvm.org/D79732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

LLVM Lab network works today at 6:30 PM PST

Hello everyone, LLVM Lab will be unavailable for a short time at about 6:30 PM PST due network maintenance. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

RE: [clang] 466e8b7 - Add StringLiteral to SyntaxTree

Hi Eduardo, Your change is causing a build failure on PS4 Windows build bot, can you please take a look and fix it or revert the change if you cannot fix it soon so we can get the bot green again? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/33164 F

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar added a comment. In D81315#2079457 , @Szelethus wrote: > Best of luck on your GSoC! I don't have much else to add to your patch, but > you seem to have made good progress already! Thanks! > In D81315#2078043

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdccfaacf93e1: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ h

[clang-tools-extra] 0e1997e - [clangd] Fix test compile with GCC (name conflict)

Author: Sam McCall Date: 2020-06-26T03:02:28+02:00 New Revision: 0e1997ed4ef74202a1bec6e7c18ba7a1df496896 URL: https://github.com/llvm/llvm-project/commit/0e1997ed4ef74202a1bec6e7c18ba7a1df496896 DIFF: https://github.com/llvm/llvm-project/commit/0e1997ed4ef74202a1bec6e7c18ba7a1df496896.diff LO

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar updated this revision to Diff 273568. vrnithinkumar marked 16 inline comments as done. vrnithinkumar added a comment. Addressing review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81315/new/ https://reviews.llvm.org/D81315 Files: clang/include/clang/StaticAna

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:35 bool isNullAfterMoveMethod(const CallEvent &Call) const; + BugType NullDereferenceBugType{this, "Null-smartPtr-deref", + "C++ smart point

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim abandoned this revision. hctim added a comment. Abandoning - fixing the underlying issue at D82615 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82249/new/ https://reviews.llvm.org/D82249 ___

[clang] dccfaac - [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

Author: Michael Liao Date: 2020-06-25T20:46:56-04:00 New Revision: dccfaacf93e1c4801cbcc4686f64eb8a35564ff7 URL: https://github.com/llvm/llvm-project/commit/dccfaacf93e1c4801cbcc4686f64eb8a35564ff7 DIFF: https://github.com/llvm/llvm-project/commit/dccfaacf93e1c4801cbcc4686f64eb8a35564ff7.diff

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk marked 2 inline comments as done. amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:18 + // CHECK-NEXT: ret <4 x i32> + return vec_dive(vsia, vsib); +} anil9 wrote: > I may be wrong but where are the variables declared ? I

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. sammccall added a parent revision: D82606: [clangd] Config: config struct propagated through Context. sammccall edited the

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

erik.pilkington added a comment. Ping, @rsmith did you want to take another look at this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76323/new/ https://reviews.llvm.org/D76323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, MadCoder. Herald added subscribers: ributzka, dexonsmith, jkorous. As a heuristic, only warn if the selector matches a method declared in the current interface. rdar://64621668 https://reviews.llvm.org/D82611 Fi

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

anil9 added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:18 + // CHECK-NEXT: ret <4 x i32> + return vec_dive(vsia, vsib); +} I may be wrong but where are the variables declared ? I do not see the variables delclared above in the fil

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9a539c01084: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals (authored by aardappel). Changed prior to commit: https://reviews.llvm.org/D82130?vs=273539&id=273548#toc Reposit

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

anil9 added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:17 +unsigned int uia, *uiap; +signed int *ia; +signed short *sia; nit: It seems that most pull requests follow an ordering like first signed declaration and then unsigned, decla

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, nemanjai, lei, saghir. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements the following function prototypes to utilize the `vmulh[s|u][w|d]` and `vdive[s|u][w|d]

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall updated this revision to Diff 273543. sammccall added a comment. config() -> Config::current(). "config" already names a namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82606/new/ https://reviews.llvm.org/D82606 Files: clang-t

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 273539. aardappel added a comment. types & variables in InputChunks.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/wasm/Config.h lld/wasm/D

[clang] b9a539c - [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

Author: Wouter van Oortmerssen Date: 2020-06-25T15:52:44-07:00 New Revision: b9a539c01084a572e406579c326a0da1e22e286f URL: https://github.com/llvm/llvm-project/commit/b9a539c01084a572e406579c326a0da1e22e286f DIFF: https://github.com/llvm/llvm-project/commit/b9a539c01084a572e406579c326a0da1e22e2

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

dschuff accepted this revision. dschuff added a comment. Compiler changes LGTM Comment at: llvm/test/CodeGen/WebAssembly/stack-alignment.ll:1 -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-keep-registers | FileCheck %s - -target datalayout = "e-

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

Szelethus abandoned this revision. Szelethus added a comment. This revision has done its job. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82122/new/ https://reviews.llvm.org/D82122 ___ cfe-commits ma

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > We could just kill all subexpr at the end of the full expression I suspect that it would be pretty bad if you, say, kill the condition of the `if`-statement before picking the branch. Or kill the

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo closed this revision. echristo added a comment. Committed a while back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list cf

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 273531. hliao added a comment. remove 'an' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu llvm/lib/Tr

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

xazax.hun added a comment. I always wondered if we actually need to track the liveness of exprs at all. We could just kill all subexpr at the end of the full expression without precomputing anything. But I might miss something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

ashi1 added inline comments. Comment at: clang/test/CodeGenCUDA/lambda.cu:53 +// DEV: call void @_ZZ12test_resolvevENKUlvE_clEv +// DEV-LABE: define internal void @_ZZ12test_resolvevENKUlvE_clEv +// DEV: call i32 @_Z10overloadedIiET_v There is a typo here, DEV-

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/AST/RecordLayout.h:75 + // can be different than Alignment in cases where it is beneficial for + // performance or backwards compatibility perserving (e.g. AIX-ABI). + CharUnits PreferredAlignment; -

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273529. cchen added a comment. Pass Info directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOp

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

xazax.hun added a comment. The analyzer inlines small functions within a TU regardless of the thresholds. I think it would be sensible to do the same across TUs in the case we don't do this already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

sbc100 accepted this revision. sbc100 added a comment. Linker changes still lgtm % comments Comment at: lld/wasm/InputChunks.cpp:338 + auto WASM_OPCODE_PTR_CONST = + config->is64 ? WASM_OPCODE_I64_CONST : WASM_OPCODE_I32_CONST; sbc100 wrote: > Just use

[PATCH] D82604: No nested namespaces in Clang-Tidy checkers

lebedev.ri added a comment. Isn't that C++17? LLVM is at C++14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82604/new/ https://reviews.llvm.org/D82604 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall created this revision. sammccall added reviewers: hokein, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This introduces the "semantic form" of config exposed to features, contrasted with the

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 273524. hliao added a comment. Revie the grammar. s/is/as/ in the first sentence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-k

[PATCH] D82226: Add Metadata to Transformer tooling

asoffer updated this revision to Diff 273522. asoffer added a comment. Last diff was a mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82226/new/ https://reviews.llvm.org/D82226 Files: clang/include/clang/Tooling/Refactoring/AtomicChange.

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

amyk added a comment. Talked to Anil, and will address his nit comments on the commit and disregard the comment about the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80970/new/ https://reviews.llvm.org/D80970 ___

[PATCH] D82604: No nested namespaces in Clang-Tidy checkers

pi1024e created this revision. Herald added subscribers: cfe-commits, Charusso. Herald added a project: clang. A lot of the code, including ironically the nested namespace checker itself, was using "namespace clang { tidy { modernize...", so I put those together for readability as "namespace cla

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10334-10335 +MCHandler.generateAllInfo(BasePointers, Pointers, Sizes, MapTypes, + Info.Dims, Info.Offsets, Info.Counts, + Info.Strides);

[PATCH] D82226: Add Metadata to Transformer tooling

asoffer updated this revision to Diff 273520. asoffer marked an inline comment as done. asoffer added a comment. Updating other test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82226/new/ https://reviews.llvm.org/D82226 Files: clang/include/c

[PATCH] D82226: Add Metadata to Transformer tooling

asoffer updated this revision to Diff 273516. asoffer marked an inline comment as done and an inline comment as not done. asoffer added a comment. Commenting fields and simplifying test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82226/new/ http

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273517. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I

[PATCH] D82226: Add Metadata to Transformer tooling

asoffer marked 2 inline comments as done. asoffer added a comment. In D82226#2114111 , @ymandel wrote: > Looks good! Only real question is one of design -- should we consider the > (deeper) change of templating the various types rather than using dynamic

[PATCH] D82561: [analyzer][CrossTU] Lower CTUImportThreshold default value

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Based on discussions I heard in between @dkrupp, @martong and You, this seems appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGe9fb1506b83d: [clangd] Config: Fragments and parsing from YAML (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D82386?vs=273254&id=

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

sammccall marked 9 inline comments as done. sammccall added a comment. Thanks for the careful review! Comment at: clang-tools-extra/clangd/ConfigFragment.h:73 +/// Only valid if SourceManager is set. +llvm::SMLoc Location; + }; kadircet wrote: > sammcc

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, vsavchenko, martong, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, balo

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus added a comment. I didn't run this on big projects just yet, and judging from the fact that `Environment` only contained ObjetiveC examples of non-expression statements, I might need a tip on how to test on ObjC code :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:238-239 +return false; + // Check it's really safe to treat that pair of `ptrtoint`/`inttoptr` is a + // no-op cast. Besides checking both of them are no-op casts, as the + // reint

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) +SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else cchen wrote: > ABataev wrote: > > Better to use integ

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 273503. aardappel added a comment. - Fixed ISEL for FrameIndex - Fixed 64-bit conditions in branches (thanks @aheejin!) - Made the FrameIndex generation code in WebAssemblyRegisterInfo work. - Made userstack.ll and stack-alignment.ll pass in wasm64. - Code r

[clang-tools-extra] e9fb150 - [clangd] Config: Fragments and parsing from YAML

Author: Sam McCall Date: 2020-06-25T22:55:45+02:00 New Revision: e9fb1506b83d001082dc535af12acf45050a527c URL: https://github.com/llvm/llvm-project/commit/e9fb1506b83d001082dc535af12acf45050a527c DIFF: https://github.com/llvm/llvm-project/commit/e9fb1506b83d001082dc535af12acf45050a527c.diff LO

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) +SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else ABataev wrote:

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

fpetrogalli updated this revision to Diff 273498. fpetrogalli marked 5 inline comments as done. fpetrogalli added a comment. This patch needed some love... @c-rhodes, I have addressed your feedback, thank you. I have also predicated all the instruction selection pattern for `-mattr=+bf16`, and

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; tra wrote: > y

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy &MapTypes, - CGOpenMPRuntime::TargetDataInfo &Info) { +

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

This revision was automatically updated to reflect the committed changes. Closed by commit rGa931ec7ca0ee: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy &MapTypes, - CGOpenMPRuntime::TargetDataInfo &Info) { + MappableExprsHandler::MapDimArrayTy &D

[PATCH] D82563: [Sema][NFC] Remove Redundant Condition

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82563/new/ https://reviews.llvm.org/D82563

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273484. cchen added a comment. Fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOpen

[PATCH] D82592: [libTooling] Rename overloaded `range` range selector.

ymandel created this revision. ymandel added a reviewer: tdl-g. Herald added a project: clang. tdl-g accepted this revision. This revision is now accepted and ready to land. Renames the overloaded `RangeSelector` combinator `range` to the more descriptive `enclose` and `encloseNodes`. The old over

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } john.brawn wrote: > MaskRay wrote: > > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is > > specified? Th

[clang] 6673d69 - [X86] Don't imply -mprfchw when -m3dnow is specified. Enable prefetchw in the backend with 3dnow feature.

Author: Craig Topper Date: 2020-06-25T12:46:52-07:00 New Revision: 6673d69226d86f4906dca4b627d6e0582486d072 URL: https://github.com/llvm/llvm-project/commit/6673d69226d86f4906dca4b627d6e0582486d072 DIFF: https://github.com/llvm/llvm-project/commit/6673d69226d86f4906dca4b627d6e0582486d072.diff

[PATCH] D82586: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. happens to be in the command path.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9da93f590414: [HIP] Improve check patterns to avoid test failures in case string "opt", etc. (authored by yamauchi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

tra marked an inline comment as done. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; yaxunl wrote: > tra

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jasonliu accepted this revision. jasonliu added a comment. LGTM. I have no further comments on this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } MaskRay wrote: > Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reprod

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 273477. hliao added a comment. Revise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu llvm/lib/Transfo

[PATCH] D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81282/new/ https://reviews.llvm.org/D81282 ___

[clang] 9da93f5 - [HIP] Improve check patterns to avoid test failures in case string "opt", etc. happens to be in the command path.

Author: Hiroshi Yamauchi Date: 2020-06-25T12:18:43-07:00 New Revision: 9da93f590414ae3b7be20061d8a97695b263482e URL: https://github.com/llvm/llvm-project/commit/9da93f590414ae3b7be20061d8a97695b263482e DIFF: https://github.com/llvm/llvm-project/commit/9da93f590414ae3b7be20061d8a97695b263482e.di

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl updated this revision to Diff 273473. yaxunl marked 2 inline comments as done. yaxunl added a comment. return the unified features. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82579/new/ https://reviews.llvm.org/D82579 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/lib

[PATCH] D82332: [Coroutines] Handle dependent promise types for final_suspend non-throw check

This revision was automatically updated to reflect the committed changes. Closed by commit rGc25acec84594: [Coroutines] Handle dependent promise types for final_suspend non-throw check (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D82579: [NFC] Extract unifyTargetFeatures

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:93 +StringRef Name = Features[I]; +assert(Name[0] == '-' || Name[0] == '+'); +LastOpt[Name.drop_front(1)] = I; tra wrote: > I

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg added a comment. Here is a makefile that does stripping: llvm-project/lldb/test/API/lang/objc/objc-ivar-stripped/Makefile Then when creating the target, use a.out.stripped: exe = self.getBuildArtifact("a.out.stripped") symbols = exe = self.getBuildArtifact("a.out") target = self.

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 273456. guiand retitled this revision from "Introduce frozen attribute at call sites for stricter poison analysis" to "Introduce noundef attribute at call sites for stricter poison analysis". guiand edited the summary of this revision. guiand added a comment.

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand marked an inline comment as done. guiand added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) { ---

[clang] 01c18f9 - Revert "[X86] Don't imply -mprfchw when -m3dnow is specified. Enable prefetchw in the backend with 3dnow feature."

Author: Craig Topper Date: 2020-06-25T11:43:02-07:00 New Revision: 01c18f9199ace4cb15a7c82a4163c9ef84972342 URL: https://github.com/llvm/llvm-project/commit/01c18f9199ace4cb15a7c82a4163c9ef84972342 DIFF: https://github.com/llvm/llvm-project/commit/01c18f9199ace4cb15a7c82a4163c9ef84972342.diff

[clang] c25acec - [Coroutines] Handle dependent promise types for final_suspend non-throw check

Author: Xun Li Date: 2020-06-25T11:27:27-07:00 New Revision: c25acec84594ca15748553341969f8e579290e27 URL: https://github.com/llvm/llvm-project/commit/c25acec84594ca15748553341969f8e579290e27 DIFF: https://github.com/llvm/llvm-project/commit/c25acec84594ca15748553341969f8e579290e27.diff LOG: [

  1   2   3   >