[PATCH] D73397: [Clang] Enable -fsanitize=leak on Fuchsia targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4261e112129: [Clang] Enable -fsanitize=leak on Fuchsia targets (authored by mcgrathr, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73

[PATCH] D73464: [clang] Add TagDecl AST matcher

f00kat updated this revision to Diff 240779. f00kat added a comment. 1. Fix Registry.cpp 2. Generate AST Matchers doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73464/new/ https://reviews.llvm.org/D73464 Files: clang/docs/LibASTMatchersRefere

[clang] f4261e1 - [Clang] Enable -fsanitize=leak on Fuchsia targets

Author: Roland McGrath Date: 2020-01-27T23:37:51-08:00 New Revision: f4261e1121293c1f5a3aba416668e6309099f9da URL: https://github.com/llvm/llvm-project/commit/f4261e1121293c1f5a3aba416668e6309099f9da DIFF: https://github.com/llvm/llvm-project/commit/f4261e1121293c1f5a3aba416668e6309099f9da.diff

[PATCH] D57265: [PM/CC1] Add -f[no-]split-cold-code CC1 options to toggle splitting

plotfi added a comment. Why hasn't this patch landed in llvm.org? I see it on the github apple/master but not on llvm.org master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57265/new/ https://reviews.llvm.org/D57265 ___ cfe-commits mail

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72820/new/ https://reviews.llvm.org/D72820 ___

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 240760. yaxunl retitled this revision from "[CUDA][HIP] Fix assertion due to dtor check on windows" to "[CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese". yaxunl edited the summary of this revision. yaxunl added a comment. Herald add

[PATCH] D73521: [analyzer][WIP] add-new-checker.py: Introduction

Charusso marked an inline comment as done. Charusso added a comment. This script dumps out a dummy checker which is the continuation of the Clang Tidy's https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-tidy/add_new_check.py However, we could stick to the main-function-re

[PATCH] D73521: [analyzer][WIP] add-new-checker.py: Introduction

Charusso updated this revision to Diff 240759. Charusso added a comment. - Make it runable. Whoops. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73521/new/ https://reviews.llvm.org/D73521 Files: clang/test/Analysis/add-new-checker/add-main-package.rst clang/test/Analysis/add-new-c

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:195 + + static const char *getTag() { return "FindLastStore"; } + I have made every tag a small-stri

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

This revision was automatically updated to reflect the committed changes. Closed by commit rG49532137d087: Make AST reading work better with LLVM_APPEND_VC_REV=NO (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 4953213 - Make AST reading work better with LLVM_APPEND_VC_REV=NO

Author: Nico Weber Date: 2020-01-27T22:08:37-05:00 New Revision: 49532137d087d8053789d18540c5e7916b91ef30 URL: https://github.com/llvm/llvm-project/commit/49532137d087d8053789d18540c5e7916b91ef30 DIFF: https://github.com/llvm/llvm-project/commit/49532137d087d8053789d18540c5e7916b91ef30.diff LO

Re: [clang] af80b8c - PR44684: Look through parens and similar constructs when determining

This seems to break check-clang-tools on non-Linux: http://45.33.8.238/mac/6529/step_8.txt http://45.33.8.238/win/6770/step_8.txt On Mon, Jan 27, 2020 at 9:21 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith > Date: 2020-01-27T18:20:57-08:00 > New Re

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to function definitions with no Decl

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if (getLangOpts().NoBuiltin || HasWildcard) - FuncAttrs.addAt

[PATCH] D73521: [analyzer][WIP] add-new-checker.py: Introduction

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This script could be used to generate a dummy Static Analyzer c

[PATCH] D73520: [analyzer] BugReporterVisitors: Refactor and documentation

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. - Repository: rC Clang https://reviews.llvm.org/D73520 Fi

[clang] af80b8c - PR44684: Look through parens and similar constructs when determining

Author: Richard Smith Date: 2020-01-27T18:20:57-08:00 New Revision: af80b8ccc5772c14920d4554b7ca7e15f2fad1c4 URL: https://github.com/llvm/llvm-project/commit/af80b8ccc5772c14920d4554b7ca7e15f2fad1c4 DIFF: https://github.com/llvm/llvm-project/commit/af80b8ccc5772c14920d4554b7ca7e15f2fad1c4.diff

[PATCH] D73513: [memtag] Plug in stack safety analysis.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62250 tests passed, 0 failed and 816 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73513: [memtag] Plug in stack safety analysis.

eugenis added a comment. To explain some design decisions: The analysis is added to the IR pipeline and not to the AArch64 codegen pipeline mainly because we plan to extend it with ThinLTO support in the future. To do that, module summary builder will need to depend on the (function-)local sta

[PATCH] D73513: [memtag] Plug in stack safety analysis.

eugenis created this revision. eugenis added reviewers: pcc, vitalybuka, ostannard. Herald added subscribers: cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Run StackSafetyAnalysis at the end of the IR pipeline and annotate proven safe allocas with !stack-safe metadata.

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to functions with no Decl

thegameg marked an inline comment as done. thegameg added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if (getLangOpts().NoBuiltin

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

rsmith added a comment. I don't like the name `getDependencies`, because the function is not getting a list of dependencies, it's getting flags that indicate whether certain properties of the construct are dependent. Maybe `getDependence` or `getDependenceFlags` would be a better name? Likewise

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

Eugene.Zelenko added a comment. As I wrote, I don't have GitHub commit access, so I need help with commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 ___ c

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

tra updated this revision to Diff 240731. tra edited the summary of this revision. tra added a comment. Use std::string instead of Twine which can't be stored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73231/new/ https://reviews.llvm.org/D73231

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. In D72527#1843427 , @Eugene.Zelenko wrote: > Just ping. Are you waiting for other reviewers or for me to "Accept Revision"? If the latter, "stamped"

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG6874dfce3aef: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang-tools-extra] 6874dfc - [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

Author: Nathan Date: 2020-01-28T00:39:07Z New Revision: 6874dfce3aef4a0d85fc9d45f4c9c3d90cfcbf6e URL: https://github.com/llvm/llvm-project/commit/6874dfce3aef4a0d85fc9d45f4c9c3d90cfcbf6e DIFF: https://github.com/llvm/llvm-project/commit/6874dfce3aef4a0d85fc9d45f4c9c3d90cfcbf6e.diff LOG: [clang

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62249 tests passed, 0 failed and 816 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 240720. void added a comment. Merge "__has_extension" patch into this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rst c

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

Eugene.Zelenko added a comment. In D73413#1843368 , @njames93 wrote: > In D73413#1843103 , @alexfh wrote: > > > How is this different from `-Wmissing-prototypes`? > > > This checks variables too, and it looks for a

[PATCH] D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes

Eugene.Zelenko added a comment. Just ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72527/new/ https://reviews.llvm.org/D72527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void abandoned this revision. void added a comment. I'm going to merge this into D69876 as it's closely related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman added a comment. Updated the diff based on review feedback. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoriesCheck.cpp:21 + Finder->addMatcher( + objcMethodDecl(hasName("dealloc"), hasDeclContext(objcCategoryImplDecl())) + .bind("dealloc")

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240718. njames93 added a comment. - Remove artifacts of old dependent review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files: clang-tools-extra/clang-tidy/bugp

[PATCH] D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73493/new/ https://reviews.llvm.org/D73493 ___

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 240716. mwyman marked 7 inline comments as done. mwyman added a comment. Addresses reviewer feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 Files: clang-tool

[PATCH] D73202: Make AST reading work better with LLVM_APPEND_VC_REV=NO

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73202/new/ https://reviews.llvm.org/D73202 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 added a comment. In D73413#1843103 , @alexfh wrote: > How is this different from `-Wmissing-prototypes`? This checks variables too, and it looks for a prototype specifically in the header files. missing-prototypes just ensures there is a protot

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c90666d2c3c: [clang-tidy] readability-redundant-string-init now flags redundant… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72448

[clang-tools-extra] 7c90666 - [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

Author: Nathan Date: 2020-01-27T23:51:45Z New Revision: 7c90666d2c3cfb5a519275d89195be317e7cc0ab URL: https://github.com/llvm/llvm-project/commit/7c90666d2c3cfb5a519275d89195be317e7cc0ab DIFF: https://github.com/llvm/llvm-project/commit/7c90666d2c3cfb5a519275d89195be317e7cc0ab.diff LOG: [clang

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3d20fd47200: [clang-tidy] readability-identifier-naming disregards parameters restrictions… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] c3d20fd - [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Author: Nathan Date: 2020-01-27T23:47:51Z New Revision: c3d20fd472000c7abdc2c9cad051a2ab339709d9 URL: https://github.com/llvm/llvm-project/commit/c3d20fd472000c7abdc2c9cad051a2ab339709d9 DIFF: https://github.com/llvm/llvm-project/commit/c3d20fd472000c7abdc2c9cad051a2ab339709d9.diff LOG: [clang

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 updated this revision to Diff 240706. njames93 added a comment. Fix diff, ready to recommit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https://reviews.llvm.org/D73098 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-extra/

[PATCH] D69876: Allow output constraints on "asm goto"

void added a comment. In D69876#1843199 , @MaskRay wrote: > Does this depend on D69868 ? Yes. I added it as a parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/ne

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void marked an inline comment as done. void added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1273 + int y; + asm goto("# %0 %1 %2" : "=r"(y) : "r"(x) : : err); + return y; MaskRay wrote: > Is the canonical spelling `%l2`? Nice c

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 240692. void added a comment. Fix extension example, found by eagle-eye @maskray! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 Files: clang/docs/LanguageExtensions.rs

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void marked an inline comment as done. void added a comment. In D73319#1843129 , @nickdesaulniers wrote: > In D73319#1842951 , @void wrote: > > > In D73319#1842900 , > > @n

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 240691. logan-5 added a comment. Rebased with trunk. Updated whitelist to include more standard designated customization points . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow marked 4 inline comments as done. wristow added inline comments. Comment at: clang/test/Driver/fast-math.c:196 +// RUN: %clang -### -ffast-math -ffp-contract=fast -c %s 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-UNSAFE-MATH %s +// wristow wrote: >

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 240689. wristow added a comment. Used the clearer '!off && !on' (rather than '!(off || on)') in the checks. Added more tests that note the current situation that `-ffast-math` enables FMA. overriding an earlier switch that had disabled it (included a "TODO"

[PATCH] D69876: Allow output constraints on "asm goto"

MaskRay added a comment. Does this depend on D69868 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 ___ cfe-commits mailing l

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

MaskRay added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1273 + int y; + asm goto("# %0 %1 %2" : "=r"(y) : "r"(x) : : err); + return y; Is the canonical spelling `%l2`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:503-504 def bind__at__load : Flag<["-"], "bind_at_load">; +def builtininc : Flag<["-"], "builtininc">

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

dblaikie added inline comments. Comment at: clang/lib/Sema/Sema.cpp:985-986 + +// FIXME: Instantiating implicit templates already in the PCH breaks some +// OpenMP-specific code paths, see https://reviews.llvm.org/D69585 . +if(LangOpts.PCHInstantiateTemplates && !Lang

[PATCH] D73464: [clang] Add TagDecl AST matcher

alexfh added a comment. A drive-by comment. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:212 + REGISTER_MATCHER(tagDecl); + REGISTER_MATCHER(tagType); REGISTER_MATCHER(enumConstantDecl); There's already `tagType` registration on the line 497. And

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. In D72811#1843066 , @cchen wrote: > In D72811#1839561 , @ABataev wrote: > > > In D72811#1839538 , @cchen wrote: > > > > > In D72811#1837392

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

nickdesaulniers added a comment. In D73319#1842951 , @void wrote: > In D73319#1842900 , @nickdesaulniers > wrote: > > > Great idea; thanks for the patch! Needs documentation. :) > > > I can't find a place for docum

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240681. void added a comment. Add description of "gnu_asm_goto_with_outputs" to the language extensions doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

boga95 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71524/new/ https://reviews.llvm.org/D71524 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

alexfh added a comment. How is this different from `-Wmissing-prototypes`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 ___ cfe-commits mailing list cfe-comm

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev updated this revision to Diff 240676. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOff

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c26d993bdc: [analyzer] Add FuchsiaLockChecker and C11LockChecker (authored by xazax.hun). Changed prior to commit: https://reviews.llvm.org/D73376?vs=240650&id=240678#toc Repository: rG LLVM Github

[clang] f4c26d9 - [analyzer] Add FuchsiaLockChecker and C11LockChecker

Author: Gabor Horvath Date: 2020-01-27T13:55:56-08:00 New Revision: f4c26d993bdcb8e5250d774c0d2a6d91fee5ca00 URL: https://github.com/llvm/llvm-project/commit/f4c26d993bdcb8e5250d774c0d2a6d91fee5ca00 DIFF: https://github.com/llvm/llvm-project/commit/f4c26d993bdcb8e5250d774c0d2a6d91fee5ca00.diff

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added a comment. In D72811#1839561 , @ABataev wrote: > In D72811#1839538 , @cchen wrote: > > > In D72811#1837392 , @jdoerfert >

[PATCH] D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers

aaron.ballman accepted this revision. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:58 + } + if (B.isInva

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to functions with no Decl

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1917 const auto *NBA = Fn->getAttr(); -bool HasWildcard = NBA && llvm::is_contained(NBA->builtinNames(), "*"); -if (getLangOpts().NoBuiltin || HasWildcard) - FuncAttrs.addAt

[PATCH] D73434: [Sema] Remove a -Wrange warning from -Wall

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73434/new/ https://reviews.llvm.org/D73434

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman created this revision. arphaman added a reviewer: dexonsmith. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. Some projects use -nostdinc, but need to access some intrinsics files when building specific files. The new `-builtininc` flag lets them use this flag

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240663. void marked 2 inline comments as done. void added a comment. Move extension test to exsiting test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang/i

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void added a comment. In D73319#1842900 , @nickdesaulniers wrote: > Great idea; thanks for the patch! Needs documentation. :) I can't find a place for documentation of extensions, at least not the names of extensions like `gnu_asm`.

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

nickdesaulniers added a comment. Great idea; thanks for the patch! Needs documentation. :) Comment at: clang/test/Parser/asm-goto-with-outputs.c:7 +#error Extension 'gnu_asm_goto_with_outputs' should be available by default +#endif + probably don't need a bunch

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240657. void added a comment. Use GNU asm predicate for the "asm goto with outputs" extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files: clang/include/clang

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

aprantl added a comment. In D73261#1838683 , @probinson wrote: > In D73261#1838552 , @djtodoro wrote: > > > > Is it necessary to use DIFlags? I am willing to do that but generally, it > > > is not welcomed because

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM!~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 ___ cfe-commits mailing list cfe-commits@lists

[clang] e6d2583 - [OPENMP50]Track changes of lastprivate conditional in parallel-based

Author: Alexey Bataev Date: 2020-01-27T14:53:25-05:00 New Revision: e6d2583e45ef3af7646d4a58bada2e639121 URL: https://github.com/llvm/llvm-project/commit/e6d2583e45ef3af7646d4a58bada2e639121 DIFF: https://github.com/llvm/llvm-project/commit/e6d2583e45ef3af7646d4a58bada2e639121.diff

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link e

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun updated this revision to Diff 240650. xazax.hun added a comment. - Add a FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Checkers/Pthrea

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

andrew.w.kaylor added a comment. It's not clear to me from reading this how the "precise" control is going to work with relation to the fast math flags. I don't think MSVC allows the granularity of control over these flags that we have in clang, so maybe they don't have this problem. Consider

[clang-tools-extra] c72a6ac - Revert "[clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions"

Author: Shoaib Meenai Date: 2020-01-27T11:50:25-08:00 New Revision: c72a6ac4b630d2344dbea44a7d75fa61795dcd76 URL: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76 DIFF: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76.diff

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 added a comment. May need to roll this back, I think as i had this on the same local branch as D73052 I have brought both of them in at once Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/ https:

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ added inline comments. Comment at: clang/test/Analysis/c11lock.c:7 +enum { + thrd_success = 0, + thrd_error = 2 xazax.hun wrote: > Strictly speaking, this is implementation defined. But the C11 > implementations I am aware of are following this trend (`thr

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

dblaikie added a comment. General question: What purpose do you (or anyone else - @probinson, @aprantl) have for this attribute? I'd like to encourage the idea that we don't need to implement every feature DWARF provides if there's no planned use for it - things can/should be implemented as-mot

[clang] 2d0b29e - [clang] Fix covered default in switch

Author: Jinsong Ji Date: 2020-01-27T19:28:11Z New Revision: 2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46 URL: https://github.com/llvm/llvm-project/commit/2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46 DIFF: https://github.com/llvm/llvm-project/commit/2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46.diff LOG: [c

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

dblaikie added a comment. In D73261#1838683 , @probinson wrote: > In D73261#1838552 , @djtodoro wrote: > > > > Is it necessary to use DIFlags? I am willing to do that but generally, it > > > is not welcomed because

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG27e3671ff49b: [clang-tidy] readability-identifier-naming disregards parameters restrictions… (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D73098?vs=240400&id=240647#toc Rep

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62196 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2155 friend class MDNode; + bool isDefault; What about default arguments for non-type template parameters? ("template" etc... ) Repository: rG LLVM Github Monorepo CH

[clang-tools-extra] 27e3671 - [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Author: Nathan Date: 2020-01-27T19:23:21Z New Revision: 27e3671ff49b72640f89c34a415412e400503442 URL: https://github.com/llvm/llvm-project/commit/27e3671ff49b72640f89c34a415412e400503442 DIFF: https://github.com/llvm/llvm-project/commit/27e3671ff49b72640f89c34a415412e400503442.diff LOG: [clang

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240643. topisani marked an inline comment as done. topisani added a comment. Addressed CR comments I'm sure about the tests, I basically just added to the one test that already exists that it passes one of each "type" of preservable argument. CHANGES SINC

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG88c7b1642079: [analyzer] Simplify BoolAssignmentChecker (authored by Mikhail Gadelha ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In D73457#1842605 , @amccarth wrote: > In D73457#1842493 , @simon_tatham > wrote: > > > R

[PATCH] D73495: [CodeGen] Attach no-builtin attributes to functions with no Decl

thegameg created this revision. thegameg added reviewers: gchatelet, tejohnson, aaron.ballman, efriedma. thegameg added a project: clang. When using -fno-builtin[-], we don't attach the IR attributes to functions with no Decl. This results in projects using -fno-builtin or -ffreestanding to star

[clang] 88c7b16 - [analyzer] Simplify BoolAssignmentChecker

Author: Mikhail Gadelha Date: 2020-01-27T14:51:35-04:00 New Revision: 88c7b1642079439a73b4d7a6e57e67347f574a15 URL: https://github.com/llvm/llvm-project/commit/88c7b1642079439a73b4d7a6e57e67347f574a15 DIFF: https://github.com/llvm/llvm-project/commit/88c7b1642079439a73b4d7a6e57e67347f574a15.dif

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

njames93 updated this revision to Diff 240640. njames93 added a comment. - Tweak documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73439/new/ https://reviews.llvm.org/D73439 Files: clang/docs/LibASTMatchersReference.html clang/includ

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240638. mibintc added a comment. rebase per @sepavloff request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst clang/includ

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

amccarth added a comment. In D73457#1842493 , @simon_tatham wrote: > Removed the special case for `MSCompatibilityVersion == 0`. If the default > compatibility setting needs to be changed, that's a separate piece of work > and should be done by someone

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added a comment. Herald added a subscriber: ormris. Can you add a bitcode roundtrip test to test/Assembler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62197 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

This revision was automatically updated to reflect the committed changes. Closed by commit rGc98d98ba9b0f: [analyzer] Fix handle leak false positive when the handle dies too early (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

  1   2   3   >