[clang] 6d6a459 - [DWARF5][clang]: Added support for DebugInfo generation for auto return type for C++ member functions.

Author: Awanish Pandey Date: 2020-01-13T12:40:18+05:30 New Revision: 6d6a4590c5d4c7fc7445d72fe685f966b0a8cafb URL: https://github.com/llvm/llvm-project/commit/6d6a4590c5d4c7fc7445d72fe685f966b0a8cafb DIFF: https://github.com/llvm/llvm-project/commit/6d6a4590c5d4c7fc7445d72fe685f966b0a8cafb.diff

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71451/new/ https://reviews.llvm.org/D71451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc958639098a8: [DWARF5][DebugInfo]: Added support for DebugInfo generation for auto return… (authored by awpandey, committed by SouraVX). Changed prior to commit: https://reviews.llvm.org/D70524?vs=2372

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61745 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

ilya-biryukov updated this revision to Diff 237577. ilya-biryukov added a comment. - Add compound assignment operations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71920/new/ https://reviews.llvm.org/D71920 Files: clang-tools-extra/clang-tidy/

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61746 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. Same restrictions apply as in the other direction: macro arguments are not supported yet, only full macro expansions can be mapped. Repository: rG LLVM Github Monorepo https://review

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

ilya-biryukov added a comment. In D72498#1815500 , @lh123 wrote: > - hover over the `front` , you'll see "instance-method `front` → > `std::vector >::reference`". > - hover over the `push_back`, you'll see "`std::vector std::allocator >::value_type && __x

[PATCH] D72498: [clangd] Print underlying type for decltypes in hover

ilya-biryukov added a comment. In D72498#1814366 , @sammccall wrote: > @ilya-biryukov @kadircet what do you think about unwrapping decltype only > when it's a return value (optional: of a function whose leading return type > is auto) to narrowly catch th

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61774 tests passed, 0 failed and 780 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61771 tests passed, 0 failed and 780 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

nridge updated this revision to Diff 237572. nridge marked an inline comment as done. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 Files: clang-tools-extra/clangd/XR

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rG79a09d8bf4d5: [clangd] Show template arguments in type hierarchy when possible (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/

[clang-tools-extra] 79a09d8 - [clangd] Show template arguments in type hierarchy when possible

Author: Nathan Ridge Date: 2020-01-12T22:31:40-05:00 New Revision: 79a09d8bf4d508b0ae6a1e3c90907488092678c5 URL: https://github.com/llvm/llvm-project/commit/79a09d8bf4d508b0ae6a1e3c90907488092678c5 DIFF: https://github.com/llvm/llvm-project/commit/79a09d8bf4d508b0ae6a1e3c90907488092678c5.diff

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ad1308b69b8: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no… (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang-tools-extra] 1ad1308 - [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

Author: Nathan Ridge Date: 2020-01-12T22:18:21-05:00 New Revision: 1ad1308b69b89cc87533c16957189a84e1dd9754 URL: https://github.com/llvm/llvm-project/commit/1ad1308b69b89cc87533c16957189a84e1dd9754 DIFF: https://github.com/llvm/llvm-project/commit/1ad1308b69b89cc87533c16957189a84e1dd9754.diff

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:898 class $10^Foo { - $11^Foo(int); + $11^Foo(int) {} $12^Foo(): $13^Foo(111) {} ilya-biryukov wrote

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge updated this revision to Diff 237570. nridge marked 2 inline comments as done. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72355/new/ https://reviews.llvm.org/D72355 Files: clang-tools-extra/clangd/un

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61771 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72565: adding __has_feature support for left c++ type_traits

kamleshbhalui abandoned this revision. kamleshbhalui added a comment. not an issue since __has_builtin does the work. i.e. __has_builtin(__is_same) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72565/new/ https://reviews.llvm.org/D72565

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

khchen added a subscriber: efriedma. khchen added a comment. Hi @efriedma Could you please guide me and review this PoC? or take a look at this [[ take a look at | maillist ]] thread? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72245/new/ https://reviews.llvm.org/D72245

[PATCH] D72579: Evaluate __{c11_,}atomic_is_lock_free to 0 (avoid libcall) if larger than MaxAtomicPromoteWidth

MaskRay created this revision. MaskRay added reviewers: adalava, dim, nemanjai, jfb, rsmith. Herald added subscribers: cfe-commits, steven.zhang, dexonsmith, krytarowski, arichardson, emaste. Herald added a project: clang. MaxAtomicPromoteWidth is defined as "the maximum width lock-free atomic op

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert added a comment. @aaron.ballman We could make the warning even stricter, but that should be a separate discussion. Is this change Ok for now? Comment at: clang/test/Sema/warn-strict-prototypes.c:60-62 // K&R function definition with previous prototype declared is

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

MaskRay added a comment. I am still confused why you need the special rule for `__atomic_is_lock_free` (GCC/clang) and `__c11_atomic_is_lock_free` (clang). https://github.com/gcc-mirror/gcc/blob/master/gcc/builtins.c#L7300-L7314 GCC `__atomic_is_lock_free` expands to either 1 or a library call

[PATCH] D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

Wawha updated this revision to Diff 237563. Wawha added a comment. Here a new version of the patch with the last version of the source. It fixes problem with inline lambda. I add more more UnitTest to test. I also make few small changes to follow remarks. Do not hesitate to make remarks, I hope t

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim marked 4 inline comments as done. fghanim added a comment. I am working on a patch. In the mean time ;) Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3020 + if (AllocaIP.isSet()) +AllocaInsertPt = &*AllocaIP.getPoint(); + auto OldReturnBlock = ReturnB

[PATCH] D72578: [compiler-rt] [builtins] Fix clear_cache_test to work with MPROTECT

mgorny created this revision. mgorny added reviewers: ro, delcypher, thakis, saugustine, rnk, compnerd. Herald added subscribers: llvm-commits, kristof.beyls, krytarowski, dberris. Herald added a project: LLVM. Fix clear_cache_test to work on NetBSD with PaX MPROTECT enabled, that is when creating

[clang] 54b2914 - Fix "pointer is null" static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-12T22:08:56Z New Revision: 54b2914accb4f5c9b58305fd6da405d20a47c452 URL: https://github.com/llvm/llvm-project/commit/54b2914accb4f5c9b58305fd6da405d20a47c452 DIFF: https://github.com/llvm/llvm-project/commit/54b2914accb4f5c9b58305fd6da405d20a47c452.diff LOG:

[clang] ada22c8 - Fix "pointer is null" static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-12T21:48:00Z New Revision: ada22c804cd956f3ee7cc9dc82e6d54ead8a4ffe URL: https://github.com/llvm/llvm-project/commit/ada22c804cd956f3ee7cc9dc82e6d54ead8a4ffe DIFF: https://github.com/llvm/llvm-project/commit/ada22c804cd956f3ee7cc9dc82e6d54ead8a4ffe.diff LOG:

[PATCH] D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef

AlexanderLanin updated this revision to Diff 237558. AlexanderLanin marked an inline comment as done. AlexanderLanin added a comment. Updated revision with llvm_unreachable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72373/new/ https://reviews.llvm.org/D72373 Files: clang-tools-ext

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

lebedev.ri added a comment. I think the fact that this is a fourth (?) different incarnation of a patch trying to solve the same *major* *ugly* problem, it may be an evidence that perhaps this problem should not be approached from the 'let's hack it together' approach, but with a concrete plan sen

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

njames93 added a comment. Another potential solution is leave is as is by default. Then emit a warning if a check is ran twice. The warning could be suppressed by passing a option to say what behaviour you want? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea marked 2 inline comments as done. aganea added inline comments. Comment at: llvm/lib/Support/CrashRecoveryContext.cpp:269 + const_cast(CRCI)->HandleCrash( + (int)ExceptionInfo->ExceptionRecord->ExceptionCode, ExceptionInfo); mstorsjo wrote: > This

[PATCH] D72560: Add -Wrange-loop-analysis changes to ReleaseNotes

Mordante closed this revision. Mordante added a comment. Committed as https://reviews.llvm.org/rGdc422e968e73790178e500f506e8fb7cfa1e62ea I accidentally forgot to add the revision id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72560/new/ https:

[PATCH] D72565: adding __has_feature support for left c++ type_traits

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/Features.def:191-192 // Type traits // N.B. Additional type traits should not be added to the following list. // Instea

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/AST/ExprConstant.cpp:11028 +// The lock free possibilities on this platform are covered by the lines +// above and we know in advance

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#1815916 , @Eugene.Zelenko wrote: > In D54943#1815912 , @0x8000- > wrote: > > > As an aside, once this is merged in, I dream of a "fix-it" for old style C > > code: > > >

[PATCH] D72565: adding __has_feature support for left c++ type_traits

dblaikie added a comment. Probably needs test coverage (perhaps check the commits that added other feature tests - there's probably somewhere you can plugin tests in a similar way to plugging in the feature tests themselves) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

njames93 added a comment. How does this sound? I'll put in a config option in there to disable the new alias behaviour. Personally I'd say default to the new behaviour. Then if an organisation relies on the old behaviour then can revert back with a command line option or .clang-tidy file edit R

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

aaron.ballman added a comment. In D72566#1815913 , @njames93 wrote: > In D72566#1815904 , @lebedev.ri > wrote: > > > I agree that the current alias situation is not ideal, though i'm not sure > > how much we can f

[clang] ad20169 - Fix "pointer is null" static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-12T14:36:59Z New Revision: ad201691d5cc0f15f6f885f3847dcc6440ee3de5 URL: https://github.com/llvm/llvm-project/commit/ad201691d5cc0f15f6f885f3847dcc6440ee3de5 DIFF: https://github.com/llvm/llvm-project/commit/ad201691d5cc0f15f6f885f3847dcc6440ee3de5.diff LOG:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

Eugene.Zelenko added a comment. In D54943#1815912 , @0x8000- wrote: > As an aside, once this is merged in, I dream of a "fix-it" for old style C > code: > > int foo; > > ... > /* page of code which does not use either foo or bar */ > ... >

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

lebedev.ri added a comment. In D72566#1815913 , @njames93 wrote: > In D72566#1815904 , @lebedev.ri > wrote: > > > I agree that the current alias situation is not ideal, though i'm not sure > > how much we can fix

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

njames93 added a comment. In D72566#1815904 , @lebedev.ri wrote: > I agree that the current alias situation is not ideal, though i'm not sure > how much we can fix it since it crosses user interface boundary > (i.e. what fixes won't lead to some regressi

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. As an aside, once this is merged in, I dream of a "fix-it" for old style C code: int foo; ... /* page of code which does not use either foo or bar */ ... foo = 5; Moves the foo declaration to the line where it is actually first initialized. Then run the

[PATCH] D72568: [clang-tidy] Alias defintions for checks

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61774 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

lebedev.ri added a comment. I agree that the current alias situation is not ideal, though i'm not sure how much we can fix it since it crosses user interface boundary (i.e. what fixes won't lead to some regressions from the previous expected behavior) To be noted, this will make adding of new al

[PATCH] D72568: [clang-tidy] Alias defintions for checks

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, JonasToth. njames93 added projects: clang, clang-tools-extra. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 added a parent revision: D72566: [clang-tidy] Clang tidy is now alias aware. Herald added

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

njames93 added a comment. should warning be printed with all the enabled checks, or just the primary name? warning: statement should be inside braces [readability-braces-around-statements] vs warning: statement should be inside braces [readability-braces-around-statements, hicpp-braces-ar

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61774 tests passed, 0 failed and 780 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D72566: [clang-tidy] Clang tidy is now alias aware

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, JonasToth, hokein. njames93 added projects: clang-tools-extra, clang. Herald added a subscriber: xazax.hun. Clang-tidy has had an on growing issue with blindly adding all checks from a module using the `-checks=somem

[PATCH] D72565: adding __has_feature support for left c++ type_traits

kamleshbhalui created this revision. kamleshbhalui added reviewers: rsmith, aaron.ballman, dblaikie, ldionne. kamleshbhalui added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. adding __has_feature support for left c++ type_traits. fixes this https://bugs.llvm.org/show_bug.c

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas added a comment. In D71174#1815830 , @lebedev.ri wrote: > A little bit late to the party, but still. > I'm honestly wondering if this should be a proper clang static analyzer > data-flow aware check. > This is basically diagnosing every `signed c

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

lebedev.ri added a comment. A little bit late to the party, but still. I'm honestly wondering if this should be a proper clang static analyzer data-flow aware check. This is basically diagnosing every `signed char` -> `signed int` promotion, regardless of whether the `char` is used as an ASCII

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousMemoryComparisonCheck.cpp:82-83 + +static bool hasPadding(const ASTContext &Ctx, const RecordDecl *RD, + uint64_t ComparedBits) { + assert(RD && RD->isCompleteDefini

[PATCH] D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check

gbencze updated this revision to Diff 237529. gbencze added a comment. Address (most of the) comments by @aaron.ballman - remove top-level `const` on locals - move declaration into `if` - pass `TagDecl` to diag - added test for `operator void *` - fixed `[[no_unique_address]]` - remove assertio

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. In D65591#1791876 , @rsmith wrote: > @ilya-biryukov Did I forget anything? SG, I don't think anything is missing. Thanks for the write-up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews