[clang] bc633a4 - Mark the major papers for C++20 consistent comparisons as "done", and

2019-12-15 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2019-12-15T22:20:06-08:00 New Revision: bc633a42dd409dbeb456263e3388b8caa4680aa0 URL: https://github.com/llvm/llvm-project/commit/bc633a42dd409dbeb456263e3388b8caa4680aa0 DIFF: https://github.com/llvm/llvm-project/commit/bc633a42dd409dbeb456263e3388b8caa4680aa0.diff

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

2019-12-15 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/31 Repository: rG LLVM Github Monorepo https:/

[clang] fbf60b7 - Properly compute whether statement expressions can throw, rather than

2019-12-15 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2019-12-15T22:02:31-08:00 New Revision: fbf60b7dbeb0f66b45037925c384859f2f161504 URL: https://github.com/llvm/llvm-project/commit/fbf60b7dbeb0f66b45037925c384859f2f161504 DIFF: https://github.com/llvm/llvm-project/commit/fbf60b7dbeb0f66b45037925c384859f2f161504.diff

[clang] 0ec1e99 - Resolve exception specifications after marking the corresponding

2019-12-15 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2019-12-15T22:02:30-08:00 New Revision: 0ec1e99001291b894de4cd8d7ecc2a283d9a3bfc URL: https://github.com/llvm/llvm-project/commit/0ec1e99001291b894de4cd8d7ecc2a283d9a3bfc DIFF: https://github.com/llvm/llvm-project/commit/0ec1e99001291b894de4cd8d7ecc2a283d9a3bfc.diff

[PATCH] D71526: [AST] Use a reference in a range-based for

2019-12-15 Thread Mark de Wever via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG29e78ec67988: [AST] Use a reference in a range-based for (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71526/new/ https://reviews.ll

[clang] 29e78ec - [AST] Use a reference in a range-based for

2019-12-15 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2019-12-15T21:17:07+01:00 New Revision: 29e78ec67988a5aa712da805f8197bfa3d738700 URL: https://github.com/llvm/llvm-project/commit/29e78ec67988a5aa712da805f8197bfa3d738700 DIFF: https://github.com/llvm/llvm-project/commit/29e78ec67988a5aa712da805f8197bfa3d738700.diff

[PATCH] D71530: [Frontend] Fixes -Wrange-loop-analysis warnings

2019-12-15 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D71529: [Sema] Fixes -Wrange-loop-analysis warnings

2019-12-15 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D71527: [Driver] Avoid copies in range-based for loops

2019-12-15 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: Eugene.Zelenko, sepavloff, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall. Repository: rG LLVM Github Monorepo htt

[PATCH] D71526: [AST] Use a reference in a range-based for

2019-12-15 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. This avoids unneeded copies when using a range-based for loops. This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

2019-12-15 Thread Raphael Isemann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4558497ff6: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] aa45584 - [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

2019-12-15 Thread Raphael Isemann via cfe-commits
Author: Raphael Isemann Date: 2019-12-15T18:11:01+01:00 New Revision: aa4558497ff6301881adf38960dd2f4d95aa8fc5 URL: https://github.com/llvm/llvm-project/commit/aa4558497ff6301881adf38960dd2f4d95aa8fc5 DIFF: https://github.com/llvm/llvm-project/commit/aa4558497ff6301881adf38960dd2f4d95aa8fc5.dif

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

2019-12-15 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor updated this revision to Diff 233968. teemperor added a comment. - Addressed Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71397/new/ https://reviews.llvm.org/D71397 Files: clang/include/clang/AST/ExternalASTSource.h clang/include/clang/Sema/ExternalSem

[PATCH] D69223: WDocumentation: Implement the \anchor.

2019-12-15 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:493 + case comments::InlineCommandComment::RenderAnchor: +OS << " RenderAnchor"; +break; Mordante wrote: > gribozavr2 wrote: > > Pleas

[clang-tools-extra] bbc9f6c - [clang-tidy] Add cert-oop58-cpp check

2019-12-15 Thread Gabor Bencze via cfe-commits
Author: Gabor Bencze Date: 2019-12-15T16:30:14+01:00 New Revision: bbc9f6c2ef074668374e06a5de471413afd2ee4b URL: https://github.com/llvm/llvm-project/commit/bbc9f6c2ef074668374e06a5de471413afd2ee4b DIFF: https://github.com/llvm/llvm-project/commit/bbc9f6c2ef074668374e06a5de471413afd2ee4b.diff

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

2019-12-15 Thread Gabor Bencze via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc9f6c2ef07: [clang-tidy] Add cert-oop58-cpp check The check warns when (a member of) the… (authored by gbencze). Changed prior to commit: https://reviews.llvm.org/D70052?vs=229925&id=233966#toc Repos

[PATCH] D71524: [analyzer] Support tainted objects in GenericTaintChecker

2019-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 created this revision. boga95 added reviewers: NoQ, Szelethus. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware. Herald added a project: clang. I extended the supported C++ features: - The `this` pointer can be tainted (0.

[PATCH] D67923: [TLI] Support for per-Function TLI that overrides available libfuncs

2019-12-15 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet accepted this revision. gchatelet added a comment. Thx ! Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:227 + const TargetLibraryInfoImpl &Impl, + LLVM_ATTRIBUTE_UNUSED Optional F = None) + : Impl(&Impl), OverrideAsUnavailable(NumLibFuncs) {

[PATCH] D70878: [analyzer] Add support for namespaces to GenericTaintChecker

2019-12-15 Thread Borsik Gábor via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. boga95 marked 2 inline comments as done. Closed by commit rG273e67425243: [analyzer] Add support for namespaces to GenericTaintChecker (authored by boga95). Changed prior to commit: https://reviews.llvm.org/D70878?vs=2316

[clang] 273e674 - [analyzer] Add support for namespaces to GenericTaintChecker

2019-12-15 Thread Borsik Gabor via cfe-commits
Author: Borsik Gabor Date: 2019-12-15T12:11:22+01:00 New Revision: 273e67425243c74b33d24aa5b2c574877cc3e9bb URL: https://github.com/llvm/llvm-project/commit/273e67425243c74b33d24aa5b2c574877cc3e9bb DIFF: https://github.com/llvm/llvm-project/commit/273e67425243c74b33d24aa5b2c574877cc3e9bb.diff

[PATCH] D64128: [CodeGen] Generate llvm.ptrmask instead of inttoptr(and(ptrtoint, C)) if possible.

2019-12-15 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. In D64128#1576391 , @rjmccall wrote: > I wouldn't favor adding something really obscure that was only useful for > clang, but I think builtins to set and clear mask bits while promising to > preserve object-reference identity

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

2019-12-15 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin added a comment. Hi Gabor, I have an inline comment for the patch. Otherwise, looks good. Comment at: clang/unittests/AST/ASTImporterTest.cpp:252 + QualType Ty = FD->getFriendType()->getType().getCanonicalType(); + if (isa(Ty)) +Ty = cast(Ty)->getNamedType(); --

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

2019-12-15 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added a comment. If I build on macOS with `cmake -GNinja -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Debug -DLLVM_ENABLE_PROJECTS=llvm;clang;lld;compiler-rt;libcxx;libcxxabi -DBUILD_SHARED_LIBS=ON -DLLVM_ENABLE_MODULES=ON`, I get lots of linker errors building e.g. libclangASTDiff.dy

[PATCH] D71433: [analyzer] CERT: POS34-C

2019-12-15 Thread Zurab Tsinadze via Phabricator via cfe-commits
zukatsinadze updated this revision to Diff 233955. zukatsinadze added a comment. - Removed extra test - Used `CallDescription` for checking call. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71433/new/ https://reviews.llvm.org/D71433 Files: clang/docs/analyzer/checkers.rst clang

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

2019-12-15 Thread Lang Hames via Phabricator via cfe-commits
lhames added a comment. In D71397#1784325 , @teemperor wrote: > I would prefer landing this as-is because it is just doing the same we do in > other places in LLVM. Afterwards migrating the whole RTTI system in LLVM to a > new system (whether that will b