[PATCH] D64123: Add clang-llvm-rename tool.

ruiu updated this revision to Diff 208883. ruiu added a comment. - Add a comment as to how to build and run clang-llvm-rename tool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64123/new/ https://reviews.llvm.org/D64123 Files: clang-tools-extra/

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

rjmccall added inline comments. Comment at: include/clang/AST/Type.h:6512 +inline bool Type::isTemplateSpecializationType() const { + return isa(this); +} This is a sugar type. What are you trying to do? Comment at: lib/Sema/SemaType.cpp:7417

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(), Anastas

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

smeenai added subscribers: beanz, smeenai. smeenai added a comment. In D58418#1577349 , @jkorous wrote: > Thanks for the revert. > > There's actually one more problem - seems like ninja doesn't like the > generated build.ninja file on Linux. > > ninja:

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

rjmccall added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = All of this can be much simpler: ``` LangAS AddrSpaceL = ToType->cas

[PATCH] D64464: [CodeGen] Emit destructor calls for non-trivial C structs

rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4100 + if (E->getType().isDestructedType() == QualType::DK_nontrivial_c_struct) +pushDestroy(QualType::DK_nontrivial_c_struct, DeclPtr, E->getType()); + Unfortunately, the lifetime of compoun

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

rjmccall added a comment. Thanks, that looks great. A few more requests and then this will be ready to go, I think. Comment at: include/clang/AST/DeclBase.h:1454 /// Number of non-inherited bits in RecordDeclBitfields. enum { NumRecordDeclBits = 11 };

[PATCH] D64294: [Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()

ychen added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:579 -static bool shouldUseFramePointer(const ArgList &Args, - const llvm::Triple &Triple) { - if (Arg *A = Args.getLastArg(options::OPT_fno_omit_frame_pointer, -

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay updated this revision to Diff 208875. MaskRay edited the summary of this revision. MaskRay added a comment. Add another test: -mabi=elfv2 -mabi=elfv1 -mabi=ibmlongdouble -mabi=ieeelongdouble Try fixing the markdown in the description Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1825 + // that don't use the altivec abi. + if (!SeenOther) +ABIName = A->getValue(); hfinkel wrote: > This seems like an uninte

[PATCH] D64464: [CodeGen] Emit destructor calls for non-trivial C structs

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:248 bool RequiresDestruction = - Dest.isIgnored() && + !Dest.isExternallyDestructed() && RetTy.isDestructedType() == QualType::DK_nontrivial_c_stru

[PATCH] D64464: [CodeGen] Emit destructor calls for non-trivial C structs

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This patch fixes a bug in IRGen where it wasn't calling the destructors for non-trivial C structs in the following cases: - member access of struct

[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak updated this revision to Diff 208861. ahatanak marked 2 inline comments as done. ahatanak added a comment. Add a bit to `RecordDeclBitfields` that indicates whether the record has a non-trivial C union member. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D64458: add -fthinlto-index= option to clang-cl

rnk added a comment. In D64458#1577435 , @pcc wrote: > Do we really need to support clang-cl syntax here? Can't the user of > -fthinlto-index= use the regular clang driver? I think it depends on how many compiler flags we have to pass to backend compil

r365590 - [analyzer] CastValueChecker: Remove a dump()

Author: charusso Date: Tue Jul 9 17:50:01 2019 New Revision: 365590 URL: http://llvm.org/viewvc/llvm-project?rev=365590&view=rev Log: [analyzer] CastValueChecker: Remove a dump() Summary: Fix a nit. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp Modified: cfe/trunk/li

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman marked 2 inline comments as done. emmettneyman added inline comments. Comment at: clang/test/SemaCXX/attr-designated-init-required.cpp:3 + +#define ATTR [[clang::designated_init_required]] + compnerd wrote: > Why the macro? I modeled this file after

[PATCH] D64458: add -fthinlto-index= option to clang-cl

pcc added a comment. Do we really need to support clang-cl syntax here? Can't the user of -fthinlto-index= use the regular clang driver? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64458/new/ https://reviews.llvm.org/D64458 __

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman added a comment. In D64380#1577350 , @compnerd wrote: > I don't see any cases where `[[clang::required]]` is tested, am I missing > something? I renamed the attribute at your suggestion. It's now called `[[clang::designated_init_required]`

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion added a comment. This is similar to r254927 for the clang driver, and reuses the tests from that commit for the backend part. On the frontend, it differs in that clang-cl does not support -x (per the comment in clang/lib/Driver/Driver.cpp line 2068: "// No driver mode exposes -x and /

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

This revision was automatically updated to reflect the committed changes. Closed by commit rL365587: [Driver] Add float-divide-by-zero back to supported sanitizers after… (authored by MaskRay, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/

r365587 - [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

Author: maskray Date: Tue Jul 9 17:30:02 2019 New Revision: 365587 URL: http://llvm.org/viewvc/llvm-project?rev=365587&view=rev Log: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272 D63793 removed float-divide-by-zero from the "undefined" set but it failed to

[PATCH] D64458: add -fthinlto-index= option to clang-cl

inglorion created this revision. inglorion added reviewers: tejohnson, pcc, rnk. Herald added subscribers: arphaman, dexonsmith, steven_wu, mehdi_amini. Herald added a project: clang. This adds a -fthinlto-index= option to clang-cl, which allows it to be used to drive ThinLTO backend passes. This

r365585 - [analyzer] CastValueChecker: Model casts

Author: charusso Date: Tue Jul 9 17:20:03 2019 New Revision: 365585 URL: http://llvm.org/viewvc/llvm-project?rev=365585&view=rev Log: [analyzer] CastValueChecker: Model casts Summary: It models the LLVM casts: - `cast<>` - `dyn_cast<>` - `cast_or_null<>` - `dyn_cast_or_null<>` It has a very bas

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208847. Charusso added a comment. - Add the llvm namespace to the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/include/

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

compnerd added a comment. I don't see any cases where `[[clang::required]]` is tested, am I missing something? Comment at: clang/test/SemaCXX/attr-designated-init-required.cpp:3 + +#define ATTR [[clang::designated_init_required]] + Why the macro? ===

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. Thanks for the revert. There's actually one more problem - seems like ninja doesn't like the generated build.ninja file on Linux. ninja: error: build.ninja:52390: bad $-escape (literal $ must be written as $$) http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/

[PATCH] D64257: [clangd] Added highlighting for class and enum types

nridge added a comment. @jvikstrom out of curiosity, are you testing these patches against a client-side implementation of semantic highlighting? If so, which one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64257/new/ https://reviews.llvm.org/D

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208842. emmettneyman added a comment. slight change to specification reference format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: clang/include/clang/

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

rsmith added a comment. C++20 designated initializers don't permit mixing designated fields with non-designated ones, so some of the examples here are invalid. However, I think we should be looking for an attribute design that works well in both C and C++, and with the various Clang extensions

r365584 - Revert "[analyzer] CastValueChecker: Model casts"

Author: charusso Date: Tue Jul 9 16:47:09 2019 New Revision: 365584 URL: http://llvm.org/viewvc/llvm-project?rev=365584&view=rev Log: Revert "[analyzer] CastValueChecker: Model casts" This reverts commit 27cf6664437efd640bb6db5594bafcce68fa2854. Removed: cfe/trunk/lib/StaticAnalyzer/Checker

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208840. emmettneyman marked an inline comment as done. emmettneyman added a comment. Remove cppreference link, add reference to C++ spec. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://re

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/clang-analyzer-apiModeling.StdCLibraryFunctions.rst:4 +clang-analyzer-apiModeling.StdCLibraryFunctions +

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

This revision was automatically updated to reflect the committed changes. Closed by commit rL365582: [analyzer] CastValueChecker: Model casts (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r365582 - [analyzer] CastValueChecker: Model casts

Author: charusso Date: Tue Jul 9 16:33:23 2019 New Revision: 365582 URL: http://llvm.org/viewvc/llvm-project?rev=365582&view=rev Log: [analyzer] CastValueChecker: Model casts Summary: It models the LLVM casts: - `cast<>` - `dyn_cast<>` - `cast_or_null<>` - `dyn_cast_or_null<>` It has a very bas

[PATCH] D50763: [Parser] Refactor and fix bugs in late-parsing

rsmith added inline comments. Herald added a project: clang. Comment at: lib/Parse/ParseCXXInlineMethods.cpp:266 +public: + UseCachedTokensRAII(Parser &Self, CachedTokens &Cache, const void *Data) + : Self(Self), Data(Data) { Can you pass ownership of the c

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added a comment. Thanks for the review! In D64374#1577279 , @NoQ wrote: > That doesn't sound like it's high on our list. That's not too many times. > Probably very few false positives come out of it. Also modeling smart > pointers is much harde

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

rnk added a comment. Reverted in rC365581 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

rnk added inline comments. Comment at: cfe/trunk/unittests/DirectoryWatcher/DirectoryWatcherTest.cpp:420 +std::error_code setTimeRes = +llvm::sys::fs::setLastAccessAndModificationTime(FD, NewTimePt, +NewTimePt);

r365581 - Revert [clang] DirectoryWatcher

Author: rnk Date: Tue Jul 9 16:22:01 2019 New Revision: 365581 URL: http://llvm.org/viewvc/llvm-project?rev=365581&view=rev Log: Revert [clang] DirectoryWatcher This reverts r365574 (git commit 31babea94a3ed38a140540f2252cf043dacec1f7) Removed: cfe/trunk/include/clang/DirectoryWatcher/

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry added a comment. The contents of each check page are identical other than the check name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/ https://reviews.llvm.org/D64454 ___

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: clang. Since clang-tidy supports use of the static analyzer there should be documentation of how to invoke the static a

r365579 - [MS] Treat ignored explicit calling conventions as an explicit __cdecl

Author: rnk Date: Tue Jul 9 16:17:43 2019 New Revision: 365579 URL: http://llvm.org/viewvc/llvm-project?rev=365579&view=rev Log: [MS] Treat ignored explicit calling conventions as an explicit __cdecl The CCCR_Ignore action is only used for Microsoft calling conventions, mainly because MSVC does

[clang-tools-extra] r365576 - [clangd] fix assert in test after r365531.

Author: sammccall Date: Tue Jul 9 16:05:20 2019 New Revision: 365576 URL: http://llvm.org/viewvc/llvm-project?rev=365576&view=rev Log: [clangd] fix assert in test after r365531. Unverified because CMake/ninja seems to be broken... Modified: clang-tools-extra/trunk/clangd/unittests/Backgroun

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added a comment. Mmm. Ok, am i understanding correctly that this was crashing because you bound a `0 (Loc)` to a prvalue expression of type `unique_ptr`? Yeah, right, don't do that :) > used like 20 times in the LLVM codebase That doesn't sound like it's high on our list. That's not too ma

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added a comment. In D64374#1577266 , @NoQ wrote: > Can you provide more info, eg. the full backtrace? Well, `unique_dyn_cast<>` and `unique_dyn_cast_or_null<>` is used like 20 times in the LLVM codebase, whoops. We want to model it. Full info:

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit rL365574: [clang] DirectoryWatcher (authored by jkorous, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58418?vs=

r365574 - [clang] DirectoryWatcher

Author: jkorous Date: Tue Jul 9 15:44:48 2019 New Revision: 365574 URL: http://llvm.org/viewvc/llvm-project?rev=365574&view=rev Log: [clang] DirectoryWatcher Asynchronously monitors specified directory for changes and passes notifications to provided callback. Dependency for index-while-buildi

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added a comment. In D64374#1577262 , @Charusso wrote: > - Add the forgotten `llvm` namespace to the `CallDescription`. Nice! In D64374#1577254 , @Charusso wrote: > The only crash-able code was that: > > #0

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208831. Charusso added a comment. - Add the forgotten `llvm` namespace to the `CallDescription`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso added a comment. In D64374#1577235 , @NoQ wrote: > Whoops. I underestimated you (: > > Ok, anyway, this was my last comment. Great job! Remember to make sure that > it works on the actual LLVM, not only on tests; mocked-up test headers are > ver

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208829. emmettneyman added a comment. Updated tests and diagnostic messages with new attribute spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: cl

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

xazax.hun added a comment. In D64448#1577109 , @gribozavr wrote: > > The tests are currently here > > I think due to their dependency on a standard library, they are not a good > > fit for clang/test/. Where else could I put them? > > Make some mocks tha

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Whoops. I underestimated you (: Ok, anyway, this was my last comment. Great job! Remember to make sure that it works on the actual LLVM, not only on tests; mocked-up test headers are very easy to g

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:172 + !CE->getArg(0)->getType()->getPointeeCXXRecordDecl()) +return false; + If we cannot obtain any of the CXXR

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:58 +static std::string getCastName(const Expr *Cast) { + return Cast->getType()->getPointeeCXXRecordDecl()->getNameAsString(); +} You should still check if `Cast->getTy

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso updated this revision to Diff 208824. Charusso marked 6 inline comments as done. Charusso added a comment. - Move to `apiModeling.llvm`. - Prevent unknown casts. - Refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 Files: clang

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. It would be nice to land this before 9.0 branch date... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D63663: [clang-doc] Add html links to references

juliehockett added a comment. I've also just noticed that the YAML generator is missing from this -- could you add the `Path` fields to hat output as well? Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:213 + llvm::SmallString<128> Path = Type.Path; + llvm::sys::p

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

lebedev.ri added a comment. In D64375#1577153 , @jdoerfert wrote: > @lebedev.ri I'd like to see if we can transition this one into a more generic > one with version numbers etc. Is that OK? I have no further comment at the moment. Repository: rG LLV

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert added a comment. I will update the table (hopefully tomorrow) and we can then see if we commit it and change it in-place or if we have more initial feedback. Thanks everyone for providing all this information! @lebedev.ri I'd like to see if we can transition this one into a more gener

[PATCH] D64383: build: use multiple `install` rather than building up a list

compnerd closed this revision. compnerd added a comment. SVN r365562 Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64383/new/ https://reviews.llvm.org/D64383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208814. emmettneyman marked 3 inline comments as done. emmettneyman added a comment. Changed attribute spelling from GNU to CXX11 and renamed the 'required' attribute to 'designated_init_required' Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

gribozavr added a comment. > The tests are currently here > I think due to their dependency on a standard library, they are not a good > fit for clang/test/. Where else could I put them? Make some mocks that reproduce the salient parts of different libraries, the coding patterns they use, and

[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

mgehre created this revision. mgehre added reviewers: gribozavr, xazax.hun. Herald added a subscriber: rnkovacs. Herald added a project: clang. Make the DerefType, i.e. the argument of gsl::Owner/gsl::Pointer optional for now. The DerefType is used when infering lifetime annotations of functions

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 208811. jdoerfert added a comment. Herald added a subscriber: jfb. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/At

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ updated this revision to Diff 208807. NoQ added a comment. Bring back the option in order to preserve backwards compatibility. Sneak in an implicit conversion from `CheckName` to `StringRef` so that not to repeat myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ htt

r365558 - XFAIL clang/test/Headers/max_align.c on i686

Author: andusy Date: Tue Jul 9 14:06:34 2019 New Revision: 365558 URL: http://llvm.org/viewvc/llvm-project?rev=365558&view=rev Log: XFAIL clang/test/Headers/max_align.c on i686 Modified: cfe/trunk/test/Headers/max_align.c Modified: cfe/trunk/test/Headers/max_align.c URL: http://llvm.org/vi

r365557 - Use the Itanium C++ ABI for the pipe_builtin.cl test

Author: rnk Date: Tue Jul 9 14:02:06 2019 New Revision: 365557 URL: http://llvm.org/viewvc/llvm-project?rev=365557&view=rev Log: Use the Itanium C++ ABI for the pipe_builtin.cl test Certain OpenCL constructs cannot yet be mangled in the MS C++ ABI. Add a FIXME for it if anyone cares to implement

r365556 - De-templatize non-dependent VS macro logic, NFC

Author: rnk Date: Tue Jul 9 13:57:28 2019 New Revision: 365556 URL: http://llvm.org/viewvc/llvm-project?rev=365556&view=rev Log: De-templatize non-dependent VS macro logic, NFC These macro definitions don't depend on the template parameter, so they don't need to be part of the template. Move the

r365555 - [CXX] Exercise all paths through these tests.

Author: probinson Date: Tue Jul 9 13:49:07 2019 New Revision: 36 URL: http://llvm.org/viewvc/llvm-project?rev=36&view=rev Log: [CXX] Exercise all paths through these tests. Differential Revision: https://reviews.llvm.org/D63894 Modified: cfe/trunk/test/CXX/dcl.dcl/basic.namespace/na

[PATCH] D63894: [CXX] Exercise all paths through these tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL36: [CXX] Exercise all paths through these tests. (authored by probinson, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. Yay, great! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64356/new/ https://reviews.llvm.org/D64356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

FYI, your test seems to fail on Windows: FAIL: Clang :: CodeGenOpenCL/pipe_builtin.cl (4679 of 15176) TEST 'Clang :: CodeGenOpenCL/pipe_builtin.cl' FAILED Script: -- : 'RUN: at line 1'; c:\b\slave\clang-x64-windows-msvc\build\build\stage1\bin\clang.exe -cc1

[PATCH] D62855: [clangd] Implementation of auto type expansion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, let's land this! We can enhance further later, but this covers the most common cases. (I think the remaining comments are trivial - then I/you can land without further review)

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi added a comment. Recommitted as https://reviews.llvm.org/rL365509 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63161/new/ https://reviews.llvm.org/D63161 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug

jdenny updated this revision to Diff 208795. jdenny retitled this revision from "[Rewrite][NFC] Add FIXME about RemoveLineIfEmpty" to "[Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug". jdenny edited the summary of this revision. jdenny added a comment. Rebase, and add a unit test t

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause: devic

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365551: hwasan: Improve precision of checks using short granule tags. (authored by pcc, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D63908?vs=

r365551 - hwasan: Improve precision of checks using short granule tags.

Author: pcc Date: Tue Jul 9 13:22:36 2019 New Revision: 365551 URL: http://llvm.org/viewvc/llvm-project?rev=365551&view=rev Log: hwasan: Improve precision of checks using short granule tags. A short granule is a granule of size between 1 and `TG-1` bytes. The size of a short granule is stored at

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

keryell added a comment. Good improvement! Comment at: docs/LanguageExtensions.rst:1758 +to enqueue constructor initialization kernel that has a name +``@_GLOBAL__sub_I_``. This kernel is only present if there +are any global objects to be initialized in the compiled binary. On

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause: device

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:567 + ParentI->Namespace = llvm::SmallVector( + Enum.Namespace.begin() + 1, Enum.Namespace.end()); + ParentI->Path = getInfoOutputFile(OutDirectory, ParentI->Namespace)

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208792. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D63857 Files: clang-tools-extra/clang-doc/CMakeLists.txt clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Generators.h cla

[PATCH] D64283: [PowerPC] Support -mabi=ieeelongdouble and -mabi=ibmlongdouble

hfinkel added a comment. Ah, fun with overloaded, legacy command-line options... Comment at: lib/Driver/ToolChains/Clang.cpp:1825 + // that don't use the altivec abi. + if (!SeenOther) +ABIName = A->getValue(); This seems like an unintentional

[PATCH] D63908: hwasan: Improve precision of checks using short granule tags.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63908/new/ https://reviews.llvm.org/D63908 _

[PATCH] D63663: [clang-doc] Add html links to references

DiegoAstiazaran updated this revision to Diff 208789. DiegoAstiazaran marked 5 inline comments as done. DiegoAstiazaran added a comment. The info path generated in serialization was the composite of the out directory and the parent namespaces. Now it's only the parent namespaces; the out directo

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

smeenai added a comment. In D64089#1576902 , @ldionne wrote: > Background question: I'm familiar with the behavior on Darwin, where we > prefer C++ headers in the toolchain (alongside the driver), however do other > platforms behave the same? I thought t

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

ldionne added a comment. Background question: I'm familiar with the behavior on Darwin, where we prefer C++ headers in the toolchain (alongside the driver), however do other platforms behave the same? I thought this was something specific to Darwin. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

sammccall added a comment. Ping... it'd be nice to have for clangd-9, though it's getting late. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63085/new/ https://reviews.llvm.org/D63085 ___ cfe-commits mailing list cf

[PATCH] D63098: [CodeComplete] Allow completing enum values within case statements, and insert 'case' as a fixit.

sammccall planned changes to this revision. sammccall added a comment. I'll give this a try. I expect it to feel quite glitchy when the enum type has a long name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63098/new/ https://reviews.llvm.org/D63098 ___

[PATCH] D63894: [CXX] Exercise all paths through these tests

probinson marked an inline comment as done. probinson added inline comments. Comment at: clang/test/SemaCXX/linkage2.cpp:3 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98 // RUN: %clang_cc1 -fsyntax-only -verify -Wno

[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

NoQ added a comment. I'd rather not abandon this patch, because it looks like a strict improvement over the lack of condition tracking, and it might as well still be an improvement over "zealous" condition tracking, as my counterexample is fairly artificial. It indicates that a slightly more so

[PATCH] D64287: [analyzer] Track the right hand side of the last store regardless of its value

NoQ added a comment. Whoa, the new notes are amazing. Looks like you've found a pretty bad omission. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1436-1437 -} -ReturnVisitor::addVisitorIfNecessary(StoreSite, InitE->IgnoreParenCasts(), -

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre updated this revision to Diff 208785. mgehre added a comment. Move checks into AST matchers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 Files: clang-tools-extra/clang-tidy/readability/CMakeList

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev added a comment. In D64356#1576813 , @NoQ wrote: > Something like this: > > F9509417: photo_2019-07-09_12-21-46.jpg > > Like, you can construct a CFG for an arbitrary statement. CFG₁ is the CFG for > xxx() and C

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 ___ cfe-c

[PATCH] D63894: [CXX] Exercise all paths through these tests

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/linkage2.cpp:3 +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98 // RUN: %cla

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

This revision was automatically updated to reflect the committed changes. Closed by commit rL365545: [OpenMP] Simplify getFloatTypeSemantics (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTIO

r365545 - [OpenMP] Simplify getFloatTypeSemantics

Author: maskray Date: Tue Jul 9 12:36:22 2019 New Revision: 365545 URL: http://llvm.org/viewvc/llvm-project?rev=365545&view=rev Log: [OpenMP] Simplify getFloatTypeSemantics When the float point representations are the same on the host and on the target device, (`&Target->getLongDoubleFormat() =

Re: [libunwind] r364217 - Merging r360861:

On 07/09/2019 12:28 PM, Dimitry Andric wrote: > On 9 Jul 2019, at 04:54, Tom Stellard wrote: >> >> On 07/08/2019 11:51 AM, Dimitry Andric wrote: >>> On 24 Jun 2019, at 20:40, Tom Stellard via cfe-commits >>> wrote: Author: tstellar Date: Mon Jun 24 11:40:58 2019 New Revision:

  1   2   3   >