[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

2019-06-22 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D62883#1554514 , @Szelethus wrote: > In D62883#1554494 , @NoQ wrote: > > > It should be pretty easy to implement, just add your new visitor to the > > list of default visitors in `findValidR

r364147 - Revert "builtins: relax __iso_volatile_{load,store}32"

2019-06-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 22 19:53:03 2019 New Revision: 364147 URL: http://llvm.org/viewvc/llvm-project?rev=364147&view=rev Log: Revert "builtins: relax __iso_volatile_{load,store}32" This reverts commit SVN r364137. This seems to be cause problems with casting in C. Removed: cfe/trun

r364145 - MSVC visualizers for type aliases

2019-06-22 Thread Mike Spertus via cfe-commits
Author: mps Date: Sat Jun 22 18:15:48 2019 New Revision: 364145 URL: http://llvm.org/viewvc/llvm-project?rev=364145&view=rev Log: MSVC visualizers for type aliases For example, the following TypeAliasTemplateDecl now displays in the autos window as template using type_identity_t = type_identity:

[PATCH] D63685: [analyzer] exploded-graph-rewriter: Add support for range constraints.

2019-06-22 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. That is a great design-decision, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63685/new/ https://reviews.llvm.org/D63685 __

[PATCH] D63684: [analyzer] exploded-graph-rewriter: NFC: Extract some code into functions.

2019-06-22 Thread Csaba Dabis via Phabricator via cfe-commits
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I like that abstraction! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63684/new/ https://reviews.llvm.org/D63684 __

r364140 - Fix TBAA representation for zero-sized fields and unnamed bit-fields.

2019-06-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Jun 22 14:30:43 2019 New Revision: 364140 URL: http://llvm.org/viewvc/llvm-project?rev=364140&view=rev Log: Fix TBAA representation for zero-sized fields and unnamed bit-fields. Unnamed bit-fields should not be represented in the TBAA metadata because they do not represen

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

2019-06-22 Thread Jinsong Ji via Phabricator via cfe-commits
jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63636/new/ https://reviews.llvm.org/D63636 __

r364139 - Remove reliance on toCharUnitsFromBits rounding down.

2019-06-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Jun 22 13:41:57 2019 New Revision: 364139 URL: http://llvm.org/viewvc/llvm-project?rev=364139&view=rev Log: Remove reliance on toCharUnitsFromBits rounding down. Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp URL

r364138 - Natural MSVC visualization of constructors

2019-06-22 Thread Mike Spertus via cfe-commits
Author: mps Date: Sat Jun 22 11:56:40 2019 New Revision: 364138 URL: http://llvm.org/viewvc/llvm-project?rev=364138&view=rev Log: Natural MSVC visualization of constructors E.g., Allow MSVC to visualize a CXXConstructorDecl like Constructor { Y(type_identity_t)} Modified: cfe/trunk/utils/C

r364137 - builtins: relax __iso_volatile_{load,store}32

2019-06-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 22 11:55:51 2019 New Revision: 364137 URL: http://llvm.org/viewvc/llvm-project?rev=364137&view=rev Log: builtins: relax __iso_volatile_{load,store}32 This is reduced from MSVC's MSVCPRT 14.21.27702 atomic header. Because Windows is a LLP64 environment, `long`, `lon

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

2019-06-22 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai updated this revision to Diff 206123. nemanjai added a comment. Remove the double cast. Simplify the test case. Rename the temp. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63636/new/ https://reviews.llvm.org/D63636 Files: lib/Headers/altivec.h te

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

2019-06-22 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai marked 3 inline comments as done. nemanjai added inline comments. Comment at: lib/Headers/altivec.h:16364 signed short *__ptr) { - return *(unaligned_vec_sshort *)(__ptr + __offset); + signed char *Adjusted = (sign

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

2019-06-22 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 206121. Tyker edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTI