[PATCH] D63030: [WebAssembly] Modernize include path handling

sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63030/new/ https://reviews.llvm.org/D63030

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast added a comment. @NoQ, I've updated the patches based on the changes you suggested. This patch, D62950 , and D62951 now looks much cleaner. These are now dependent on the approval of D63041

[PATCH] D62951: [analyzer][tests] Use normalize_plist in place of diff_plist (`tail` cases)

hubert.reinterpretcast updated this revision to Diff 203708. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62950: [analyzer][tests] Use normalize_plist in place of diff_plist (`cat` cases)

hubert.reinterpretcast updated this revision to Diff 203707. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D62949: [analyzer][tests] Add normalize_plist to replace diff_plist

hubert.reinterpretcast updated this revision to Diff 203706. hubert.reinterpretcast added a comment. Update based on review comments, building from rL362877 and D63041 Repository: rC Clang CHANGES SINCE LAST ACTION https

r362887 - [analyzer][NFC] Add dividers to BugReporterVisitors.cpp

Author: szelethus Date: Sat Jun 8 13:25:39 2019 New Revision: 362887 URL: http://llvm.org/viewvc/llvm-project?rev=362887&view=rev Log: [analyzer][NFC] Add dividers to BugReporterVisitors.cpp Some minor formatting to make the file more readable. Added //===--===// around the implementatio

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru marked an inline comment as done. sylvestre.ledru added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:610 + Builder.defineMacro("__VERSION__", "\"" CLANG_VERSION_STRING + " Compatible " + Twine(getClangFullCPPVersion()) + +

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

lebedev.ri added inline comments. Comment at: lib/Frontend/InitPreprocessor.cpp:610 + Builder.defineMacro("__VERSION__", "\"" CLANG_VERSION_STRING + " Compatible " + Twine(getClangFullCPPVersion()) + + "\""); So how does

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203700. sylvestre.ledru added a comment. fix rst syntax Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreprocessor.cpp te

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, `__VERSION__` returns the Clang version instead of 4.2.1. I think this needs double backquotes on

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 203697. serge-sans-paille added a comment. Using @beanz idea, provide an option to `add_llvm_executable` to declare it as receiving plugins, which provides lower coupling with actual plugins Tested with four configurations: `BUILD_SHARED_LIBS` ON/O

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203695. sylvestre.ledru added a comment. Fix the typo (thanks hubert) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreproc

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

hubert.reinterpretcast added inline comments. Comment at: docs/ReleaseNotes.rst:79 - ``clang -dumpversion`` now returns the version of Clang itself. + Similarly, __VERSION__ returns the Clang version instead of 4.2.1. Use code font for `__VERSION__`. ==

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru added a comment. In D63048#1535222 , @xbolva00 wrote: > Btw, what about this code > > // Currently claim to be compatible with GCC 4.2.1-5621, but only if we're > // not compiling for MSVC compatibility > Builder.defineMacro("__GNUC_M

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru updated this revision to Diff 203693. sylvestre.ledru added a comment. update of the release notes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63048/new/ https://reviews.llvm.org/D63048 Files: docs/ReleaseNotes.rst lib/Frontend/InitPreproce

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

xbolva00 added a comment. Btw, what about this code // Currently claim to be compatible with GCC 4.2.1-5621, but only if we're // not compiling for MSVC compatibility Builder.defineMacro("__GNUC_MINOR__", "2"); Builder.defineMacro("__GNUC_PATCHLEVEL__", "1"); Builder.defineMacro("__GNUC

[PATCH] D59702: Unbreak the build of compiler-rt on Linux/mips64el

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. indeed, closing Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59702/new/ https://reviews.llvm.org/D59702 ___ cfe-commits mailing

[PATCH] D60379: Make precompiled headers reproducible

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. yeah thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379 ___ cfe-commits mailing list cfe-commits@

[PATCH] D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: rnk. Herald added a subscriber: fedor.sergeev. Herald added a project: clang. Just like in https://reviews.llvm.org/D56803 for -dumpversion Repository: rC Clang https://reviews.llvm.org/D63048 Files: lib/Frontend/Init

r362877 - [analyzer][NFC][tests] Pre-normalize expected-plists

Author: hubert.reinterpretcast Date: Sat Jun 8 06:51:37 2019 New Revision: 362877 URL: http://llvm.org/viewvc/llvm-project?rev=362877&view=rev Log: [analyzer][NFC][tests] Pre-normalize expected-plists As suggested in the review for D62949, this patch pre-normalizes the reference expected output

r362876 - [analyzer][NFC][tests] Remove unused expected-plist files

Author: hubert.reinterpretcast Date: Sat Jun 8 06:48:25 2019 New Revision: 362876 URL: http://llvm.org/viewvc/llvm-project?rev=362876&view=rev Log: [analyzer][NFC][tests] Remove unused expected-plist files Removed: cfe/trunk/test/Analysis/Inputs/expected-plists/cstring-plist.c.plist cfe/

Re: AST in JSONFormat

On Sat, Jun 8, 2019 at 5:46 AM Monalisa Rout via cfe-commits wrote: > > Hello, > > I am using LibTooling to dump the clangAST in JSON format which is available > in clang 9. > I need the JSON Schema for that. Is it available ?? > > If not wil you be interested in one ?? The JSON format for AST d

[PATCH] D54091: [RISCV] Add inline asm constraints I, J & K for RISC-V

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Jim. This looks good to me, but is blocked on the dependent patch being updated. I added a minor comment on riscv-inline-asm.c Comment at: test/CodeGen/

[PATCH] D54091: [RISCV] Add inline asm constraints I, J & K for RISC-V

lewis-revill updated this revision to Diff 203367. lewis-revill edited the summary of this revision. lewis-revill added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Rebased and fixed test run line Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

AST in JSONFormat

Hello, I am using LibTooling to dump the clangAST in JSON format which is available in clang 9. I need the JSON Schema for that. Is it available ?? If not wil you be interested in one ?? Regards, Mona ___ cfe-commits mailing list cfe-commits@lists.llvm

r362808 - Build with _XOPEN_SOURCE defined on AIX

Author: daltenty Date: Fri Jun 7 08:45:25 2019 New Revision: 362808 URL: http://llvm.org/viewvc/llvm-project?rev=362808&view=rev Log: Build with _XOPEN_SOURCE defined on AIX Summary: It is useful to build with _XOPEN_SOURCE defined on AIX, enabling X/Open and POSIX compatibility mode, to work ar

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

nickdesaulniers added a comment. For future travelers, we're tracking 2 related bugs: - `-no-integrated-as` providing different results: https://github.com/ClangBuiltLinux/linux/issues/500 - `IfConverter` `assert`ing on `INLINEASM_BR` `MachineInstr`s: https://github.com/ClangBuiltLinux/linux/is

r362637 - [cmake] Remove duplicate TestingSupport library for linking

Author: pzheng Date: Wed Jun 5 12:44:08 2019 New Revision: 362637 URL: http://llvm.org/viewvc/llvm-project?rev=362637&view=rev Log: [cmake] Remove duplicate TestingSupport library for linking Summary: This patch cleans up a duplicate use of TestingSupport library. Subscribers: mgorny, cfe-commi

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a comment. There's still something weird in the backend, but things seem to generally work if you pass -fno-integrated-as to clang which the linux kernel does. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 ___

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

erichkeane added a comment. In D56571#1523895 , @nickdesaulniers wrote: > Was this committed accidentally? > > Today in master I see: > > - r362106: Revert "clang support gnu asm goto." Erich Keane > > - r362059: Mark CodeGen/asm-goto.c as x86 specific

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

xbolva00 added a comment. There is a bug.. I took GCC’s example for asm goto and trunk emits: https://godbolt.org/z/9EcTR9 Wrong jb instruction target.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 _