rsmith added inline comments.
Comment at: cfe/trunk/lib/Sema/TreeTransform.h:7173
+auto *MD = dyn_cast_or_null(FD);
+if (!MD || !MD->getParent()->isGenericLambda()) {
+ assert(!Promise->getType()->isDependentType() &&
This assert doesn't seem correct
Author: rsmith
Date: Sun Jun 2 23:02:10 2019
New Revision: 362358
URL: http://llvm.org/viewvc/llvm-project?rev=362358&view=rev
Log:
PR42104: Support instantiations of lambdas that implicitly capture
packs.
Two changes:
* Track odr-use via FunctionParmPackExprs to properly handle dependent
od
nridge updated this revision to Diff 202646.
nridge marked 5 inline comments as done.
nridge added a comment.
Address remaining review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62471/new/
https://reviews.llvm.org/D62471
Files:
clang
This revision was automatically updated to reflect the committed changes.
nridge marked 4 inline comments as done.
Closed by commit rL362353: [clangd] Serialization support for RelationSlab
(authored by nridge, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362352: [clangd] Add RelationSlab (authored by nridge,
committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D59407?vs=
modocache added a comment.
Great, thanks for the review!
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62550/new/
https://reviews.llvm.org/D62550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362348: [coroutines][PR41909] Don't build dependent
coroutine statements for generic… (authored by modocache, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Reposit
Author: modocache
Date: Sun Jun 2 17:47:32 2019
New Revision: 362348
URL: http://llvm.org/viewvc/llvm-project?rev=362348&view=rev
Log:
[coroutines][PR41909] Don't build dependent coroutine statements for generic
lambda
Summary:
https://bugs.llvm.org/show_bug.cgi?id=41909 describes an issue in w
Author: dergachev
Date: Sun Jun 2 17:21:00 2019
New Revision: 362347
URL: http://llvm.org/viewvc/llvm-project?rev=362347&view=rev
Log:
Revert "[analyzer] exploded-graph-rewriter: An attempt to fix Windows
buildbots."
This reverts commit r362343.
Instead, disable tests on Windows for now.
Modi
Author: dergachev
Date: Sun Jun 2 16:17:56 2019
New Revision: 362343
URL: http://llvm.org/viewvc/llvm-project?rev=362343&view=rev
Log:
[analyzer] exploded-graph-rewriter: An attempt to fix Windows buildbots.
Breakage caused by r362340.
Modified:
cfe/trunk/test/Analysis/exploded-graph-rewrit
jcai19 marked 6 inline comments as done.
jcai19 added inline comments.
Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.cpp:31
+ Result,
+ "prefer pipe2() to pipe() because pipe2() allows O_CLOEXEC",
+ ReplacementText);
gribozavr w
jcai19 updated this revision to Diff 202625.
jcai19 marked an inline comment as done.
jcai19 added a comment.
Remove CHECK-MESSAGES-NOT and update description based on comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61967/new/
https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362340: [analyzer] exploded-graph-rewriter: Initial commit.
(authored by dergachev, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:
Author: dergachev
Date: Sun Jun 2 14:40:53 2019
New Revision: 362340
URL: http://llvm.org/viewvc/llvm-project?rev=362340&view=rev
Log:
[analyzer] exploded-graph-rewriter: Initial commit.
This is a utility to improve readability and generally manipulate
GraphViz dumps of the analysis graph. Such
Author: rsmith
Date: Sun Jun 2 11:53:44 2019
New Revision: 362336
URL: http://llvm.org/viewvc/llvm-project?rev=362336&view=rev
Log:
Transform lambda expression captures when transforming an expression to
potentially-evaluated.
This ensures that every potentially-evaluated expression is built in
Author: dhinton
Date: Sun Jun 2 10:56:26 2019
New Revision: 362334
URL: http://llvm.org/viewvc/llvm-project?rev=362334&view=rev
Log:
Fix bug in r362328 -- append to dependency list instead of overwrite it.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
Author: nico
Date: Sun Jun 2 10:23:53 2019
New Revision: 362331
URL: http://llvm.org/viewvc/llvm-project?rev=362331&view=rev
Log:
Add mangling test coverage for non-volatile const member pointers
Modified:
cfe/trunk/test/CodeGenCXX/mangle-ms.cpp
Modified: cfe/trunk/test/CodeGenCXX/mangle-ms
Author: nico
Date: Sun Jun 2 09:47:07 2019
New Revision: 362329
URL: http://llvm.org/viewvc/llvm-project?rev=362329&view=rev
Log:
Add test coverage for __pascal mangling
Modified:
cfe/trunk/test/CodeGenCXX/mangle-windows.cpp
Modified: cfe/trunk/test/CodeGenCXX/mangle-windows.cpp
URL:
http:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL362328: [test] Fix plugin tests (authored by dhinton,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D62445?vs=202573&id=202605#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
Author: dhinton
Date: Sun Jun 2 08:53:43 2019
New Revision: 362328
URL: http://llvm.org/viewvc/llvm-project?rev=362328&view=rev
Log:
[test] Fix plugin tests
Recommit of r361790 that was temporarily reverted in r361793 due to bot
breakage.
Summary:
The following changes were required to fix the
t.yomitch added a comment.
Thanks Eric!
I don't have commit access; could someone please commit this for me?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62133/new/
https://reviews.llvm.org/D62133
___
cfe-commits ma
krytarowski added a comment.
sysv abi is not only for UNIX but most non-Windows ones (BSDs, HAIKU, ...).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59744/new/
https://reviews.llvm.org/D59744
___
cfe-commits mailing list
cfe-commits@lists
Thank you!
On Sun, Jun 2, 2019 at 6:57 AM Richard Smith via cfe-commits
wrote:
>
> Author: rsmith
> Date: Sat Jun 1 21:00:38 2019
> New Revision: 362316
>
> URL: http://llvm.org/viewvc/llvm-project?rev=362316&view=rev
> Log:
> Add script to update OpenMP -ast-dump test expectations, and use it t
23 matches
Mail list logo
