[PATCH] D56043: [Driver] Don't pass default value to getCompilerRTArgString

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56043/new/ https://reviews.llvm.org/D56043 ___ c

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. OK, that makes sense. I'm not a huge fan of how this set of code looks, but it also seems unfair to require you to extensively refactor it for this. Any issues with crtbegin/end and where

[PATCH] D56181: [CMake][Fuchsia] Include check-lld in the list of bootstrap targets

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett, leonardchan. Herald added subscribers: cfe-commits, mgorny. This allows running lld tests when doing 2-stage toolchain build. Repository: rC Clang https://reviews.llvm.org/D56181 Files: clang/cmake/

Re: r350143 - Add vtable anchor to classes.

While I realize it's in the coding standard - is there any particular other motivation for this? (Given you've been doing layering cleanup - I'm wondering fi this is an interesting workaround for some layering problems, for instance?) On Sat, Dec 29, 2018 at 1:05 PM Richard Trieu via cfe-commits <

r350182 - Make clearer which clang::type subclasses have visualizers

Author: mps Date: Mon Dec 31 15:01:34 2018 New Revision: 350182 URL: http://llvm.org/viewvc/llvm-project?rev=350182&view=rev Log: Make clearer which clang::type subclasses have visualizers Modified: cfe/trunk/utils/ClangVisualizers/clang.natvis Modified: cfe/trunk/utils/ClangVisualizers/clan

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek added a comment. I'd be happy to abandon this change if we decide to not move forward with D28791 . I've made that change a parent revision of this change (although they don't necessarily have to land in that order) to make it obvious. Repository: rC

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

krytarowski added a comment. This patch attempts to add support for .o/object files from compiler-rt and right now there are no users and the only potential ones are crt* according to my guess. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://re

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek added a comment. I'd suggest moving this discussion to D28791 since your comments seem to be more related to the content of that change, not the content of this patch. I'm not trying to bypass the discussion in D28791 , I

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

krytarowski added a reviewer: joerg. krytarowski added a comment. Adding joerg who raised concerns in the original change and is bypassed with this change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://reviews.llvm.org/D56044 __

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

krytarowski added a comment. I don't know the original rationale of GNU.. but the final result (probably not out of interest of FSF) is that it's a vendor lock of glibc&gcc. Please implement your crt* in your libc. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

krytarowski added a comment. Sorry, but this rather belongs to libc(abi) of Fuchsia. Why to push it into LLVM? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://reviews.llvm.org/D56044 ___ cfe-commits

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek added a comment. This is needed for `crtbegin.o`/`crtend.o`, I originally implemented it as part of D28791 but that change is already pretty big so this is an attempt to split independent parts that could land separately into smaller changes. Repositor

[PATCH] D56134: [AST] Store some data of CXXNewExpr as trailing objects

rjmccall added a comment. LGTM. Comment at: include/clang/AST/ExprCXX.h:1950 /// The allocated type-source information, as written in the source. TypeSourceInfo *AllocatedTypeInfo; If you ever want a somewhat bigger refactoring project that might provid

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Hi vit, I found what's going on with the "Cannot Select" error. divdc3.c contains code that gets lowered to a libcall. However this lowering doesn't go further to lower down to the legal operations permitted in this target. The debug snippet is: Legalizing: t38: f6

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

rjmccall added inline comments. Comment at: lib/Sema/SemaOverload.cpp:9279 +(CandAS1 != LangAS::opencl_generic && CandAS1 != LangAS::Default)) + return true; + } Anastasia wrote: > rjmccall wrote: > > rjmccall wrote: > > > This at least needs a comm

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:78 +RecTy = Context.getAddrSpaceQualType( +RecTy, MD->getTypeQualifiers().getAddressSpace()); return Context.getPointerType(CanQualType::CreateUnsafe(RecTy)); Would you mind making

[PATCH] D55948: Modify DeclaratorChuck::getFunction to use DeclSpec for qualifiers

rjmccall added inline comments. Comment at: include/clang/Sema/DeclSpec.h:1365 +AttributeFactory AttrFactory; +MethodQualifiers = new DeclSpec(AttrFactory); + } This `DeclSpec` ends up with a dangling reference to the `AttributeFactory`; I t

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:9702 +static bool RejectConstNotMutableType(Sema &SemaRef, ValueDecl *D, + OpenMPClauseKind CKind, Functions must start from the small letters. =

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1342878 , @jdenny wrote: > Hi Alexey, > > > In D56113#1342076 , @jdenny wrote: > > > >> In D56113#1341940 , @ABataev > >> wrote: > >> > >

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. Hi Alexey, > In D56113#1342076 , @jdenny wrote: > >> In D56113#1341940 , @ABataev wrote: >> >> > The patch does not seem quite correct. I committed another fix for this >> > problem. >> >>

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

ken-cunningham-webuse added a comment. I found the relevant recent discussions on the mailing list, and the commits from August that started the Darwin PPC withdrawal from the source. I have this patch in my local folder of llvm/darwinppc fixes. I suppose this ticket might be closed then? Re

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:651 +llvm::Optional> +getNodeConstructorType(MatcherCtor targetCtor) { + const auto &ctors = RegistryData->nodeConstructors(); targetCtor -> TargetCtor Comme

[PATCH] D56090: Add a matcher for members of an initializer list expression

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D56090#1341023 , @hwright wrote: > @lebedev.ri Where do the appropriate tests live? (I couldn't find an obvious > subdirect

[PATCH] D55710: add pragmas to control Software Pipelining optimisation

aaron.ballman added a comment. The docs are getting much closer -- just a few grammatical things left to fix, I believe. Comment at: include/clang/Basic/AttrDocs.td:2582 specified for the subsequent loop. The directive allows vectorization, -interleaving, and unrolling to be

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

krytarowski added inline comments. Comment at: lib/esan/esan_interceptors.cpp:90 } while (false) +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + do { \ --

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1342076 , @jdenny wrote: > In D56113#1341940 , @ABataev wrote: > > > The patch does not seem quite correct. I committed another fix for this > > problem. > > > Thanks for the fix,

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

krytarowski added a comment. What's the rationale for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://reviews.llvm.org/D56044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

echristo added a comment. Is something passing compiler-rt in as a -r link output or something? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56044/new/ https://reviews.llvm.org/D56044 ___ cfe-commits mailing list cf