Buildbot numbers for the week of 12/16/2018 - 12/22/2018

Hello everyone, Below are some buildbot numbers for the last week of 12/16/2018 - 12/22/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 12/09/2018 - 12/15/2018

Hello everyone, Below are some buildbot numbers for the week of 12/09/2018 - 12/15/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

r350143 - Add vtable anchor to classes.

Author: rtrieu Date: Fri Dec 28 18:02:30 2018 New Revision: 350143 URL: http://llvm.org/viewvc/llvm-project?rev=350143&view=rev Log: Add vtable anchor to classes. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/include/clang/AST/DeclTemplate.h cfe/trunk/include/clang/Lex/Mod

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added inline comments. Comment at: lib/tsan/rtl/tsan_interceptors.cc:45 #define dirfd(dirp) (*(int *)(dirp)) #define fileno_unlocked fileno We might want to go for emulating `_unlocked`: ``` #define fileno_unlocked(p) \ 488 ((p)->_fi

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis updated this revision to Diff 179667. thakis edited the summary of this revision. thakis added a comment. Herald added a subscriber: mgorny. - add test BUILD.gn support to sync script - remove bigobj fixme since that issue isn't specific to that file CHANGES SINCE LAST ACTION https://re

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

jdenny added a comment. In D56113#1341940 , @ABataev wrote: > The patch does not seem quite correct. I committed another fix for this > problem. Thanks for the fix, r350127, which does seem to address the use cases I care about right now. However, you

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

krytarowski added a subscriber: dvyukov. krytarowski added a comment. If we understand it correctly, unpoision FILE would be only for inlined routines accessing FILE buffer(s) directly. On NetBSD we enforce _REENTRANT for all sanitizers in order to support only _REENTRANT variations of calls tha

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

vitalybuka added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:49 + + fclose(fp); + return 0; why does this close file only on success? I assume normal test behavior is return 0; So please replace all return N with as

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

krytarowski added inline comments. Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:7 +int main(int argc, char **argv) { + FILE *fp; + int fd; Please move local variable declaration to the first line used (whenever possible) ==

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, dberris, kubamracek. Add two new test cases that test the following stdio.h functions: - clearerr() - feof() - ferror() - fileno() - fgetc() - getc() - ungetc() Rep

[PATCH] D56134: [AST] Store some data of CXXNewExpr as trailing objects

riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a reviewer: shafik. Herald added a subscriber: cfe-commits. Store the optional array size expression, optional initialization expression and optional placement new arguments in

[clang-tools-extra] r350133 - [clang-tidy] Export the abseil duration inverse lookup function, NFC

Author: hwright Date: Fri Dec 28 11:04:21 2018 New Revision: 350133 URL: http://llvm.org/viewvc/llvm-project?rev=350133&view=rev Log: [clang-tidy] Export the abseil duration inverse lookup function, NFC This allows other tools to use this function. Modified: clang-tools-extra/trunk/clang-tid

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added inline comments. Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:24 +// parameters via using alias not detected by ``isTemplateTypeParamType()``. +static bool isAliasedTemplateParamType(const QualType &ParamType) { + return (ParamType.getCanonicalType().ge

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added reviewers: eugenis, kcc. mgorny added a comment. We've been discussing this, and I think we're doing this the wrong way. Could you help me a little understand this? In particular, what is the purpose of unpoisoning file? Is it in order to account for stdio functions being implement

r350130 - [objc-gnustep2] Fix a bug in category generation.

Author: theraven Date: Fri Dec 28 09:44:54 2018 New Revision: 350130 URL: http://llvm.org/viewvc/llvm-project?rev=350130&view=rev Log: [objc-gnustep2] Fix a bug in category generation. We were not emitting a protocol definition while generating the category method list. This was fine in most cas

r350127 - [OPENMP]Fix processing of the clauses on target combined directives.

Author: abataev Date: Fri Dec 28 09:27:32 2018 New Revision: 350127 URL: http://llvm.org/viewvc/llvm-project?rev=350127&view=rev Log: [OPENMP]Fix processing of the clauses on target combined directives. For constants with the predefined data-sharing clauses we may had troubles with the target com

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. The patch does not seem quite correct. I committed another fix for this problem. There is still the problem with the explicitly specified `shared` clause on `target teams` directive, but I don't think that it must cause some troubles. The variable still should not be tra

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179641. mgorny marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc lib/sanitizer_common/sanitizer_platform_limits_

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5698 +#if SANITIZER_NETBSD + if (fp->_bf._base) +COMMON_INTERCEPTOR_INITIALIZE_RANGE(fp->_bf._base, krytarowski wrote: >

[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Szelethus added a comment. Missed out on the developments. Thank you so much for handling this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55823/new/ https://reviews.llvm.org/D55823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/SemaOverload.cpp:9279 +(CandAS1 != LangAS::opencl_generic && CandAS1 != LangAS::Default)) + return true; + } rjmccall wrote: > rjmccall wrote: > > This

Re: r347339 - [clang][Parse] Diagnose useless null statements / empty init-statements

On Fri, Dec 28, 2018 at 2:57 AM Nico Weber wrote: > > Should this be in -Wextra-semi? It seems weird to have to pass both > -Wextra-semi and -Wextra-semi-stmt. It does seem somewhat weird, and my initial implementation did add it into -Wextra-semi, but the review https://reviews.llvm.org/D52695#i