[libunwind] r348832 - Don't export assembly functions when function visibility annotations are disabled

Author: mstorsjo Date: Mon Dec 10 23:34:14 2018 New Revision: 348832 URL: http://llvm.org/viewvc/llvm-project?rev=348832&view=rev Log: Don't export assembly functions when function visibility annotations are disabled Patch by Peiyuan Song! Differential Revision: https://reviews.llvm.org/D55537

r348831 - Revert r348830 "[Sema]improve static_assert(!expr)"

Author: courbet Date: Mon Dec 10 23:28:00 2018 New Revision: 348831 URL: http://llvm.org/viewvc/llvm-project?rev=348831&view=rev Log: Revert r348830 "[Sema]improve static_assert(!expr)" Submitted the wrong change. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp cfe/trunk/test/SemaCXX/stati

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 177662. jdoerfert added a comment. Update according to initial feedback Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files: include/clang/AST/ASTContext.h include/clang/Basic

r348830 - [Sema]improve static_assert(!expr)

Author: courbet Date: Mon Dec 10 23:04:49 2018 New Revision: 348830 URL: http://llvm.org/viewvc/llvm-project?rev=348830&view=rev Log: [Sema]improve static_assert(!expr) Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp cfe/trunk/test/SemaCXX/static-assert.cpp Modified: cfe/trunk/lib/Sema/Sem

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF marked 14 inline comments as done. EricWF added a comment. Address review comments. Fixes incoming. Comment at: include/clang/AST/ExprCXX.h:218 + SourceLocation RP, unsigned MinNumArgs = 0, + bool UsesADL = false) : CallExpr

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

fowles added inline comments. Comment at: include/clang/AST/ExprCXX.h:218 + SourceLocation RP, unsigned MinNumArgs = 0, + bool UsesADL = false) : CallExpr(C, CUDAKernelCallExprClass, fn, Config, args, t, VK, RP, Can

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

void added a comment. In D54355#1326494 , @craig.topper wrote: > I'm seeing a case where an inline assembly 'n' constraint is behaving > differently in -O0 now. Previously we would evaluate the __builtin_constant_p > as part of the EvaluateAsInt call in

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast added a comment. I'll update the tests to be in terms of constant/variable array length tomorrow. I think I've gotten through the rest of the comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55510/new/ https://reviews.llvm.org/D5551

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177656. hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added a comment. Address remaining ExprConstant.cpp review comments Use BytesRemaining/BytesPerElement to improve readability; tweak FIXME comment to refer

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

EricWF marked 2 inline comments as done. EricWF added a comment. Sorry for the delayed response. My email filters were incorrect. Comment at: include/clang/Basic/Builtins.def:759 +// Random C++ builtins. +LANGBUILTIN(__builtin_is_constant_evaluated, "b", "ncu", CXX_LANG) +

[PATCH] D55546: [clang] Add AST matcher for block expressions 🔍

stephanemoore created this revision. Herald added a subscriber: cfe-commits. This change adds a new AST matcher for block expressions. Test Notes: Ran the clang unit tests. Repository: rC Clang https://reviews.llvm.org/D55546 Files: docs/LibASTMatchersReference.html include/clang/ASTMat

[PATCH] D55544: Warning: objc-encodings-larger-than=

stephanemoore added a comment. FYI: I have a clang-tidy check almost ready for review that aims to flag large Objective-C type encodings. Comment at: include/clang/Basic/LangOptions.def:103 +BENIGN_LANGOPT(ObjCLargeEncodingSize, 32, 0, + "if non-zero, warn about O

[PATCH] D55545: Allow IncludeSorter to use #import for Objective-C files

compositeprimes created this revision. compositeprimes added reviewers: klimek, alexfh. Herald added a subscriber: cfe-commits. The change infers whether a source file is Objective-C using LangOpts, and if it detects Objective-C, it uses "#import" instead of "#include" for all inserted imports.

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach created this revision. dmaclach added a project: clang. Herald added a subscriber: cfe-commits. Issue a warning when the Objective C runtime encoding generated for an iVar, method, or block exceeds a user configurable value. Off by default. Note that handling iVars and methods will als

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai created this revision. vsapsai added reviewers: rsmith, rjmccall. Herald added subscribers: dexonsmith, jkorous. Fixes assertion > Assertion failed: (isa(Val) && "cast() argument of incompatible > type!"), function cast, file llvm/Support/Casting.h, line 255. It was triggered by trying

r348827 - Move CodeGenOptions from Frontend to Basic

Author: rtrieu Date: Mon Dec 10 19:18:39 2018 New Revision: 348827 URL: http://llvm.org/viewvc/llvm-project?rev=348827&view=rev Log: Move CodeGenOptions from Frontend to Basic Basic uses CodeGenOptions and should not depend on Frontend. Added: cfe/trunk/include/clang/Basic/CodeGenOptions.def

[PATCH] D54355: Use is.constant intrinsic for __builtin_constant_p

craig.topper added a comment. I'm seeing a case where an inline assembly 'n' constraint is behaving differently in -O0 now. Previously we would evaluate the __builtin_constant_p as part of the EvaluateAsInt call in CodeGenFunction::EmitAsmInput, but I think we're not doing that now. This causes

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail Naysh wrote: > Eugene.Zelenko wrote: > > Mis

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

Naysh added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail Eugene.Zelenko wrote: > Missing link to guidelines, @

[PATCH] D54921: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC348822: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.l

r348821 - [analyzer] Hack for backwards compatibility for options for RetainCountChecker.

Author: george.karpenkov Date: Mon Dec 10 17:13:58 2018 New Revision: 348821 URL: http://llvm.org/viewvc/llvm-project?rev=348821&view=rev Log: [analyzer] Hack for backwards compatibility for options for RetainCountChecker. To be removed once the clients update. Modified: cfe/trunk/lib/Stati

r348822 - [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker

Author: george.karpenkov Date: Mon Dec 10 17:14:17 2018 New Revision: 348822 URL: http://llvm.org/viewvc/llvm-project?rev=348822&view=rev Log: [analyzer] Remove memoization from RunLoopAutoreleaseLeakChecker Memoization dose not seem to be necessary, as other statement visitors run just fine with

r348820 - [analyzer] Display a diagnostics when an inlined function violates its os_consumed summary

Author: george.karpenkov Date: Mon Dec 10 17:13:40 2018 New Revision: 348820 URL: http://llvm.org/viewvc/llvm-project?rev=348820&view=rev Log: [analyzer] Display a diagnostics when an inlined function violates its os_consumed summary This is currently a diagnostics, but might be upgraded to an e

[PATCH] D55528: [analyzer] Resolve another bug where the name of the leaked object was not printed properly

This revision was automatically updated to reflect the committed changes. Closed by commit rC348819: [analyzer] Resolve another bug where the name of the leaked object was not… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https:

r348819 - [analyzer] Resolve another bug where the name of the leaked object was not printed properly

Author: george.karpenkov Date: Mon Dec 10 17:13:20 2018 New Revision: 348819 URL: http://llvm.org/viewvc/llvm-project?rev=348819&view=rev Log: [analyzer] Resolve another bug where the name of the leaked object was not printed properly Differential Revision: https://reviews.llvm.org/D55528 Modif

[PATCH] D55066: [ASan] Minor documentation fix: clarify static linking limitation.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 ___ cfe-commits

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU); ---

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177620. leonardchan marked 2 inline comments as done. leonardchan added a comment. - Added the CXX11 test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/cl

[PATCH] D55424: [analyzer] Supply all checkers with a shouldRegister function

NoQ added a comment. Should we also pass `CheckerManager` into `shouldRegister...`? Or is it entirely useless? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55424/new/ https://reviews.llvm.org/D55424 ___ cfe-commits

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

EricWF created this revision. EricWF added reviewers: fowles, rsmith, klimek. Herald added a reviewer: shafik. Currently the Clang AST doesn't store information about how the callee of a CallExpr was found. Specifically if it was found using ADL. However, this information is invaluable to toolin

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +Q

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177618. hubert.reinterpretcast marked 6 inline comments as done. hubert.reinterpretcast added a comment. Use lvalue designator, add assertions for type matching Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5551

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore marked 4 inline comments as done. stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-118 diag(MatchedDecl->getLocation(), - "function name %0 not using function naming conventions described by " - "Google Ob

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-125 + if (MatchedDecl->getStorageClass() == SC_Static) { +diag(MatchedDecl->getLocation(), + "static function name %0 must be in Pascal case as required by " + "Goo

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thanks, just minor suggestions. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:114-118 diag(MatchedDecl->getLocation(), - "function name %0 not usin

[PATCH] D55482: [clang-tidy] Improve google-objc-function-naming diagnostics 📙

stephanemoore updated this revision to Diff 177609. stephanemoore marked 4 inline comments as done. stephanemoore added a comment. Use the select modifier to customize diagnostics for static and non-static function instead of branching diagnostic code paths for static and non-static functions.

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:8465 +return false; + uint64_t LengthPerElement{CharTy1Width / Info.Ctx.getCharWidth()}; + assert(MaxLength && "MaxLength should not be zero: the following loop " Use `toCharUnit

r348809 - Update test for instcombine change

Author: arsenm Date: Mon Dec 10 15:02:40 2018 New Revision: 348809 URL: http://llvm.org/viewvc/llvm-project?rev=348809&view=rev Log: Update test for instcombine change Modified: cfe/trunk/test/CodeGen/vector.c Modified: cfe/trunk/test/CodeGen/vector.c URL: http://llvm.org/viewvc/llvm-projec

[PATCH] D54604: Automatic variable initialization

jfb updated this revision to Diff 177600. jfb added a comment. - Make sure uninit-variables.c doesn't break. - Address Peter's comments, improve tests. - Add an ugly option to enable zero init - Update warning-flags.c - Fix typo - Use negative NaN with repeated 0xFF payload for all floating-point

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast updated this revision to Diff 177597. hubert.reinterpretcast marked 11 inline comments as done. hubert.reinterpretcast added a comment. Make an initial pass at addressing the review comments Address comments on style and code comments Repository: rC Clang CHANGES SINCE

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

hubert.reinterpretcast added inline comments. Comment at: lib/AST/ExprConstant.cpp:6159-6160 +// Give up on byte-oriented matching against multibyte elements. +if (IsRawByte && Info.Ctx.getTypeSize(CharTy) > Info.Ctx.getCharWidth()) + return false; // Figure out

[PATCH] D15881: [DWARF] Omitting the explicit import of an anonymous namespace is a debugger-tuning decision, not a target decision.

probinson abandoned this revision. probinson added a comment. Herald added a subscriber: JDevlieghere. Abandoning dead patch. This wound up being done a different way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15881/new/ https://reviews.llvm.org/D15881 __

[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

martong added a comment. Alexey, good news! I have finished the testing of the above patch applied on top of 174545. Neither is a regression on Linux nor on macOS. (ASTTests, check-clang-astmerge, check-clang-import, check-clang-analysis, check-lldb). Repository: rC Clang CHANGES SINCE LAST

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:89 void dumpDecl(const Decl *D); -void dumpStmt(const Stmt *S); +void dumpStmt(const Stmt *S, const std::string &label = {}); aaron.ballman wrote: > Label > > Rather than using `{}`

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 177595. steveire added a comment. Clean up API a bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp test/AST/a

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D55483#1326029 , @aaron.ballman wrote: > This is missing all of the Sema and SemaCXX tests. Should have tests for > member functions, variadic functions, incorrect arguments, incor

Re: r348794 - Change InitListExpr dump to label and pointer

I suggest continuing this discussion here: https://reviews.llvm.org/D55488 On 10/12/2018 21:42, Aaron Ballman wrote: On Mon, Dec 10, 2018 at 4:13 PM Richard Smith via cfe-commits wrote: On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits wrote: Author: steveire Date: Mon Dec 10 12:5

[PATCH] D55488: Add utility for dumping a label with child nodes

steveire updated this revision to Diff 177594. steveire marked an inline comment as done. steveire added a comment. Update with new approach Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55488/new/ https://reviews.llvm.org/D55488 Files: include/clang/AST/ASTDu

Re: r348794 - Change InitListExpr dump to label and pointer

On Mon, Dec 10, 2018 at 4:13 PM Richard Smith via cfe-commits wrote: > > On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits > wrote: >> >> Author: steveire >> Date: Mon Dec 10 12:53:32 2018 >> New Revision: 348794 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=348794&view=rev >> Log

[PATCH] D55510: [ExprConstant] Improve memchr/memcmp for type mismatch and multibyte element types

rsmith added inline comments. Comment at: lib/AST/ExprConstant.cpp:6147-6148 + return ZeroInitialization(E); +if (!Result.checkNullPointerForFoldAccess(Info, E, AK_Read)) + return false; +QualType CharTy = Why do we need to do this explicitly, r

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

ldionne added inline comments. Comment at: libcxx/include/memory:1658 +|| !__has_construct::value) && + is_trivially_move_constructible<_DestTp>::value, void Quuxplusone wrote: > Shouldn't this be something like `is_trivia

r348799 - Revert "Change InitListExpr dump to label and pointer"

Author: steveire Date: Mon Dec 10 13:20:05 2018 New Revision: 348799 URL: http://llvm.org/viewvc/llvm-project?rev=348799&view=rev Log: Revert "Change InitListExpr dump to label and pointer" This reverts commit r348794. Modified: cfe/trunk/lib/AST/ASTDumper.cpp cfe/trunk/test/AST/ast-dump

Re: r348794 - Change InitListExpr dump to label and pointer

I'll revert it to allow for further discussion. On 10/12/2018 21:12, Richard Smith wrote: On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: steveire Date: Mon Dec 10 12:53:32 2018 New Revision: 348794 URL: http://llv

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.cpp:77 + getInverseForScale(Scale); + if (const auto *MaybeCallArg = selectFirst( + "e", hwright wrote: > JonasToth wrote: > > In Principle the `Node` could have multip

Re: r348794 - Change InitListExpr dump to label and pointer

On Mon, 10 Dec 2018 at 12:56, Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: steveire > Date: Mon Dec 10 12:53:32 2018 > New Revision: 348794 > > URL: http://llvm.org/viewvc/llvm-project?rev=348794&view=rev > Log: > Change InitListExpr dump to label and pointer > > Su

Re: r348798 - Fix nits

On Tue, Dec 11, 2018 at 12:07 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Mon Dec 10 13:04:04 2018 > New Revision: 348798 > > URL: http://llvm.org/viewvc/llvm-project?rev=348798&view=rev > Log: > Fix nits Can you *please* write proper commit messages, pretty please? I have

r348798 - Fix nits

Author: steveire Date: Mon Dec 10 13:04:04 2018 New Revision: 348798 URL: http://llvm.org/viewvc/llvm-project?rev=348798&view=rev Log: Fix nits Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTD

[PATCH] D55393: Re-order content of template parameter dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rL348797: Re-order content of template parameter dumps (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55393?vs=177412&id

r348797 - Re-order content of template parameter dumps

Author: steveire Date: Mon Dec 10 13:03:00 2018 New Revision: 348797 URL: http://llvm.org/viewvc/llvm-project?rev=348797&view=rev Log: Re-order content of template parameter dumps Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55393 Modified:

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added inline comments. Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:29 +AST_MATCHER(CXXMethodDecl, isOverloadedOperator) { + // Don't put [[nodiscard]] front of operators. + return Node.isOverloadedOperator(); s/front/in front/ ===

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright updated this revision to Diff 177590. hwright marked 9 inline comments as done. hwright added a comment. Add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55245/new/ https://reviews.llvm.org/D55245 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeL

[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.cpp:21 +struct DurationScale2IndexFunctor { + using argument_type = DurationScale; + unsigned operator()(DurationScale Scale) const { JonasToth wrote: > Are you using `argument_type`?

[PATCH] D55405: [CMake] Use hidden visibility for static libc++ in Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55405/new/ https://reviews.llvm.org/D55405 ___ cfe-commit

[PATCH] D55395: Re-order content in OMPDeclareReductionDecl dump

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL348795: Re-order content in OMPDeclareReductionDecl dump (authored by steveire, committed by ). Herald added a subscriber:

[PATCH] D55495: Change InitListExpr dump to label and pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL348794: Change InitListExpr dump to label and pointer (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55495?vs=177426&i

r348794 - Change InitListExpr dump to label and pointer

Author: steveire Date: Mon Dec 10 12:53:32 2018 New Revision: 348794 URL: http://llvm.org/viewvc/llvm-project?rev=348794&view=rev Log: Change InitListExpr dump to label and pointer Summary: Don't add a child just for the label. Reviewers: aaron.ballman Subscribers: cfe-commits Differential Rev

r348795 - Re-order content in OMPDeclareReductionDecl dump

Author: steveire Date: Mon Dec 10 12:53:39 2018 New Revision: 348795 URL: http://llvm.org/viewvc/llvm-project?rev=348795&view=rev Log: Re-order content in OMPDeclareReductionDecl dump Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55395 Modif

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/modernize-use-nodiscard.rst:49 + + +.. code-block:: c++ Unnecessary empty line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55433/new/ https://reviews.llvm.org/D55433 ___

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added a comment. I'm fine with making this change under the assumption that we've gotten the language rule right. Even if that weren't abstractly reasonable for general language work — and I do think it's reasonable when we have a good-faith question about the right semantics — this i

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/test/Sema/address_space_attribute.cpp:9 + // CHECK: VarDecl {{.*}} x '__attribute__((address_space(1))) int *' + __attribute__((address_space(1))) int *x; + leonardchan wrote: > aaron.ballman wrote: > > Can

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

Quuxplusone added inline comments. Comment at: libcxx/include/memory:1645 -template +template _LIBCPP_INLINE_VISIBILITY ldionne wrote: > Quuxplusone wrote: > > ldionne wrote: > > > Coming at it from a slightly different angle, I would think t

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1325998 , @rjmccall wrote: > We sent the question out, but we haven't gotten a response yet. I think > going forward under the idea that this just changes the type but does the > operation on the original operand t

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177587. leonardchan marked 3 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/clang/Sema/Sema.h clang/lib/AST/TypePrinter.cpp clan

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added inline comments. Comment at: clang/test/Sema/address_space_attribute.cpp:9 + // CHECK: VarDecl {{.*}} x '__attribute__((address_space(1))) int *' + __attribute__((address_space(1))) int *x; + aaron.ballman wrote: > Can you also add a test usin

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 177584. MyDeveloperDay marked 11 inline comments as done. MyDeveloperDay added a comment. Addressing review comments - grammatical errors in documentation and comments - prevent adding [[nodiscard]] to macros - clean up list.rst CHANGES SINCE LAST AC

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. This is missing all of the Sema and SemaCXX tests. Should have tests for member functions, variadic functions, incorrect arguments, incorrect subjects, etc. =

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/test/Sema/address_space_attribute.cpp:1 +// RUN: %clang_cc1 %s -ast-dump | FileCheck %s + This test should be moved to the AST directory instead of Sema. Comment at: clang/test/Sema/address

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:15 +// FIXME: After changing the subject from Function to HasFunctionProto, AllocSize is no longer listed (similar to Format, et

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added a comment. We sent the question out, but we haven't gotten a response yet. I think going forward under the idea that this just changes the type but does the operation on the original operand types is the right way to go forward in the short term. Repository: rC Clang CHANGES

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman added inline comments. Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:15 +// FIXME: After changing the subject from Function to HasFunctionProto, AllocSize is no longer listed (similar to Format, etc) +// FIXME-NEXT: AllocSize (SubjectMatchRu

[PATCH] D55527: Normalize GlobalDecls when used with CPUDispatch

erichkeane created this revision. erichkeane added reviewers: rsmith, aaron.ballman. Previously, CPUDispatch functionality did some wacky things with GlobalDecls, which resulted in multiple GlobalDecls having the same mangled name. This patch corrects this in a few ways: First, it Moves the emiss

[PATCH] D54489: Implement -frecord-command-line (-frecord-gcc-switches)

scott.linder added a comment. There may be changes to some details in the LLVM patch; once they are finalized I will update the Clang patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54489/new/ https://reviews.llvm.org/D54489 ___ cfe-c

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. In D55508#1325960 , @Eugene.Zelenko wrote: > By the word, will be good idea to have script which check alphabetical order > and use it during build. Sometimes alphabetical order may be violated after > merge with trunk. I th

[PATCH] D55488: Add utility for dumping a label with child nodes

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:115 + template + void addChild(const std::string &label, Fn doAddChild) { +if (label.empty()) label -> Label doAddChild -> DoAddChild Comment at: include

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

Eugene.Zelenko added a comment. By the word, will be good idea to have script which check alphabetical order and use it during build. Sometimes alphabetical order may be violated after merge with trunk. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ ht

[clang-tools-extra] r348793 - [clang-tidy] insert release notes for new checkers alphabetically

Author: jonastoth Date: Mon Dec 10 11:41:53 2018 New Revision: 348793 URL: http://llvm.org/viewvc/llvm-project?rev=348793&view=rev Log: [clang-tidy] insert release notes for new checkers alphabetically Summary: Almost all code review comments on new checkers {D55433} {D48866} {D54349} seem to a

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

This revision was automatically updated to reflect the committed changes. Closed by commit rL348793: [clang-tidy] insert release notes for new checkers alphabetically (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. In D55508#1325834 , @MyDeveloperDay wrote: > In D55508#1325758 , @JonasToth wrote: > > > LGTM. Do you have commit access? > > > I do not I'm afraid I will commit for you. CHANGES SINC

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1320936 , @rjmccall wrote: > Okay, thanks, that makes sense to me. > > I'll ask around to find a way to contact the C committee. @rjmccall Any updates on this? If we aren't able to find a way to contact anyone affi

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

bruno added a comment. Hi Eric, Thanks for working on this! Comment at: include/clang/Basic/Builtins.def:759 +// Random C++ builtins. +LANGBUILTIN(__builtin_is_constant_evaluated, "b", "ncu", CXX_LANG) + Name bikeshedding : perhaps the builtin name could be de

r348790 - Add an explicit triple to this test to fix failing test bots.

Author: aaronballman Date: Mon Dec 10 11:18:11 2018 New Revision: 348790 URL: http://llvm.org/viewvc/llvm-project?rev=348790&view=rev Log: Add an explicit triple to this test to fix failing test bots. Modified: cfe/trunk/test/AST/ast-dump-expr.c Modified: cfe/trunk/test/AST/ast-dump-expr.c U

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

ldionne added inline comments. Comment at: libcxx/include/memory:1645 -template +template _LIBCPP_INLINE_VISIBILITY Quuxplusone wrote: > ldionne wrote: > > Coming at it from a slightly different angle, I would think this is what we > > want:

[PATCH] D55097: [constexpr][c++2a] Try-catch blocks in constexpr functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL348789: [constexpr][c++2a] Try-catch blocks in constexpr functions (authored by bruno, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55097?v

r348789 - [constexpr][c++2a] Try-catch blocks in constexpr functions

Author: bruno Date: Mon Dec 10 11:03:12 2018 New Revision: 348789 URL: http://llvm.org/viewvc/llvm-project?rev=348789&view=rev Log: [constexpr][c++2a] Try-catch blocks in constexpr functions Implement support for try-catch blocks in constexpr functions, as proposed in http://wg21.link/P1002 and v

[PATCH] D55525: [Driver] Add support for -fembed-bitcode for assembly file

steven_wu created this revision. steven_wu added reviewers: compnerd, dexonsmith. Herald added a subscriber: jkorous. Handle -fembed-bitcode for assembly inputs. When the input file is assembly, write a marker as "__LLVM,__asm" section. Fix llvm.org/pr39659 Repository: rC Clang https://revie

[PATCH] D21230: Do not embed all the cc1 options in bitcode commandline

steven_wu abandoned this revision. steven_wu added a comment. Herald added subscribers: jkorous, mehdi_amini. This is upstreamed by Saleem already CHANGES SINCE LAST ACTION https://reviews.llvm.org/D21230/new/ https://reviews.llvm.org/D21230 ___

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay added a comment. In D55508#1325758 , @JonasToth wrote: > LGTM. Do you have commit access? I do not I'm afraid CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 __

Re: r348685 - Move diagnostic enums into Basic.

Hey Richard, Thanks for cleaning up some of the layering here! I /think/ I vaguely recall having a conversation with Richard Smith about a different direction to fix the layering of the diagnostics system - but it was/is more involved. Ah, here, apparently I sent out a WIP patch & must've got eng

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177561. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/clang/Sema/Sema.h clang/lib/AST/TypePrinter.cpp clan

r348786 - Adding tests for -ast-dump; NFC.

Author: aaronballman Date: Mon Dec 10 10:37:47 2018 New Revision: 348786 URL: http://llvm.org/viewvc/llvm-project?rev=348786&view=rev Log: Adding tests for -ast-dump; NFC. This adds tests for expressions in C. Added: cfe/trunk/test/AST/ast-dump-expr.c Added: cfe/trunk/test/AST/ast-dump-expr

  1   2   >