[PATCH] D55039: [sema] Warn of mangling change if function parameters are noexcept.

Rakete added inline comments. Comment at: lib/Sema/SemaDecl.cpp:9933 +llvm::any_of(FPT->param_types(), + [](QualType Q) { return hasNoexcept(Q); })) + return true; You don't need this lambda. Comment at: lib

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

rjmccall added a comment. I think `-fvisibility=hidden` isn't good enough because you want to infer hidden visibility even for external symbol references, and that's just not how global visibility works. But after this discussion, I'm prepared to accept that (1) we should have some sort of sin

[PATCH] D54604: Automatic variable initialization

pcc added inline comments. Comment at: include/clang/Driver/ToolChain.h:355 + virtual LangOptions::TrivialAutoVarInitKind + GetDefaultTrivialAutoVarInit() const { +return LangOptions::TrivialAutoVarInitKind::Uninitialized; I wouldn't introduce this function

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D55250 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.

r348238 - Remove unnecessary include.

Author: rtrieu Date: Mon Dec 3 20:53:18 2018 New Revision: 348238 URL: http://llvm.org/viewvc/llvm-project?rev=348238&view=rev Log: Remove unnecessary include. Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h URL: http://llvm.org/viewvc/llvm-pro

[PATCH] D55246: AST: Relax an assertion in constexpr constructor evaluation.

pcc created this revision. pcc added a reviewer: rsmith. Herald added a subscriber: llvm-commits. It's possible for the base type specified in a constructor to be qualified via sugar, so the existing assertion was too strict. Relax it so that we only check that the unqualified types are the same.

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348235: [analyzer] MoveChecker: Add more common state resetting methods. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54563?vs=176512&id=176537#toc Reposit

r348235 - [analyzer] MoveChecker: Add more common state resetting methods.

Author: dergachev Date: Mon Dec 3 19:38:08 2018 New Revision: 348235 URL: http://llvm.org/viewvc/llvm-project?rev=348235&view=rev Log: [analyzer] MoveChecker: Add more common state resetting methods. Includes "resize" and "shrink" because they can reset the object to a known state in certain cir

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

NoQ added a comment. Hmm, i shouldn't have included `shrink_to_fit`. It definitely keeps the object in unspecified state if it is already in unspecified state. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54563/new/ https://reviews.llvm.org/D54563 __

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

This revision was automatically updated to reflect the committed changes. Closed by commit rL348234: [Sema] Provide -fvisibility-global-new-delete-hidden option (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53787

r348234 - [Sema] Provide -fvisibility-global-new-delete-hidden option

Author: phosek Date: Mon Dec 3 19:25:25 2018 New Revision: 348234 URL: http://llvm.org/viewvc/llvm-project?rev=348234&view=rev Log: [Sema] Provide -fvisibility-global-new-delete-hidden option When the global new and delete operators aren't declared, Clang provides and implicit declaration, but t

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

phosek updated this revision to Diff 176533. phosek marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53787/new/ https://reviews.llvm.org/D53787 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.t

r348233 - Fix -Wmismatched-tags to not warn on redeclarations of structs in system

Author: rsmith Date: Mon Dec 3 18:45:28 2018 New Revision: 348233 URL: http://llvm.org/viewvc/llvm-project?rev=348233&view=rev Log: Fix -Wmismatched-tags to not warn on redeclarations of structs in system headers. Previously, we would only check whether the new declaration is in a system header,

[PATCH] D54466: [Analyzer] Iterator Checkers - Use the region of the topmost base class for iterators stored in a region

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54466/new/ https://reviews.llvm.org/D54466 ___ cfe-commits mailing list cfe

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

rsmith added a comment. In D51568#1314004 , @andrewjcg wrote: > > I don't think we need to change the serialization format for this: a > > serialized path beginning with / is already treated as absolute and any > > other path is already treated as relati

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348229: [analyzer] MoveChecker: Improve warning and note messages. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54560/new/ https:/

r348229 - [analyzer] MoveChecker: Improve warning and note messages.

Author: dergachev Date: Mon Dec 3 18:00:29 2018 New Revision: 348229 URL: http://llvm.org/viewvc/llvm-project?rev=348229&view=rev Log: [analyzer] MoveChecker: Improve warning and note messages. The warning piece traditionally describes the bug itself, i.e. "The bug is a _", eg. "Attempt to d

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ added a comment. In D54560#1302051 , @MTC wrote: > > The "moved-from" terminology we adopt here still feels a bit weird to me, > > but i don't have a better suggestion, so i just removed the single-quotes > > so that to at least feel proud about what

[PATCH] D53850: Declares __cpu_model as dso local

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53850/new/ https://reviews.llvm.org/D53850 ___ cf

[PATCH] D53850: Declares __cpu_model as dso local

srhines added a comment. Craig, does this look ok now? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53850/new/ https://reviews.llvm.org/D53850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

NoQ added a comment. I'm glad you brought this stuff up, found two more bugs to fix. In D54563#1317678 , @Szelethus wrote: > Can you add tests for that just in case? :) The test works, but i noticed that we aren't respecting const references. That is,

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

Szelethus added a comment. Okay, I submit! :D Comment at: test/Analysis/use-after-move.cpp:260-262 for (int i = 0; i < bignum(); i++) { // expected-note {{Loop condition is false. Execution jumps to the end of the function}} rightRefCall(std::move(a));// no

[PATCH] D52117: Generate llvm.loop.parallel_accesses instead of llvm.mem.parallel_loop_access metadata.

hfinkel added inline comments. Comment at: lib/CodeGen/CGLoopInfo.cpp:372 + if (Active.size() >= 2) { +LoopInfo &NewFront = reverse(Active).begin()[1]; +NewFront.addAccGroups(Front.getNestedAccGroups()); reverse(Active).begin() looks odd. Can we get the

[PATCH] D53787: [Sema] Provide -fvisibility-global-new-delete-hidden option

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good with minor changes, thanks. Comment at: clang/include/clang/Basic/LangOptions.def:228 BENIGN_LANGOPT(InlineVisibilityHidden , 1, 0, "hidden default visibility for

[PATCH] D55039: [sema] Warn of mangling change if function parameters are noexcept.

mattd updated this revision to Diff 176515. mattd added a comment. - Move the HasNoexcept lambda to its own static function. - Added an additional check in HasNoexcept to recursively check return values. - Modified the parameter check in Sema::CheckFunctionDeclaration to use llvm::any_of, all we

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

NoQ added inline comments. Comment at: test/Analysis/use-after-move.cpp:331 for (int i = 0; i < bignum(); i++) { // expected-note {{Loop condition is true. Entering loop body}} expected-note {{Loop condition is true. Entering loop body}} constCopyOrMoveCall(std::m

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

Szelethus added a comment. Can you add tests for that just in case? :) Comment at: test/Analysis/use-after-move.cpp:331 for (int i = 0; i < bignum(); i++) { // expected-note {{Loop condition is true. Entering loop body}} expected-note {{Loop condition is true. Entering

r348218 - NFC: Make this test kinder on downstream forks

Author: epilk Date: Mon Dec 3 16:31:31 2018 New Revision: 348218 URL: http://llvm.org/viewvc/llvm-project?rev=348218&view=rev Log: NFC: Make this test kinder on downstream forks Downstream forks that have their own attributes often run into this test failing when a new attribute is added to clan

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

NoQ updated this revision to Diff 176512. NoQ added a comment. Add a TODO. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54563/new/ https://reviews.llvm.org/D54563 Files: lib/StaticAnalyzer/Checkers/MoveChecker.cpp test/Analysis/use-after-move.cpp Index: test/Analysis/use-after-m

[PATCH] D54563: [analyzer] MoveChecker Pt.4: Add a few more state reset methods.

NoQ added a comment. In D54563#1306358 , @Szelethus wrote: > This suggests to me that `list1.splice(list1.begin(), std::move(list2))` > leaves `list2` in a valid, well-defined, but empty state. I think this should work automagically. Because `list2` is

r348214 - [Hexagon] Fix intrinsic test

Author: kparzysz Date: Mon Dec 3 15:52:33 2018 New Revision: 348214 URL: http://llvm.org/viewvc/llvm-project?rev=348214&view=rev Log: [Hexagon] Fix intrinsic test Modified: cfe/trunk/test/CodeGen/builtins-hexagon.c Modified: cfe/trunk/test/CodeGen/builtins-hexagon.c URL: http://llvm.org/vi

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:385-386 + } + // Provide the caller with the classification of the object + // we've obtained here accidentally, for later use. + return OK; Szelethus wrote: > NoQ wrote: > > S

[PATCH] D54560: [analyzer] MoveChecker Pt.3: Improve warning messages a bit.

NoQ updated this revision to Diff 176504. NoQ marked 4 inline comments as done. NoQ added a comment. Address comments! In D54560#1304155 , @Charusso wrote: > In D54560#1301870 , @NoQ wrote: > > > Write down full me

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + leonardchan wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > leonardchan wrote: > > > > > rjmccall wrote: > > > > > > ebevhan wrote

r348213 - Relax test even more for Windows

Author: adrian Date: Mon Dec 3 15:40:51 2018 New Revision: 348213 URL: http://llvm.org/viewvc/llvm-project?rev=348213&view=rev Log: Relax test even more for Windows Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c URL: http://llvm.org/

r348211 - Relax tests to also work on Windows

Author: adrian Date: Mon Dec 3 15:11:19 2018 New Revision: 348211 URL: http://llvm.org/viewvc/llvm-project?rev=348211&view=rev Log: Relax tests to also work on Windows Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c cfe/trunk/test/Modules/module-debuginfo-prefix.m Modified: cfe/trun

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Should be fixed in r348211. -- adrian > On Dec 3, 2018, at 3:07 PM, Adrian Prantl via cfe-commits > wrote: > > No, your failures are Windows-specific (/ vs \), and I haven't fixed them > yet. Thanks for letting me know! > > -- adrian > >> On Dec 3, 2018, at 3:06 PM, Galina Kistanova wrote:

[PATCH] D54557: [analyzer] MoveChecker Pt.2: Restrict the warning to STL objects and locals.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348210: [analyzer] MoveChecker: Restrict to locals and std:: objects. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54557?vs=174475&id=176491#toc Repository

r348210 - [analyzer] MoveChecker: Restrict to locals and std:: objects.

Author: dergachev Date: Mon Dec 3 15:06:07 2018 New Revision: 348210 URL: http://llvm.org/viewvc/llvm-project?rev=348210&view=rev Log: [analyzer] MoveChecker: Restrict to locals and std:: objects. In general case there use-after-move is not a bug. It depends on how the move-constructor or move-a

[PATCH] D54547: PTH-- Remove feature entirely-

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Since you've already submitted a fix to Boost, https://github.com/boostorg/build/commit/3385fe2aa699a45e722a1013658f824b6a7c761f, I think this is fine to remove. CHANGES SINCE LAST ACTIO

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

No, your failures are Windows-specific (/ vs \), and I haven't fixed them yet. Thanks for letting me know! -- adrian > On Dec 3, 2018, at 3:06 PM, Galina Kistanova wrote: > > Adrian, did not see your response, please ignore my email. > > Thanks > > Galina > > On Mon, Dec 3, 2018 at 3:04 PM

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Adrian, did not see your response, please ignore my email. Thanks Galina On Mon, Dec 3, 2018 at 3:04 PM Galina Kistanova wrote: > Hello Adrian, > > This commit broke tests on couple of our builders: > > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/14371 > >

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

Hello Adrian, This commit broke tests on couple of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/14371 http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast . . . Failing Tests (2): Clang :: CodeGen/debug-prefix-map

r348209 - NFC: Add .vscode to .gitignore

Author: gornishanov Date: Mon Dec 3 14:51:07 2018 New Revision: 348209 URL: http://llvm.org/viewvc/llvm-project?rev=348209&view=rev Log: NFC: Add .vscode to .gitignore Modified: cfe/trunk/.gitignore Modified: cfe/trunk/.gitignore URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/.gitignor

[PATCH] D54372: [analyzer] MisusedMovedObject: NFC: Remove dead code after D18860

This revision was automatically updated to reflect the committed changes. Closed by commit rL348208: [analyzer] MoveChecker: NFC: Remove the workaround for the "zombie symbols" bug. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r348208 - [analyzer] MoveChecker: NFC: Remove the workaround for the "zombie symbols" bug.

Author: dergachev Date: Mon Dec 3 14:44:16 2018 New Revision: 348208 URL: http://llvm.org/viewvc/llvm-project?rev=348208&view=rev Log: [analyzer] MoveChecker: NFC: Remove the workaround for the "zombie symbols" bug. The checker had extra code to clean up memory regions that were sticking around

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + rjmccall wrote: > ebevhan wrote: > > rjmccall wrote: > > > leonardchan wrote: > > > > rjmccall wrote: > > >

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

This should be fixed by LLVM r348203. Thanks for your patience! -- adrian > On Dec 3, 2018, at 1:27 PM, Adrian Prantl via cfe-commits > wrote: > > I'll take a look right away. Thanks for letting me know! > > -- adrian > >> On Dec 3, 2018, at 1:26 PM, Vlad Tsyrklevich wrote: >> >> This chan

[clang-tools-extra] r348202 - [Documentation] Fix formatting and wrap up to 80 characters in Clang-tidy readability-uppercase-literal-suffix documentation.

Author: eugenezelenko Date: Mon Dec 3 14:35:40 2018 New Revision: 348202 URL: http://llvm.org/viewvc/llvm-project?rev=348202&view=rev Log: [Documentation] Fix formatting and wrap up to 80 characters in Clang-tidy readability-uppercase-literal-suffix documentation. Modified: clang-tools-ext

[PATCH] D54556: [analyzer] MoveChecker Pt.1: Give MisusedMovedObject checker a more consistent name.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348201: [analyzer] Rename MisusedMovedObjectChecker to MoveChecker (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D54556?vs=174123&id=176484#toc Repository:

[PATCH] D55057: [Headers] Make max_align_t match GCC's implementation.

jyknight added inline comments. Comment at: lib/Headers/__stddef_max_align_t.h:40 __attribute__((__aligned__(__alignof__(long double; +#ifdef __i386__ + __float128 __clang_max_align_nonce3 EricWF wrote: > uweigand wrote: > > jyknight wrote: > > > uwei

r348201 - [analyzer] Rename MisusedMovedObjectChecker to MoveChecker

Author: dergachev Date: Mon Dec 3 14:32:32 2018 New Revision: 348201 URL: http://llvm.org/viewvc/llvm-project?rev=348201&view=rev Log: [analyzer] Rename MisusedMovedObjectChecker to MoveChecker This follows the Static Analyzer's tradition to name checkers after things in which they find bugs, no

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

donat.nagy added a comment. Macro-generated long switches: I cannot access the check results right now, but if I recall correctly, the check assigned these errors to certain lines in the `.inc` files. This means that (1) it is not very easy to to suppress them with `//NOLINT` comments, but (2)

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

steveire updated this revision to Diff 176481. steveire added a comment. Move to implementation Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://reviews.llvm.org/D55190 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST

r348200 - [analyzer] Dump stable identifiers for objects under construction.

Author: dergachev Date: Mon Dec 3 14:23:21 2018 New Revision: 348200 URL: http://llvm.org/viewvc/llvm-project?rev=348200&view=rev Log: [analyzer] Dump stable identifiers for objects under construction. This continues the work that was started in r342313, which now gets applied to object-under-co

[PATCH] D54459: [analyzer] Dump reproducible identifiers for objects under construction.

This revision was automatically updated to reflect the committed changes. Closed by commit rC348200: [analyzer] Dump stable identifiers for objects under construction. (authored by dergachev, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54459/new/

[PATCH] D54488: [AST] [analyzer] NFC: Reuse code in stable ID dumping methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348199: [AST] [analyzer] NFC: Reuse code in stable ID dumping methods. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

r348199 - [AST] [analyzer] NFC: Reuse code in stable ID dumping methods.

Author: dergachev Date: Mon Dec 3 14:19:05 2018 New Revision: 348199 URL: http://llvm.org/viewvc/llvm-project?rev=348199&view=rev Log: [AST] [analyzer] NFC: Reuse code in stable ID dumping methods. Use the new fancy method introduced in r348197 to simplify some code. Differential Revision: http

[PATCH] D55189: Extract TextNodeDumper class

steveire updated this revision to Diff 176478. steveire added a comment. Herald added a subscriber: mgorny. Move implementation to cpp file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55189/new/ https://reviews.llvm.org/D55189 Files: include/clang/AST/TextNo

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348198: [AST] Generate unique identifiers for CXXCtorInitializer objects. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

r348198 - [AST] Generate unique identifiers for CXXCtorInitializer objects.

Author: dergachev Date: Mon Dec 3 14:15:34 2018 New Revision: 348198 URL: http://llvm.org/viewvc/llvm-project?rev=348198&view=rev Log: [AST] Generate unique identifiers for CXXCtorInitializer objects. This continues the work started in r342309 and r342315 to provide identifiers to AST objects th

[PATCH] D55016: Correctly support -shared-libgcc.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. -eric Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55016/new/ https://reviews.llvm.org/D55016 ___ cf

Re: r348131 - [AST] Fix an uninitialized bug in the bits of FunctionDecl

Why the change from using setter functions to direct assignment? On Mon, Dec 3, 2018 at 5:06 AM Bruno Ricci via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: brunoricci > Date: Mon Dec 3 05:04:10 2018 > New Revision: 348131 > > URL: http://llvm.org/viewvc/llvm-project?rev=348131&vie

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

scott.linder added a comment. In D53153#1315109 , @rjmccall wrote: > Okay. So it's still the case that all symbols will be defined within the > linkage unit; it's just that some things might need to get exposed outside of > it. > > LLVM does provide a `

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

NoQ updated this revision to Diff 176470. NoQ added a comment. Wait, i already did that in D54488 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54457/new/ https://reviews.llvm.org/D54457 Files: include/clang/AST/DeclCXX.h lib/AST/DeclCXX.cpp Ind

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman added a comment. Please mention this change in the release notes though. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 ___ cfe-commit

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mgrang added a comment. In D55229#1317333 , @rnk wrote: > I think @compnerd arranged things this way. I don't know why > -flto-visibility-public-std is involved, I have no idea what that does. I > think we should do what MSVC does here, which is to leave

[PATCH] D55127: [OpenCL] Diagnose conflicting address spaces between template definition and its instantiation

rjmccall added a comment. Okay. What you're saying is that the current OpenCL C++ compiler is implicitly adding an address-space qualifier at the top level to explicit template arguments. I agree that it should not be doing that. Can you explain why the changes to `TreeTransform` are required

r348192 - Typo correction; NFC.

Author: aaronballman Date: Mon Dec 3 13:27:15 2018 New Revision: 348192 URL: http://llvm.org/viewvc/llvm-project?rev=348192&view=rev Log: Typo correction; NFC. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h URL: http://llvm.org/viewvc/llvm-p

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

I'll take a look right away. Thanks for letting me know! -- adrian > On Dec 3, 2018, at 1:26 PM, Vlad Tsyrklevich wrote: > > This change appears to have broken a number of compiler-rt coverage tests, > e.g. in this run >

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176467. steveire added a comment. Remove namespace Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST

Re: r348154 - Avoid emitting redundant or unusable directories in DIFile metadata entries.

This change appears to have broken a number of compiler-rt coverage tests, e.g. in this run . The source of the error appears to be that llvm-cov is now trying to use a relative p

[PATCH] D54905: [AddressSanitizer] Add flag to disable linking with CXX runtime

eugenis added a comment. Linux linkers won't include a member of an archive only because it resolves a weak symbol, so in your example the answer is none. ASan uses -Wl,-whole-archive to pull all its members, this will resolve operator new to ASan definition unless there is another definition i

[PATCH] D55188: Extract TextChildDumper class

steveire updated this revision to Diff 176466. steveire added a comment. Rename class. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55188/new/ https://reviews.llvm.org/D55188 Files: include/clang/AST/ASTDumperUtils.h lib/AST/ASTDumper.cpp Index: lib/AST/AS

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

NoQ updated this revision to Diff 176465. NoQ added a comment. Rebase on top of D54486 ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54457/new/ https://reviews.llvm.org/D54457 Files: include/clang/AST/DeclCXX.h lib/AST/DeclBase.cpp lib/AST/DeclC

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 176464. kpn added a comment. Address review comment: Shrink the diff by eliminating unneeded use of else. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 Files: include/llvm/IR/IRBuilder.h unittests/IR/IRBui

[PATCH] D55068: NFC: Simplify dumpStmt child handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL348189: NFC: Simplify dumpStmt child handling (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D40218: [Clang] Add __builtin_launder

rsmith added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:1425-1426 + + // FIXME: We either have an incomplete class type, or we have a class template + // whose instantiation has not been forced. Example: + // I think it's a bug that `launder` does

r348189 - NFC: Simplify dumpStmt child handling

Author: steveire Date: Mon Dec 3 13:05:52 2018 New Revision: 348189 URL: http://llvm.org/viewvc/llvm-project?rev=348189&view=rev Log: NFC: Simplify dumpStmt child handling Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D55068 Modified: cf

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348188: Re-apply r347954 "[analyzer] Nullability: Don't detect post factum violation..." (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r348188 - Re-apply r347954 "[analyzer] Nullability: Don't detect post factum violation..."

Author: dergachev Date: Mon Dec 3 13:04:30 2018 New Revision: 348188 URL: http://llvm.org/viewvc/llvm-project?rev=348188&view=rev Log: Re-apply r347954 "[analyzer] Nullability: Don't detect post factum violation..." Buildbot failures were caused by an unrelated UB that was introduced in r347943

[PATCH] D55066: [ASan] Minor documentation fix: remove static linking limitation.

eugenis added a comment. How about "Static linking of executables is not supported"? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55066/new/ https://reviews.llvm.org/D55066 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + ebevhan wrote: > rjmccall wrote: > > leonardchan wrote: > > > rjmccall wrote: > > > > ebevhan wrote: > > > > > rjmccall wrote: > > > > > > Hmm. So adding a

[PATCH] D54017: [analyzer] NullabilityChecker: Invariant violation should only be triggered for symbols.

NoQ added a comment. Wasn't me: rC347970 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54017/new/ https://reviews.llvm.org/D54017 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

rnk added a comment. I think @compnerd arranged things this way. I don't know why -flto-visibility-public-std is involved, I have no idea what that does. I think we should do what MSVC does here, which is to leave _CxxThrowException unannotated and let the linker synthesize import thunks. Here

Re: r347588 - Revert "[clang][slh] add attribute for speculative load hardening"

Also, including the SVN revision (llvm's util/git-svn/git-svnrevert script can help with this) is helpful for other folks following along who may not be using git. On Mon, Nov 26, 2018 at 12:19 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Nov 26, 2018 at 3:13 PM

[PATCH] D55151: [gcov/Darwin] Ensure external symbols are exported when using an export list

This revision was automatically updated to reflect the committed changes. Closed by commit rL348187: [gcov/Darwin] Ensure external symbols are exported when using an export list (authored by vedantk, committed by ). Herald added subscribers: llvm-commits, delcypher. Changed prior to commit: htt

r348187 - [gcov/Darwin] Ensure external symbols are exported when using an export list

Author: vedantk Date: Mon Dec 3 12:53:58 2018 New Revision: 348187 URL: http://llvm.org/viewvc/llvm-project?rev=348187&view=rev Log: [gcov/Darwin] Ensure external symbols are exported when using an export list Make sure that symbols needed to implement runtime support for gcov are exported when

[PATCH] D55190: Move dump of individual comment nodes to NodeDumper

aaron.ballman added a comment. Looks reasonable, but similar to D55189 , can more of the implementation be pushed into a .cpp file rather than left in a header? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55190/new/ https://re

[PATCH] D55212: Handle alloc_size attribute on function pointers

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[HasFunctionProto]>; arichardson wrote: > aaron.ballman wrote: > > arichards

[PATCH] D55134: [CTU] Add triple/lang mismatch handling

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55134/new/ https://reviews.llvm.org/D55134 ___

r348184 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 12:26:51 2018 New Revision: 348184 URL: http://llvm.org/viewvc/llvm-project?rev=348184&view=rev Log: Portable Python script across Python version Workaround naming and hierarchy changes in BaseHTTPServer and SimpleHTTPServer module. Differential Revisi

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mgrang added a comment. In D55229#1317232 , @pcc wrote: > The reason why it has that name is that it was originally added to support > the logic here: > http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CGVTables.cpp#991 > > It looks like it was later rep

[PATCH] D55189: Extract TextNodeDumper class

aaron.ballman added a comment. Basically looking good, modulo namespace questions from D55188 and a few other organizational questions. Comment at: include/clang/AST/ASTTextNodeDumper.h:1 +//===--- ASTTextNodeDumper.h - Printing of AST nodes

[PATCH] D55212: Handle alloc_size attribute on function pointers

arichardson marked an inline comment as done. arichardson added a comment. Thanks for the review! I'll write a C++ test tomorrow. Comment at: include/clang/Basic/Attr.td:1072 def AllocSize : InheritableAttr { let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectLis

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

pcc added a comment. The reason why it has that name is that it was originally added to support the logic here: http://llvm-cs.pcc.me.uk/tools/clang/lib/CodeGen/CGVTables.cpp#991 It looks like it was later repurposed as a "was /MT passed to the driver" flag when the logic was added to mark runt

r348182 - Portable Python script across Python version

Author: serge_sans_paille Date: Mon Dec 3 12:12:34 2018 New Revision: 348182 URL: http://llvm.org/viewvc/llvm-project?rev=348182&view=rev Log: Portable Python script across Python version Python2 supports both backticks and `repr` to access the __repr__ slot. Python3 only supports `repr`. Diff

[PATCH] D55229: [COFF, ARM64] Make -flto-visibility-public-std a driver and cc1 flag

mstorsjo added a comment. FWIW, I don't see how this patch is related to ARM64 (the subject/tag of the patch). Using that for the test probably is fine as it can use any architecture, although an x86 one probably would increase the chances of it getting run by everyone. I don't have much input

[PATCH] D55188: Extract TextChildDumper class

aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumperUtils.h:22 + +namespace ast_dumper { +// Colors used for various parts of the AST dump steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > > aaron.ballman wrote: > > > > I'm no

  1   2   3   >