wuzish added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
hubert.reinterpretcast wrote:
> wuzish wr
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rjmccall added a comment.
Oops, sorry for the unedited comment; it's fixed on Phab.
Repository:
rC Clang
https://reviews.llvm.org/D52615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rjmccall added a comment.
In https://reviews.llvm.org/D52615#1275946, @filcab wrote:
> In https://reviews.llvm.org/D52615#1272725, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D52615#1266320, @filcab wrote:
> >
> > > In https://reviews.llvm.org/D52615#1254567, @rsmith wrote:
> > >
> > > > T
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
wuzish wrote:
> hubert.re
ubsan updated this revision to Diff 171247.
ubsan added a comment.
fix nits
Repository:
rC Clang
https://reviews.llvm.org/D53207
Files:
docs/ReleaseNotes.rst
include/clang/AST/Stmt.h
include/clang/ASTMatchers/ASTMatchers.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Ba
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D53609
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
wuzish added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
hubert.reinterpretcast wrote:
> wuzish wr
Author: rsmith
Date: Thu Oct 25 20:21:20 2018
New Revision: 345362
URL: http://llvm.org/viewvc/llvm-project?rev=345362&view=rev
Log:
PR31978: Don't crash if CodeGen sees a top-level BindingDecl.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
cfe/trunk/test/Parser/cxx1z-decomposition.cp
Author: compnerd
Date: Thu Oct 25 20:16:16 2018
New Revision: 345360
URL: http://llvm.org/viewvc/llvm-project?rev=345360&view=rev
Log:
CodeGen: correct the case for swift 4.2, 5.0
This corrects the leader for the swift names. The encoding for 4.2 and
5.0 differ by a single bit on the second char
tekknolagi added a comment.
@NoQ I think @alexshap will be committing this. Thanks
Repository:
rC Clang
https://reviews.llvm.org/D53206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
hubert.reinterpretcast added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
wuzish wrote:
> hubert.re
wuzish added inline comments.
Comment at: clang/lib/Sema/SemaOverload.cpp:3913
+for (auto Type : Types) {
+ if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector)
+return false;
hubert.reinterpretcast wrote:
> Consideri
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345354: [AArch64] Support Windows stack probe command-line
arguments. (authored by efriedma, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53617
Files:
lib/CodeGen/TargetInfo.cpp
Author: efriedma
Date: Thu Oct 25 18:31:57 2018
New Revision: 345354
URL: http://llvm.org/viewvc/llvm-project?rev=345354&view=rev
Log:
[AArch64] Support Windows stack probe command-line arguments.
Adds support for -mno-stack-arg-probe and -mstack-probe-size.
(Not really happy copy-pasting code,
NoQ accepted this revision.
NoQ added a comment.
Thanks! Also do you have commit access or do you need someone to commit this
for you?
Repository:
rC Clang
https://reviews.llvm.org/D53206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
tekknolagi updated this revision to Diff 171234.
tekknolagi added a comment.
Add comments suggested by @NoQ and @bcraig
Repository:
rC Clang
https://reviews.llvm.org/D53206
Files:
lib/StaticAnalyzer/Checkers/PaddingChecker.cpp
test/Analysis/padding_inherit.cpp
Index: test/Analysis/paddi
neerajksingh updated this revision to Diff 171233.
https://reviews.llvm.org/D53457
Files:
docs/UsersManual.rst
include/clang/Driver/CLCompatOptions.td
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
test/Driver/cl-options.c
Index: test/Driver/cl-options.c
==
tekknolagi added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:78-81
+// We need to be looking at a definition, not just any pointer to the
+// declaration.
+if (!(RD = RD->getDefinition()))
+ return;
NoQ wrote:
> Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345344: [AArch64] Implement FP16FML intrinsics (authored by
bryanpkc, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53633?vs=170811&id=17123
Author: george.karpenkov
Date: Thu Oct 25 16:38:58 2018
New Revision: 345341
URL: http://llvm.org/viewvc/llvm-project?rev=345341&view=rev
Log:
[analyzer] Fix a bug in "collapsed" graph viewer
Nodes which have only one predecessor and only one successor can not
always be hidden, even if all states
Author: george.karpenkov
Date: Thu Oct 25 16:38:07 2018
New Revision: 345338
URL: http://llvm.org/viewvc/llvm-project?rev=345338&view=rev
Log:
[analyzer] Correct modelling of OSDynamicCast: eagerly state split
Previously, OSDynamicCast was modeled as an identity.
This is not correct: the output
Author: george.karpenkov
Date: Thu Oct 25 16:38:41 2018
New Revision: 345340
URL: http://llvm.org/viewvc/llvm-project?rev=345340&view=rev
Log:
[analyzer] [RetainCountChecker] Do not invalidate references passed to
constructors and operators
Differential Revision: https://reviews.llvm.org/D53660
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345339: [analyzer] Remove custom rule for OSIterator in
RetainCountChecker (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews
Author: george.karpenkov
Date: Thu Oct 25 16:38:24 2018
New Revision: 345339
URL: http://llvm.org/viewvc/llvm-project?rev=345339&view=rev
Log:
[analyzer] Remove custom rule for OSIterator in RetainCountChecker
Differential Revision: https://reviews.llvm.org/D53628
Modified:
cfe/trunk/lib/Sta
I've already pointed Zach at this and I think he's going to handle it.
On Thu, 25 Oct 2018 at 16:00, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Could you update the demangler too?
>
> On Thu, Oct 25, 2018 at 6:53 PM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.o
erik.pilkington updated this revision to Diff 171218.
erik.pilkington marked an inline comment as done.
erik.pilkington added a comment.
Add documentation and release notes, `{}`s. Thanks!
https://reviews.llvm.org/D53621
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3223-3247
+if (ResultWidth < CommonWidth) {
+ // In the event we extended the sign of both operands, the intrinsic will
+ // not saturate to the initial bit width of the result type. I
leonardchan created this revision.
leonardchan added reviewers: ebevhan, bjope, rjmccall.
leonardchan added a project: clang.
This patch covers addition between fixed point types and other fixed point
types or integers, using the conversion rules described in 4.1.4 of N1169.
Usual arithmetic ru
Could you update the demangler too?
On Thu, Oct 25, 2018 at 6:53 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Oct 25 15:51:16 2018
> New Revision: 345330
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345330&view=rev
> Log:
> Add MS ABI mang
Author: rsmith
Date: Thu Oct 25 15:51:16 2018
New Revision: 345330
URL: http://llvm.org/viewvc/llvm-project?rev=345330&view=rev
Log:
Add MS ABI mangling for operator<=>.
Thanks to Cameron DaCamara at Microsoft for letting us know what their
chosen mangling is here!
Added:
cfe/trunk/test/Code
vsapsai updated this revision to Diff 171210.
vsapsai added a comment.
- Rebase once again.
- Use Doxygen comments in some places.
https://reviews.llvm.org/D50539
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clang/test/VFS/Inputs/Broken.framework/Headers/Error.h
clang/test/VFS/Inputs/
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Patch looks great, thanks!
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:78-81
+// We need to be looking at a definition, not just any pointer to the
+// decla
arphaman added a comment.
Thanks! It looks pretty good, just minor nit. could you also update the
language extension doc and release notes?
Comment at: clang/lib/Sema/SemaAttr.cpp:645
+
+ for (const PragmaAttributeEntry &Entry : PragmaAttributeStack.back().Entries)
+if (!
Author: rsmith
Date: Thu Oct 25 15:35:16 2018
New Revision: 345328
URL: http://llvm.org/viewvc/llvm-project?rev=345328&view=rev
Log:
Avoid STMT_ and DECL_ bitcodes overlapping.
This doesn't appear to matter for deserialization purposes, because we
always know what kind of entity (declaration or s
xbolva00 added a comment.
ping
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
neerajksingh updated this revision to Diff 171203.
neerajksingh retitled this revision from "clang-cl: Add "/Xdriver:"
pass-through arg support." to "clang-cl: Add "/clang:" pass-through arg
support.".
neerajksingh edited the summary of this revision.
neerajksingh added a comment.
Change the spe
aheejin added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:12528
+ case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f32x4:
+ case WebAssembly::BI__builtin_wasm_trunc_saturate_s_f64x2: {
Value *Src = EmitScalarExpr(E->getArg(0));
But unlike oth
thakis added a comment.
Comment from the peanut gallery:
- I like the whitelist model for gcc-style flags. It allows us to curate them
(and `/?` output) since many don't make much sense in the cl world.
- I like the idea behind this patch (and /clang: seems like a good spelling)
Repository:
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai added a comment.
In https://reviews.llvm.org/D50539#1273688, @dexonsmith wrote:
> In https://reviews.llvm.org/D50539#1273654, @vsapsai wrote:
>
> > I was using `//` instead of `///` on purpose. Class
> > `VFSFromYamlDirIterImpl` resides entirely in .cpp file and isn't available
> > outs
NoQ accepted this revision.
NoQ added inline comments.
This revision is now accepted and ready to land.
Comment at:
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist:17-18
+
+ name
+ expansion
+
NoQ wrote:
> They look em
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:471
+DisplayMacroExpansions =
+getBooleanOption("expand-macros", /*Default=*/false);
+ return DisplayMacroExpansions.getValue();
Yup, np, let's wait until it lands the
rnk accepted this revision.
rnk added a comment.
lgtm
https://reviews.llvm.org/D53066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:163
+
+switch (FloatingSize) {
+ case 64:
donat.nagy wrote:
> NoQ wrote:
> > Continuing the float semantics discussion on the new revision - Did you
> > consider `l
The reason for the revert was that the assertion was triggered by a bunch
of tests. It looks like we diagnose the errors later? I'm not sure yet.
On Thu, Oct 25, 2018 at 4:52 PM Eric Fiselier wrote:
> Ack. My bad.
>
> On Thu, Oct 25, 2018 at 4:02 PM Richard Smith
> wrote:
>
>> When reverting (e
Ack. My bad.
On Thu, Oct 25, 2018 at 4:02 PM Richard Smith wrote:
> When reverting (even when reverting your own commit), please include in
> the commit description a reason for the revert.
>
> On Thu, 25 Oct 2018 at 12:52, Eric Fiselier via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>
gtbercea updated this revision to Diff 171180.
gtbercea added a comment.
Change tests.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenM
Author: rakete
Date: Thu Oct 25 13:15:03 2018
New Revision: 345308
URL: http://llvm.org/viewvc/llvm-project?rev=345308&view=rev
Log:
[C++17] Reject shadowing of capture by parameter in lambda
Summary:
This change rejects the shadowing of a capture by a parameter in lambdas in
C++17.
```
int
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345308: [C++17] Reject shadowing of capture by parameter in
lambda (authored by Rakete, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53595
Files:
include/clang/Basic/Diagnostic
Rakete updated this revision to Diff 171174.
Rakete added a comment.
Update DR list.
https://reviews.llvm.org/D53595
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaLambda.cpp
test/CXX/drs/dr22xx.cpp
test/SemaCXX/warn-shadow-in-lambdas.
When reverting (even when reverting your own commit), please include in the
commit description a reason for the revert.
On Thu, 25 Oct 2018 at 12:52, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Thu Oct 25 12:50:43 2018
> New Revision: 345306
>
> URL
NoQ added a comment.
In https://reviews.llvm.org/D53076#1276315, @Charusso wrote:
> In https://reviews.llvm.org/D53076#1276277, @NoQ wrote:
>
> > I mean, the idea of checking constraints instead of matching program points
> > is generally good, but the example i gave above suggests that there's
ABataev added inline comments.
Comment at: test/OpenMP/distribute_parallel_for_codegen.cpp:410
// LAMBDA-DAG: [[OMP_IV:%.omp.iv]] = alloca
+ // LAMBDA-DAG: [[OMP_CAPT_EXPR:%.capture_expr.1]] = alloca
// LAMBDA-DAG: [[OMP_LB:%.omp.comb.lb]] = alloca
Author: ericwf
Date: Thu Oct 25 12:50:43 2018
New Revision: 345306
URL: http://llvm.org/viewvc/llvm-project?rev=345306&view=rev
Log:
Revert "[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03"
This reverts commit b5d8d0de744d2c212bdb17d5c5fd4447dd14dbd2.
Removed:
cfe/trunk/
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
Reverted the check, reopened https://reviews.llvm.org/D52670.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53719
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
lebedev.ri abandoned this revision.
lebedev.ri added a comment.
Reverted the check, reopened https://reviews.llvm.org/D52670.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53723
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
lebedev.ri updated this revision to Diff 171172.
lebedev.ri added a comment.
Reverted in https://reviews.llvm.org/rL345305 due to multiple
apparently-lurking bugs.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52670
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cer
rsmith added a comment.
In https://reviews.llvm.org/D53717#1276245, @rsmith wrote:
> Do you have evidence that this complexity is worthwhile? (I wouldn't imagine
> we have very many `ForStmt`s per translation unit, so saving 16 bytes for
> each of them seems unlikely to matter.)
Strikes me th
Author: lebedevri
Date: Thu Oct 25 12:44:51 2018
New Revision: 345305
URL: http://llvm.org/viewvc/llvm-project?rev=345305&view=rev
Log:
[clang-tidy] Revert my readability-uppercase-literal-suffix check.
There are some lurking issues with the handling of the SourceManager.
Somehow sometimes we end
reverting
On Thu., Oct. 25, 2018, 2:18 p.m. Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org wrote:
> Author: ericwf
> Date: Thu Oct 25 11:16:16 2018
> New Revision: 345296
>
> URL: http://llvm.org/viewvc/llvm-project?rev=345296&view=rev
> Log:
> [SemaCXX] Unconfuse Clang when std::alig
vsapsai marked 2 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:2527
+ return TryEmitResult(CGF.EmitScalarExpr(e),
+ !shouldRetainObjCLifetime(type.getObjCLifetime()));
+ }
vsapsai
gtbercea updated this revision to Diff 171170.
gtbercea added a comment.
Add test for collapse.
Repository:
rC Clang
https://reviews.llvm.org/D53448
Files:
include/clang/AST/StmtOpenMP.h
lib/AST/StmtOpenMP.cpp
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGe
vsapsai created this revision.
vsapsai added reviewers: rjmccall, ahatanak.
Herald added a subscriber: dexonsmith.
The goal is to use `emitConstant` in more places. Didn't move
`ComplexExprEmitter::emitConstant` because it returns a different type.
https://reviews.llvm.org/D53725
Files:
clang
Author: rakete
Date: Thu Oct 25 12:27:57 2018
New Revision: 345303
URL: http://llvm.org/viewvc/llvm-project?rev=345303&view=rev
Log:
Rebase defect report list.
Modified:
cfe/trunk/www/cxx_dr_status.html
Modified: cfe/trunk/www/cxx_dr_status.html
URL:
http://llvm.org/viewvc/llvm-project/
vsapsai updated this revision to Diff 171168.
vsapsai added a comment.
- Address review comments.
https://reviews.llvm.org/D53674
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScalar.cpp
clang/lib/CodeGen/CGObjC.cpp
clang/lib/CodeGen/CodeGenFunction.h
clang/test/CodeGenO
rsmith added a comment.
In https://reviews.llvm.org/D53595#1276346, @Rakete wrote:
> In https://reviews.llvm.org/D53595#1276330, @rsmith wrote:
>
> > In https://reviews.llvm.org/D53595#1273848, @Rakete wrote:
> >
> > > Addresed review comments :)
> > >
> > > I updated the dr status file b
rsmith requested changes to this revision.
rsmith added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Frontend/CompilerInstance.cpp:491-494
+ PrintingPolicy Policy = Context->getPrintingPolicy();
+ if (!getCodeGenOpts().DebugColumnInfo)
+Po
Rakete added a comment.
In https://reviews.llvm.org/D53595#1276330, @rsmith wrote:
> In https://reviews.llvm.org/D53595#1273848, @Rakete wrote:
>
> > Addresed review comments :)
> >
> > I updated the dr status file but a lot of unrelated changes made it in. Is
> > this okay?
>
>
> Please
erichkeane closed this revision.
erichkeane added a comment.
https://reviews.llvm.org/rL345302
https://reviews.llvm.org/D53718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: Thu Oct 25 12:13:46 2018
New Revision: 345302
URL: http://llvm.org/viewvc/llvm-project?rev=345302&view=rev
Log:
Change keep-static-consts to work on static storage duration, not
storage class.
To be more in line with what GCC does, switch the condition to be based
on the
erichkeane updated this revision to Diff 171163.
erichkeane edited the summary of this revision.
erichkeane added a comment.
Add to the test
https://reviews.llvm.org/D53718
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/keep-static-consts.cpp
Index: test/CodeGen/keep-static-consts.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345301: [WebAssembly] Bitselect and min/max builtins
(authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53685
Files:
cfe/tru
Author: tlively
Date: Thu Oct 25 12:11:41 2018
New Revision: 345301
URL: http://llvm.org/viewvc/llvm-project?rev=345301&view=rev
Log:
[WebAssembly] Bitselect and min/max builtins
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, sunfish, cfe-commits
Differential Revision: https
rsmith added a comment.
Also please mark PR39428 as fixed once this is submitted :)
Repository:
rC Clang
https://reviews.llvm.org/D53595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D53595#1273848, @Rakete wrote:
> Addresed review comments :)
>
> I updated the dr status file but a lot of unrelated changes made it in. Is
> this okay?
Pleas
JonasToth added a comment.
Did you discover these in a real project? May I ask which one and add it to my
BB? :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345300: [WebAssembly] Lower to target-independent saturating
add (authored by tlively, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53722
File
erichkeane added a comment.
In https://reviews.llvm.org/D53718#1276205, @zturner wrote:
> Will this work for the following variable?
>
> constexpr int N = 3;
>
Yep, just confirmed that it does! Adding to the test and will update the
review.
Repository:
rC Clang
https://reviews.llvm.org
Author: tlively
Date: Thu Oct 25 12:06:15 2018
New Revision: 345300
URL: http://llvm.org/viewvc/llvm-project?rev=345300&view=rev
Log:
[WebAssembly] Lower to target-independent saturating add
Summary: Goes along with D53721.
Reviewers: aheejin, dschuff
Subscribers: sbc100, jgravelle-google, sunf
Charusso added a comment.
In https://reviews.llvm.org/D53076#1276277, @NoQ wrote:
> I mean, the idea of checking constraints instead of matching program points
> is generally good, but the example i gave above suggests that there's a bug
> somewhere.
I think it is an unimplemented feature whi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345298: Implement Function Multiversioning for Non-ELF
Systems. (authored by erichkeane, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53586
Author: erichkeane
Date: Thu Oct 25 11:57:19 2018
New Revision: 345298
URL: http://llvm.org/viewvc/llvm-project?rev=345298&view=rev
Log:
Implement Function Multiversioning for Non-ELF Systems.
Similar to how ICC handles CPU-Dispatch on Windows, this patch uses the
resolver function directly to fo
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, kristina, sunfish, jgravelle-google,
sbc100.
Use the same convention as all the other WebAssembly builtin names.
Repository:
rC Clang
https://reviews.llvm.org/D53724
Files:
inc
Charusso added a comment.
In https://reviews.llvm.org/D53076#1276270, @george.karpenkov wrote:
> @NoQ has a good point: we need to preserve the distinction between the things
> analyzer "assumes" and the things analyzer "knows".
Yes, but I think it should be a new patch because I would like to
lebedev.ri created this revision.
lebedev.ri added reviewers: JonasToth, aaron.ballman, alexfh, hokein, xazax.hun.
lebedev.ri added a project: clang-tools-extra.
Herald added a subscriber: rnkovacs.
lebedev.ri added a dependency: D53719: [clang-tidy]
UppercaseLiteralSuffixCheck: bugfix: don't cri
rsmith added a comment.
In https://reviews.llvm.org/D53207#1276062, @ubsan wrote:
> I don't actually know how to send this upstream, since it's been accepted...
> How should I proceed?
If you don't have an SVN account, you can ask someone who does to commit it for
you. (In this case, I'll do
NoQ added a comment.
I mean, the idea of checking constraints instead of matching program points is
generally good, but the example i gave above suggests that there's a bug
somewhere.
https://reviews.llvm.org/D53076
___
cfe-commits mailing list
cf
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Actually, apologies again: I have rushed through this too much.
@NoQ has a good point: we need to preserve the distinction between the things
analyzer "assumes" an
tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100.
Goes along with https://reviews.llvm.org/D53721.
Repository:
rC Clang
https://reviews.llvm.org/D53722
Files:
lib/CodeGen/CGBuiltin.cpp
test/
rsmith added a comment.
Do you have evidence that this complexity is worthwhile? (I wouldn't imagine we
have very many `ForStmt`s per translation unit, so saving 16 bytes for each of
them seems unlikely to matter.)
Comment at: include/clang/AST/Stmt.h:1863
+ Expr *getCond()
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
> I'm basically asking "is the
> `unless(hasParent(substNonTypeTemplateParmExpr()))` fix correct? or is there
> something else i'm missing?"
Ah ok, I am not aware of another way, but no
Charusso added a comment.
Thanks everyone for the review!
@george.karpenkov could you commit it please? I am interested in your ideas in
the little discussion started with @NoQ at the beginning of the project.
https://reviews.llvm.org/D53076
___
c
lebedev.ri added a comment.
In https://reviews.llvm.org/D53719#1276208, @JonasToth wrote:
> What do you mean by "general way to avoid"? Templates?
I'm basically asking "is the
`unless(hasParent(substNonTypeTemplateParmExpr()))` fix correct? or is there
something else i'm missing?"
Repositor
eandrews added a comment.
I think it makes sense to include this case just to make the flag more
complete. Also, we don't really match GCC behavior for this flag. GCC emits all
static constants by default (when O0). When optimized, this flag has no effect
on GCC. The negation is used to not em
JonasToth added a comment.
What do you mean by "general way to avoid"? Templates?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
zturner added a comment.
Will this work for the following variable?
constexpr int N = 3;
Repository:
rC Clang
https://reviews.llvm.org/D53718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
erichkeane added a comment.
In https://reviews.llvm.org/D53586#1276198, @rnk wrote:
> Here's a thought. What happens if different TUs observe different overload
> sets, perhaps because of ifdefs? Different TUs will generate different
> resolvers, but they won't dispatch to the same sets of targ
rnk accepted this revision.
rnk added a comment.
Here's a thought. What happens if different TUs observe different overload
sets, perhaps because of ifdefs? Different TUs will generate different
resolvers, but they won't dispatch to the same sets of targets. I'm guessing
we'd treat that as an O
Author: ericwf
Date: Thu Oct 25 11:16:16 2018
New Revision: 345296
URL: http://llvm.org/viewvc/llvm-project?rev=345296&view=rev
Log:
[SemaCXX] Unconfuse Clang when std::align_val_t is unscoped in C++03
Summary:
When -faligned-allocation is specified in C++03 libc++ defines std::align_val_t
as an
1 - 100 of 204 matches
Mail list logo
