Hi Eric,
I fixed a compilation warning introduced with this patch in r343661.
Regards,
Mikael
On 10/02/2018 12:43 PM, Eric Liu via cfe-commits wrote:
Author: ioeric
Date: Tue Oct 2 03:43:55 2018
New Revision: 343576
URL: http://llvm.org/viewvc/llvm-project?rev=343576&view=rev
Log:
[clangd] C
Author: uabelho
Date: Tue Oct 2 22:41:14 2018
New Revision: 343661
URL: http://llvm.org/viewvc/llvm-project?rev=343661&view=rev
Log:
Fix compilation warning by removing unused variable [NFC]
clang complained with
../tools/clang/tools/extra/clangd/FS.cpp:19:12: error: unused variable 'Err'
[-We
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343660: [Frontend] Delete -print-decl-contexts (authored by
MaskRay, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52529?vs=167842&id=168070
Author: maskray
Date: Tue Oct 2 20:50:44 2018
New Revision: 343660
URL: http://llvm.org/viewvc/llvm-project?rev=343660&view=rev
Log:
[Frontend] Delete -print-decl-contexts
Summary: Its job is covered by -ast-dump. The option is rarely used and lacks
many AST nodes which will lead to llvm_unreac
arsenm closed this revision.
arsenm added a comment.
r343653
https://reviews.llvm.org/D52412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Tue Oct 2 19:01:19 2018
New Revision: 343653
URL: http://llvm.org/viewvc/llvm-project?rev=343653&view=rev
Log:
OpenCL: Mark printf format string argument
Fixes not warning on format string errors.
Added:
cfe/trunk/test/SemaOpenCL/printf-format-string-warnings.cl
Modifie
rjmccall added a comment.
In https://reviews.llvm.org/D52674#1253401, @smeenai wrote:
> Actually, I take that back ... I just misread the stack trace.
>
> There are a bunch of hops between the `mangleCXXRTTI` call and the ultimate
> mangling function:
>
> MicrosoftMangleContextImpl::mangleCXXR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343652: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia
toolchain (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52660?vs=
smeenai requested review of this revision.
smeenai added a comment.
Actually, I take that back ... I just misread the stack trace.
There are a bunch of hops between the `mangleCXXRTTI` call and the ultimate
mangling function:
MicrosoftMangleContextImpl::mangleCXXRTTI(QualType, raw_ostream &)
Author: phosek
Date: Tue Oct 2 18:27:00 2018
New Revision: 343652
URL: http://llvm.org/viewvc/llvm-project?rev=343652&view=rev
Log:
[CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain
We don't need to provide stable ABI and hence we can use the v2.
Differential Revision: https://reviews.llv
phosek updated this revision to Diff 168064.
Repository:
rCXX libc++
https://reviews.llvm.org/D52660
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
Index: clang/cmake/caches/Fuchsia-stage2.cmake
===
--- clang/cmake/caches/Fuch
phosek updated this revision to Diff 168061.
Herald added a subscriber: libcxx-commits.
Repository:
rCXX libc++
https://reviews.llvm.org/D52660
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
Index: clang/cmake/caches/Fuchsia-stage2.cmake
smeenai planned changes to this revision.
smeenai added a comment.
In https://reviews.llvm.org/D52674#1251931, @rjmccall wrote:
> In https://reviews.llvm.org/D52674#1251439, @smeenai wrote:
>
> > In https://reviews.llvm.org/D52674#1251419, @rjmccall wrote:
> >
> > > Conceptually this seems fine,
efriedma added inline comments.
Comment at: test/CodeGen/ms-intrinsics.c:379
+// CHECK: [[RESULT:%[0-9]+]] = atomicrmw add i32* %value, i32 %mask seq_cst
+// CHECK: ret i32 [[RESULT:%[0-9]+]]
+// CHECK: }
Missing "add" instruction. _InterlockedAdd is suppose
leonardchan created this revision.
leonardchan added reviewers: mcgrathr, phosek, fedor.sergeev, philip.pfaffe,
vitalybuka.
leonardchan added projects: clang, Sanitizers.
leonardchan added a dependency: D52739: [PassManager/Sanitizer] Port of
AddresSanitizer pass from legacy to new PassManager.
mgrang created this revision.
mgrang added reviewers: rnk, mstorsjo, compnerd, TomTan, haripul.
Herald added subscribers: jfb, chrib, kristof.beyls.
Repository:
rC Clang
https://reviews.llvm.org/D52811
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-intr
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D52809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
mgrang created this revision.
mgrang added reviewers: rnk, mstorsjo, compnerd, TomTan, haripul.
Herald added a reviewer: javed.absar.
Herald added subscribers: jfb, chrib, kristof.beyls.
Repository:
rC Clang
https://reviews.llvm.org/D52809
Files:
include/clang/Basic/BuiltinsAArch64.def
lib
sammccall updated this revision to Diff 168049.
sammccall added a comment.
Update comment, revert unintended change
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52808
Files:
clangd/index/dex/Trigram.cpp
clangd/index/dex/Trigram.h
unittests/clangd/DexTests.cpp
Index: un
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3003
+ case Builtin::BI_InterlockedCompareExchangePointer:
+ case Builtin::BI_InterlockedCompareExchangePointer_nf: {
llvm::Type *RTy;
Is the no fence version really equivalent to this seq_cs
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous,
ilya-biryukov.
1. Instead of a$$ for a short-query trigram, just use a
2. Generate more short-query trigrams, e.g. "AbcDefGhi" now yields "d" and
"ag".
mgrang created this revision.
mgrang added reviewers: rnk, mstorsjo, compnerd, TomTan, haripul.
Herald added subscribers: jfb, chrib, kristof.beyls.
Repository:
rC Clang
https://reviews.llvm.org/D52807
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/ms-intr
mgrang abandoned this revision.
mgrang added a comment.
Will abandon this patch since I have implementations of these which I will
upstream soon.
https://reviews.llvm.org/D51204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
mgrang added inline comments.
Comment at: lib/Format/Format.cpp:1856
+ }
+ std::sort(Indices.begin(), Indices.end(), [&](unsigned LHSI, unsigned RHSI) {
+// Negating IsStatic to push static imports above non-static imports.
Please use llvm::sort instead
Author: george.karpenkov
Date: Tue Oct 2 15:31:44 2018
New Revision: 343643
URL: http://llvm.org/viewvc/llvm-project?rev=343643&view=rev
Log:
[analyzer] [tests] Hotfix: missing space
Modified:
cfe/trunk/utils/analyzer/SATestBuild.py
Modified: cfe/trunk/utils/analyzer/SATestBuild.py
URL:
ht
mgorny updated this revision to Diff 168042.
mgorny added a comment.
(also included README update)
https://reviews.llvm.org/D52806
Files:
bindings/python/README.txt
bindings/python/clang/cindex.py
Index: bindings/python/clang/cindex.py
=
mgorny created this revision.
mgorny added reviewers: jbcoe, arphaman, frutiger.
Support a new CLANG_LIBRARY_PATH environment variable within the Python
bindings. This variable can be used to force the bindings to load
libclang.* from a specific directory without having to explicitly
read the pat
Author: rnk
Date: Tue Oct 2 15:23:27 2018
New Revision: 343641
URL: http://llvm.org/viewvc/llvm-project?rev=343641&view=rev
Log:
Remove spurious assertion in -Wdocumentation
Some code in OpenCV uses interesting doxygen directives that make it so
we don't see any tokens inside a @note, despite th
It didn't seem to work. I have temporarily disabled the test for windows
(r343637).
On Tue, Oct 2, 2018 at 10:05 PM Eric Liu wrote:
> Hi Douglas,
>
> Thanks for letting me know! The test seemed to be too strict for windows.
> r343623 is an attempt to fix. If it still doesn't work, feel free to r
Author: ioeric
Date: Tue Oct 2 14:47:41 2018
New Revision: 343637
URL: http://llvm.org/viewvc/llvm-project?rev=343637&view=rev
Log:
[clangd] Temporarily disable VFS stats cache test for windows.
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
Modified: clang-tools-extra/t
aaron.ballman added a comment.
In https://reviews.llvm.org/D52398#1251894, @aaronpuchert wrote:
> @delesley Any objections to this?
>
> It's certainly useful for our code base, because our `assert`-like macros use
> `__builtin_expect`, but I'm not sure if that applies to the general public.
I
On Mon, Oct 1, 2018 at 4:58 PM Richard Smith wrote:
> On Mon, 1 Oct 2018 at 16:10, George Karpenkov via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi Richard,
>>
>> On Oct 1, 2018, at 2:50 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>> This looks like
george.karpenkov added a comment.
This should also prevent leaks.
Repository:
rC Clang
https://reviews.llvm.org/D52804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a minor nit.
Comment at: clang-query/QueryParser.cpp:42
+End = Begin;
+return StringRef(Begin, 0);
+ }
This is just re
NoQ created this revision.
NoQ added reviewers: dcoughlin, george.karpenkov.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, baloghadamsoftware, xazax.hun.
The checker was trying to produce a separate `ProgramPointTag` for every dead
symbol it cleans up, so
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some naming and style convention nits, LGTM.
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:151
Sema.parse(" Foo ( Bar ( 17), Baz( \n \"
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343636: [analyzer] [tests] Allow specifying entire
-analyze-config on the command line… (authored by george.karpenkov, committed
by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343635: [analyzer] Fix crash in exploded graph dumping
(authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D52756?vs=
Author: george.karpenkov
Date: Tue Oct 2 14:19:23 2018
New Revision: 343636
URL: http://llvm.org/viewvc/llvm-project?rev=343636&view=rev
Log:
[analyzer] [tests] Allow specifying entire -analyze-config on the command line,
make sure it's always propagated
Differential Revision: https://reviews.l
Author: george.karpenkov
Date: Tue Oct 2 14:19:01 2018
New Revision: 343635
URL: http://llvm.org/viewvc/llvm-project?rev=343635&view=rev
Log:
[analyzer] Fix crash in exploded graph dumping
By allocating new DeclStmt to ASTContext
Differential Revision: https://reviews.llvm.org/D52756
Modified:
lebedev.ri added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:770
+NullPointerArithmetic,
+ExtraSemiStmt
]>;
I'm really unsure of this. Maybe this should only be `EmptyInitStatement`.
Repository:
rC Clang
https://reviews.ll
JonasToth added a comment.
True
Am 02.10.2018 um 22:28 schrieb Roman Lebedev via Phabricator:
> lebedev.ri added inline comments.
>
>
> Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:50
> + const auto VarType = Var->getType();
> + if (std::find_if(WhiteListTypes.
lebedev.ri updated this revision to Diff 168020.
lebedev.ri added a comment.
Slightly improved test coverage for macros in
`extra-semi-resulting-in-nullstmt-in-init-statement.cpp`
Repository:
rC Clang
https://reviews.llvm.org/D52695
Files:
docs/ReleaseNotes.rst
include/clang/Basic/Diagn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343632: [analyzer] Promote StdCLibraryFunctionsChecker to
the apiModeling category. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
Author: dergachev
Date: Tue Oct 2 13:50:40 2018
New Revision: 343632
URL: http://llvm.org/viewvc/llvm-project?rev=343632&view=rev
Log:
[analyzer] Promote StdCLibraryFunctionsChecker to the apiModeling category.
Because all our languages are C-based, there's no reason to
enable this checker only
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343631: [analyzer] Fix symbol discovery in
nonloc::LocAsInteger values. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52667
Files:
lib/StaticAnalyzer/Core/SV
Author: dergachev
Date: Tue Oct 2 13:48:12 2018
New Revision: 343631
URL: http://llvm.org/viewvc/llvm-project?rev=343631&view=rev
Log:
[analyzer] Fix symbol discovery in nonloc::LocAsInteger values.
Doesn't do much despite sounding quite bad, but fixes an exotic test case where
liveness of a non
SamMaier created this revision.
Herald added subscribers: cfe-commits, mgrang, mgorny, srhines.
This is for https://bugs.chromium.org/p/chromium/issues/detail?id=768983 -
however it will be useful for anyone using clang-format for Java, not just
Chromium.
Repository:
rC Clang
https://review
lebedev.ri added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:167-168
+ CXX11ExtraSemi,
+ ExtraSemiStmt,
+ EmptyInitStatement]>;
-
lebedev.ri updated this revision to Diff 168017.
lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.
- Moved `-Wempty-init-stmt` into `-Wextra-semi-stmt`
- Moved `-Wextra-semi-stmt` out of `-Wextra-semi`
- Tentatively enabled `-Wextra-semi-stmt` in `-Wextra` (and removed
`-We
Author: zturner
Date: Tue Oct 2 13:42:36 2018
New Revision: 343629
URL: http://llvm.org/viewvc/llvm-project?rev=343629&view=rev
Log:
[cl-compat] Change /JMC from unsupported to ignored.
A tracking bug for actually implementing this in clang-cl is at
https://bugs.llvm.org/show_bug.cgi?id=39156.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343629: [cl-compat] Change /JMC from unsupported to ignored.
(authored by zturner, committed by ).
Herald added a subscrib
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:164
+def ExtraSemiStmt : DiagGroup<"extra-semi-stmt">;
+def EmptyInitStatement : DiagGroup<"empty-init-stmt">;
def ExtraSemi : DiagGroup<"extra-semi", [CXX98CompatExtraSemi,
I thin
lebedev.ri added inline comments.
Comment at: clang-tidy/performance/ForRangeCopyCheck.cpp:50
+ const auto VarType = Var->getType();
+ if (std::find_if(WhiteListTypes.begin(), WhiteListTypes.end(),
+ [&](llvm::StringRef WhiteListType) {
JonasT
rnk added a comment.
lgtm Can you file a bug about implementing /JMC and link it from the commit
message?
https://reviews.llvm.org/D52798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
zturner created this revision.
zturner added reviewers: rnk, thakis.
Herald added subscribers: JDevlieghere, aprantl.
This command line option doesn't really affect generated code, only generated
debug info, and it's set by default in newer versions of VS, so it's annoying
to have to turn it off
Hi Douglas,
Thanks for letting me know! The test seemed to be too strict for windows.
r343623 is an attempt to fix. If it still doesn't work, feel free to revert
the commits, and I'll re-investigate on Thursday.
- Eric
On Tue, Oct 2, 2018 at 9:25 PM wrote:
> Hi Eric,
>
> One of the tests you a
Oops, thanks! This one always gets me.
I couldn't think of a good name either, but here qualifying the type
(dex::Corpus) should work.
Re-landed as r343622
On Tue, Oct 2, 2018 at 7:34 PM Reid Kleckner wrote:
> I reverted this in r343610 because I noticed many bots were failing to
> build after t
Author: ioeric
Date: Tue Oct 2 13:00:32 2018
New Revision: 343623
URL: http://llvm.org/viewvc/llvm-project?rev=343623&view=rev
Log:
[clangd] Try to fix windows buildbot after r343576
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20347/steps/test/logs/s
Author: sammccall
Date: Tue Oct 2 12:59:23 2018
New Revision: 343622
URL: http://llvm.org/viewvc/llvm-project?rev=343622&view=rev
Log:
Reland r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold
constant. NFC""
This reverts commit r343610.
Modified:
clang-tools-extra/trunk
Hahnfeld added a comment.
In https://reviews.llvm.org/D52733#1252966, @ABataev wrote:
> In https://reviews.llvm.org/D52733#1252963, @Hahnfeld wrote:
>
> > In https://reviews.llvm.org/D52733#1251421, @ABataev wrote:
> >
> > > It might lead to increased register pressure, isn't it? Currently, I'm
ABataev added a comment.
In https://reviews.llvm.org/D52733#1252963, @Hahnfeld wrote:
> In https://reviews.llvm.org/D52733#1251421, @ABataev wrote:
>
> > It might lead to increased register pressure, isn't it? Currently, I'm
> > trying to emit the code that can be optimized out and, thus, may de
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
The bug being fixed: when a posting list doesn't exist in the index, it
was previously just dropped from the query rather than being tre
Hahnfeld added a comment.
In https://reviews.llvm.org/D52733#1251421, @ABataev wrote:
> It might lead to increased register pressure, isn't it? Currently, I'm trying
> to emit the code that can be optimized out and, thus, may decrease the
> register pressure. That's why I tried to reduce the nu
Szelethus added a comment.
I'll probably do something with this parameter spaghetti, it bothers me too,
but maybe in a separate patch :)
Repository:
rC Clang
https://reviews.llvm.org/D52787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343620: [analyzer][NFC] Refactor functions in
PlistDiagnostics to take AnalyzerOptions… (authored by Szelethus, committed by
).
Repository:
rC Clang
https://reviews.llvm.org/D52787
Files:
lib/Stati
Author: szelethus
Date: Tue Oct 2 12:27:34 2018
New Revision: 343620
URL: http://llvm.org/viewvc/llvm-project?rev=343620&view=rev
Log:
[analyzer][NFC] Refactor functions in PlistDiagnostics to take AnalyzerOptions
as parameter
I intend to add a new flag macro-expnasions-as-events, and unfortuna
lebedev.ri added a comment.
@rsmith Ping.
Though, https://reviews.llvm.org/D50901 is less controversial, so maybe best to
start there..
Repository:
rC Clang
https://reviews.llvm.org/D50250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hi Eric,
One of the tests you added in this commit is causing a failure on the PS4
Windows bot:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20347/steps/test/logs/stdio:
FAIL: Extra Tools Unit Tests ::
clangd/./ClangdTests.exe/ClangdTests.PreambleVF
lebedev.ri added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:237
+SourceLocation SemiLocation = ConsumeToken();
+if (!HasLeadingEmptyMacro && getCurScope()->isCompoundStmtScope() &&
+!SemiLocation.isMacroID()) {
rsmith wrote:
> I'm a litt
lebedev.ri updated this revision to Diff 168000.
lebedev.ri marked 4 inline comments as done.
lebedev.ri added a comment.
Thank you for taking a look!
- Move it into `ParseCompoundStatementBody()`, thus fixing false-positives with
`case X: ;` e.g.
- Rename to `-Wextra-semi-stmt`
- Add `-Wempty-i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343618: [OpenMP][NVPTX] Simplify codegen for orphaned
parallel, NFCI. (authored by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52732
Files:
lib/CodeGen/CGOpenMPRuntimeNV
Author: hahnfeld
Date: Tue Oct 2 12:12:47 2018
New Revision: 343617
URL: http://llvm.org/viewvc/llvm-project?rev=343617&view=rev
Log:
[OpenMP] Simplify code for reductions on distribute directives, NFC.
Only need to care about the 'distribute simd' case, all other composite
directives are handle
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343617: [OpenMP] Simplify code for reductions on distribute
directives, NFC. (authored by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52731
Files:
lib/CodeGen/CGStmtOpen
Author: hahnfeld
Date: Tue Oct 2 12:12:54 2018
New Revision: 343618
URL: http://llvm.org/viewvc/llvm-project?rev=343618&view=rev
Log:
[OpenMP][NVPTX] Simplify codegen for orphaned parallel, NFCI.
Worker threads fork off to the compiler generated worker function
directly after entering the kernel
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, NoQ, rnkovacs, dkrupp, whisperity,
martong, baloghadamsoftware.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
xazax.hun.
Szelethus added a dependency: D52742: [analyzer][PlistMacroExpansion]
Szelethus updated this revision to Diff 167992.
Szelethus retitled this revision from "[analyzer][WIP] Add macro expansions to
the plist output" to "[analyzer][PlistMacroExpansion] Part 1.: New
expand-macros flag".
Szelethus edited the summary of this revision.
Szelethus removed reviewers: xazax.
JonasToth added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:103
for (const Stmt *Parent : getParentStmts(S, Context)) {
+// For statements that have multiple parents, make sure we're using the
+// parent that lies within the sub-tree under Root.
zturner added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:792
Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name);
+ if (Args.hasArg(OPT_echo_main_file_name))
+llvm::outs() << Opts.MainFileName << "\n";
steveire wrote:
> ztur
boga95 updated this revision to Diff 167991.
boga95 marked 7 inline comments as done.
https://reviews.llvm.org/D52281
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp
clang-tidy/modernize/Replac
steveire added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:792
Opts.MainFileName = Args.getLastArgValue(OPT_main_file_name);
+ if (Args.hasArg(OPT_echo_main_file_name))
+llvm::outs() << Opts.MainFileName << "\n";
zturner wrote:
> ztur
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190
+ for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) {
+EXPECT_EQ("", Sema.Errors[i]);
+ }
aaron.ballman wrote:
steveire updated this revision to Diff 167987.
steveire added a comment.
use cxx_range_for
Repository:
rC Clang
https://reviews.llvm.org/D52751
Files:
lib/ASTMatchers/Dynamic/Parser.cpp
unittests/ASTMatchers/Dynamic/ParserTest.cpp
Index: unittests/ASTMatchers/Dynamic/ParserTest.cpp
===
xbolva00 updated this revision to Diff 167985.
xbolva00 added a comment.
- Addressed review comments
https://reviews.llvm.org/D52791
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaStmt.cpp
test/Sema/misleading-pointer-decl.c
Index: test/Sema/misleading-pointer-decl.c
===
steveire added a comment.
In https://reviews.llvm.org/D52746#1252455, @aaron.ballman wrote:
> Please update `HelpQuery::run()` to print out the new mnemonic (it's the
> *only* form of public documentation we have for clang-query currently).
Good point, thanks!
Repository:
rCTE Clang Tools
steveire updated this revision to Diff 167984.
steveire added a comment.
Add docs
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52746
Files:
clang-query/Query.cpp
clang-query/QueryParser.cpp
unittests/clang-query/QueryParserTest.cpp
Index: unittests/clang-query/QueryPa
erik.pilkington added a comment.
Thanks for working on this!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:318-320
+def warn_misleading_var_type_decl : Warning<
+ "misleading variable declaration, supposed to be a pointer type instead ?">,
+ InGroup>;
---
mstorsjo added a comment.
Ping @jroelofs or someone else willing to have a look
Repository:
rC Clang
https://reviews.llvm.org/D52533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC343611: [HIP] Support early finalization of device code for
-fno-gpu-rdc (authored by yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D52377
Files:
include/clang/Basic/LangOpti
Author: yaxunl
Date: Tue Oct 2 10:48:54 2018
New Revision: 343611
URL: http://llvm.org/viewvc/llvm-project?rev=343611&view=rev
Log:
[HIP] Support early finalization of device code for -fno-gpu-rdc
This patch renames -f{no-}cuda-rdc to -f{no-}gpu-rdc and keeps the original
options as aliases. Whe
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:306-307
+ const FIDMap& FM,
+ const Preprocessor &PP,
+ AnalyzerOptions &AnOpts) {
+ ReportPiece(o, P, FM, PP, AnOpts, /*in
xbolva00 updated this revision to Diff 167978.
xbolva00 added a comment.
- Avoid possible crash
https://reviews.llvm.org/D52791
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaStmt.cpp
test/Sema/misleading-var-type-decl.c
Index: test/Sema/misleading-var-type-decl.c
==
sidorovd added a comment.
In https://reviews.llvm.org/D52658#1252744, @Anastasia wrote:
> Does it mean we should close https://reviews.llvm.org/D32896?
Yes
In https://reviews.llvm.org/D52658#1252744, @Anastasia wrote:
> Would it make sense to keep this value as Clang implementation and if ven
I reverted this in r343610 because I noticed many bots were failing to
build after this change. Declaring the field `Corpus Corpus;` upsets GCC. I
considered trying to pick a different field name, but I wasn't able to come
up with one I liked, so I'm punting it back to you. =/
On Tue, Oct 2, 2018
xbolva00 created this revision.
xbolva00 added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
void foo() {
char* a, b; // warn that b is not a pointer type as someone may expect
}
Fixes PR39150 (also I see a request for this checker on GCC Bugzilla)
Repository:
rC Clang
http
Author: rnk
Date: Tue Oct 2 10:31:43 2018
New Revision: 343610
URL: http://llvm.org/viewvc/llvm-project?rev=343610&view=rev
Log:
Revert r343589 "[clangd] Dex: add Corpus factory for iterators, rename, fold
constant. NFC"
Declaring a field with the same name as a type causes GCC to error out:
D
Anastasia added inline comments.
Comment at: lib/Sema/SemaCast.cpp:2283
+ const QualType &SrcType,
+ const QualType &DestType) {
+ // OpenCL v1 s6.5: Casting a pointer to address space A to a pointer to
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343608: [clangd] Don't make check-clangd as a
dependency in check-clang-tools (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
Anastasia added a comment.
Does it mean we should close https://reviews.llvm.org/D32896?
Would it make sense to keep this value as Clang implementation and if vendors
need to change this they can `undef` it and redefine a new value. Would this
work?
Repository:
rC Clang
https://reviews.llv
1 - 100 of 218 matches
Mail list logo
