shuaiwang updated this revision to Diff 166595.
shuaiwang marked 5 inline comments as done.
shuaiwang added a comment.
Addresses review comments.
Repository:
rC Clang
https://reviews.llvm.org/D52219
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
lib/Analysis/ExprMutationAn
shuaiwang marked 10 inline comments as done.
shuaiwang added inline comments.
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:86
+// - Pointer to non-const
+// - Pointer-like type with `operator*` returning non-const reference
+bool isPointeeMutable(const Expr *Exp, const ASTCo
Author: rtrieu
Date: Fri Sep 21 18:50:52 2018
New Revision: 342794
URL: http://llvm.org/viewvc/llvm-project?rev=342794&view=rev
Log:
Update smart pointer detection for thread safety analysis.
Objects are determined to be smart pointers if they have both a star and arrow
operator. Some implementa
vsapsai added a comment.
It seems like there are too many asserts and they are too specific, they seem
to be aimed at specific potential bugs. What about asserts that make sure we
maintain some invariants? For example, check `DiagStr < DiagEnd` once in a loop
instead of every place we increment
ldionne updated this revision to Diff 166590.
ldionne added a comment.
Fix warnings on undefined entities
Repository:
rC Clang
https://reviews.llvm.org/D51789
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaDec
My bad. I saw that Vitaly accepted it and thought it would be ok since
I got 2 LGTMs.
On Fri, Sep 21, 2018 at 6:21 PM Aaron Ballman wrote:
>
> The reviewer asked you to wait a day so that others might have a
> chance to review it, so this commit seems premature. I have no
> technical concerns with
The reviewer asked you to wait a day so that others might have a
chance to review it, so this commit seems premature. I have no
technical concerns with the patch, but the sanitizer owners should
have had a chance to weigh in. That said, I don't see value in
reverting and recommitting later, so if t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342793: [Lexer] Add udefined_behavior_sanitizer feature
(authored by leonardchan, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D52386
Files:
include/clang/Basic/Features.def
test/L
Author: leonardchan
Date: Fri Sep 21 18:03:16 2018
New Revision: 342793
URL: http://llvm.org/viewvc/llvm-project?rev=342793&view=rev
Log:
[Lexer] Add udefined_behavior_sanitizer feature
This can be used to detect whether the code is being built with UBSan using
the __has_feature(undefined_behavio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342793: [Lexer] Add udefined_behavior_sanitizer feature
(authored by leonardchan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52386?vs=166
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM but you should probably a wait a day to see if sanitizer owners are fine
with with this as well.
Repository:
rC Clang
https://reviews.llvm.org/D52386
__
leonardchan created this revision.
leonardchan added reviewers: phosek, kcc, echristo, vitalybuka, morehouse.
leonardchan added a project: clang.
This can be used to detect whether the code is being built with UBSan using the
__has_feature(undefined_behavior_sanitizer) predicate.
Repository:
jlebar requested changes to this revision.
jlebar added subscribers: timshen, rsmith.
jlebar added a comment.
This revision now requires changes to proceed.
Sorry for missing tra's ping earlier, I get a lot of HIP email traffic that's
99% inactionable by me, so I didn't notice my username in tra'
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:31
+static bool singleNamedNamespaceChild(const NamespaceDecl &ND) {
+ const NamespaceDecl::decl_range Decls = ND.decls();
+ if (std::distance(Decls.begin(), Decls.end()) != 1)
Higuoxing updated this revision to Diff 166583.
Higuoxing added a comment.
I update the *SuggestParentheses* function, now, it could deal with parentheses
inside macros
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
In C, enumerators are not hoisted into, say, a struct decl context when the
enumeration is declared inside of a struct. Instead, the enumerators are
hoisted into the translation unit decl context. This patch fi
rsmith added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4683-4686
+ "Member '%0' marked with 'exclude_from_explicit_instantiation' attribute is "
+ "not defined but an explicit template instantiation declaration exists. "
+ "Reliance on this
nickdesaulniers added inline comments.
Comment at: lib/Sema/SemaType.cpp:1682
// or via one or more typedefs."
-if (!S.getLangOpts().C99 && !S.getLangOpts().CPlusPlus
-&& TypeQuals & Result.getCVRQualifiers()) {
srhines wrote:
> This is broken fo
nickdesaulniers updated this revision to Diff 166578.
nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.
- also run test on gnu99+
Repository:
rC Clang
https://reviews.llvm.org/D52248
Files:
lib/Sema/SemaType.cpp
test/Sema/gnu89-const.c
Index: test/Sema/
kristina marked 2 inline comments as done.
kristina added a comment.
Binary layout also looks sane (compiled with `-fPIC -faddrsig -Wl,--icf=safe`),
just digging it through it in a dissasembler:
[/q/src/clwn]$ llvm-readobj -elf-output-style=GNU -sections
/q/org.llvm.caches/clownschool/clwn-sy
Author: aaronpuchert
Date: Fri Sep 21 16:46:35 2018
New Revision: 342790
URL: http://llvm.org/viewvc/llvm-project?rev=342790&view=rev
Log:
Thread safety analysis: Make printSCFG compile again [NFC]
Not used productively, so no observable functional change.
Note that printSCFG doesn't yet work re
kristina updated this revision to Diff 166576.
kristina added a comment.
Does this look about right? I'm not sure what's up with DSO local attribute, it
doesn't seem to apply, I think this test makes sense though. `ninja
check-clang-codegen` succeeded this time:
Testing Time: 12.77s
Expec
Author: ctice
Date: Fri Sep 21 16:19:49 2018
New Revision: 342789
URL: http://llvm.org/viewvc/llvm-project?rev=342789&view=rev
Log:
Fix codemodels.c test case (only test mcmodel-kernel on x86)
A recent commit I made broke aarch64 testing, because "kernel"
apparently is not a valid code-model on a
Author: aaronpuchert
Date: Fri Sep 21 16:08:30 2018
New Revision: 342787
URL: http://llvm.org/viewvc/llvm-project?rev=342787&view=rev
Log:
Thread safety analysis: Make sure FactEntrys stored in FactManager are
immutable [NFC]
Since FactEntrys are stored in the FactManager, we can't manipulate th
delesley added a comment.
In https://reviews.llvm.org/D51187#1241354, @aaronpuchert wrote:
> Thanks for pointing out my error! Ignoring the implementation for a moment,
> do you think this is a good idea or will it produce too many false positives?
> Releasable/relockable scoped capabilities th
Author: rtrieu
Date: Fri Sep 21 14:20:33 2018
New Revision: 342774
URL: http://llvm.org/viewvc/llvm-project?rev=342774&view=rev
Log:
Make compare function in r342648 have strict weak ordering.
Comparison functions used in sorting algorithms need to have strict weak
ordering. Remove the assert an
gromer added a comment.
OK, the diffs are now un-borked. Sorry for the flailing incompetence.
https://reviews.llvm.org/D51812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
Overall the patch look OK. I'll take a closer look on Monday.
Which mode do you expect will be most commonly used for HIP by default? With
this patch we'll have two different ways to do similar things in HIP vs. CUDA.
E.g. by default CUDA compiles GPU code in each TU in a co
gromer updated this revision to Diff 166558.
https://reviews.llvm.org/D51812
Files:
b/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
Index: b/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
===
--- b/llvm/tools/clang/lib/
smeenai added a comment.
In https://reviews.llvm.org/D52344#1242530, @rjmccall wrote:
> In https://reviews.llvm.org/D52344#1242451, @kristina wrote:
>
> > Would you be okay with me renaming `cfstring` to `.cfstring` for ELF so
> > it's in line with ELF section naming conventions (I'm not entirel
yaxunl updated this revision to Diff 166556.
yaxunl added a comment.
Fix comments.
https://reviews.llvm.org/D52377
Files:
include/clang/Driver/Options.td
include/clang/Driver/Types.def
lib/CodeGen/CGCUDANV.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChai
rjmccall added a reviewer: theraven.
rjmccall added a comment.
In https://reviews.llvm.org/D52344#1242451, @kristina wrote:
> Would you be okay with me renaming `cfstring` to `.cfstring` for ELF so it's
> in line with ELF section naming conventions (I'm not entirely sure if that
> could cause i
gromer updated this revision to Diff 166545.
https://reviews.llvm.org/D51812
Files:
B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
Index: B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
===
--- B/llvm/tools/clang/lib/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342770: [analyzer] Process state in checkEndFunction in
RetainCountChecker (authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342769: [analyzer] Highlight sink nodes in red (authored by
george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52337?vs=166400&
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342769: [analyzer] Highlight sink nodes in red (authored by
george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D52337?vs=166400&i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342768: [analyzer] Associate diagnostics created in
checkEndFunction with a return… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342770: [analyzer] Process state in checkEndFunction in
RetainCountChecker (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342765: [analyzer] [NFC] Dead code removal (authored by
george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D52269?vs=166143&id=16
Author: george.karpenkov
Date: Fri Sep 21 13:37:20 2018
New Revision: 342770
URL: http://llvm.org/viewvc/llvm-project?rev=342770&view=rev
Log:
[analyzer] Process state in checkEndFunction in RetainCountChecker
Modify the RetainCountChecker to perform state "adjustments" in
checkEndFunction, as pe
Author: george.karpenkov
Date: Fri Sep 21 13:36:41 2018
New Revision: 342768
URL: http://llvm.org/viewvc/llvm-project?rev=342768&view=rev
Log:
[analyzer] Associate diagnostics created in checkEndFunction with a return
statement, if possible
If not possible, use the last line of the declaration,
Author: george.karpenkov
Date: Fri Sep 21 13:37:01 2018
New Revision: 342769
URL: http://llvm.org/viewvc/llvm-project?rev=342769&view=rev
Log:
[analyzer] Highlight sink nodes in red
Differential Revision: https://reviews.llvm.org/D52337
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.
Author: george.karpenkov
Date: Fri Sep 21 13:36:21 2018
New Revision: 342767
URL: http://llvm.org/viewvc/llvm-project?rev=342767&view=rev
Log:
[analyzer] [NFC] Prefer make_unique over "new"
Differential Revision: https://reviews.llvm.org/D52336
Modified:
cfe/trunk/lib/StaticAnalyzer/Checker
Author: george.karpenkov
Date: Fri Sep 21 13:36:01 2018
New Revision: 342766
URL: http://llvm.org/viewvc/llvm-project?rev=342766&view=rev
Log:
[analyzer] Fix bug in isInevitablySinking
If the non-sink report is generated at the exit node, it will be
suppressed by the current functionality in isIn
Author: george.karpenkov
Date: Fri Sep 21 13:35:39 2018
New Revision: 342765
URL: http://llvm.org/viewvc/llvm-project?rev=342765&view=rev
Log:
[analyzer] [NFC] Dead code removal
Differential Revision: https://reviews.llvm.org/D52269
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/BugRe
yaxunl created this revision.
yaxunl added a reviewer: tra.
This patch introduced a driver option `--hip-early-finalize`. When enabled,
clang will assume the device code in each translation unit does not call
external functions except those in the device library, therefore it is possible
to compil
kristina added a comment.
Would you be okay with me renaming `cfstring` to `.cfstring` for ELF so it's in
line with ELF section naming conventions (I'm not entirely sure if that could
cause issues with ObjC stuff)? And yes I think it's best to avoid that
code-path altogether if it turns out to
phosek added a comment.
In https://reviews.llvm.org/D45639#1193112, @ldionne wrote:
> @phosek I don't understand how you can expect code compiled with new headers
> to link against an old dylib, unless you're setting the target platform, in
> which case anything that would fail to link will ins
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342764: [libc++abi] is_strcmp parameter to is_equal is
unused for WIN32 (authored by pirama, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52368
rjmccall added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:4108
+ // consistent with old behavior for this target as it would fail
+ // on the cast<> instead.
+ assert(GV && "isa isn't a GlobalValue");
compnerd wrote:
> I think that
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
Hello, please add linebreaks to your commit messages. This commit makes
`git log` look pretty ugly.
On Fri, Sep 21, 2018 at 9:55 AM JF Bastien via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jfb
> Date: Fri Sep 21 06:54:09 2018
> New Revision: 342734
>
> URL: http://llvm.org/viewvc
wgml marked 2 inline comments as done.
wgml added inline comments.
Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:52
+const NamespaceContextVec &Namespaces) {
+ std::ostringstream Result;
+ bool First = true;
aaron.ballman wrote:
> Can thi
wgml updated this revision to Diff 166529.
wgml marked 4 inline comments as done.
wgml edited the summary of this revision.
https://reviews.llvm.org/D52136
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp
clang-tidy/modernize/ConcatNestedNamesp
juliehockett updated this revision to Diff 166526.
juliehockett added a comment.
Adding test case
https://reviews.llvm.org/D52313
Files:
clang-tools-extra/clang-doc/Serialize.cpp
clang-tools-extra/test/clang-doc/bc-record.cpp
clang-tools-extra/test/clang-doc/mapper-record.cpp
clang-tool
pirama updated this revision to Diff 166527.
pirama added a comment.
Simplify patch.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
Files:
src/private_typeinfo.cpp
Index: src/private_typeinfo.cpp
===
--- src/pri
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This looks fine to me, but this definitely should have an accompanying test.
As to the other items you mention, the current section naming actually is
important as it enables the CFString
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342758: Add necessary support for storing code-model to
module IR. (authored by ctice, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52323?v
Author: ctice
Date: Fri Sep 21 11:34:59 2018
New Revision: 342758
URL: http://llvm.org/viewvc/llvm-project?rev=342758&view=rev
Log:
Add necessary support for storing code-model to module IR.
Currently the code-model does not get saved in the module IR, so if a
code model is specified when compili
gromer added inline comments.
Comment at: b/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp:601
+case MaybeFallThrough:
+ if (ReturnsValue)
+S.Diag(RBrace, diag::warn_maybe_falloff_nonvoid_coroutine)
rsmith wrote:
> This `if` and the one belo
erik.pilkington added reviewers: jlebar, Anastasia.
erik.pilkington added subscribers: jlebar, Anastasia.
erik.pilkington added inline comments.
Comment at: clang/include/clang/Basic/Features.def:233
EXTENSION(cxx_variadic_templates, LangOpts.CPlusPlus)
+EXTENSION(cxx_fixed_enum
gromer updated this revision to Diff 166521.
gromer marked 2 inline comments as done.
https://reviews.llvm.org/D51812
Files:
B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
Index: B/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp
==
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
LGTM too.
Thanks again!
Repository:
rC Clang
https://reviews.llvm.org/D52268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
erik.pilkington added a comment.
> There's no reason to make this an `ObjC2`-only feature; we should probably
> eliminate that distinction throughout the compiler.
Sure, I was just writing a proposal to do that:
http://lists.llvm.org/pipermail/cfe-dev/2018-September/059468.html
Repository:
mclow.lists added a comment.
This seems like overkill to me; why not add `(void) use_strcmp` right before
line 67 instead?
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rjmccall added a comment.
In https://reviews.llvm.org/D52339#1242241, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52339#1242202, @erik.pilkington wrote:
>
> > From the last line in the paper, it seems that C++ compatibility is a goal
> > of the paper (or at least a consideration). We sh
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D52268#1241793, @riccibruno wrote:
> In https://reviews.llvm.org/D52268#1241033, @rjmccall wrote:
>
> > `LinkageComputer` isn't actually persisted anywhere, righ
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342752: [CUDA] Fixed parsing of optional
template-argument-list. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52321?vs=166509&id=166512#toc
Repository:
rC Clan
Author: tra
Date: Fri Sep 21 10:46:28 2018
New Revision: 342752
URL: http://llvm.org/viewvc/llvm-project?rev=342752&view=rev
Log:
[CUDA] Fixed parsing of optional template-argument-list.
We need to consider all tokens that start with '>' when
we're checking for the end of an empty template argume
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D52323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
aaron.ballman added a comment.
In https://reviews.llvm.org/D52339#1242202, @erik.pilkington wrote:
> From the last line in the paper, it seems that C++ compatibility is a goal of
> the paper (or at least a consideration). We should probably think about this
> if/when the final wording gets acce
erik.pilkington added inline comments.
Comment at: clang/include/clang/Basic/Features.def:90
FEATURE(objc_default_synthesize_properties, LangOpts.ObjC2)
-FEATURE(objc_fixed_enum, LangOpts.ObjC2)
+FEATURE(objc_fixed_enum, true)
FEATURE(objc_instancetype, LangOpts.ObjC2)
tra updated this revision to Diff 166509.
tra added a comment.
Added '>=' and '>>=' to the list of tokens that may indicate the end of the
empty template argument list.
https://reviews.llvm.org/D52321
Files:
clang/lib/Parse/ParseTemplate.cpp
clang/test/Parser/cuda-kernel-call-c++11.cu
cla
Author: jfb
Date: Fri Sep 21 10:38:41 2018
New Revision: 342750
URL: http://llvm.org/viewvc/llvm-project?rev=342750&view=rev
Log:
[NFC] remove unused variable
It was causing a warning.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
UR
pirama created this revision.
pirama added reviewers: EricWF, srhines, mstorsjo.
Herald added subscribers: libcxx-commits, ldionne, christof.
Mark it as unused to avoid -Wunused-parameter.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D52368
Files:
src/private_typeinfo.cpp
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342749: [CUDA] Ignore uncallable functions when we check for
usual deallocators. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.
erik.pilkington added a comment.
In https://reviews.llvm.org/D52339#1242126, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52339#1242118, @jfb wrote:
>
> > In https://reviews.llvm.org/D52339#1242103, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
>
Author: tra
Date: Fri Sep 21 10:29:33 2018
New Revision: 342749
URL: http://llvm.org/viewvc/llvm-project?rev=342749&view=rev
Log:
[CUDA] Ignore uncallable functions when we check for usual deallocators.
Previously clang considered function variants from both sides of
compilation and that resulted
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:27-32
+ // template
+ // void f(T func) {
+ // func();
+ // ^~~
+ // ::std::invoke(func, 1)
+ Finder->addMatcher(callExpr(has(declRefExpr())).bind("functor"),
grimar added a comment.
To summarise:
- It shares most of the benefits with the .dwo solution.
- Unlike .dwo, there is no need to split the file and it is friendlier to other
tools (ccache, distcc, etc)
- But unlike .dwo a distributed build system has to copy larger .o files.
https://reviews.l
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Parse/ParseTemplate.cpp:949-950
GreaterThanIsOperatorScope G(GreaterThanIsOperator, false);
-if (Tok.isNot(tok::greater) && Tok.isNot(tok::
aaron.ballman added a comment.
In https://reviews.llvm.org/D52339#1242118, @jfb wrote:
> In https://reviews.llvm.org/D52339#1242103, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
> >
> > > I think we should consider proposing this to the C committee.
> > > @
jfb added a comment.
In https://reviews.llvm.org/D52339#1242103, @aaron.ballman wrote:
> In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
>
> > I think we should consider proposing this to the C committee.
> > @aaron.ballman I can help Erik write the paper, would you be able to
> > prese
cmtice updated this revision to Diff 166492.
cmtice edited the summary of this revision.
cmtice added a comment.
Move include statement from CodeGenModule.h to CodeGenModule.cpp
Remove incorrect "default" case statement.
Add test for "tiny" code model.
https://reviews.llvm.org/D52323
Files:
cmtice marked an inline comment as done.
cmtice added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:569
+ .Default(~0u);
+if ((CM != ~0u) && (CM != ~1u)) {
+ llvm::CodeModel::Model codeModel =
static_cast(CM);
tejohnson wro
aaron.ballman added a comment.
In https://reviews.llvm.org/D52339#1242086, @jfb wrote:
> I think we should consider proposing this to the C committee. @aaron.ballman
> I can help Erik write the paper, would you be able to present it? Too tight
> for the upcoming meeting, but I'm guessing we hav
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
When no scope qualifier is specified, allow completing index symbols
from any scope and insert proper automatically. This is still experime
jfb added a comment.
I think we should consider proposing this to the C committee. @aaron.ballman I
can help Erik write the paper, would you be able to present it? Too tight for
the upcoming meeting, but I'm guessing we have *plenty* of time for ++C17.
Repository:
rC Clang
https://reviews.l
sammccall requested changes to this revision.
sammccall added a comment.
This revision now requires changes to proceed.
This change does several things, and I think most of them need further thought.
Can we discuss Monday?
Comment at: clang-tools-extra/clangd/benchmarks/IndexB
tejohnson added a comment.
Note that if you add a line like:
"Depends on https://reviews.llvm.org/D52322"; in the summary that Phabricator
will automatically link the two in the right way.
Comment at: lib/CodeGen/CodeGenModule.cpp:569
+ .Default(~0u);
+if
sammccall added a comment.
In https://reviews.llvm.org/D52300#1241754, @kbobyrev wrote:
> I addressed the easiest issues. I'll try to implement separate storage
> structure for `Head`s and `Payload`s which would potentially make the
> implementation cleaner and easier to understand (and also mo
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:78
+static void DexQueries(benchmark::State &State) {
+ const auto Dex = buildDex();
Why did we move this benchmark (`DexQueries`)? It seems unnecessary.
===
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Whoops, that acceptance was accidental. Pretending I want changes just to make
it clear in Phab. :-)
Repository:
rC Clang
https://reviews.llvm.org/D52339
___
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I really like this idea in general, thank you for proposing this patch!
Comment at: clang/include/clang/Basic/Fea
Author: abataev
Date: Fri Sep 21 07:55:26 2018
New Revision: 342741
URL: http://llvm.org/viewvc/llvm-project?rev=342741&view=rev
Log:
[OPENMP] Disable emission of the class with vptr if they are not used in
target constructs.
Prevent compilation of the classes with the virtual tables when
compili
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/PostingList.cpp:29
+ DecompressedChunk = ChunkIndex->decompress();
+ InnerIndex = begin(DecompressedChunk);
+}
sammccall wrote:
> nit: we generally use members (Decompres
kbobyrev closed this revision.
kbobyrev added a comment.
I think this one is addressed in the VByte patch, so I'm closing this revision
in order to prevent conflicts between these two.
https://reviews.llvm.org/D52084
___
cfe-commits mailing list
cf
kbobyrev updated this revision to Diff 166482.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D52357
Files:
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/unittests/clangd/DexTests.cpp
Index: clang-tools-extra/unittests/clangd/DexTests.cpp
kbobyrev updated this revision to Diff 166481.
kbobyrev marked 3 inline comments as done.
kbobyrev added a comment.
- Be more explicit about the nature of "benchmarks" with memory tracking logic
via `State::SetLabel(...)`.
- Force single iteration for "benchmarks" with memory usage tracking
- Add
1 - 100 of 161 matches
Mail list logo
