devnexen updated this revision to Diff 162139.
devnexen added a comment.
- Returns immediately for both case when sizeof destination.
- Adding few more cases.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340515: [x86/retpoline] Split the LLVM concept of retpolines
into separate (authored by chandlerc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51150?vs=162130&id=162138#toc
Repos
Author: chandlerc
Date: Wed Aug 22 23:06:38 2018
New Revision: 340515
URL: http://llvm.org/viewvc/llvm-project?rev=340515&view=rev
Log:
[x86/retpoline] Split the LLVM concept of retpolines into separate
subtarget features for indirect calls and indirect branches.
This is in preparation for enabli
chandlerc added a comment.
Thanks!
I'm going to go ahead and land this, but happy to iterate on anything if others
have comments.
Repository:
rL LLVM
https://reviews.llvm.org/D51150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
dpayne updated this revision to Diff 162129.
dpayne added a comment.
Adding unit tests to check indents, these were mostly taken from the original
patch https://reviews.llvm.org/D22505.
Repository:
rC Clang
https://reviews.llvm.org/D51120
Files:
docs/ClangFormatStyleOptions.rst
lib/Form
Author: jfb
Date: Wed Aug 22 21:09:49 2018
New Revision: 340511
URL: http://llvm.org/viewvc/llvm-project?rev=340511&view=rev
Log:
Missing quote in previous commit
The test was failing because I missed a quote.
Modified:
cfe/trunk/test/CodeGen/pr18235.c
Modified: cfe/trunk/test/CodeGen/pr182
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D51150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
chandlerc created this revision.
chandlerc added reviewers: echristo, rnk, craig.topper.
Herald added subscribers: hiraditya, mcrosier, sanjoy.
Herald added a reviewer: javed.absar.
This is in preparation for enabling *only* the call retpolines when
using speculative load hardening.
I've continue
Author: jfb
Date: Wed Aug 22 20:55:24 2018
New Revision: 340510
URL: http://llvm.org/viewvc/llvm-project?rev=340510&view=rev
Log:
Improve incompatible triple error
When complaining that the triple is incompatible with all targets, print out
the triple not just a generic error about triples not m
leonardchan added inline comments.
Comment at: lib/Parse/ParseExpr.cpp:1126
+
+Actions.StartCheckingNoDeref();
+
rsmith wrote:
> leonardchan wrote:
> > rsmith wrote:
> > > This parser-driven start/stop mechanism will not work in C++ templates.
> > > Instead,
leonardchan updated this revision to Diff 162126.
leonardchan marked 13 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D49511
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/Diagnosti
Author: george.karpenkov
Date: Wed Aug 22 17:26:59 2018
New Revision: 340502
URL: http://llvm.org/viewvc/llvm-project?rev=340502&view=rev
Log:
[analyzer] Preliminary version of retain count checking for OSObjects
Has quite a lot of false positives, disabled behind the flag.
Differential Revision
pcc added a comment.
With ELF it was around 0.1% for a self-host of Clang. I also checked the
overhead with COFF for Chromium's base_unittests and it was around 0.2% without
debug info. I think that's small enough that we can turn this on by default.
Repository:
rL LLVM
https://reviews.llvm
Author: george.karpenkov
Date: Wed Aug 22 17:02:35 2018
New Revision: 340501
URL: http://llvm.org/viewvc/llvm-project?rev=340501&view=rev
Log:
Revert "[CStringSyntaxChecker] Check strlcat sizeof check"
This reverts commit 3073790e87378fea9a68fb052185fec9596ef135.
The check is not correct, strlac
rnk added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1276
+InitVar->setSection(".CRT$XCLa");
+CGM.addUsedGlobal(InitVar);
+ }
mstorsjo wrote:
> rjmccall wrote:
> > DHowett-MSFT wrote:
> > > rjmccall wrote:
> > > > Is the priority system not go
Author: george.karpenkov
Date: Wed Aug 22 17:02:12 2018
New Revision: 340500
URL: http://llvm.org/viewvc/llvm-project?rev=340500&view=rev
Log:
Revert "[CStringSyntaxChecker] Reduces space around error message for strlcat."
This reverts commit 6b43b80320722da41ca6ef7a3b57cc300fb83094.
Modified:
Might be because the constructed AST for a @finally on Windows will contain a
CapturedStmt: https://reviews.llvm.org/D47564. You probably want to explicitly
specify a non windows-msvc triple in the test.
From: cfe-commits on behalf of Raphael
Isemann via cfe-commits
Reply-To: Raphael Isemann
thakis closed this revision.
thakis added a comment.
r340498, thanks!
https://reviews.llvm.org/D51134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Wed Aug 22 16:53:39 2018
New Revision: 340498
URL: http://llvm.org/viewvc/llvm-project?rev=340498&view=rev
Log:
win: Omit ".exe" from clang and clang-cl driver-level diagnostics.
Like https://reviews.llvm.org/D51133 but for clang.
https://reviews.llvm.org/D51134
Modified:
Author: hans
Date: Wed Aug 22 16:53:29 2018
New Revision: 340496
URL: http://llvm.org/viewvc/llvm-project?rev=340496&view=rev
Log:
Creating release candidate rc2 from release_700 branch
Added:
libunwind/tags/RELEASE_700/rc2/ (props changed)
- copied from r340495, libunwind/branches/re
Author: hans
Date: Wed Aug 22 16:52:36 2018
New Revision: 340490
URL: http://llvm.org/viewvc/llvm-project?rev=340490&view=rev
Log:
Creating release candidate rc2 from release_700 branch
Added:
libcxxabi/tags/RELEASE_700/rc2/ (props changed)
- copied from r340489, libcxxabi/branches/re
Author: hans
Date: Wed Aug 22 16:52:29 2018
New Revision: 340489
URL: http://llvm.org/viewvc/llvm-project?rev=340489&view=rev
Log:
Creating release candidate rc2 from release_700 branch
Added:
libcxx/tags/RELEASE_700/rc2/ (props changed)
- copied from r340488, libcxx/branches/release_
Author: teemperor
Date: Wed Aug 22 16:50:30 2018
New Revision: 340483
URL: http://llvm.org/viewvc/llvm-project?rev=340483&view=rev
Log:
Revert "[ASTImporter] Add test for
ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt"
This test breaks llvm-clang-x86_64-expensive-checks-win.
Removed:
cfe/tru
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: lib/Basic/SourceManager.cpp:1705
// If we haven't found what we want yet, try again, but this time stat()
// each of the files in case the files have changed since we originally
---
arphaman updated this revision to Diff 162106.
arphaman added a comment.
Address review comments.
https://reviews.llvm.org/D50926
Files:
include/clang/Basic/SourceManager.h
lib/Basic/SourceManager.cpp
unittests/Basic/SourceManagerTest.cpp
Index: unittests/Basic/SourceManagerTest.cpp
george.karpenkov reopened this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
This is not correct, `strlcat(dest, "mystr", sizeof(dest))` is perfectly fine,
as can be seen in many examples including strlcat man page.
Repository:
rL LLVM
https://r
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51142
Files:
test/Import/pack-expansion-expr/Inputs/F.cpp
test/Import/pack-expansion-expr/test.cpp
Index: test/Import/pack-e
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340479: [NFC] Add tags file to .gitignore (authored by
george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D50109?vs=162099&id=162
Author: george.karpenkov
Date: Wed Aug 22 16:23:17 2018
New Revision: 340479
URL: http://llvm.org/viewvc/llvm-project?rev=340479&view=rev
Log:
[NFC] Add tags file to .gitignore
Differential Revision: https://reviews.llvm.org/D50109
Modified:
cfe/trunk/.gitignore
Modified: cfe/trunk/.gitigno
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340474: [analyzer] Track the problematic subexpression in
UndefResultChecker (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://revie
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340475: [analyzer] Track non-zero values in ReturnVisitor
(authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D51131?
Author: george.karpenkov
Date: Wed Aug 22 16:17:25 2018
New Revision: 340475
URL: http://llvm.org/viewvc/llvm-project?rev=340475&view=rev
Log:
[analyzer] Track non-zero values in ReturnVisitor
Tracking those can help to provide much better diagnostics in many cases.
In general, most of the visit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340473: [analyzer] [NFC] Minor refactoring of
BugReporterVisitors (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org
Author: george.karpenkov
Date: Wed Aug 22 16:17:02 2018
New Revision: 340474
URL: http://llvm.org/viewvc/llvm-project?rev=340474&view=rev
Log:
[analyzer] Track the problematic subexpression in UndefResultChecker
This is tested in a subsequent commit, which allows tracking those values.
Different
Author: george.karpenkov
Date: Wed Aug 22 16:16:44 2018
New Revision: 340473
URL: http://llvm.org/viewvc/llvm-project?rev=340473&view=rev
Log:
[analyzer] [NFC] Minor refactoring of BugReporterVisitors
Differential Revision: https://reviews.llvm.org/D51130
Modified:
cfe/trunk/lib/StaticAnalyz
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340471: [Driver] Check normalized triples for multiarch
runtime path (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50547?vs=161821&id=162090#toc
Repository:
Author: phosek
Date: Wed Aug 22 15:56:46 2018
New Revision: 340471
URL: http://llvm.org/viewvc/llvm-project?rev=340471&view=rev
Log:
[Driver] Check normalized triples for multiarch runtime path
Previously we only used target triple as provided which matches the
GCC behavior, but it also means tha
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340468: [ASTImporter] Add test for
ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt (authored by teemperor, committed
by ).
Repository:
rC Clang
https://reviews.llvm.org/D51121
Files:
test/Import/objc
Author: teemperor
Date: Wed Aug 22 15:51:37 2018
New Revision: 340468
URL: http://llvm.org/viewvc/llvm-project?rev=340468&view=rev
Log:
[ASTImporter] Add test for ObjCAtTryStmt/ObjCAtCatchStmt/ObjCAtThrowStmt
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: martong, cfe-commi
Author: teemperor
Date: Wed Aug 22 15:50:45 2018
New Revision: 340467
URL: http://llvm.org/viewvc/llvm-project?rev=340467&view=rev
Log:
[ASTImporter] Actually test ArrayInitLoopExpr in the array-init-loop-expr test.
Summary:
The `array-init-loop-expr` test is currently not testing the importing o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340467: [ASTImporter] Actually test ArrayInitLoopExpr in the
array-init-loop-expr test. (authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340466: [ASTImporter] Remove duplicated and dead
CXXNamedCastExpr handling code. (authored by teemperor, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51110?vs=161994&id=162084#toc
Author: teemperor
Date: Wed Aug 22 15:49:32 2018
New Revision: 340466
URL: http://llvm.org/viewvc/llvm-project?rev=340466&view=rev
Log:
[ASTImporter] Remove duplicated and dead CXXNamedCastExpr handling code.
Summary:
`CXXNamedCastExpr` importing is already handled in the respective
`VisitCXXNam
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340465: [ASTImporter] Add test for ObjCTypeParamDecl
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51059
Files:
test/Import/objc-param-decl/Inputs/S.m
test
juliehockett created this revision.
juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri.
Adds a virtual destructor to the base Info class.
https://reviews.llvm.org/D51137
Files:
clang-tools-extra/clang-doc/Representation.h
clang-tools-extra/clang-doc/Serialize.cpp
Index: c
Author: teemperor
Date: Wed Aug 22 15:48:40 2018
New Revision: 340465
URL: http://llvm.org/viewvc/llvm-project?rev=340465&view=rev
Log:
[ASTImporter] Add test for ObjCTypeParamDecl
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: martong, cfe-commits
Differential Revision: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340464: [ASTImporter] Add test for SwitchStmt (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51056?vs=161798&id=16208
Author: teemperor
Date: Wed Aug 22 15:47:10 2018
New Revision: 340464
URL: http://llvm.org/viewvc/llvm-project?rev=340464&view=rev
Log:
[ASTImporter] Add test for SwitchStmt
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: a_sidorin, martong, cfe-commits
Differential Revisio
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340463: [ASTImporter] Add test for ObjCAutoreleasePoolStmt
(authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D51123
Files:
test/Import/objc-autoreleasepool/Inputs
Author: teemperor
Date: Wed Aug 22 15:45:04 2018
New Revision: 340463
URL: http://llvm.org/viewvc/llvm-project?rev=340463&view=rev
Log:
[ASTImporter] Add test for ObjCAutoreleasePoolStmt
Reviewers: a.sidorin, a_sidorin
Reviewed By: a_sidorin
Subscribers: martong, cfe-commits
Differential Revis
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Nice, thanks!
https://reviews.llvm.org/D51134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Quuxplusone created this revision.
Herald added a subscriber: cfe-commits.
Rename `HasMutableFields` to `HasMutableSubobject` for accuracy.
This bitflag is set whenever the record type has a mutable subobject,
regardless of whether that subobject is a direct member, or a member
of some b
thakis created this revision.
thakis added a reviewer: hans.
Like https://reviews.llvm.org/D51133 but for clang.
https://reviews.llvm.org/D51134
Files:
clang/tools/driver/driver.cpp
Index: clang/tools/driver/driver.cpp
===
---
aaronpuchert added inline comments.
Comment at: lib/Analysis/ThreadSafety.cpp:932
+ // We're relocking the underlying mutexes. Warn on double locking.
+ if (FSet.findLock(FactMan, UnderCp))
+Handler.handleDoubleLock(DiagKind, UnderCp.toString(), entry.loc());
--
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Thank you for working on this!
Repository:
rC Clang
https://reviews.llvm.org/D51056
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: aaronpuchert
Date: Wed Aug 22 15:14:53 2018
New Revision: 340459
URL: http://llvm.org/viewvc/llvm-project?rev=340459&view=rev
Log:
Thread safety analysis: Allow relockable scopes
Summary:
It's already allowed to prematurely release a scoped lock, now we also
allow relocking it again, poss
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Wow, I totally overlooked this. Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D51115
___
cfe-commits mailing list
cfe-commits
tra added a comment.
`__clang_cuda_device_functions.h` is not intended to be a device-side math.h,
despite having a lot of overlap/similarities. It may change at any time we get
new CUDA version.
I would suggest writing an OpenMP-specific replacement for math.h which would
map to whatever devic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340459: Thread safety analysis: Allow relockable scopes
(authored by aaronpuchert, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49885
Files:
lebedev.ri updated this revision to Diff 162050.
lebedev.ri added a subscriber: chandlerc.
lebedev.ri added a comment.
Rebased ontop of https://reviews.llvm.org/D50901, added
- ``-fsanitize=implicit-integer-arithmetic-value-change``: Catches implicit
conversions that change the arithmetic
Author: aaronpuchert
Date: Wed Aug 22 14:06:04 2018
New Revision: 340452
URL: http://llvm.org/viewvc/llvm-project?rev=340452&view=rev
Log:
[NFC] Test commit
Modified:
cfe/trunk/lib/Analysis/ThreadSafety.cpp
Modified: cfe/trunk/lib/Analysis/ThreadSafety.cpp
URL:
http://llvm.org/viewvc/llvm-p
greened added a comment.
Ping?
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz accepted this revision.
beanz added a comment.
LGTM as-is
Comment at: clang/lib/Driver/ToolChain.cpp:372
- const Driver &D = getDriver();
- SmallString<128> P(D.ResourceDir);
- llvm::sys::path::append(P, D.getTargetTriple(), "lib");
- if (getVFS().exists(P)) {
+ fo
arphaman added a comment.
In https://reviews.llvm.org/D50571#1208635, @joaotavora wrote:
> In https://reviews.llvm.org/D50571#1206020, @arphaman wrote:
>
> > In https://reviews.llvm.org/D50571#1205650, @joaotavora wrote:
> >
> > > > LGTM. Let's watch out for possible breakages in any of the clien
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340449: [clangd] send diagnostic categories only when
'categorySupport' (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
Author: arphaman
Date: Wed Aug 22 13:30:06 2018
New Revision: 340449
URL: http://llvm.org/viewvc/llvm-project?rev=340449&view=rev
Log:
[clangd] send diagnostic categories only when 'categorySupport'
capability was given by the client
After r339738 Clangd started sending categories with each diagn
lebedev.ri updated this revision to Diff 162040.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
Rebased, addressed @vsk review note, should be NFC.
@vsk thank you for taking a look!
> LebedevRI: It looks like it's in good shape. I wasn't around for
> the discussion re
NoQ added a comment.
In https://reviews.llvm.org/D48027#1207721, @rnkovacs wrote:
> I guess it is highly unlikely for someone to write namespaces like that, and
> if they do, I think they deserve to have them treated as a `std::string`.
Yup. On the other hand, if we specify our method as `{"ba
On Wed, 22 Aug 2018 at 06:55, Anastasia Stulova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Richard,
>
> > This is incorrect. Implicit function declarations declare unprototyped
> functions, which are *not* variadic, and are in fact supported by Clang's
> OpenCL language mode.
>
> We
teemperor added inline comments.
Comment at: test/Import/objc-try-catch/Inputs/F.m:9
+Exception *e;
+@throw e;
+ }
We usually should create a expression here, but the ObjCMessageExpr isn't
implemented yet, so this bit weird code has to do the job.
Rep
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51123
Files:
test/Import/objc-autoreleasepool/Inputs/F.m
test/Import/objc-autoreleasepool/test.m
Index: test/Import/objc-aut
teemperor added a comment.
Turns out, the clang-import-test actually allows passing clang args via `-Xcc`,
so I probably will revert the lang options changes I did in the previous
commits.
Repository:
rC Clang
https://reviews.llvm.org/D51121
__
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51121
Files:
test/Import/objc-try-catch/Inputs/F.m
test/Import/objc-try-catch/test.m
Index: test/Import/objc-try-catch/test.
dpayne created this revision.
dpayne added reviewers: klimek, djasper.
Herald added subscribers: cfe-commits, mgorny.
Hi,
This is another attempt at fixing the issue describe here
https://reviews.llvm.org/D22505. Some code bases will have an extra indent for
member variables and functions, whil
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:419
+ case CK_LValueBitCast:
+ case CK_FixedPointCast: {
state =
a.sidorin wrote:
> Should we consider this construction as unsupported rather than supported as
> a
Author: eandrews
Date: Wed Aug 22 12:05:19 2018
New Revision: 340439
URL: http://llvm.org/viewvc/llvm-project?rev=340439&view=rev
Log:
Currently clang does not emit unused static constants. GCC emits these
constants by default when there is no optimization.
GCC's option -fno-keep-static-consts ca
smeenai added a subscriber: rnk.
smeenai added a comment.
Sorry for the belated response; I was on vacation.
I'm confused by the funclet-based unwinding support. Do you intend GNUStep to
be used with windows-msvc triples? If so, how is the runtime throwing
exceptions? We took the approach of ha
lebedev.ri added inline comments.
Comment at:
test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c:23
+__attribute__((no_sanitize("integer"))) unsigned char
blacklist_1_convert_unsigned_int_to_unsigned_char(unsigned int x) {
+ // CHECK: }
+ return x;
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340439: Currently clang does not emit unused static
constants. GCC emits these (authored by eandrews, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40925?vs=161544&id=162022#toc
Re
vsk added inline comments.
Comment at:
test/CodeGen/catch-implicit-integer-truncations-basics-negatives.c:23
+__attribute__((no_sanitize("integer"))) unsigned char
blacklist_1_convert_unsigned_int_to_unsigned_char(unsigned int x) {
+ // CHECK: }
+ return x;
I
Merged to 7.0 in r340437.
On Tue, Aug 14, 2018 at 3:04 AM, David Chisnall via cfe-commits
wrote:
> Author: theraven
> Date: Tue Aug 14 03:04:36 2018
> New Revision: 339667
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339667&view=rev
> Log:
> Add a stub mangling for ObjC selectors in the Micro
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
The `array-init-loop-expr` test is currently not testing the importing of
ArrayInitLoopExprs.
This is because we import the `S` struct into the `test.cpp` context
and only do a co
Author: rnk
Date: Wed Aug 22 10:47:41 2018
New Revision: 340427
URL: http://llvm.org/viewvc/llvm-project?rev=340427&view=rev
Log:
Disable the aligned allocation test on old mac versions instead of XFAILing it
It looks like this test XPASSes when the deployment target is older than
the OS of the s
Author: ericwf
Date: Wed Aug 22 10:47:13 2018
New Revision: 340426
URL: http://llvm.org/viewvc/llvm-project?rev=340426&view=rev
Log:
Add diagnostics for min/max algorithms when a InputIterator is used.
These algorithms require a ForwardIterator or better. Ensure
we diagnose the contract violation
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340424: [Android] Default to -fno-math-errno (authored by
pirama, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51068
Files:
cfe/trunk/lib/Dr
Author: pirama
Date: Wed Aug 22 10:43:05 2018
New Revision: 340424
URL: http://llvm.org/viewvc/llvm-project?rev=340424&view=rev
Log:
[Android] Default to -fno-math-errno
Summary: Android's libm does not set errno.
Reviewers: srhines, enh
Subscribers: cfe-commits
Differential Revision: https://
teemperor added a comment.
See
http://lab.llvm.org:8080/coverage/coverage-reports/clang/coverage/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/AST/ASTImporter.cpp.html#L6044
for the test coverage entry.
Repository:
rC Clang
https://reviews.llvm.org/D51110
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
`CXXNamedCastExpr` importing is already handled in the respective
`VisitCXXNamedCastExpr` method.
So this code here can never be reached under normal circumstances and we might
as
hugoeg updated this revision to Diff 161995.
hugoeg marked 2 inline comments as done.
https://reviews.llvm.org/D51061
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/StrCatAppendCheck.cpp
clang-tidy/abseil/StrCatAppendCheck.h
docs/Release
kito-cheng updated this revision to Diff 161990.
kito-cheng added a comment.
Herald added subscribers: jocewei, the_o, brucehoult, MartinMosbeck, mgrang,
edward-jones, zzheng, niosHD, sabuasal, simoncook, johnrusso, rbar.
Changes:
- Add test.
https://reviews.llvm.org/D50043
Files:
lib/Drive
MaskRay created this revision.
MaskRay added reviewers: rupprecht, alexshap, jhenderson.
Herald added a subscriber: cfe-commits.
This is to accommodate a change in llvm/lib/Option/OptTable.cpp
https://reviews.llvm.org/D51009
Repository:
rC Clang
https://reviews.llvm.org/D51109
Files:
lib/
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:70
+
+ Flags uses of ``absl::StrCat()`` to append to a std::string. Suggests
+ ``absl::StrAppend()`` should be used instead.
Please enclose std::string into ``
Comment a
Author: chh
Date: Wed Aug 22 10:13:40 2018
New Revision: 340421
URL: http://llvm.org/viewvc/llvm-project?rev=340421&view=rev
Log:
[Tooling] Allow -flto flags and filter out -Wa, flags
This change fixes the problem in https://bugs.llvm.org/show_bug.cgi?id=38332
by allowing driver::Action::BackendJ
gregrodgers added a comment.
I like the idea of using an automatic include as a cc1 option (-include).
However, I would prefer a more general automatic include for OpenMP, not just
for math functions (__clang_cuda_device_functions.h). Clang cuda automatically
includes __clang_cuda_runtime_wrap
hugoeg updated this revision to Diff 161982.
https://reviews.llvm.org/D51061
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/StrCatAppendCheck.cpp
clang-tidy/abseil/StrCatAppendCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/abseil
Author: hans
Date: Wed Aug 22 09:39:24 2018
New Revision: 340419
URL: http://llvm.org/viewvc/llvm-project?rev=340419&view=rev
Log:
Merging r340406:
r340406 | ericwf | 2018-08-22 15:29:52 +0200 (Wed, 22 Aug 2018) | 12 lines
A
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-str-cat-append.cpp:91
+
+void bar() {
+ std::string a, b;
hugoeg wrote:
> JonasToth wrote:
> > What happens if `StrCat` is used e.g. in an `std::accumulate` call as the
> > binary operator? (ht
hokein added inline comments.
Comment at: clangd/index/Index.h:46
+
+inline bool operator==(const SymbolLocation::Position &L,
+ const SymbolLocation::Position &R) {
ilya-biryukov wrote:
> NIT: having friend decls inside the classes themselv
hugoeg updated this revision to Diff 161974.
hugoeg added a comment.
minor fixes
https://reviews.llvm.org/D51061
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/StrCatAppendCheck.cpp
clang-tidy/abseil/StrCatAppendCheck.h
docs/ReleaseNot
dschuff added a comment.
This should probably have some tests. It looks like there are some existing x32
tests in test/Driver/linux-header-search.cpp and test/Driver/cross-linux.c that
might be relevant for updating.
Repository:
rC Clang
https://reviews.llvm.org/D43630
__
1 - 100 of 201 matches
Mail list logo
