Re: r338627 - [test] Fix %hmaptool path for standalone builds

Merged to 7.0 in r339102. On Wed, Aug 1, 2018 at 10:38 PM, Michal Gorny via cfe-commits wrote: > Author: mgorny > Date: Wed Aug 1 13:38:22 2018 > New Revision: 338627 > > URL: http://llvm.org/viewvc/llvm-project?rev=338627&view=rev > Log: > [test] Fix %hmaptool path for standalone builds > > Fix

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

hans added a comment. What do you other reviewers say? I'm not familiar with this code, but this seems reasonable to me. Repository: rCXXA libc++abi https://reviews.llvm.org/D50170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D50349: Port getStartLoc -> getBeginLoc

hans added a comment. In https://reviews.llvm.org/D50349#1190029, @rsmith wrote: > +Hans (release manager for LLVM 7) > > Hans, this patch series will affect the API of common Clang classes, > resulting in patches to Clang SVN needing some (mechanical) modifications to > be applied to the Clang

r339093 - Auto var init test fix #2

Author: jfb Date: Mon Aug 6 21:44:13 2018 New Revision: 339093 URL: http://llvm.org/viewvc/llvm-project?rev=339093&view=rev Log: Auto var init test fix #2 It turns out that the AVX bots have different alignment for their vectors, and my test mistakenly assumed a particular vector alignent on th

[PATCH] D50088: [Sema] Fix an error with C++17 auto non-type template parameters

erik.pilkington updated this revision to Diff 159449. erik.pilkington retitled this revision from "[Sema] Dig through AutoTypes that have been deduced to an undeduced AutoType in Type::isUndeducedType" to "[Sema] Fix an error with C++17 auto non-type template parameters". erik.pilkington edited t

r339090 - Remove broken command flag

Author: jfb Date: Mon Aug 6 21:03:03 2018 New Revision: 339090 URL: http://llvm.org/viewvc/llvm-project?rev=339090&view=rev Log: Remove broken command flag I was using it for testing, r339089 shouldn't have contained it. Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/t

[PATCH] D45045: [DebugInfo] Generate debug information for labels.

HsiangKai added a comment. In https://reviews.llvm.org/D45045#1189201, @vext01 wrote: > Hi, > > I've been experimenting some more with this patch. > > It seems to me that if a label is optimised away, but you've requested it be > preserved, then you get a DWARF label with a zero offset. Is that

[PATCH] D50361: [NFC] Test automatic variable initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rC339089: [NFC] Test automatic variable initialization (authored by jfb, committed by ). Changed prior to commit: https://reviews.llvm.org/D50361?vs=159397&id=159448#toc Repository: rC Clang https://r

r339089 - [NFC] Test automatic variable initialization

Author: jfb Date: Mon Aug 6 20:12:52 2018 New Revision: 339089 URL: http://llvm.org/viewvc/llvm-project?rev=339089&view=rev Log: [NFC] Test automatic variable initialization Summary: r337887 started using memset for automatic variable initialization where sensible. A follow-up discussion leads

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

pcc added a comment. Please upload patches with context. `arc diff` will do this for you. Comment at: clang/docs/ControlFlowIntegrityDesign.rst:277 +Forward-Edge CFI for Virtual Calls by Interleaving Virtual Tables +

[PATCH] D50363: [analyzer] pr37204: Take signedness into account in BasicValueFactory::getTruthValue().

This revision was automatically updated to reflect the committed changes. Closed by commit rC339088: [analyzer] pr37204: Take signedness into account in getTruthValue(). (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D50363?vs=159435&id=159446#toc Rep

r339088 - [analyzer] pr37204: Take signedness into account in getTruthValue().

Author: dergachev Date: Mon Aug 6 19:27:38 2018 New Revision: 339088 URL: http://llvm.org/viewvc/llvm-project?rev=339088&view=rev Log: [analyzer] pr37204: Take signedness into account in getTruthValue(). It now actually produces a signed APSInt when the QualType passed into it is signed, which i

[PATCH] D49627: [CFG] [analyzer] Constructors of member CXXOperatorCallExpr's argument 0 are not argument constructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rC339087: [analyzer] NFC: Document that we support implicit argument constructors. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D49627 Files: include/clang/Ana

Re: r338301 - Avoid returning an invalid end source loc

test case? On Mon, Jul 30, 2018 at 1:39 PM Stephen Kelly via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: steveire > Date: Mon Jul 30 13:39:14 2018 > New Revision: 338301 > > URL: http://llvm.org/viewvc/llvm-project?rev=338301&view=rev > Log: > Avoid returning an invalid end source

r339087 - [analyzer] NFC: Document that we support implicit argument constructors.

Author: dergachev Date: Mon Aug 6 19:22:59 2018 New Revision: 339087 URL: http://llvm.org/viewvc/llvm-project?rev=339087&view=rev Log: [analyzer] NFC: Document that we support implicit argument constructors. The change in the AST in r338135 caused us to accidentally support inlining constructors

[PATCH] D50372: Introduce the VTable interleaving scheme to the CFI design documentation

zhaomo created this revision. zhaomo added reviewers: pcc, vlad.tsyrklevich. Herald added a subscriber: cfe-commits. Dimitar et. al. in [1] proposed a novel VTable layout scheme that enables efficient implementation of virtual call CFI. This patch adds an introduction of this scheme to the CFI d

[PATCH] D50291: [C++] Delay checking of constexpr-ness for special members.

rsmith added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:6045 // Inform the class that we've finished declaring this member. Record->finishedDefaultedOrDeletedMember(M); M->setTrivialForCall( Your new handling should go

[PATCH] D41284: [Concepts] Associated constraints infrastructure.

rsmith added inline comments. Comment at: lib/AST/DeclTemplate.cpp:203 + +Expr *TemplateDecl::getAssociatedConstraints() { + return getOrCollectAssociatedConstraints(getASTContext(), Rather than producing an `Expr*` (which will presumably eventually need to con

[PATCH] D41217: [Concepts] Concept Specialization Expressions

rsmith added inline comments. Comment at: include/clang/AST/ExprCXX.h:4420 + /// \brief The concept named. + ConceptDecl *NamedConcept; + You should also track the `FoundDecl` and the optional `NestedNameSpecifierLoc` (just like a `DeclRefExpr` would). Clang-b

[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

efriedma added a comment. I mean, which of the callers of startFrontendTimer() is calling it with a pointer to std::declval()? https://reviews.llvm.org/D47196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D50363: [analyzer] pr37204: Take signedness into account in BasicValueFactory::getTruthValue().

NoQ updated this revision to Diff 159435. NoQ added a comment. Whoops, how did this `T, ` thing get in there. https://reviews.llvm.org/D50363 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h test/Analysis/casts.c test/Analysis/std-c-library-functions-inlined.c

[PATCH] D40381: Parse concept definition

rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:3007 +/// \brief Definition of concept, not just declaration actually. +class ConceptDecl : public TemplateDecl { This comment isn't appropriate. Please just describe what the node is. (

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

This revision was automatically updated to reflect the committed changes. Closed by commit rL339080: Changed how LLVM IR was generated to increase vectorization (authored by emmettneyman, committed by ). Changed prior to commit: https://reviews.llvm.org/D50342?vs=159425&id=159427#toc Repositor

r339080 - Changed how LLVM IR was generated to increase vectorization

Author: emmettneyman Date: Mon Aug 6 16:11:38 2018 New Revision: 339080 URL: http://llvm.org/viewvc/llvm-project?rev=339080&view=rev Log: Changed how LLVM IR was generated to increase vectorization Summary: Changed the structure of the generated IR to make it easier to vectorize Reviewers: mor

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

emmettneyman updated this revision to Diff 159425. emmettneyman added a comment. Rebased and ready to land Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_

[PATCH] D50111: [analyzer] Add ASTContext to CheckerManager

This revision was automatically updated to reflect the committed changes. Closed by commit rC339079: [analyzer] Add ASTContext to CheckerManager (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D50111?vs=158

r339079 - [analyzer] Add ASTContext to CheckerManager

Author: george.karpenkov Date: Mon Aug 6 16:09:07 2018 New Revision: 339079 URL: http://llvm.org/viewvc/llvm-project?rev=339079&view=rev Log: [analyzer] Add ASTContext to CheckerManager Some checkers require ASTContext. Having it in the constructor saves a lot of boilerplate of having to pass it

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:6522 +bool HasDifferingLAddrSpace = LAddrSpace != ResultAddrSpace; +bool HasDifferingRAddrSpace = RAddrSpace != ResultAddrSpace; + I was going to tell you to use the predicate `Qualifiers:

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

emmettneyman updated this revision to Diff 159421. emmettneyman added a comment. Some small fixes to improve simplicity of generated IR Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index: clang/tools/clang-fuzze

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:127 +<< "define void @foo(i32* %a, i32* %b, i32* %c, i64 %s) {\n" +<< "%1 = icmp sgt i64 %s, 0\n" +<< "br i1 %1, label %start, label %

[PATCH] D43357: [Concepts] Function trailing requires clauses

rsmith added a comment. Looking promising, but this patch will need some rework: you need to track the trailing requires clause on the `Declarator` itself, not on the `DeclChunk`, because it's not part of the `DeclChunk` (and may appear in contexts where there is no function chunk).

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL339074: [lit, python] Always add quotes around the python path in lit (authored by stella.stamenova, committed by ). Heral

r339074 - [lit, python] Always add quotes around the python path in lit

Author: stella.stamenova Date: Mon Aug 6 15:37:45 2018 New Revision: 339074 URL: http://llvm.org/viewvc/llvm-project?rev=339074&view=rev Log: [lit, python] Always add quotes around the python path in lit Summary: The issue with the python path is that the path to python on Windows can contain s

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:127 +<< "define void @foo(i32* %a, i32* %b, i32* %c, i64 %s) {\n" +<< "%1 = icmp sgt i64 %s, 0\n" +<< "br i1 %1, label %start, label %end

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 159409. leonardchan marked 3 inline comments as done. leonardchan added a comment. - Changed tick to single quote in diagnostic Repository: rC Clang https://reviews.llvm.org/D49511 Files: include/clang/AST/Type.h include/clang/Basic/Attr.td inc

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

rnkovacs added a comment. In https://reviews.llvm.org/D50211#1190146, @NoQ wrote: > Welcome to the club! :D Thanks, makes me feel better. https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

NoQ added a comment. Welcome to the club! https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

rnkovacs closed this revision. rnkovacs added a comment. Committed in r339067, I just messed up the revision-closing line in the commit message. https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D50363: [analyzer] pr37204: Take signedness into account in BasicValueFactory::getTruthValue().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware, eraman. I don't see why BasicValueFactory::getTruthValue(bool, QualType) always returns an unsigned `A

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

leonardchan updated this revision to Diff 159405. leonardchan marked an inline comment as done. leonardchan added a comment. - Replaced instances of a `pointer type mismatch` warning involving 2 conditional operands with different address spaces with a new error specifically for this situation.

r339067 - [analyzer] InnerPointerChecker: fix displayed checker name.

Author: rkovacs Date: Mon Aug 6 15:03:42 2018 New Revision: 339067 URL: http://llvm.org/viewvc/llvm-project?rev=339067&view=rev Log: [analyzer] InnerPointerChecker: fix displayed checker name. For InnerPointerChecker to function properly, both the checker itself and parts of MallocChecker that h

[PATCH] D50361: [NFC] Test automatic variable initialization

jfb added a comment. I'm honestly not sure there's anything to review here since it's just showing us what the current behavior is. LMK if I'm not testing something that I should. I'd much rather test current behavior as one patch first, because then the follow-ups show a clear before / after d

[PATCH] D48661: [Fixed Point Arithmetic] Fixed Point Constant

bricci added a comment. Added some comments inline. However I have not looked at the logic too closely and have not looked at the tests at all. Comment at: cfe/trunk/include/clang/AST/ASTContext.h:1966 unsigned char getFixedPointIBits(QualType Ty) const; + FixedPointSemant

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

This revision was automatically updated to reflect the committed changes. Closed by commit rC339063: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the… (authored by simark, committed by ). Changed prior to commit: https://reviews.llvm.org/D48903?vs=158625&id=159401#toc R

r339063 - [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

Author: simark Date: Mon Aug 6 14:48:20 2018 New Revision: 339063 URL: http://llvm.org/viewvc/llvm-project?rev=339063&view=rev Log: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name Summary: InMemoryFileSystem::status behaves differently than RealFileSystem

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

simark added a comment. In https://reviews.llvm.org/D48903#1189056, @ilya-biryukov wrote: > I see, thanks for the explanation. > > LGTM for the update revision, given we have confirmation the tests pass on > Windows. Thanks, I'll push it, let's hope this time is the right time! Repository:

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added a comment. You might want to ask Richard on IRC if there are caveats when using that for these purposes. Repository: rC Clang https://reviews.llvm.org/D50152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Szelethus added a comment. I'll be back in office tomorrow, about ~13 hours later. But feel free to commit it on my behalf if it's urgent. https://reviews.llvm.org/D49438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1643 +if (Ctx.getBlockVarCopyInits(VD)) + return true; + return false; ahatanak wrote: > ahatanak wrote: > > rjmccall wrote: > > > Can you just ask Sema to check `canThrow` for the exp

[PATCH] D50361: [NFC] Test automatic variable initialization

jfb created this revision. Herald added subscribers: cfe-commits, dexonsmith. r337887 started using memset for automatic variable initialization where sensible. A follow-up discussion leads me to believe that we should better test automatic variable initialization, and that there are probably fo

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

george.karpenkov added a comment. @Szelethus in any case, could you commit this change for now? I'm very keen on seeing the results on a few of our internal projects, and it's much easier to do that once the change is committed. https://reviews.llvm.org/D49438 __

[PATCH] D50281: [lit, python] Always add quotes around the python path in lit

stella.stamenova updated this revision to Diff 159395. Repository: rC Clang https://reviews.llvm.org/D50281 Files: test/Tooling/clang-diff-json.cpp Index: test/Tooling/clang-diff-json.cpp === --- test/Tooling/clang-diff-json.c

Re: r337005 - [NFC] Rename clang::AttributeList to clang::ParsedAttr

Thank you. Michael 2018-08-06 13:13 GMT-05:00 Keane, Erich : > Good grief... I even made a note to remove this 'TODO' on my whiteboard! > > I discussed the name with AaronBallman who preferred ParsedAttr over > ParsedAttribute (since ParsedAttributes is also a type). > > Fixed in r339039. > > -

[PATCH] D50349: Port getStartLoc -> getBeginLoc

rsmith added a comment. +Hans (release manager for LLVM 7) Hans, this patch series will affect the API of common Clang classes, resulting in patches to Clang SVN needing some (mechanical) modifications to be applied to the Clang 7 release branch if we land it now. What do you think about that?

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth added a comment. In https://reviews.llvm.org/D45444#1189262, @aaron.ballman wrote: > However, I'm wondering how this should integrate with other const-correctness > efforts like `readability-non-const-parameter`? I think this check/functionality will kinda replace the `readability-n

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1643 +if (Ctx.getBlockVarCopyInits(VD)) + return true; + return false; ahatanak wrote: > rjmccall wrote: > > Can you just ask Sema to check `canThrow` for the expression and pass it >

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 159390. JonasToth marked 4 inline comments as done. JonasToth added a comment. - address review issues, todos/fixmes and diag nit Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:183 + // TODO Implement automatic code transformation to add the 'const'. + diag(Variable->getLocStart(), "variable %0 of type %1 can

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:147 + // Example: `int i = 10`, `int i` (will be used if program is correct) + const auto LocalValDecl = varDecl(unless(anyOf( +

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

emmettneyman updated this revision to Diff 159389. emmettneyman added a comment. Added back more descriptive variable and loop names Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index: clang/tools/clang-fuzzer/p

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1643 +if (Ctx.getBlockVarCopyInits(VD)) + return true; + return false; rjmccall wrote: > Can you just ask Sema to check `canThrow` for the expression and pass it down? Since this chang

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

ahatanak updated this revision to Diff 159388. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Repository: rC Clang https://reviews.llvm.org/D50152 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGBlocks.h lib/CodeGen/CGDecl.cpp lib/CodeGen/

[PATCH] D50359: Add a new library, libclang-cxx

pirama added a comment. This implements the new library proposed in http://lists.llvm.org/pipermail/cfe-dev/2018-August/058736.html. Repository: rC Clang https://reviews.llvm.org/D50359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D50359: Add a new library, libclang-cxx

pirama created this revision. Herald added a subscriber: mgorny. The current libclang.so exports only the symbols required for the stable C api. This is opposed to libLLVM.so, which exports all the symbols from the LLVM libraries, including those from the C++ API. This patch adds libclang-cxx.so

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Szelethus added a comment. If we ignore references, check whether the pointee was constructed within the constructor, and maybe add some other clever heuristics, I'm very much in favor of enabling pointer chasing by enabled. But I totally support disabling it for now. https://reviews.llvm.org

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

rjmccall added inline comments. Comment at: test/Sema/conditional-expr.c:78 + // expected-error@-1{{converting '__attribute__((address_space(2))) int *' to type 'void *' changes address space of pointer}} + // expected-error@-2{{conve

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Szelethus added a comment. In https://reviews.llvm.org/D49438#1189772, @george.karpenkov wrote: > > I think what pointer chasing should do, is check whether that pointer owns > > the pointee > > But ownership is a convention, and it's not always deducible from a codebase. How about the followi

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

leonardchan added a comment. In https://reviews.llvm.org/D50278#1189919, @rjmccall wrote: > I would expect this to replace the existing warning, not to appear together > with it. Will do. Comment at: test/Sema/conditional-expr.c:78 + // expected-error@

[PATCH] D50352: Mark up deprecated methods as such

teemperor added a comment. I don't think Clang/LLVM use `[[deprecated]]` anywhere. Just change the API and people have to migrate their code. Repository: rC Clang https://reviews.llvm.org/D50352 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D44352: [Concepts] Constrained template parameters

saar.raz updated this revision to Diff 159378. saar.raz added a comment. Split TryParseConstrainedParameter and ParseConstrainedTemplateParameter in preparation for requries expressions. Repository: rC Clang https://reviews.llvm.org/D44352 Files: include/clang/AST/DeclTemplate.h include

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:129 +<< "br i1 %5, label %6, label %8\n" +<< "; :6:\n" +<< "br label %9\n" emmettneyman wrote: > morehouse wrote: > > Do

[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1630 +if (const CXXDestructorDecl *DD = RD->getDestructor()) + if (const auto FPT = DD->getType()->getAs()) +// Conservatively assume the destructor can throw if the exception I

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

rjmccall added inline comments. Comment at: test/Sema/conditional-expr.c:78 + // expected-error@-1{{converting '__attribute__((address_space(2))) int *' to type 'void *' changes address space of pointer}} + // expected-error@-2{{conve

[PATCH] D50278: [Sema] Fix for crash on conditional operation with address_space pointer

rjmccall added a comment. I would expect this to replace the existing warning, not to appear together with it. Repository: rC Clang https://reviews.llvm.org/D50278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Sure, that's fine. https://reviews.llvm.org/D49952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

emmettneyman updated this revision to Diff 159373. emmettneyman added a comment. Changed pc to unknown Repository: rC Clang https://reviews.llvm.org/D50342 Files: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp Index: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llv

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:125 std::ostream &operator<<(std::ostream &os, const LoopFunction &x) { - return os << "define void @foo(i32* %a, i32* %b, i32* noalias %c, i64 %s) {\n" -<

[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

teemperor resigned from this revision. teemperor added a comment. This revision now requires review to proceed. Woops, I wanted to resign actually (and not accept this). Repository: rC Clang https://reviews.llvm.org/D50347 ___ cfe-commits mailing

[PATCH] D50199: [MinGW] Predefine UNICODE if -municode is specified during compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rC339048: [MinGW] Predefine UNICODE if -municode is specified during compilation (authored by mstorsjo, committed by ). Repository: rC Clang https://reviews.llvm.org/D50199 Files: lib/Driver/ToolChain

r339048 - [MinGW] Predefine UNICODE if -municode is specified during compilation

Author: mstorsjo Date: Mon Aug 6 12:48:44 2018 New Revision: 339048 URL: http://llvm.org/viewvc/llvm-project?rev=339048&view=rev Log: [MinGW] Predefine UNICODE if -municode is specified during compilation Differential Revision: https://reviews.llvm.org/D50199 Modified: cfe/trunk/lib/Driver/

[PATCH] D50355: Port getLocEnd -> getEndLoc

steveire created this revision. Herald added subscribers: cfe-commits, kbarton, ioeric, nemanjai. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50355 Files: change-namespace/ChangeNamespace.cpp clang-move/ClangMove.cpp clang-tidy/android/CloexecCheck.cpp clang-tidy/bugpr

[PATCH] D50353: Remove deprecated API

steveire created this revision. Herald added a reviewer: teemperor. Herald added a subscriber: cfe-commits. Herald added a reviewer: teemperor. Repository: rC Clang https://reviews.llvm.org/D50353 Files: include/clang/AST/Comment.h include/clang/AST/Decl.h include/clang/AST/DeclBase.h

[PATCH] D50350: Port getLocStart -> getBeginLoc

steveire created this revision. Herald added subscribers: cfe-commits, jfb, whisperity, jholewinski. Herald added a reviewer: teemperor. Repository: rC Clang https://reviews.llvm.org/D50350 Files: docs/RAVFrontendAction.rst include/clang/AST/Comment.h include/clang/AST/Decl.h include/c

[PATCH] D50348: :Add getEndLoc API to replace getLocEnd

steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50348 Files: include/clang/AST/Comment.h include/clang/AST/Decl.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/DeclObjC.h include/cla

[PATCH] D50349: Port getStartLoc -> getBeginLoc

steveire created this revision. Herald added a reviewer: teemperor. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50349 Files: include/clang/AST/Decl.h lib/AST/ASTImporter.cpp lib/Analysis/CloneDetection.cpp lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D50347: Add getBeginLoc API to replace getStartLoc

steveire created this revision. Herald added a reviewer: teemperor. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50347 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h include/clang/Analysis/CloneDetection.h lib/CodeGen/CoverageMappi

[PATCH] D50346: Add getBeginLoc API to replace getLocStart

steveire created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D50346 Files: include/clang/AST/Comment.h include/clang/AST/Decl.h include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/DeclObjC.h include/cla

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

bviyer marked an inline comment as done. bviyer added a comment. John, I have updated the test case as you requested (I think). I am a bit new to Clang, so apologize if I mistook your request. https://reviews.llvm.org/D49952 ___ cfe-commits mailing

[PATCH] D49952: Check for NULL Destination-Type when creating ArrayConstant

bviyer updated this revision to Diff 159353. https://reviews.llvm.org/D49952 Files: lib/CodeGen/CGExprConstant.cpp test/CodeGenCXX/empty-struct-init-list.cpp Index: test/CodeGenCXX/empty-struct-init-list.cpp === --- /dev/null +

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

george.karpenkov added a comment. > I think what pointer chasing should do, is check whether that pointer owns > the pointee But ownership is a convention, and it's not always deducible from a codebase. I think of those as two separate checks, and I think we should only talk about enabling the

r339044 - Fix for broken build on clang-hexagon-elf for ambiguous call to

Author: leonardchan Date: Mon Aug 6 12:31:00 2018 New Revision: 339044 URL: http://llvm.org/viewvc/llvm-project?rev=339044&view=rev Log: Fix for broken build on clang-hexagon-elf for ambiguous call to std::abs. Modified: cfe/trunk/lib/Basic/FixedPoint.cpp Modified: cfe/trunk/lib/Basic/Fixed

[PATCH] D49438: [analyzer][UninitializedObjectChecker] New flag to turn off dereferencing

Szelethus added a comment. I think what pointer chasing should do, is check whether that pointer owns the pointee. In that case, it should be fine to analyze it. Do you mind if I put a TODO around flag's description stating that this should be implemented and pointer chasing should be enabled b

[PATCH] D43357: [Concepts] Function trailing requires clauses

saar.raz updated this revision to Diff 159349. saar.raz added a comment. Herald added a subscriber: jfb. - Fix bad diagnostic detection and suppression Repository: rC Clang https://reviews.llvm.org/D43357 Files: include/clang/AST/Decl.h include/clang/AST/DeclCXX.h include/clang/AST/Rec

[PATCH] D50344: [libc++] Enable aligned allocation based on feature test macro, irrespective of standard

ldionne created this revision. ldionne added a reviewer: vsapsai. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof. The current code enables aligned allocation functions when compiling in C++17 and later. This is a problem because aligned allocation func

Re: r338899 - [OpenCL] Always emit alloca in entry block for enqueue_kernel builtin

That's what I was missing; I should have looked more closely at the buildbot logs, I see the export there now. Thanks! Scott On 2018-08-06 12:51, Vlad Tsyrklevich wrote: Have you tried setting detect_stack_use_after_return in ASAN_OPTIONS? The ASan buildbot sets the following ASAN_OPTIONS prio

[PATCH] D50261: [AST] Remove unnecessary indirections in DeclarationNameTable

riccibruno added a comment. Yes it would be nice indeed. IIRC it is only needed for QualType in one of the moved class. This patch is especially nice since it both cleanup the code and speed up clang :) Repository: rL LLVM https://reviews.llvm.org/D50261 __

[PATCH] D49897: [WebAssembly] Force use of lld for test/Driver/wasm-toolchain.c(pp)

sbc100 added a comment. But in the CL description you say "..when configuring clang to use a different linker by default". How is this possible?i.e. do you have a config where these tests are currently failing? Repository: rC Clang https://reviews.llvm.org/D49897 ___

[PATCH] D50099: [DebugInfo][OpenCL] Address post-commit review of D49930

scott.linder added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:997 llvm::DINode::DIFlags Flags = llvm::DINode::FlagAppleBlock; unsigned LineNo = 0; echristo wrote: > scott.linder wrote: > > echristo wrote: > > > Just noticed that LineNo is 0.

[PATCH] D50055: Update the coding standard about NFC changes and whitespace

rnk added a comment. In https://reviews.llvm.org/D50055#1188479, @chandlerc wrote: > Maybe double check with Reid and/or Hal to make sure we've all ended up on > the same page before landing though. lgtm, thanks https://reviews.llvm.org/D50055 _

[PATCH] D50342: Changed how LLVM IR was generated to increase vectorization

morehouse added inline comments. Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:125 std::ostream &operator<<(std::ostream &os, const LoopFunction &x) { - return os << "define void @foo(i32* %a, i32* %b, i32* noalias %c, i64 %s) {\n" -<< "

  1   2   >